All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH 1/1] efi_loader: efi_var_mem_notify_exit_boot_services
@ 2020-09-08 10:58 Heinrich Schuchardt
  2020-09-08 11:06 ` Ilias Apalodimas
  0 siblings, 1 reply; 2+ messages in thread
From: Heinrich Schuchardt @ 2020-09-08 10:58 UTC (permalink / raw)
  To: u-boot

efi_var_mem_notify_exit_boot_services() is invoked when ExitBootServices()
is called by the UEFI payload.

efi_var_mem_notify_exit_boot_services() should not be defined as
__efi_runtime as it is invoking EFI_ENTRY() and EFI_EXIT() which themselves
are not __efi_runtime.

Fixes: f1f990a8c958 ("efi_loader: memory buffer for variables")
Fixes: e01aed47d6a0 ("efi_loader: Enable run-time variable support for tee based variables")
Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
---
 lib/efi_loader/efi_var_mem.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/efi_loader/efi_var_mem.c b/lib/efi_loader/efi_var_mem.c
index 8f4a5a5e47..1d2b44580f 100644
--- a/lib/efi_loader/efi_var_mem.c
+++ b/lib/efi_loader/efi_var_mem.c
@@ -211,7 +211,7 @@ static void efi_var_mem_bs_del(void)
  * @event:	callback event
  * @context:	callback context
  */
-static void EFIAPI __efi_runtime
+static void EFIAPI
 efi_var_mem_notify_exit_boot_services(struct efi_event *event, void *context)
 {
 	EFI_ENTRY("%p, %p", event, context);
--
2.20.1

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* [PATCH 1/1] efi_loader: efi_var_mem_notify_exit_boot_services
  2020-09-08 10:58 [PATCH 1/1] efi_loader: efi_var_mem_notify_exit_boot_services Heinrich Schuchardt
@ 2020-09-08 11:06 ` Ilias Apalodimas
  0 siblings, 0 replies; 2+ messages in thread
From: Ilias Apalodimas @ 2020-09-08 11:06 UTC (permalink / raw)
  To: u-boot

On Tue, Sep 08, 2020 at 10:58:14AM +0000, Heinrich Schuchardt wrote:
> efi_var_mem_notify_exit_boot_services() is invoked when ExitBootServices()
> is called by the UEFI payload.
> 
> efi_var_mem_notify_exit_boot_services() should not be defined as
> __efi_runtime as it is invoking EFI_ENTRY() and EFI_EXIT() which themselves
> are not __efi_runtime.
> 
> Fixes: f1f990a8c958 ("efi_loader: memory buffer for variables")
> Fixes: e01aed47d6a0 ("efi_loader: Enable run-time variable support for tee based variables")
> Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
> ---
>  lib/efi_loader/efi_var_mem.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/lib/efi_loader/efi_var_mem.c b/lib/efi_loader/efi_var_mem.c
> index 8f4a5a5e47..1d2b44580f 100644
> --- a/lib/efi_loader/efi_var_mem.c
> +++ b/lib/efi_loader/efi_var_mem.c
> @@ -211,7 +211,7 @@ static void efi_var_mem_bs_del(void)
>   * @event:	callback event
>   * @context:	callback context
>   */
> -static void EFIAPI __efi_runtime
> +static void EFIAPI
>  efi_var_mem_notify_exit_boot_services(struct efi_event *event, void *context)
>  {
>  	EFI_ENTRY("%p, %p", event, context);
> --
> 2.20.1
> 
Acked-by: Ilias Apalodimas <ilias.apalodimas@linaro.org>

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2020-09-08 11:06 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-09-08 10:58 [PATCH 1/1] efi_loader: efi_var_mem_notify_exit_boot_services Heinrich Schuchardt
2020-09-08 11:06 ` Ilias Apalodimas

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.