* [PATCH v2] stubdom: remove tpm_version from vtpmmgr
@ 2020-09-09 8:58 Olaf Hering
2020-09-09 9:27 ` Samuel Thibault
0 siblings, 1 reply; 2+ messages in thread
From: Olaf Hering @ 2020-09-09 8:58 UTC (permalink / raw)
To: xen-devel; +Cc: Olaf Hering, Daniel De Graaf, Quan Xu, Samuel Thibault
Giving an enum a name turns it into a variable, which is bad when it is
done in a header file that is consumbed by multiple files.
ld: /home/abuild/rpmbuild/BUILD/xen-4.14.20200616T103126.3625b04991/non-dbg/stubdom/vtpmmgr/vtpmmgr.a(vtpm_cmd_handler.o):(.bss+0x0): multiple definition of `tpm_version'; /home/abuild/rpmbuild/BUILD/xen-4.14.20200616T103126.3625b04991/non-dbg/stubdom/vtpmmgr/vtpmmgr.a(vtpmmgr.o):(.bss+0x0): first defined here
Signed-off-by: Olaf Hering <olaf@aepfle.de>
---
stubdom/vtpmmgr/vtpmmgr.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/stubdom/vtpmmgr/vtpmmgr.h b/stubdom/vtpmmgr/vtpmmgr.h
index 2e6f8de9e4..f40ca9fd67 100644
--- a/stubdom/vtpmmgr/vtpmmgr.h
+++ b/stubdom/vtpmmgr/vtpmmgr.h
@@ -53,7 +53,7 @@
enum {
TPM1_HARDWARE = 1,
TPM2_HARDWARE,
-} tpm_version;
+};
struct tpm_hardware_version {
int hw_version;
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v2] stubdom: remove tpm_version from vtpmmgr
2020-09-09 8:58 [PATCH v2] stubdom: remove tpm_version from vtpmmgr Olaf Hering
@ 2020-09-09 9:27 ` Samuel Thibault
0 siblings, 0 replies; 2+ messages in thread
From: Samuel Thibault @ 2020-09-09 9:27 UTC (permalink / raw)
To: Olaf Hering; +Cc: xen-devel, Daniel De Graaf, Quan Xu
Olaf Hering, le mer. 09 sept. 2020 10:58:28 +0200, a ecrit:
> Giving an enum a name turns it into a variable, which is bad when it is
> done in a header file that is consumbed by multiple files.
>
> ld: /home/abuild/rpmbuild/BUILD/xen-4.14.20200616T103126.3625b04991/non-dbg/stubdom/vtpmmgr/vtpmmgr.a(vtpm_cmd_handler.o):(.bss+0x0): multiple definition of `tpm_version'; /home/abuild/rpmbuild/BUILD/xen-4.14.20200616T103126.3625b04991/non-dbg/stubdom/vtpmmgr/vtpmmgr.a(vtpmmgr.o):(.bss+0x0): first defined here
>
> Signed-off-by: Olaf Hering <olaf@aepfle.de>
Reviewed-by: Samuel Thibault <samuel.thibault@ens-lyon.org>
> ---
> stubdom/vtpmmgr/vtpmmgr.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/stubdom/vtpmmgr/vtpmmgr.h b/stubdom/vtpmmgr/vtpmmgr.h
> index 2e6f8de9e4..f40ca9fd67 100644
> --- a/stubdom/vtpmmgr/vtpmmgr.h
> +++ b/stubdom/vtpmmgr/vtpmmgr.h
> @@ -53,7 +53,7 @@
> enum {
> TPM1_HARDWARE = 1,
> TPM2_HARDWARE,
> -} tpm_version;
> +};
>
> struct tpm_hardware_version {
> int hw_version;
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-09-09 9:27 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-09-09 8:58 [PATCH v2] stubdom: remove tpm_version from vtpmmgr Olaf Hering
2020-09-09 9:27 ` Samuel Thibault
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.