* [RFC] Device addition to the tlv320adcx140 and tas2562
@ 2020-09-09 15:01 Dan Murphy
2020-09-09 15:35 ` Mark Brown
0 siblings, 1 reply; 3+ messages in thread
From: Dan Murphy @ 2020-09-09 15:01 UTC (permalink / raw)
To: Mark Brown, Liam Girdwood, tiwai; +Cc: alsa-devel, LKML
Hello
Looking for guidance on how to move forward with adding a device to
existing drivers.
For the TLV320adcx140 driver I have another device which is register and
bitmap compatible but it does not support Analog microphones or Line In
like the x140.
Should I add a new driver specifically for this part or should I add the
new audio maps, widgets and controls to the existing driver? This would
make this existing driver really big in terms of LoC and object size.
Similar question for the TAS2562. I have a new device that is register
and bitmap compatible but removes the I/V sense. Adding this new device
to the existing driver wouldn't be as intrusive as the x140 as the audio
map and controls are much simpler
Dan
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [RFC] Device addition to the tlv320adcx140 and tas2562
2020-09-09 15:01 [RFC] Device addition to the tlv320adcx140 and tas2562 Dan Murphy
@ 2020-09-09 15:35 ` Mark Brown
0 siblings, 0 replies; 3+ messages in thread
From: Mark Brown @ 2020-09-09 15:35 UTC (permalink / raw)
To: Dan Murphy; +Cc: Liam Girdwood, tiwai, alsa-devel, LKML
[-- Attachment #1: Type: text/plain, Size: 906 bytes --]
On Wed, Sep 09, 2020 at 10:01:51AM -0500, Dan Murphy wrote:
> For the TLV320adcx140 driver I have another device which is register and
> bitmap compatible but it does not support Analog microphones or Line In like
> the x140.
> Should I add a new driver specifically for this part or should I add the new
> audio maps, widgets and controls to the existing driver? This would make
> this existing driver really big in terms of LoC and object size.
Are they sharing anything (eg, the code is the same but the data tables
vary) or is it just two unrelated devices?
> Similar question for the TAS2562. I have a new device that is register and
> bitmap compatible but removes the I/V sense. Adding this new device to the
> existing driver wouldn't be as intrusive as the x140 as the audio map and
> controls are much simpler
That definitely sounds like sharing the driver makes sense.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [RFC] Device addition to the tlv320adcx140 and tas2562
@ 2020-09-09 15:35 ` Mark Brown
0 siblings, 0 replies; 3+ messages in thread
From: Mark Brown @ 2020-09-09 15:35 UTC (permalink / raw)
To: Dan Murphy; +Cc: LKML, alsa-devel, Liam Girdwood, tiwai
[-- Attachment #1: Type: text/plain, Size: 906 bytes --]
On Wed, Sep 09, 2020 at 10:01:51AM -0500, Dan Murphy wrote:
> For the TLV320adcx140 driver I have another device which is register and
> bitmap compatible but it does not support Analog microphones or Line In like
> the x140.
> Should I add a new driver specifically for this part or should I add the new
> audio maps, widgets and controls to the existing driver? This would make
> this existing driver really big in terms of LoC and object size.
Are they sharing anything (eg, the code is the same but the data tables
vary) or is it just two unrelated devices?
> Similar question for the TAS2562. I have a new device that is register and
> bitmap compatible but removes the I/V sense. Adding this new device to the
> existing driver wouldn't be as intrusive as the x140 as the audio map and
> controls are much simpler
That definitely sounds like sharing the driver makes sense.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-09-09 18:06 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-09-09 15:01 [RFC] Device addition to the tlv320adcx140 and tas2562 Dan Murphy
2020-09-09 15:35 ` Mark Brown
2020-09-09 15:35 ` Mark Brown
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.