* [PATCH net-next 1/6] hinic: Fix some kernel-doc warnings in hinic_hw_io.c
2020-09-10 14:56 [PATCH net-next 0/6] Fix some kernel-doc warnings for hns Wang Hai
@ 2020-09-10 14:56 ` Wang Hai
2020-09-10 14:56 ` [PATCH net-next 2/6] net: hns: fix 'cdev' kernel-doc warning in hnae_ae_unregister() Wang Hai
` (5 subsequent siblings)
6 siblings, 0 replies; 8+ messages in thread
From: Wang Hai @ 2020-09-10 14:56 UTC (permalink / raw)
To: yisen.zhuang, salil.mehta, davem, kuba, snelson, colin.king, maz,
luobin9
Cc: netdev, linux-kernel
Fixes the following W=1 kernel build warning(s):
drivers/net/ethernet/huawei/hinic/hinic_hw_io.c:373: warning: Excess function parameter 'sq_msix_entry' description in 'hinic_io_create_qps'
drivers/net/ethernet/huawei/hinic/hinic_hw_io.c:373: warning: Excess function parameter 'rq_msix_entry' description in 'hinic_io_create_qps'
Rename these wrong names.
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Wang Hai <wanghai38@huawei.com>
---
drivers/net/ethernet/huawei/hinic/hinic_hw_io.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/huawei/hinic/hinic_hw_io.c b/drivers/net/ethernet/huawei/hinic/hinic_hw_io.c
index 6772d8978722..4ef4008e65bd 100644
--- a/drivers/net/ethernet/huawei/hinic/hinic_hw_io.c
+++ b/drivers/net/ethernet/huawei/hinic/hinic_hw_io.c
@@ -363,8 +363,8 @@ static void destroy_qp(struct hinic_func_to_io *func_to_io,
* @func_to_io: func to io channel that holds the IO components
* @base_qpn: base qp number
* @num_qps: number queue pairs to create
- * @sq_msix_entry: msix entries for sq
- * @rq_msix_entry: msix entries for rq
+ * @sq_msix_entries: msix entries for sq
+ * @rq_msix_entries: msix entries for rq
*
* Return 0 - Success, negative - Failure
**/
--
2.17.1
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [PATCH net-next 2/6] net: hns: fix 'cdev' kernel-doc warning in hnae_ae_unregister()
2020-09-10 14:56 [PATCH net-next 0/6] Fix some kernel-doc warnings for hns Wang Hai
2020-09-10 14:56 ` [PATCH net-next 1/6] hinic: Fix some kernel-doc warnings in hinic_hw_io.c Wang Hai
@ 2020-09-10 14:56 ` Wang Hai
2020-09-10 14:56 ` [PATCH net-next 3/6] net: hns: Fix some kernel-doc warnings in hns_dsaf_xgmac.c Wang Hai
` (4 subsequent siblings)
6 siblings, 0 replies; 8+ messages in thread
From: Wang Hai @ 2020-09-10 14:56 UTC (permalink / raw)
To: yisen.zhuang, salil.mehta, davem, kuba, snelson, colin.king, maz,
luobin9
Cc: netdev, linux-kernel
Rename cdev to hdev.
Fixes the following W=1 kernel build warning(s):
drivers/net/ethernet/hisilicon/hns/hnae.c:444: warning: Excess function parameter 'cdev' description in 'hnae_ae_unregister'
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Wang Hai <wanghai38@huawei.com>
---
drivers/net/ethernet/hisilicon/hns/hnae.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/hisilicon/hns/hnae.c b/drivers/net/ethernet/hisilicon/hns/hnae.c
index 08339278c722..e017b7c34140 100644
--- a/drivers/net/ethernet/hisilicon/hns/hnae.c
+++ b/drivers/net/ethernet/hisilicon/hns/hnae.c
@@ -438,7 +438,7 @@ EXPORT_SYMBOL(hnae_ae_register);
/**
* hnae_ae_unregister - unregisters a HNAE AE engine
- * @cdev: the device to unregister
+ * @hdev: the device to unregister
*/
void hnae_ae_unregister(struct hnae_ae_dev *hdev)
{
--
2.17.1
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [PATCH net-next 3/6] net: hns: Fix some kernel-doc warnings in hns_dsaf_xgmac.c
2020-09-10 14:56 [PATCH net-next 0/6] Fix some kernel-doc warnings for hns Wang Hai
2020-09-10 14:56 ` [PATCH net-next 1/6] hinic: Fix some kernel-doc warnings in hinic_hw_io.c Wang Hai
2020-09-10 14:56 ` [PATCH net-next 2/6] net: hns: fix 'cdev' kernel-doc warning in hnae_ae_unregister() Wang Hai
@ 2020-09-10 14:56 ` Wang Hai
2020-09-10 14:56 ` [PATCH net-next 4/6] net: hns: Fix some kernel-doc warnings in hns_enet.c Wang Hai
` (3 subsequent siblings)
6 siblings, 0 replies; 8+ messages in thread
From: Wang Hai @ 2020-09-10 14:56 UTC (permalink / raw)
To: yisen.zhuang, salil.mehta, davem, kuba, snelson, colin.king, maz,
luobin9
Cc: netdev, linux-kernel
Fixes the following W=1 kernel build warning(s):
drivers/net/ethernet/hisilicon/hns/hns_dsaf_xgmac.c:137: warning: Excess function parameter 'drv' description in 'hns_xgmac_enable'
drivers/net/ethernet/hisilicon/hns/hns_dsaf_xgmac.c:497: warning: Excess function parameter 'cmd' description in 'hns_xgmac_get_regs'
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Wang Hai <wanghai38@huawei.com>
---
drivers/net/ethernet/hisilicon/hns/hns_dsaf_xgmac.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/hisilicon/hns/hns_dsaf_xgmac.c b/drivers/net/ethernet/hisilicon/hns/hns_dsaf_xgmac.c
index 0a3dbab2dfc9..d832cd018c1c 100644
--- a/drivers/net/ethernet/hisilicon/hns/hns_dsaf_xgmac.c
+++ b/drivers/net/ethernet/hisilicon/hns/hns_dsaf_xgmac.c
@@ -130,7 +130,7 @@ static void hns_xgmac_lf_rf_control_init(struct mac_driver *mac_drv)
/**
*hns_xgmac_enable - enable xgmac port
- *@drv: mac driver
+ *@mac_drv: mac driver
*@mode: mode of mac port
*/
static void hns_xgmac_enable(void *mac_drv, enum mac_commom_mode mode)
@@ -490,7 +490,6 @@ static void hns_xgmac_get_link_status(void *mac_drv, u32 *link_stat)
/**
*hns_xgmac_get_regs - dump xgmac regs
*@mac_drv: mac driver
- *@cmd:ethtool cmd
*@data:data for value of regs
*/
static void hns_xgmac_get_regs(void *mac_drv, void *data)
--
2.17.1
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [PATCH net-next 4/6] net: hns: Fix some kernel-doc warnings in hns_enet.c
2020-09-10 14:56 [PATCH net-next 0/6] Fix some kernel-doc warnings for hns Wang Hai
` (2 preceding siblings ...)
2020-09-10 14:56 ` [PATCH net-next 3/6] net: hns: Fix some kernel-doc warnings in hns_dsaf_xgmac.c Wang Hai
@ 2020-09-10 14:56 ` Wang Hai
2020-09-10 14:56 ` [PATCH net-next 5/6] net: hns: Fix a kernel-doc warning in hinic_hw_api_cmd.c Wang Hai
` (2 subsequent siblings)
6 siblings, 0 replies; 8+ messages in thread
From: Wang Hai @ 2020-09-10 14:56 UTC (permalink / raw)
To: yisen.zhuang, salil.mehta, davem, kuba, snelson, colin.king, maz,
luobin9
Cc: netdev, linux-kernel
Fixes the following W=1 kernel build warning(s):
drivers/net/ethernet/hisilicon/hns/hns_enet.c:1841: warning: Excess function parameter 'netdev' description in 'hns_set_multicast_list'
drivers/net/ethernet/hisilicon/hns/hns_enet.c:1841: warning: Excess function parameter 'p' description in 'hns_set_multicast_list'
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Wang Hai <wanghai38@huawei.com>
---
drivers/net/ethernet/hisilicon/hns/hns_enet.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/hisilicon/hns/hns_enet.c b/drivers/net/ethernet/hisilicon/hns/hns_enet.c
index b13f3a5cdf59..b658b9de81d7 100644
--- a/drivers/net/ethernet/hisilicon/hns/hns_enet.c
+++ b/drivers/net/ethernet/hisilicon/hns/hns_enet.c
@@ -1829,8 +1829,7 @@ static int hns_nic_uc_unsync(struct net_device *netdev,
/**
* nic_set_multicast_list - set mutl mac address
- * @netdev: net device
- * @p: mac address
+ * @ndev: net device
*
* return void
*/
--
2.17.1
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [PATCH net-next 5/6] net: hns: Fix a kernel-doc warning in hinic_hw_api_cmd.c
2020-09-10 14:56 [PATCH net-next 0/6] Fix some kernel-doc warnings for hns Wang Hai
` (3 preceding siblings ...)
2020-09-10 14:56 ` [PATCH net-next 4/6] net: hns: Fix some kernel-doc warnings in hns_enet.c Wang Hai
@ 2020-09-10 14:56 ` Wang Hai
2020-09-10 14:56 ` [PATCH net-next 6/6] net: hns: Fix a kernel-doc warning in hinic_hw_eqs.c Wang Hai
2020-09-10 22:18 ` [PATCH net-next 0/6] Fix some kernel-doc warnings for hns David Miller
6 siblings, 0 replies; 8+ messages in thread
From: Wang Hai @ 2020-09-10 14:56 UTC (permalink / raw)
To: yisen.zhuang, salil.mehta, davem, kuba, snelson, colin.king, maz,
luobin9
Cc: netdev, linux-kernel
Fixes the following W=1 kernel build warning(s):
drivers/net/ethernet/huawei/hinic/hinic_hw_api_cmd.c:382: warning: Excess function parameter 'size' description in 'api_cmd'
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Wang Hai <wanghai38@huawei.com>
---
drivers/net/ethernet/huawei/hinic/hinic_hw_api_cmd.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/huawei/hinic/hinic_hw_api_cmd.c b/drivers/net/ethernet/huawei/hinic/hinic_hw_api_cmd.c
index 29e88e25a4a4..4e4029d5c8e1 100644
--- a/drivers/net/ethernet/huawei/hinic/hinic_hw_api_cmd.c
+++ b/drivers/net/ethernet/huawei/hinic/hinic_hw_api_cmd.c
@@ -373,7 +373,7 @@ static int wait_for_api_cmd_completion(struct hinic_api_cmd_chain *chain)
* @chain: chain for the command
* @dest: destination node on the card that will receive the command
* @cmd: command data
- * @size: the command size
+ * @cmd_size: the command size
*
* Return 0 - Success, negative - Failure
**/
--
2.17.1
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [PATCH net-next 6/6] net: hns: Fix a kernel-doc warning in hinic_hw_eqs.c
2020-09-10 14:56 [PATCH net-next 0/6] Fix some kernel-doc warnings for hns Wang Hai
` (4 preceding siblings ...)
2020-09-10 14:56 ` [PATCH net-next 5/6] net: hns: Fix a kernel-doc warning in hinic_hw_api_cmd.c Wang Hai
@ 2020-09-10 14:56 ` Wang Hai
2020-09-10 22:18 ` [PATCH net-next 0/6] Fix some kernel-doc warnings for hns David Miller
6 siblings, 0 replies; 8+ messages in thread
From: Wang Hai @ 2020-09-10 14:56 UTC (permalink / raw)
To: yisen.zhuang, salil.mehta, davem, kuba, snelson, colin.king, maz,
luobin9
Cc: netdev, linux-kernel
Fixes the following W=1 kernel build warning(s):
drivers/net/ethernet/huawei/hinic/hinic_hw_eqs.c:115: warning: Excess function parameter 'hw_handler' description in 'hinic_aeq_register_hw_cb'
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Wang Hai <wanghai38@huawei.com>
---
drivers/net/ethernet/huawei/hinic/hinic_hw_eqs.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/huawei/hinic/hinic_hw_eqs.c b/drivers/net/ethernet/huawei/hinic/hinic_hw_eqs.c
index ca8cb68a8d20..b30733f4a59e 100644
--- a/drivers/net/ethernet/huawei/hinic/hinic_hw_eqs.c
+++ b/drivers/net/ethernet/huawei/hinic/hinic_hw_eqs.c
@@ -106,7 +106,7 @@ enum eq_arm_state {
* @aeqs: pointer to Async eqs of the chip
* @event: aeq event to register callback for it
* @handle: private data will be used by the callback
- * @hw_handler: callback function
+ * @hwe_handler: callback function
**/
void hinic_aeq_register_hw_cb(struct hinic_aeqs *aeqs,
enum hinic_aeq_type event, void *handle,
--
2.17.1
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH net-next 0/6] Fix some kernel-doc warnings for hns
2020-09-10 14:56 [PATCH net-next 0/6] Fix some kernel-doc warnings for hns Wang Hai
` (5 preceding siblings ...)
2020-09-10 14:56 ` [PATCH net-next 6/6] net: hns: Fix a kernel-doc warning in hinic_hw_eqs.c Wang Hai
@ 2020-09-10 22:18 ` David Miller
6 siblings, 0 replies; 8+ messages in thread
From: David Miller @ 2020-09-10 22:18 UTC (permalink / raw)
To: wanghai38
Cc: yisen.zhuang, salil.mehta, kuba, snelson, colin.king, maz,
luobin9, netdev, linux-kernel
From: Wang Hai <wanghai38@huawei.com>
Date: Thu, 10 Sep 2020 22:56:14 +0800
> Fix some kernel-doc warnings for hns.
Series applied to net-next, thanks.
^ permalink raw reply [flat|nested] 8+ messages in thread