* [PATCH net] net: dec: de2104x: Increase receive ring size for Tulip
@ 2020-09-10 19:05 Lucy Yan
2020-09-10 19:33 ` Moritz Fischer
2020-09-10 22:29 ` David Miller
0 siblings, 2 replies; 3+ messages in thread
From: Lucy Yan @ 2020-09-10 19:05 UTC (permalink / raw)
To: David S . Miller, Jakub Kicinski
Cc: Heiner Kallweit, Arnd Bergmann, Moritz Fischer, Lucy Yan,
Leon Romanovsky, Michael S . Tsirkin, Vaibhav Gupta, netdev,
linux-parisc, linux-kernel
Increase Rx ring size to address issue where hardware is reaching
the receive work limit.
Before:
[ 102.223342] de2104x 0000:17:00.0 eth0: rx work limit reached
[ 102.245695] de2104x 0000:17:00.0 eth0: rx work limit reached
[ 102.251387] de2104x 0000:17:00.0 eth0: rx work limit reached
[ 102.267444] de2104x 0000:17:00.0 eth0: rx work limit reached
Signed-off-by: Lucy Yan <lucyyan@google.com>
---
drivers/net/ethernet/dec/tulip/de2104x.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/dec/tulip/de2104x.c b/drivers/net/ethernet/dec/tulip/de2104x.c
index cb116b530f5e..2610efe4f873 100644
--- a/drivers/net/ethernet/dec/tulip/de2104x.c
+++ b/drivers/net/ethernet/dec/tulip/de2104x.c
@@ -85,7 +85,7 @@ MODULE_PARM_DESC (rx_copybreak, "de2104x Breakpoint at which Rx packets are copi
#define DSL CONFIG_DE2104X_DSL
#endif
-#define DE_RX_RING_SIZE 64
+#define DE_RX_RING_SIZE 128
#define DE_TX_RING_SIZE 64
#define DE_RING_BYTES \
((sizeof(struct de_desc) * DE_RX_RING_SIZE) + \
--
2.28.0.526.ge36021eeef-goog
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH net] net: dec: de2104x: Increase receive ring size for Tulip
2020-09-10 19:05 [PATCH net] net: dec: de2104x: Increase receive ring size for Tulip Lucy Yan
@ 2020-09-10 19:33 ` Moritz Fischer
2020-09-10 22:29 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: Moritz Fischer @ 2020-09-10 19:33 UTC (permalink / raw)
To: Lucy Yan
Cc: David S . Miller, Jakub Kicinski, Heiner Kallweit, Arnd Bergmann,
Moritz Fischer, Leon Romanovsky, Michael S . Tsirkin,
Vaibhav Gupta, netdev, linux-parisc, linux-kernel
On Thu, Sep 10, 2020 at 12:05:09PM -0700, Lucy Yan wrote:
> Increase Rx ring size to address issue where hardware is reaching
> the receive work limit.
>
> Before:
>
> [ 102.223342] de2104x 0000:17:00.0 eth0: rx work limit reached
> [ 102.245695] de2104x 0000:17:00.0 eth0: rx work limit reached
> [ 102.251387] de2104x 0000:17:00.0 eth0: rx work limit reached
> [ 102.267444] de2104x 0000:17:00.0 eth0: rx work limit reached
>
> Signed-off-by: Lucy Yan <lucyyan@google.com>
Reviewed-by: Moritz Fischer <mdf@kernel.org>
> ---
> drivers/net/ethernet/dec/tulip/de2104x.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/dec/tulip/de2104x.c b/drivers/net/ethernet/dec/tulip/de2104x.c
> index cb116b530f5e..2610efe4f873 100644
> --- a/drivers/net/ethernet/dec/tulip/de2104x.c
> +++ b/drivers/net/ethernet/dec/tulip/de2104x.c
> @@ -85,7 +85,7 @@ MODULE_PARM_DESC (rx_copybreak, "de2104x Breakpoint at which Rx packets are copi
> #define DSL CONFIG_DE2104X_DSL
> #endif
>
> -#define DE_RX_RING_SIZE 64
> +#define DE_RX_RING_SIZE 128
> #define DE_TX_RING_SIZE 64
> #define DE_RING_BYTES \
> ((sizeof(struct de_desc) * DE_RX_RING_SIZE) + \
> --
> 2.28.0.526.ge36021eeef-goog
>
Thanks,
Moritz
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH net] net: dec: de2104x: Increase receive ring size for Tulip
2020-09-10 19:05 [PATCH net] net: dec: de2104x: Increase receive ring size for Tulip Lucy Yan
2020-09-10 19:33 ` Moritz Fischer
@ 2020-09-10 22:29 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2020-09-10 22:29 UTC (permalink / raw)
To: lucyyan
Cc: kuba, hkallweit1, arnd, mdf, leon, mst, vaibhavgupta40, netdev,
linux-parisc, linux-kernel
From: Lucy Yan <lucyyan@google.com>
Date: Thu, 10 Sep 2020 12:05:09 -0700
> Increase Rx ring size to address issue where hardware is reaching
> the receive work limit.
>
> Before:
>
> [ 102.223342] de2104x 0000:17:00.0 eth0: rx work limit reached
> [ 102.245695] de2104x 0000:17:00.0 eth0: rx work limit reached
> [ 102.251387] de2104x 0000:17:00.0 eth0: rx work limit reached
> [ 102.267444] de2104x 0000:17:00.0 eth0: rx work limit reached
>
> Signed-off-by: Lucy Yan <lucyyan@google.com>
Applied, thank you.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-09-10 22:29 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-09-10 19:05 [PATCH net] net: dec: de2104x: Increase receive ring size for Tulip Lucy Yan
2020-09-10 19:33 ` Moritz Fischer
2020-09-10 22:29 ` David Miller
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.