[Intel-gfx] [bug report] drm/i915: Use ww pinning for intel_context_create_request()

[Intel-gfx] [bug report] drm/i915: Use ww pinning for intel_context_create_request()

[Dan Carpenter]

Hello Maarten Lankhorst,

The patch 8a929c9eb1c2: "drm/i915: Use ww pinning for
intel_context_create_request()" from Aug 19, 2020, leads to the
following static checker warning:

	drivers/gpu/drm/i915/gt/intel_context.c:481 intel_context_create_request()
	error: uninitialized symbol 'rq'.

drivers/gpu/drm/i915/gt/intel_context.c
   459  struct i915_request *intel_context_create_request(struct intel_context *ce)
   460  {
   461          struct i915_gem_ww_ctx ww;
   462          struct i915_request *rq;
   463          int err;
   464  
   465          i915_gem_ww_ctx_init(&ww, true);
   466  retry:
   467          err = intel_context_pin_ww(ce, &ww);
   468          if (!err) {
   469                  rq = i915_request_create(ce);
   470                  intel_context_unpin(ce);
   471          } else if (err == -EDEADLK) {
   472                  err = i915_gem_ww_ctx_backoff(&ww);
   473                  if (!err)
   474                          goto retry;

"rq" not initialized on the -EDEADLK path.

   475          } else {
   476                  rq = ERR_PTR(err);
   477          }
   478  
   479          i915_gem_ww_ctx_fini(&ww);
   480  
   481          if (IS_ERR(rq))
                           ^^

   482                  return rq;
   483  

regards,
dan carpenter
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx