All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH v5 0/2] wcn36xx: Miscellaneous updates
@ 2020-09-10 15:08 Bryan O'Donoghue
  2020-09-10 15:08 ` [PATCH v5 1/2] wcn36xx: Mark internal smd functions static Bryan O'Donoghue
                   ` (2 more replies)
  0 siblings, 3 replies; 8+ messages in thread
From: Bryan O'Donoghue @ 2020-09-10 15:08 UTC (permalink / raw)
  To: kvalo, wcn36xx, linux-wireless; +Cc: bryan.odonoghue, shawn.guo, loic.poulain

This series is seven in a set of seven to add support for wcn3680 at 802.11ac
data-rates.

This set marks functions previously declared non-static as static. In order
to facilitate granular standalone commits and avoid single patch
code-bombs. A series of functions were previously declared non-static.
Antecedent changes have made use of those functions so we can now mark them
static.

In a similar theme of cleanup, I've added on a fix for some whitespace
damage in main.c and smd.c which while not strictly related to wcn3680 I've
opted to throw into the bucket under a "miscellaneous update" title.

Hope that's OK.

V5:
- No change to V4 but need to send the set again so that
  prerequisite-patch-id makes sense to the build robot here.

V4:
- No functional change.
  Sending out full set again using --base=ath-202009090652 to aid kernel
  test robot
- https://lore.kernel.org/linux-wireless/20200908183424.2871101-1-bryan.odonoghue@linaro.org/T/#t

V3/RESEND:
- Messed up my .git/config resending from my @linaro.org address

Bryan O'Donoghue (2):
  wcn36xx: Mark internal smd functions static
  wcn36xx: Ensure spaces between functions

 drivers/net/wireless/ath/wcn36xx/main.c |  1 +
 drivers/net/wireless/ath/wcn36xx/smd.c  | 65 +++++++++----------------
 2 files changed, 23 insertions(+), 43 deletions(-)


base-commit: 160b351d75cb50a0dd2abf9b63e1891935aa9e4a
prerequisite-patch-id: 9a4ac7faca179f6594c9b3a115ee69a2da540a69
prerequisite-patch-id: 183286f9c22d1aaa12f356651224e6b337ef1938
prerequisite-patch-id: af468d413daaf8d2aad195fcb43c6e66390d8468
prerequisite-patch-id: 08122a9557904ce5358f52dd08cc33270fa202c1
prerequisite-patch-id: 82e0b7c5b2e9fa80baca001cce12577d98e306a9
prerequisite-patch-id: 8ee7f5bd6cb5b7b7d713947b554ad93bb90d8230
prerequisite-patch-id: d05c2253e4523b05b2e43491aa13ceeef68fd2f0
prerequisite-patch-id: 8be29513d3efa64df15297bcf81ec3db55088ee1
prerequisite-patch-id: d267dcd834afad75a69bcd2adcccfdad6566a7ba
prerequisite-patch-id: 47145acae6e24e8e6580fca1dbddfbec24f7b50b
prerequisite-patch-id: 8c66bccb923be821cf109a3a0d3a1a028edb4930
prerequisite-patch-id: d0f5f3769b2963208fd2348840726fa1d3501b63
prerequisite-patch-id: 746f63cf58fa3bf62736435c81dba2558aba8e81
prerequisite-patch-id: 375bb7847ae74c63d2eacdbd0d73371aef1546fe
prerequisite-patch-id: 8a598e22a08b0ec233d0ec56eeb53673eb1b8feb
prerequisite-patch-id: b0eba574ddc35ecec2d0e39c0d3351d1b260420e
prerequisite-patch-id: 143a1019813b7e4974a67e9eea1f1d599c0fdfdf
prerequisite-patch-id: f66d9fe9eb731272b825c9430c15dca89d6c6129
prerequisite-patch-id: c8c2d2dd1452c357f73fc4c92e5b564d59a05562
prerequisite-patch-id: 273c13464a69354d32790ed7509472d9c2b11231
prerequisite-patch-id: adbde1c98b85a16a6500b4210d4f055b9493418c
prerequisite-patch-id: 559b6f9af6b26f860896dea4c7eb385ba9bdf0d5
prerequisite-patch-id: 94c091c0c78b754d4c842a097a6db126bf6e770f
prerequisite-patch-id: f2e549349c09f4675775b40bf9bb9b1f2bec6db8
prerequisite-patch-id: c3a6aa788141f5b8782d28dac264470c8081bb97
prerequisite-patch-id: 452450f26295dc4fc48dec07ba85538d78bae4b4
prerequisite-patch-id: 8e7850077db9ec00df9be4fe3e0e4a4e8b06fbba
prerequisite-patch-id: 233db8337812d9d34f99b41ccebd8758a6ada6d9
prerequisite-patch-id: 0bbaaf402d2dd50a50aaa6505e5d10e743cf03e5
-- 
2.27.0


^ permalink raw reply	[flat|nested] 8+ messages in thread
* [PATCH v5 1/2] wcn36xx: Mark internal smd functions static
  2020-09-10 15:08 [PATCH v5 0/2] wcn36xx: Miscellaneous updates Bryan O'Donoghue
@ 2020-09-10 15:08 ` Bryan O'Donoghue
  2020-09-22  7:40   ` Kalle Valo
  2020-09-10 15:08 ` [PATCH v5 2/2] wcn36xx: Ensure spaces between functions Bryan O'Donoghue
  2020-09-10 15:55 ` [PATCH v5 0/2] wcn36xx: Miscellaneous updates Bryan O'Donoghue
  2 siblings, 1 reply; 8+ messages in thread
From: Bryan O'Donoghue @ 2020-09-10 15:08 UTC (permalink / raw)
  To: kvalo, wcn36xx, linux-wireless; +Cc: bryan.odonoghue, shawn.guo, loic.poulain

This commit marks all smd.c functions that are only used inside of smd.c as
static. Previous commits added some VHT specific setup functions non-static
which is the right thing to do in terms of having granular git commits that
compile warning free. What we really want is for local not global scope on
those functions.

This patch makes the conversion from global to local scope.

Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
---
 drivers/net/wireless/ath/wcn36xx/smd.c | 61 ++++++++------------------
 1 file changed, 18 insertions(+), 43 deletions(-)

diff --git a/drivers/net/wireless/ath/wcn36xx/smd.c b/drivers/net/wireless/ath/wcn36xx/smd.c
index e74abc153153..bccdae62ffbc 100644
--- a/drivers/net/wireless/ath/wcn36xx/smd.c
+++ b/drivers/net/wireless/ath/wcn36xx/smd.c
@@ -80,7 +80,7 @@ static struct wcn36xx_cfg_val wcn36xx_cfg_vals[] = {
 	WCN36XX_CFG_VAL(ENABLE_DYNAMIC_RA_START_RATE, 133), /* MCS 5 */
 };
 
-struct wcn36xx_cfg_val wcn3680_cfg_vals[] = {
+static struct wcn36xx_cfg_val wcn3680_cfg_vals[] = {
 	WCN36XX_CFG_VAL(CURRENT_TX_ANTENNA, 1),
 	WCN36XX_CFG_VAL(CURRENT_RX_ANTENNA, 1),
 	WCN36XX_CFG_VAL(LOW_GAIN_OVERRIDE, 0),
@@ -242,11 +242,7 @@ static void wcn36xx_smd_set_bss_ht_params(struct ieee80211_vif *vif,
 	}
 }
 
-void
-wcn36xx_smd_set_bss_vht_params(struct ieee80211_vif *vif,
-			       struct ieee80211_sta *sta,
-			       struct wcn36xx_hal_config_bss_params_v1 *bss);
-void
+static void
 wcn36xx_smd_set_bss_vht_params(struct ieee80211_vif *vif,
 			       struct ieee80211_sta *sta,
 			       struct wcn36xx_hal_config_bss_params_v1 *bss)
@@ -283,10 +279,7 @@ static void wcn36xx_smd_set_sta_ht_params(struct ieee80211_sta *sta,
 	}
 }
 
-void wcn36xx_smd_set_sta_vht_params(struct wcn36xx *wcn,
-		struct ieee80211_sta *sta,
-		struct wcn36xx_hal_config_sta_params_v1 *sta_params);
-void wcn36xx_smd_set_sta_vht_params(struct wcn36xx *wcn,
+static void wcn36xx_smd_set_sta_vht_params(struct wcn36xx *wcn,
 		struct ieee80211_sta *sta,
 		struct wcn36xx_hal_config_sta_params_v1 *sta_params)
 {
@@ -308,9 +301,7 @@ void wcn36xx_smd_set_sta_vht_params(struct wcn36xx *wcn,
 	}
 }
 
-void wcn36xx_smd_set_sta_ht_ldpc_params(struct ieee80211_sta *sta,
-		struct wcn36xx_hal_config_sta_params_v1 *sta_params);
-void wcn36xx_smd_set_sta_ht_ldpc_params(struct ieee80211_sta *sta,
+static void wcn36xx_smd_set_sta_ht_ldpc_params(struct ieee80211_sta *sta,
 		struct wcn36xx_hal_config_sta_params_v1 *sta_params)
 {
 	if (sta->ht_cap.ht_supported) {
@@ -335,9 +326,7 @@ static void wcn36xx_smd_set_sta_default_ht_params(
 	sta_params->dsss_cck_mode_40mhz = 1;
 }
 
-void wcn36xx_smd_set_sta_default_vht_params(struct wcn36xx *wcn,
-		struct wcn36xx_hal_config_sta_params_v1 *sta_params);
-void wcn36xx_smd_set_sta_default_vht_params(struct wcn36xx *wcn,
+static void wcn36xx_smd_set_sta_default_vht_params(struct wcn36xx *wcn,
 		struct wcn36xx_hal_config_sta_params_v1 *sta_params)
 {
 	if (wcn->rf_id == RF_IRIS_WCN3680) {
@@ -353,9 +342,7 @@ void wcn36xx_smd_set_sta_default_vht_params(struct wcn36xx *wcn,
 	sta_params->vht_tx_bf_enabled = 0;
 }
 
-void wcn36xx_smd_set_sta_default_ht_ldpc_params(struct wcn36xx *wcn,
-		struct wcn36xx_hal_config_sta_params_v1 *sta_params);
-void wcn36xx_smd_set_sta_default_ht_ldpc_params(struct wcn36xx *wcn,
+static void wcn36xx_smd_set_sta_default_ht_ldpc_params(struct wcn36xx *wcn,
 		struct wcn36xx_hal_config_sta_params_v1 *sta_params)
 {
 	if (wcn->rf_id == RF_IRIS_WCN3680)
@@ -1376,12 +1363,7 @@ static void wcn36xx_smd_convert_sta_to_v1(struct wcn36xx *wcn,
 	v1->p2p = orig->p2p;
 }
 
-void
-wcn36xx_smd_set_sta_params_v1(struct wcn36xx *wcn,
-			      struct ieee80211_vif *vif,
-			      struct ieee80211_sta *sta,
-			      struct wcn36xx_hal_config_sta_params_v1 *sta_par);
-void
+static void
 wcn36xx_smd_set_sta_params_v1(struct wcn36xx *wcn,
 			      struct ieee80211_vif *vif,
 			      struct ieee80211_sta *sta,
@@ -1520,18 +1502,12 @@ int wcn36xx_smd_config_sta(struct wcn36xx *wcn, struct ieee80211_vif *vif,
 	return ret;
 }
 
-void wcn36xx_smd_set_bss_params(struct wcn36xx *wcn,
-				struct ieee80211_vif *vif,
-				struct ieee80211_sta *sta,
-				const u8 *bssid,
-				bool update,
-				struct wcn36xx_hal_config_bss_params *bss);
-void wcn36xx_smd_set_bss_params(struct wcn36xx *wcn,
-				struct ieee80211_vif *vif,
-				struct ieee80211_sta *sta,
-				const u8 *bssid,
-				bool update,
-				struct wcn36xx_hal_config_bss_params *bss)
+static void wcn36xx_smd_set_bss_params(struct wcn36xx *wcn,
+				       struct ieee80211_vif *vif,
+				       struct ieee80211_sta *sta,
+				       const u8 *bssid,
+				       bool update,
+				       struct wcn36xx_hal_config_bss_params *bss)
 {
 	struct wcn36xx_vif *vif_priv = wcn36xx_vif_to_priv(vif);
 
@@ -1736,12 +1712,11 @@ static int wcn36xx_smd_config_bss_v1(struct wcn36xx *wcn,
 	return ret;
 }
 
-int wcn36xx_smd_config_bss_v0(struct wcn36xx *wcn, struct ieee80211_vif *vif,
-			      struct ieee80211_sta *sta, const u8 *bssid,
-			      bool update);
-int wcn36xx_smd_config_bss_v0(struct wcn36xx *wcn, struct ieee80211_vif *vif,
-			      struct ieee80211_sta *sta, const u8 *bssid,
-			      bool update)
+static int wcn36xx_smd_config_bss_v0(struct wcn36xx *wcn,
+				     struct ieee80211_vif *vif,
+				     struct ieee80211_sta *sta,
+				     const u8 *bssid,
+				     bool update)
 {
 	struct wcn36xx_hal_config_bss_req_msg *msg;
 	struct wcn36xx_hal_config_bss_params *bss;
-- 
2.27.0


^ permalink raw reply related	[flat|nested] 8+ messages in thread
* [PATCH v5 2/2] wcn36xx: Ensure spaces between functions
  2020-09-10 15:08 [PATCH v5 0/2] wcn36xx: Miscellaneous updates Bryan O'Donoghue
  2020-09-10 15:08 ` [PATCH v5 1/2] wcn36xx: Mark internal smd functions static Bryan O'Donoghue
@ 2020-09-10 15:08 ` Bryan O'Donoghue
  2020-09-10 15:55 ` [PATCH v5 0/2] wcn36xx: Miscellaneous updates Bryan O'Donoghue
  2 siblings, 0 replies; 8+ messages in thread
From: Bryan O'Donoghue @ 2020-09-10 15:08 UTC (permalink / raw)
  To: kvalo, wcn36xx, linux-wireless; +Cc: bryan.odonoghue, shawn.guo, loic.poulain

This is a small update to fix an error I saw where a few functions do not
have a blank line in between them.

Affects smd.c and main.c - no logic is affected by this change.

Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
---
 drivers/net/wireless/ath/wcn36xx/main.c | 1 +
 drivers/net/wireless/ath/wcn36xx/smd.c  | 4 ++++
 2 files changed, 5 insertions(+)

diff --git a/drivers/net/wireless/ath/wcn36xx/main.c b/drivers/net/wireless/ath/wcn36xx/main.c
index 43596b919ed7..706728fba72d 100644
--- a/drivers/net/wireless/ath/wcn36xx/main.c
+++ b/drivers/net/wireless/ath/wcn36xx/main.c
@@ -775,6 +775,7 @@ static void wcn36xx_update_allowed_rates(struct ieee80211_sta *sta,
 				sta->vht_cap.vht_mcs.tx_mcs_map;
 	}
 }
+
 void wcn36xx_set_default_rates(struct wcn36xx_hal_supported_rates *rates)
 {
 	u16 ofdm_rates[WCN36XX_HAL_NUM_OFDM_RATES] = {
diff --git a/drivers/net/wireless/ath/wcn36xx/smd.c b/drivers/net/wireless/ath/wcn36xx/smd.c
index bccdae62ffbc..766400f7b61c 100644
--- a/drivers/net/wireless/ath/wcn36xx/smd.c
+++ b/drivers/net/wireless/ath/wcn36xx/smd.c
@@ -218,6 +218,7 @@ static inline u8 is_cap_supported(unsigned long caps, unsigned long flag)
 {
 	return caps & flag ? 1 : 0;
 }
+
 static void wcn36xx_smd_set_bss_ht_params(struct ieee80211_vif *vif,
 		struct ieee80211_sta *sta,
 		struct wcn36xx_hal_config_bss_params *bss_params)
@@ -2191,6 +2192,7 @@ int wcn36xx_smd_exit_bmps(struct wcn36xx *wcn, struct ieee80211_vif *vif)
 	mutex_unlock(&wcn->hal_mutex);
 	return ret;
 }
+
 int wcn36xx_smd_set_power_params(struct wcn36xx *wcn, bool ignore_dtim)
 {
 	struct wcn36xx_hal_set_power_params_req_msg msg_body;
@@ -2220,6 +2222,7 @@ int wcn36xx_smd_set_power_params(struct wcn36xx *wcn, bool ignore_dtim)
 	mutex_unlock(&wcn->hal_mutex);
 	return ret;
 }
+
 /* Notice: This function should be called after associated, or else it
  * will be invalid
  */
@@ -2899,6 +2902,7 @@ static void wcn36xx_ind_smd_work(struct work_struct *work)
 		kfree(hal_ind_msg);
 	}
 }
+
 int wcn36xx_smd_open(struct wcn36xx *wcn)
 {
 	wcn->hal_ind_wq = create_freezable_workqueue("wcn36xx_smd_ind");
-- 
2.27.0


^ permalink raw reply related	[flat|nested] 8+ messages in thread
* Re: [PATCH v5 0/2] wcn36xx: Miscellaneous updates
  2020-09-10 15:08 [PATCH v5 0/2] wcn36xx: Miscellaneous updates Bryan O'Donoghue
  2020-09-10 15:08 ` [PATCH v5 1/2] wcn36xx: Mark internal smd functions static Bryan O'Donoghue
  2020-09-10 15:08 ` [PATCH v5 2/2] wcn36xx: Ensure spaces between functions Bryan O'Donoghue
@ 2020-09-10 15:55 ` Bryan O'Donoghue
  2020-09-10 16:07   ` Bryan O'Donoghue
                     ` (2 more replies)
  2 siblings, 3 replies; 8+ messages in thread
From: Bryan O'Donoghue @ 2020-09-10 15:55 UTC (permalink / raw)
  To: Bryan O'Donoghue, kvalo, wcn36xx, linux-wireless
  Cc: shawn.guo, loic.poulain

On 10/09/2020 16:08, Bryan O'Donoghue wrote:
> This series is seven in a set of seven to add support for wcn3680 at 802.11ac
> data-rates.
> 
> This set marks functions previously declared non-static as static. In order
> to facilitate granular standalone commits and avoid single patch
> code-bombs. A series of functions were previously declared non-static.
> Antecedent changes have made use of those functions so we can now mark them
> static.
> 
> In a similar theme of cleanup, I've added on a fix for some whitespace
> damage in main.c and smd.c which while not strictly related to wcn3680 I've
> opted to throw into the bucket under a "miscellaneous update" title.
> 
> Hope that's OK.
> 
> V5:
> - No change to V4 but need to send the set again so that
>    prerequisite-patch-id makes sense to the build robot here.
> 
> V4:
> - No functional change.
>    Sending out full set again using --base=ath-202009090652 to aid kernel
>    test robot
> - https://lore.kernel.org/linux-wireless/20200908183424.2871101-1-bryan.odonoghue@linaro.org/T/#t
> 
> V3/RESEND:
> - Messed up my .git/config resending from my @linaro.org address
> 
> Bryan O'Donoghue (2):
>    wcn36xx: Mark internal smd functions static
>    wcn36xx: Ensure spaces between functions
> 
>   drivers/net/wireless/ath/wcn36xx/main.c |  1 +
>   drivers/net/wireless/ath/wcn36xx/smd.c  | 65 +++++++++----------------
>   2 files changed, 23 insertions(+), 43 deletions(-)
> 
> 
> base-commit: 160b351d75cb50a0dd2abf9b63e1891935aa9e4a
> prerequisite-patch-id: 9a4ac7faca179f6594c9b3a115ee69a2da540a69
> prerequisite-patch-id: 183286f9c22d1aaa12f356651224e6b337ef1938
> prerequisite-patch-id: af468d413daaf8d2aad195fcb43c6e66390d8468
> prerequisite-patch-id: 08122a9557904ce5358f52dd08cc33270fa202c1
> prerequisite-patch-id: 82e0b7c5b2e9fa80baca001cce12577d98e306a9
> prerequisite-patch-id: 8ee7f5bd6cb5b7b7d713947b554ad93bb90d8230
> prerequisite-patch-id: d05c2253e4523b05b2e43491aa13ceeef68fd2f0
> prerequisite-patch-id: 8be29513d3efa64df15297bcf81ec3db55088ee1
> prerequisite-patch-id: d267dcd834afad75a69bcd2adcccfdad6566a7ba
> prerequisite-patch-id: 47145acae6e24e8e6580fca1dbddfbec24f7b50b
> prerequisite-patch-id: 8c66bccb923be821cf109a3a0d3a1a028edb4930
> prerequisite-patch-id: d0f5f3769b2963208fd2348840726fa1d3501b63
> prerequisite-patch-id: 746f63cf58fa3bf62736435c81dba2558aba8e81
> prerequisite-patch-id: 375bb7847ae74c63d2eacdbd0d73371aef1546fe
> prerequisite-patch-id: 8a598e22a08b0ec233d0ec56eeb53673eb1b8feb
> prerequisite-patch-id: b0eba574ddc35ecec2d0e39c0d3351d1b260420e
> prerequisite-patch-id: 143a1019813b7e4974a67e9eea1f1d599c0fdfdf
> prerequisite-patch-id: f66d9fe9eb731272b825c9430c15dca89d6c6129
> prerequisite-patch-id: c8c2d2dd1452c357f73fc4c92e5b564d59a05562
> prerequisite-patch-id: 273c13464a69354d32790ed7509472d9c2b11231
> prerequisite-patch-id: adbde1c98b85a16a6500b4210d4f055b9493418c
> prerequisite-patch-id: 559b6f9af6b26f860896dea4c7eb385ba9bdf0d5
> prerequisite-patch-id: 94c091c0c78b754d4c842a097a6db126bf6e770f
> prerequisite-patch-id: f2e549349c09f4675775b40bf9bb9b1f2bec6db8
> prerequisite-patch-id: c3a6aa788141f5b8782d28dac264470c8081bb97
> prerequisite-patch-id: 452450f26295dc4fc48dec07ba85538d78bae4b4
> prerequisite-patch-id: 8e7850077db9ec00df9be4fe3e0e4a4e8b06fbba
> prerequisite-patch-id: 233db8337812d9d34f99b41ccebd8758a6ada6d9
> prerequisite-patch-id: 0bbaaf402d2dd50a50aaa6505e5d10e743cf03e5
> 

Is there any reason these emails are percolating through this list so 
slowly ?

http://lists.infradead.org/pipermail/wcn36xx/2020-September/thread.html

^ permalink raw reply	[flat|nested] 8+ messages in thread
* Re: [PATCH v5 0/2] wcn36xx: Miscellaneous updates
  2020-09-10 15:55 ` [PATCH v5 0/2] wcn36xx: Miscellaneous updates Bryan O'Donoghue
@ 2020-09-10 16:07   ` Bryan O'Donoghue
  2020-09-10 16:22   ` Kalle Valo
       [not found]   ` <0101017478d3b3af-e0300995-fa17-44ef-b4c2-286469dfeb87-000000@us-west-2.amazonses.com>
  2 siblings, 0 replies; 8+ messages in thread
From: Bryan O'Donoghue @ 2020-09-10 16:07 UTC (permalink / raw)
  To: Bryan O'Donoghue, kvalo, wcn36xx, linux-wireless
  Cc: shawn.guo, loic.poulain

On 10/09/2020 16:55, Bryan O'Donoghue wrote:
> On 10/09/2020 16:08, Bryan O'Donoghue wrote:
>> This series is seven in a set of seven to add support for wcn3680 at 
>> 802.11ac
>> data-rates.
>>
>> This set marks functions previously declared non-static as static. In 
>> order
>> to facilitate granular standalone commits and avoid single patch
>> code-bombs. A series of functions were previously declared non-static.
>> Antecedent changes have made use of those functions so we can now mark 
>> them
>> static.
>>
>> In a similar theme of cleanup, I've added on a fix for some whitespace
>> damage in main.c and smd.c which while not strictly related to wcn3680 
>> I've
>> opted to throw into the bucket under a "miscellaneous update" title.
>>
>> Hope that's OK.
>>
>> V5:
>> - No change to V4 but need to send the set again so that
>>    prerequisite-patch-id makes sense to the build robot here.
>>
>> V4:
>> - No functional change.
>>    Sending out full set again using --base=ath-202009090652 to aid kernel
>>    test robot
>> - 
>> https://lore.kernel.org/linux-wireless/20200908183424.2871101-1-bryan.odonoghue@linaro.org/T/#t 
>>
>>
>> V3/RESEND:
>> - Messed up my .git/config resending from my @linaro.org address
>>
>> Bryan O'Donoghue (2):
>>    wcn36xx: Mark internal smd functions static
>>    wcn36xx: Ensure spaces between functions
>>
>>   drivers/net/wireless/ath/wcn36xx/main.c |  1 +
>>   drivers/net/wireless/ath/wcn36xx/smd.c  | 65 +++++++++----------------
>>   2 files changed, 23 insertions(+), 43 deletions(-)
>>
>>
>> base-commit: 160b351d75cb50a0dd2abf9b63e1891935aa9e4a
>> prerequisite-patch-id: 9a4ac7faca179f6594c9b3a115ee69a2da540a69
>> prerequisite-patch-id: 183286f9c22d1aaa12f356651224e6b337ef1938
>> prerequisite-patch-id: af468d413daaf8d2aad195fcb43c6e66390d8468
>> prerequisite-patch-id: 08122a9557904ce5358f52dd08cc33270fa202c1
>> prerequisite-patch-id: 82e0b7c5b2e9fa80baca001cce12577d98e306a9
>> prerequisite-patch-id: 8ee7f5bd6cb5b7b7d713947b554ad93bb90d8230
>> prerequisite-patch-id: d05c2253e4523b05b2e43491aa13ceeef68fd2f0
>> prerequisite-patch-id: 8be29513d3efa64df15297bcf81ec3db55088ee1
>> prerequisite-patch-id: d267dcd834afad75a69bcd2adcccfdad6566a7ba
>> prerequisite-patch-id: 47145acae6e24e8e6580fca1dbddfbec24f7b50b
>> prerequisite-patch-id: 8c66bccb923be821cf109a3a0d3a1a028edb4930
>> prerequisite-patch-id: d0f5f3769b2963208fd2348840726fa1d3501b63
>> prerequisite-patch-id: 746f63cf58fa3bf62736435c81dba2558aba8e81
>> prerequisite-patch-id: 375bb7847ae74c63d2eacdbd0d73371aef1546fe
>> prerequisite-patch-id: 8a598e22a08b0ec233d0ec56eeb53673eb1b8feb
>> prerequisite-patch-id: b0eba574ddc35ecec2d0e39c0d3351d1b260420e
>> prerequisite-patch-id: 143a1019813b7e4974a67e9eea1f1d599c0fdfdf
>> prerequisite-patch-id: f66d9fe9eb731272b825c9430c15dca89d6c6129
>> prerequisite-patch-id: c8c2d2dd1452c357f73fc4c92e5b564d59a05562
>> prerequisite-patch-id: 273c13464a69354d32790ed7509472d9c2b11231
>> prerequisite-patch-id: adbde1c98b85a16a6500b4210d4f055b9493418c
>> prerequisite-patch-id: 559b6f9af6b26f860896dea4c7eb385ba9bdf0d5
>> prerequisite-patch-id: 94c091c0c78b754d4c842a097a6db126bf6e770f
>> prerequisite-patch-id: f2e549349c09f4675775b40bf9bb9b1f2bec6db8
>> prerequisite-patch-id: c3a6aa788141f5b8782d28dac264470c8081bb97
>> prerequisite-patch-id: 452450f26295dc4fc48dec07ba85538d78bae4b4
>> prerequisite-patch-id: 8e7850077db9ec00df9be4fe3e0e4a4e8b06fbba
>> prerequisite-patch-id: 233db8337812d9d34f99b41ccebd8758a6ada6d9
>> prerequisite-patch-id: 0bbaaf402d2dd50a50aaa6505e5d10e743cf03e5
>>
> 
> Is there any reason these emails are percolating through this list so 
> slowly ?
> 
> http://lists.infradead.org/pipermail/wcn36xx/2020-September/thread.html

BTW this happened yesterday too, mails were visible in wcn36xx but not 
on linux-wireless. I sent a mail about it and the emails appeared.

Is there some sort of moderation queue ?

Every email is visible in the wcn36xx mailing list. For an unknown 
reason not arriving at linux-wireless.

For example the second email in this set. I have it in my inbox, in my 
sent items and it has appeared in wcn36xx

?

http://lists.infradead.org/pipermail/wcn36xx/2020-September/002234.html

^ permalink raw reply	[flat|nested] 8+ messages in thread
* Re: [PATCH v5 0/2] wcn36xx: Miscellaneous updates
  2020-09-10 15:55 ` [PATCH v5 0/2] wcn36xx: Miscellaneous updates Bryan O'Donoghue
  2020-09-10 16:07   ` Bryan O'Donoghue
@ 2020-09-10 16:22   ` Kalle Valo
       [not found]   ` <0101017478d3b3af-e0300995-fa17-44ef-b4c2-286469dfeb87-000000@us-west-2.amazonses.com>
  2 siblings, 0 replies; 8+ messages in thread
From: Kalle Valo @ 2020-09-10 16:22 UTC (permalink / raw)
  To: Bryan O'Donoghue
  Cc: Bryan O'Donoghue, wcn36xx, linux-wireless, shawn.guo, loic.poulain

Bryan O'Donoghue <pure.logic@nexus-software.ie> writes:

> On 10/09/2020 16:08, Bryan O'Donoghue wrote:
>> This series is seven in a set of seven to add support for wcn3680 at 802.11ac
>> data-rates.
>>
>> This set marks functions previously declared non-static as static. In order
>> to facilitate granular standalone commits and avoid single patch
>> code-bombs. A series of functions were previously declared non-static.
>> Antecedent changes have made use of those functions so we can now mark them
>> static.
>>
>> In a similar theme of cleanup, I've added on a fix for some whitespace
>> damage in main.c and smd.c which while not strictly related to wcn3680 I've
>> opted to throw into the bucket under a "miscellaneous update" title.
>>
>> Hope that's OK.
>>
>> V5:
>> - No change to V4 but need to send the set again so that
>>    prerequisite-patch-id makes sense to the build robot here.
>>
>> V4:
>> - No functional change.
>>    Sending out full set again using --base=ath-202009090652 to aid kernel
>>    test robot
>> - https://lore.kernel.org/linux-wireless/20200908183424.2871101-1-bryan.odonoghue@linaro.org/T/#t
>>
>> V3/RESEND:
>> - Messed up my .git/config resending from my @linaro.org address
>>
>> Bryan O'Donoghue (2):
>>    wcn36xx: Mark internal smd functions static
>>    wcn36xx: Ensure spaces between functions
>>
>>   drivers/net/wireless/ath/wcn36xx/main.c |  1 +
>>   drivers/net/wireless/ath/wcn36xx/smd.c  | 65 +++++++++----------------
>>   2 files changed, 23 insertions(+), 43 deletions(-)
>>
>>
>> base-commit: 160b351d75cb50a0dd2abf9b63e1891935aa9e4a
>> prerequisite-patch-id: 9a4ac7faca179f6594c9b3a115ee69a2da540a69
>> prerequisite-patch-id: 183286f9c22d1aaa12f356651224e6b337ef1938
>> prerequisite-patch-id: af468d413daaf8d2aad195fcb43c6e66390d8468
>> prerequisite-patch-id: 08122a9557904ce5358f52dd08cc33270fa202c1
>> prerequisite-patch-id: 82e0b7c5b2e9fa80baca001cce12577d98e306a9
>> prerequisite-patch-id: 8ee7f5bd6cb5b7b7d713947b554ad93bb90d8230
>> prerequisite-patch-id: d05c2253e4523b05b2e43491aa13ceeef68fd2f0
>> prerequisite-patch-id: 8be29513d3efa64df15297bcf81ec3db55088ee1
>> prerequisite-patch-id: d267dcd834afad75a69bcd2adcccfdad6566a7ba
>> prerequisite-patch-id: 47145acae6e24e8e6580fca1dbddfbec24f7b50b
>> prerequisite-patch-id: 8c66bccb923be821cf109a3a0d3a1a028edb4930
>> prerequisite-patch-id: d0f5f3769b2963208fd2348840726fa1d3501b63
>> prerequisite-patch-id: 746f63cf58fa3bf62736435c81dba2558aba8e81
>> prerequisite-patch-id: 375bb7847ae74c63d2eacdbd0d73371aef1546fe
>> prerequisite-patch-id: 8a598e22a08b0ec233d0ec56eeb53673eb1b8feb
>> prerequisite-patch-id: b0eba574ddc35ecec2d0e39c0d3351d1b260420e
>> prerequisite-patch-id: 143a1019813b7e4974a67e9eea1f1d599c0fdfdf
>> prerequisite-patch-id: f66d9fe9eb731272b825c9430c15dca89d6c6129
>> prerequisite-patch-id: c8c2d2dd1452c357f73fc4c92e5b564d59a05562
>> prerequisite-patch-id: 273c13464a69354d32790ed7509472d9c2b11231
>> prerequisite-patch-id: adbde1c98b85a16a6500b4210d4f055b9493418c
>> prerequisite-patch-id: 559b6f9af6b26f860896dea4c7eb385ba9bdf0d5
>> prerequisite-patch-id: 94c091c0c78b754d4c842a097a6db126bf6e770f
>> prerequisite-patch-id: f2e549349c09f4675775b40bf9bb9b1f2bec6db8
>> prerequisite-patch-id: c3a6aa788141f5b8782d28dac264470c8081bb97
>> prerequisite-patch-id: 452450f26295dc4fc48dec07ba85538d78bae4b4
>> prerequisite-patch-id: 8e7850077db9ec00df9be4fe3e0e4a4e8b06fbba
>> prerequisite-patch-id: 233db8337812d9d34f99b41ccebd8758a6ada6d9
>> prerequisite-patch-id: 0bbaaf402d2dd50a50aaa6505e5d10e743cf03e5
>>
>
> Is there any reason these emails are percolating through this list so
> slowly ?

I think vger has been slow the last few days, just give it time. At
least I have not yet noticed any mails gone missing.

But please stop with the patch bombs, they are making me crazy. For
example, even just changing the state of 36 patches in patchwork takes
time.

When I said to split the huge patchset into smaller patchsets I didn't
mean that you still send _all_ of them at the _same_ time, and _every_
time you change something. This is even worse than submitting one huge
patchset. The easiest way is to send one patchset first, wait for few
days (ideally wait for me to apply it) and then send a new one.

More info in the link below.

-- 
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches

^ permalink raw reply	[flat|nested] 8+ messages in thread
* Re: [PATCH v5 0/2] wcn36xx: Miscellaneous updates
       [not found]   ` <0101017478d3b3af-e0300995-fa17-44ef-b4c2-286469dfeb87-000000@us-west-2.amazonses.com>
@ 2020-09-10 16:28     ` Bryan O'Donoghue
  0 siblings, 0 replies; 8+ messages in thread
From: Bryan O'Donoghue @ 2020-09-10 16:28 UTC (permalink / raw)
  To: Kalle Valo, Bryan O'Donoghue
  Cc: wcn36xx, linux-wireless, shawn.guo, loic.poulain

On 10/09/2020 17:22, Kalle Valo wrote:
> I think vger has been slow the last few days, just give it time. At
> least I have not yet noticed any mails gone missing.

OK.


> When I said to split the huge patchset into smaller patchsets I didn't
> mean that you still send_all_  of them at the_same_  time, and_every_
> time you change something. This is even worse than submitting one huge
> patchset. The easiest way is to send one patchset first, wait for few
> days (ideally wait for me to apply it) and then send a new one.

Ah. Sorry about that.

I have until the end of the month with the hardware I'm working with, 
then I'll have to switch to some other platform.

I'll wait for you ;)


^ permalink raw reply	[flat|nested] 8+ messages in thread
* Re: [PATCH v5 1/2] wcn36xx: Mark internal smd functions static
  2020-09-10 15:08 ` [PATCH v5 1/2] wcn36xx: Mark internal smd functions static Bryan O'Donoghue
@ 2020-09-22  7:40   ` Kalle Valo
  0 siblings, 0 replies; 8+ messages in thread
From: Kalle Valo @ 2020-09-22  7:40 UTC (permalink / raw)
  To: Bryan O'Donoghue
  Cc: wcn36xx, linux-wireless, bryan.odonoghue, shawn.guo, loic.poulain

Bryan O'Donoghue <bryan.odonoghue@linaro.org> wrote:

> This commit marks all smd.c functions that are only used inside of smd.c as
> static. Previous commits added some VHT specific setup functions non-static
> which is the right thing to do in terms of having granular git commits that
> compile warning free. What we really want is for local not global scope on
> those functions.
> 
> This patch makes the conversion from global to local scope.
> 
> Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
> Signed-off-by: Kalle Valo <kvalo@codeaurora.org>

2 patches applied to ath-next branch of ath.git, thanks.

7f885b0bdf6f wcn36xx: Mark internal smd functions static
214091517f0c wcn36xx: Ensure spaces between functions

-- 
https://patchwork.kernel.org/patch/11768913/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches


^ permalink raw reply	[flat|nested] 8+ messages in thread
end of thread, other threads:[~2020-09-22  7:41 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-09-10 15:08 [PATCH v5 0/2] wcn36xx: Miscellaneous updates Bryan O'Donoghue
2020-09-10 15:08 ` [PATCH v5 1/2] wcn36xx: Mark internal smd functions static Bryan O'Donoghue
2020-09-22  7:40   ` Kalle Valo
2020-09-10 15:08 ` [PATCH v5 2/2] wcn36xx: Ensure spaces between functions Bryan O'Donoghue
2020-09-10 15:55 ` [PATCH v5 0/2] wcn36xx: Miscellaneous updates Bryan O'Donoghue
2020-09-10 16:07   ` Bryan O'Donoghue
2020-09-10 16:22   ` Kalle Valo
     [not found]   ` <0101017478d3b3af-e0300995-fa17-44ef-b4c2-286469dfeb87-000000@us-west-2.amazonses.com>
2020-09-10 16:28     ` Bryan O'Donoghue

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.