* [PATCH] sbus: char: Remove meaningless jump label out_free
@ 2020-09-11 7:13 ` Jing Xiangfeng
0 siblings, 0 replies; 4+ messages in thread
From: Jing Xiangfeng @ 2020-09-11 7:13 UTC (permalink / raw)
To: davem, dan.j.williams, dvhart, mchehab+samsung, gregkh, dsterba, arnd
Cc: sparclinux, linux-kernel, jingxiangfeng
After commit 57a4a3d7f756 ("display7seg: Introduce the use of the managed
version of kzalloc"), The out_free jump label has nothing to do but goto
out. So remove it.
Signed-off-by: Jing Xiangfeng <jingxiangfeng@huawei.com>
---
drivers/sbus/char/display7seg.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/sbus/char/display7seg.c b/drivers/sbus/char/display7seg.c
index fad936eb845f..00e72b97d0b6 100644
--- a/drivers/sbus/char/display7seg.c
+++ b/drivers/sbus/char/display7seg.c
@@ -186,7 +186,7 @@ static int d7s_probe(struct platform_device *op)
p->regs = of_ioremap(&op->resource[0], 0, sizeof(u8), "d7s");
if (!p->regs) {
printk(KERN_ERR PFX "Cannot map chip registers\n");
- goto out_free;
+ goto out;
}
err = misc_register(&d7s_miscdev);
@@ -228,8 +228,6 @@ static int d7s_probe(struct platform_device *op)
out_iounmap:
of_iounmap(&op->resource[0], p->regs, sizeof(u8));
-
-out_free:
goto out;
}
--
2.17.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH] sbus: char: Remove meaningless jump label out_free
@ 2020-09-11 7:13 ` Jing Xiangfeng
0 siblings, 0 replies; 4+ messages in thread
From: Jing Xiangfeng @ 2020-09-11 7:13 UTC (permalink / raw)
To: davem, dan.j.williams, dvhart, mchehab+samsung, gregkh, dsterba, arnd
Cc: sparclinux, linux-kernel, jingxiangfeng
After commit 57a4a3d7f756 ("display7seg: Introduce the use of the managed
version of kzalloc"), The out_free jump label has nothing to do but goto
out. So remove it.
Signed-off-by: Jing Xiangfeng <jingxiangfeng@huawei.com>
---
drivers/sbus/char/display7seg.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/sbus/char/display7seg.c b/drivers/sbus/char/display7seg.c
index fad936eb845f..00e72b97d0b6 100644
--- a/drivers/sbus/char/display7seg.c
+++ b/drivers/sbus/char/display7seg.c
@@ -186,7 +186,7 @@ static int d7s_probe(struct platform_device *op)
p->regs = of_ioremap(&op->resource[0], 0, sizeof(u8), "d7s");
if (!p->regs) {
printk(KERN_ERR PFX "Cannot map chip registers\n");
- goto out_free;
+ goto out;
}
err = misc_register(&d7s_miscdev);
@@ -228,8 +228,6 @@ static int d7s_probe(struct platform_device *op)
out_iounmap:
of_iounmap(&op->resource[0], p->regs, sizeof(u8));
-
-out_free:
goto out;
}
--
2.17.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] sbus: char: Remove meaningless jump label out_free
2020-09-11 7:13 ` Jing Xiangfeng
@ 2020-09-15 0:05 ` David Miller
-1 siblings, 0 replies; 4+ messages in thread
From: David Miller @ 2020-09-15 0:05 UTC (permalink / raw)
To: jingxiangfeng
Cc: dan.j.williams, dvhart, mchehab+samsung, gregkh, dsterba, arnd,
sparclinux, linux-kernel
From: Jing Xiangfeng <jingxiangfeng@huawei.com>
Date: Fri, 11 Sep 2020 15:13:41 +0800
> After commit 57a4a3d7f756 ("display7seg: Introduce the use of the managed
> version of kzalloc"), The out_free jump label has nothing to do but goto
> out. So remove it.
>
> Signed-off-by: Jing Xiangfeng <jingxiangfeng@huawei.com>
Applied, thank you.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] sbus: char: Remove meaningless jump label out_free
@ 2020-09-15 0:05 ` David Miller
0 siblings, 0 replies; 4+ messages in thread
From: David Miller @ 2020-09-15 0:05 UTC (permalink / raw)
To: jingxiangfeng
Cc: dan.j.williams, dvhart, mchehab+samsung, gregkh, dsterba, arnd,
sparclinux, linux-kernel
From: Jing Xiangfeng <jingxiangfeng@huawei.com>
Date: Fri, 11 Sep 2020 15:13:41 +0800
> After commit 57a4a3d7f756 ("display7seg: Introduce the use of the managed
> version of kzalloc"), The out_free jump label has nothing to do but goto
> out. So remove it.
>
> Signed-off-by: Jing Xiangfeng <jingxiangfeng@huawei.com>
Applied, thank you.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-09-15 0:05 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-09-11 7:13 [PATCH] sbus: char: Remove meaningless jump label out_free Jing Xiangfeng
2020-09-11 7:13 ` Jing Xiangfeng
2020-09-15 0:05 ` David Miller
2020-09-15 0:05 ` David Miller
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.