* [Intel-gfx] [PATCH] drm/i915/tgl, rkl: Make Wa_1606700617/22010271021 permanent
@ 2020-09-11 22:11 Swathi Dhanavanthri
2020-09-11 23:00 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork
` (2 more replies)
0 siblings, 3 replies; 7+ messages in thread
From: Swathi Dhanavanthri @ 2020-09-11 22:11 UTC (permalink / raw)
To: intel-gfx
This workaround applies to all TGL and RKL steppings.
Signed-off-by: Swathi Dhanavanthri <swathi.dhanavanthri@intel.com>
---
drivers/gpu/drm/i915/gt/intel_workarounds.c | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/i915/gt/intel_workarounds.c b/drivers/gpu/drm/i915/gt/intel_workarounds.c
index 39817c5a7058..6c580d0d9ea8 100644
--- a/drivers/gpu/drm/i915/gt/intel_workarounds.c
+++ b/drivers/gpu/drm/i915/gt/intel_workarounds.c
@@ -1729,10 +1729,11 @@ rcs_engine_wa_init(struct intel_engine_cs *engine, struct i915_wa_list *wal)
GEN6_RC_SLEEP_PSMI_CONTROL,
GEN12_WAIT_FOR_EVENT_POWER_DOWN_DISABLE |
GEN8_RC_SEMA_IDLE_MSG_DISABLE);
- }
- if (IS_TGL_U(i915) || IS_TGL_Y(i915)) {
- /* Wa_1606700617:tgl */
+ /*
+ * Wa_1606700617:tgl
+ * Wa_22010271021:tgl,rkl
+ */
wa_masked_en(wal,
GEN9_CS_DEBUG_MODE1,
FF_DOP_CLOCK_GATE_DISABLE);
--
2.20.1
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/tgl, rkl: Make Wa_1606700617/22010271021 permanent
2020-09-11 22:11 [Intel-gfx] [PATCH] drm/i915/tgl, rkl: Make Wa_1606700617/22010271021 permanent Swathi Dhanavanthri
@ 2020-09-11 23:00 ` Patchwork
2020-09-12 0:02 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
2020-09-12 1:10 ` [Intel-gfx] [PATCH] " Rodrigo Vivi
2 siblings, 0 replies; 7+ messages in thread
From: Patchwork @ 2020-09-11 23:00 UTC (permalink / raw)
To: Swathi Dhanavanthri; +Cc: intel-gfx
[-- Attachment #1.1: Type: text/plain, Size: 6599 bytes --]
== Series Details ==
Series: drm/i915/tgl, rkl: Make Wa_1606700617/22010271021 permanent
URL : https://patchwork.freedesktop.org/series/81608/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_9002 -> Patchwork_18484
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18484/index.html
Known issues
------------
Here are the changes found in Patchwork_18484 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_flink_basic@bad-flink:
- fi-tgl-y: [PASS][1] -> [DMESG-WARN][2] ([i915#402])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9002/fi-tgl-y/igt@gem_flink_basic@bad-flink.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18484/fi-tgl-y/igt@gem_flink_basic@bad-flink.html
* igt@i915_module_load@reload:
- fi-tgl-y: [PASS][3] -> [DMESG-WARN][4] ([i915#1982])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9002/fi-tgl-y/igt@i915_module_load@reload.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18484/fi-tgl-y/igt@i915_module_load@reload.html
* igt@kms_busy@basic@flip:
- fi-kbl-x1275: [PASS][5] -> [DMESG-WARN][6] ([i915#62] / [i915#92] / [i915#95])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9002/fi-kbl-x1275/igt@kms_busy@basic@flip.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18484/fi-kbl-x1275/igt@kms_busy@basic@flip.html
* igt@kms_cursor_legacy@basic-busy-flip-before-cursor-atomic:
- fi-icl-u2: [PASS][7] -> [DMESG-WARN][8] ([i915#1982])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9002/fi-icl-u2/igt@kms_cursor_legacy@basic-busy-flip-before-cursor-atomic.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18484/fi-icl-u2/igt@kms_cursor_legacy@basic-busy-flip-before-cursor-atomic.html
#### Possible fixes ####
* igt@gem_flink_basic@double-flink:
- fi-tgl-y: [DMESG-WARN][9] ([i915#402]) -> [PASS][10]
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9002/fi-tgl-y/igt@gem_flink_basic@double-flink.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18484/fi-tgl-y/igt@gem_flink_basic@double-flink.html
* igt@i915_selftest@live@execlists:
- fi-icl-y: [INCOMPLETE][11] ([i915#2276]) -> [PASS][12]
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9002/fi-icl-y/igt@i915_selftest@live@execlists.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18484/fi-icl-y/igt@i915_selftest@live@execlists.html
* igt@kms_cursor_legacy@basic-busy-flip-before-cursor-atomic:
- fi-bsw-kefka: [DMESG-WARN][13] ([i915#1982]) -> [PASS][14] +1 similar issue
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9002/fi-bsw-kefka/igt@kms_cursor_legacy@basic-busy-flip-before-cursor-atomic.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18484/fi-bsw-kefka/igt@kms_cursor_legacy@basic-busy-flip-before-cursor-atomic.html
* igt@kms_cursor_legacy@basic-busy-flip-before-cursor-legacy:
- fi-icl-u2: [DMESG-WARN][15] ([i915#1982]) -> [PASS][16] +2 similar issues
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9002/fi-icl-u2/igt@kms_cursor_legacy@basic-busy-flip-before-cursor-legacy.html
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18484/fi-icl-u2/igt@kms_cursor_legacy@basic-busy-flip-before-cursor-legacy.html
* igt@kms_flip@basic-flip-vs-wf_vblank@c-dp2:
- fi-skl-guc: [DMESG-WARN][17] ([i915#2203]) -> [PASS][18] +1 similar issue
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9002/fi-skl-guc/igt@kms_flip@basic-flip-vs-wf_vblank@c-dp2.html
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18484/fi-skl-guc/igt@kms_flip@basic-flip-vs-wf_vblank@c-dp2.html
#### Warnings ####
* igt@gem_exec_suspend@basic-s3:
- fi-tgl-y: [DMESG-WARN][19] ([i915#2411] / [i915#402]) -> [DMESG-WARN][20] ([i915#2411])
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9002/fi-tgl-y/igt@gem_exec_suspend@basic-s3.html
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18484/fi-tgl-y/igt@gem_exec_suspend@basic-s3.html
* igt@kms_force_connector_basic@prune-stale-modes:
- fi-kbl-x1275: [DMESG-WARN][21] ([i915#62] / [i915#92]) -> [DMESG-WARN][22] ([i915#62] / [i915#92] / [i915#95]) +2 similar issues
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9002/fi-kbl-x1275/igt@kms_force_connector_basic@prune-stale-modes.html
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18484/fi-kbl-x1275/igt@kms_force_connector_basic@prune-stale-modes.html
* igt@prime_vgem@basic-fence-flip:
- fi-kbl-x1275: [DMESG-WARN][23] ([i915#62] / [i915#92] / [i915#95]) -> [DMESG-WARN][24] ([i915#62] / [i915#92]) +4 similar issues
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9002/fi-kbl-x1275/igt@prime_vgem@basic-fence-flip.html
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18484/fi-kbl-x1275/igt@prime_vgem@basic-fence-flip.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[i915#1982]: https://gitlab.freedesktop.org/drm/intel/issues/1982
[i915#2203]: https://gitlab.freedesktop.org/drm/intel/issues/2203
[i915#2276]: https://gitlab.freedesktop.org/drm/intel/issues/2276
[i915#2411]: https://gitlab.freedesktop.org/drm/intel/issues/2411
[i915#402]: https://gitlab.freedesktop.org/drm/intel/issues/402
[i915#62]: https://gitlab.freedesktop.org/drm/intel/issues/62
[i915#92]: https://gitlab.freedesktop.org/drm/intel/issues/92
[i915#95]: https://gitlab.freedesktop.org/drm/intel/issues/95
Participating hosts (45 -> 38)
------------------------------
Missing (7): fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-cfl-guc fi-kbl-7560u fi-byt-clapper
Build changes
-------------
* Linux: CI_DRM_9002 -> Patchwork_18484
CI-20190529: 20190529
CI_DRM_9002: 575f7eba4c8b1a1f5bf95ca2e9e7bee055fea079 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5781: 66766dd7cd99465d977ac07db8a2413dbbfe8d84 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_18484: c643941caadff5070f14e0b2fc5c64600cb1c0fe @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
c643941caadf drm/i915/tgl, rkl: Make Wa_1606700617/22010271021 permanent
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18484/index.html
[-- Attachment #1.2: Type: text/html, Size: 8548 bytes --]
[-- Attachment #2: Type: text/plain, Size: 160 bytes --]
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 7+ messages in thread
* [Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/tgl, rkl: Make Wa_1606700617/22010271021 permanent
2020-09-11 22:11 [Intel-gfx] [PATCH] drm/i915/tgl, rkl: Make Wa_1606700617/22010271021 permanent Swathi Dhanavanthri
2020-09-11 23:00 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork
@ 2020-09-12 0:02 ` Patchwork
2020-09-12 1:10 ` [Intel-gfx] [PATCH] " Rodrigo Vivi
2 siblings, 0 replies; 7+ messages in thread
From: Patchwork @ 2020-09-12 0:02 UTC (permalink / raw)
To: Swathi Dhanavanthri; +Cc: intel-gfx
[-- Attachment #1.1: Type: text/plain, Size: 19158 bytes --]
== Series Details ==
Series: drm/i915/tgl, rkl: Make Wa_1606700617/22010271021 permanent
URL : https://patchwork.freedesktop.org/series/81608/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_9002_full -> Patchwork_18484_full
====================================================
Summary
-------
**SUCCESS**
No regressions found.
Known issues
------------
Here are the changes found in Patchwork_18484_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_exec_whisper@basic-normal-all:
- shard-glk: [PASS][1] -> [DMESG-WARN][2] ([i915#118] / [i915#95])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9002/shard-glk8/igt@gem_exec_whisper@basic-normal-all.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18484/shard-glk2/igt@gem_exec_whisper@basic-normal-all.html
* igt@gem_userptr_blits@sync-unmap-cycles:
- shard-skl: [PASS][3] -> [TIMEOUT][4] ([i915#1958] / [i915#2424])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9002/shard-skl10/igt@gem_userptr_blits@sync-unmap-cycles.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18484/shard-skl10/igt@gem_userptr_blits@sync-unmap-cycles.html
* igt@i915_pm_dc@dc6-psr:
- shard-iclb: [PASS][5] -> [FAIL][6] ([i915#454])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9002/shard-iclb2/igt@i915_pm_dc@dc6-psr.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18484/shard-iclb6/igt@i915_pm_dc@dc6-psr.html
* igt@i915_pm_rc6_residency@rc6-fence:
- shard-hsw: [PASS][7] -> [WARN][8] ([i915#1519])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9002/shard-hsw6/igt@i915_pm_rc6_residency@rc6-fence.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18484/shard-hsw4/igt@i915_pm_rc6_residency@rc6-fence.html
* igt@i915_pm_rpm@system-suspend-modeset:
- shard-skl: [PASS][9] -> [INCOMPLETE][10] ([i915#151])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9002/shard-skl2/igt@i915_pm_rpm@system-suspend-modeset.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18484/shard-skl1/igt@i915_pm_rpm@system-suspend-modeset.html
* igt@i915_selftest@mock@contexts:
- shard-apl: [PASS][11] -> [INCOMPLETE][12] ([i915#1635] / [i915#2278])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9002/shard-apl1/igt@i915_selftest@mock@contexts.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18484/shard-apl2/igt@i915_selftest@mock@contexts.html
* igt@kms_cursor_crc@pipe-a-cursor-suspend:
- shard-kbl: [PASS][13] -> [DMESG-WARN][14] ([i915#180]) +6 similar issues
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9002/shard-kbl1/igt@kms_cursor_crc@pipe-a-cursor-suspend.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18484/shard-kbl1/igt@kms_cursor_crc@pipe-a-cursor-suspend.html
* igt@kms_cursor_crc@pipe-b-cursor-suspend:
- shard-skl: [PASS][15] -> [INCOMPLETE][16] ([i915#300])
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9002/shard-skl3/igt@kms_cursor_crc@pipe-b-cursor-suspend.html
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18484/shard-skl9/igt@kms_cursor_crc@pipe-b-cursor-suspend.html
* igt@kms_cursor_crc@pipe-c-cursor-256x256-random:
- shard-skl: [PASS][17] -> [FAIL][18] ([i915#54])
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9002/shard-skl10/igt@kms_cursor_crc@pipe-c-cursor-256x256-random.html
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18484/shard-skl10/igt@kms_cursor_crc@pipe-c-cursor-256x256-random.html
* igt@kms_flip@flip-vs-suspend@c-edp1:
- shard-skl: [PASS][19] -> [INCOMPLETE][20] ([i915#198])
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9002/shard-skl1/igt@kms_flip@flip-vs-suspend@c-edp1.html
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18484/shard-skl3/igt@kms_flip@flip-vs-suspend@c-edp1.html
* igt@kms_flip@plain-flip-ts-check-interruptible@b-hdmi-a1:
- shard-glk: [PASS][21] -> [FAIL][22] ([i915#2122])
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9002/shard-glk4/igt@kms_flip@plain-flip-ts-check-interruptible@b-hdmi-a1.html
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18484/shard-glk4/igt@kms_flip@plain-flip-ts-check-interruptible@b-hdmi-a1.html
* igt@kms_frontbuffer_tracking@fbc-shrfb-scaledprimary:
- shard-iclb: [PASS][23] -> [DMESG-WARN][24] ([i915#1982])
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9002/shard-iclb6/igt@kms_frontbuffer_tracking@fbc-shrfb-scaledprimary.html
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18484/shard-iclb3/igt@kms_frontbuffer_tracking@fbc-shrfb-scaledprimary.html
* igt@kms_frontbuffer_tracking@fbcpsr-rgb101010-draw-render:
- shard-tglb: [PASS][25] -> [DMESG-WARN][26] ([i915#1982]) +4 similar issues
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9002/shard-tglb3/igt@kms_frontbuffer_tracking@fbcpsr-rgb101010-draw-render.html
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18484/shard-tglb2/igt@kms_frontbuffer_tracking@fbcpsr-rgb101010-draw-render.html
* igt@kms_frontbuffer_tracking@psr-1p-offscren-pri-indfb-draw-mmap-gtt:
- shard-skl: [PASS][27] -> [DMESG-WARN][28] ([i915#1982]) +4 similar issues
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9002/shard-skl10/igt@kms_frontbuffer_tracking@psr-1p-offscren-pri-indfb-draw-mmap-gtt.html
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18484/shard-skl10/igt@kms_frontbuffer_tracking@psr-1p-offscren-pri-indfb-draw-mmap-gtt.html
* igt@kms_hdr@bpc-switch-suspend:
- shard-skl: [PASS][29] -> [FAIL][30] ([i915#1188])
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9002/shard-skl7/igt@kms_hdr@bpc-switch-suspend.html
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18484/shard-skl4/igt@kms_hdr@bpc-switch-suspend.html
* igt@kms_plane_alpha_blend@pipe-b-coverage-7efc:
- shard-skl: [PASS][31] -> [FAIL][32] ([fdo#108145] / [i915#265])
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9002/shard-skl3/igt@kms_plane_alpha_blend@pipe-b-coverage-7efc.html
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18484/shard-skl2/igt@kms_plane_alpha_blend@pipe-b-coverage-7efc.html
* igt@kms_psr@psr2_primary_mmap_gtt:
- shard-iclb: [PASS][33] -> [SKIP][34] ([fdo#109441]) +2 similar issues
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9002/shard-iclb2/igt@kms_psr@psr2_primary_mmap_gtt.html
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18484/shard-iclb6/igt@kms_psr@psr2_primary_mmap_gtt.html
* igt@perf@polling-parameterized:
- shard-skl: [PASS][35] -> [FAIL][36] ([i915#1542])
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9002/shard-skl1/igt@perf@polling-parameterized.html
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18484/shard-skl3/igt@perf@polling-parameterized.html
#### Possible fixes ####
* igt@gem_ctx_persistence@engines-mixed-process@bcs0:
- shard-kbl: [FAIL][37] ([i915#2374]) -> [PASS][38]
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9002/shard-kbl1/igt@gem_ctx_persistence@engines-mixed-process@bcs0.html
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18484/shard-kbl1/igt@gem_ctx_persistence@engines-mixed-process@bcs0.html
* igt@gem_exec_reloc@basic-many-active@vecs0:
- shard-glk: [FAIL][39] ([i915#2389]) -> [PASS][40]
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9002/shard-glk7/igt@gem_exec_reloc@basic-many-active@vecs0.html
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18484/shard-glk8/igt@gem_exec_reloc@basic-many-active@vecs0.html
* igt@kms_cursor_crc@pipe-c-cursor-suspend:
- shard-kbl: [DMESG-WARN][41] ([i915#180]) -> [PASS][42] +1 similar issue
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9002/shard-kbl4/igt@kms_cursor_crc@pipe-c-cursor-suspend.html
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18484/shard-kbl2/igt@kms_cursor_crc@pipe-c-cursor-suspend.html
* igt@kms_cursor_edge_walk@pipe-a-256x256-left-edge:
- shard-tglb: [INCOMPLETE][43] ([i915#750]) -> [PASS][44]
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9002/shard-tglb8/igt@kms_cursor_edge_walk@pipe-a-256x256-left-edge.html
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18484/shard-tglb3/igt@kms_cursor_edge_walk@pipe-a-256x256-left-edge.html
* igt@kms_cursor_edge_walk@pipe-c-128x128-top-edge:
- shard-glk: [DMESG-WARN][45] ([i915#1982]) -> [PASS][46]
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9002/shard-glk6/igt@kms_cursor_edge_walk@pipe-c-128x128-top-edge.html
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18484/shard-glk1/igt@kms_cursor_edge_walk@pipe-c-128x128-top-edge.html
* igt@kms_cursor_legacy@2x-long-cursor-vs-flip-legacy:
- shard-hsw: [FAIL][47] ([i915#96]) -> [PASS][48]
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9002/shard-hsw6/igt@kms_cursor_legacy@2x-long-cursor-vs-flip-legacy.html
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18484/shard-hsw4/igt@kms_cursor_legacy@2x-long-cursor-vs-flip-legacy.html
* igt@kms_cursor_legacy@short-flip-after-cursor-atomic-transitions-varying-size:
- shard-kbl: [DMESG-WARN][49] ([i915#1982]) -> [PASS][50]
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9002/shard-kbl6/igt@kms_cursor_legacy@short-flip-after-cursor-atomic-transitions-varying-size.html
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18484/shard-kbl3/igt@kms_cursor_legacy@short-flip-after-cursor-atomic-transitions-varying-size.html
* igt@kms_flip@2x-flip-vs-expired-vblank@bc-hdmi-a1-hdmi-a2:
- shard-glk: [FAIL][51] ([i915#79]) -> [PASS][52]
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9002/shard-glk1/igt@kms_flip@2x-flip-vs-expired-vblank@bc-hdmi-a1-hdmi-a2.html
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18484/shard-glk6/igt@kms_flip@2x-flip-vs-expired-vblank@bc-hdmi-a1-hdmi-a2.html
* igt@kms_flip@2x-plain-flip-fb-recreate@ac-hdmi-a1-hdmi-a2:
- shard-glk: [FAIL][53] ([i915#2122]) -> [PASS][54]
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9002/shard-glk3/igt@kms_flip@2x-plain-flip-fb-recreate@ac-hdmi-a1-hdmi-a2.html
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18484/shard-glk9/igt@kms_flip@2x-plain-flip-fb-recreate@ac-hdmi-a1-hdmi-a2.html
* igt@kms_flip@flip-vs-suspend-interruptible@c-hdmi-a1:
- shard-hsw: [INCOMPLETE][55] ([i915#2055]) -> [PASS][56]
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9002/shard-hsw4/igt@kms_flip@flip-vs-suspend-interruptible@c-hdmi-a1.html
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18484/shard-hsw8/igt@kms_flip@flip-vs-suspend-interruptible@c-hdmi-a1.html
* igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-spr-indfb-move:
- shard-tglb: [DMESG-WARN][57] ([i915#1982]) -> [PASS][58] +1 similar issue
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9002/shard-tglb5/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-spr-indfb-move.html
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18484/shard-tglb1/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-spr-indfb-move.html
* igt@kms_hdr@bpc-switch:
- shard-skl: [FAIL][59] ([i915#1188]) -> [PASS][60]
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9002/shard-skl1/igt@kms_hdr@bpc-switch.html
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18484/shard-skl2/igt@kms_hdr@bpc-switch.html
* igt@kms_plane@plane-panning-bottom-right-suspend-pipe-a-planes:
- shard-skl: [FAIL][61] ([i915#1036]) -> [PASS][62]
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9002/shard-skl6/igt@kms_plane@plane-panning-bottom-right-suspend-pipe-a-planes.html
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18484/shard-skl8/igt@kms_plane@plane-panning-bottom-right-suspend-pipe-a-planes.html
* igt@kms_plane_alpha_blend@pipe-b-constant-alpha-min:
- shard-skl: [FAIL][63] ([fdo#108145] / [i915#265]) -> [PASS][64]
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9002/shard-skl6/igt@kms_plane_alpha_blend@pipe-b-constant-alpha-min.html
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18484/shard-skl8/igt@kms_plane_alpha_blend@pipe-b-constant-alpha-min.html
* igt@kms_psr@psr2_primary_mmap_cpu:
- shard-iclb: [SKIP][65] ([fdo#109441]) -> [PASS][66] +2 similar issues
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9002/shard-iclb7/igt@kms_psr@psr2_primary_mmap_cpu.html
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18484/shard-iclb2/igt@kms_psr@psr2_primary_mmap_cpu.html
* igt@kms_setmode@basic:
- shard-glk: [FAIL][67] ([i915#31]) -> [PASS][68]
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9002/shard-glk6/igt@kms_setmode@basic.html
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18484/shard-glk9/igt@kms_setmode@basic.html
* igt@prime_mmap@test_refcounting:
- shard-skl: [DMESG-WARN][69] ([i915#1982]) -> [PASS][70] +3 similar issues
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9002/shard-skl10/igt@prime_mmap@test_refcounting.html
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18484/shard-skl10/igt@prime_mmap@test_refcounting.html
#### Warnings ####
* igt@i915_pm_dc@dc3co-vpb-simulation:
- shard-iclb: [SKIP][71] ([i915#588]) -> [SKIP][72] ([i915#658])
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9002/shard-iclb2/igt@i915_pm_dc@dc3co-vpb-simulation.html
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18484/shard-iclb6/igt@i915_pm_dc@dc3co-vpb-simulation.html
* igt@i915_suspend@forcewake:
- shard-kbl: [INCOMPLETE][73] ([i915#155] / [i915#636]) -> [DMESG-WARN][74] ([i915#180])
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9002/shard-kbl3/igt@i915_suspend@forcewake.html
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18484/shard-kbl7/igt@i915_suspend@forcewake.html
* igt@kms_color@pipe-c-ctm-0-25:
- shard-skl: [DMESG-FAIL][75] ([i915#1982]) -> [DMESG-WARN][76] ([i915#1982])
[75]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9002/shard-skl9/igt@kms_color@pipe-c-ctm-0-25.html
[76]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18484/shard-skl3/igt@kms_color@pipe-c-ctm-0-25.html
* igt@kms_plane_alpha_blend@pipe-a-constant-alpha-min:
- shard-skl: [FAIL][77] ([fdo#108145] / [i915#265]) -> [DMESG-WARN][78] ([i915#1982])
[77]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9002/shard-skl6/igt@kms_plane_alpha_blend@pipe-a-constant-alpha-min.html
[78]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18484/shard-skl8/igt@kms_plane_alpha_blend@pipe-a-constant-alpha-min.html
* igt@kms_plane_alpha_blend@pipe-c-coverage-7efc:
- shard-skl: [FAIL][79] ([fdo#108145] / [i915#265]) -> [DMESG-FAIL][80] ([fdo#108145] / [i915#1982]) +1 similar issue
[79]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9002/shard-skl10/igt@kms_plane_alpha_blend@pipe-c-coverage-7efc.html
[80]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18484/shard-skl10/igt@kms_plane_alpha_blend@pipe-c-coverage-7efc.html
* igt@runner@aborted:
- shard-skl: ([FAIL][81], [FAIL][82]) ([i915#1436] / [i915#1611] / [i915#1814] / [i915#2029]) -> [FAIL][83] ([i915#1436])
[81]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9002/shard-skl6/igt@runner@aborted.html
[82]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9002/shard-skl8/igt@runner@aborted.html
[83]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18484/shard-skl6/igt@runner@aborted.html
[fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
[fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
[i915#1036]: https://gitlab.freedesktop.org/drm/intel/issues/1036
[i915#118]: https://gitlab.freedesktop.org/drm/intel/issues/118
[i915#1188]: https://gitlab.freedesktop.org/drm/intel/issues/1188
[i915#1436]: https://gitlab.freedesktop.org/drm/intel/issues/1436
[i915#151]: https://gitlab.freedesktop.org/drm/intel/issues/151
[i915#1519]: https://gitlab.freedesktop.org/drm/intel/issues/1519
[i915#1542]: https://gitlab.freedesktop.org/drm/intel/issues/1542
[i915#155]: https://gitlab.freedesktop.org/drm/intel/issues/155
[i915#1611]: https://gitlab.freedesktop.org/drm/intel/issues/1611
[i915#1635]: https://gitlab.freedesktop.org/drm/intel/issues/1635
[i915#180]: https://gitlab.freedesktop.org/drm/intel/issues/180
[i915#1814]: https://gitlab.freedesktop.org/drm/intel/issues/1814
[i915#1958]: https://gitlab.freedesktop.org/drm/intel/issues/1958
[i915#198]: https://gitlab.freedesktop.org/drm/intel/issues/198
[i915#1982]: https://gitlab.freedesktop.org/drm/intel/issues/1982
[i915#2029]: https://gitlab.freedesktop.org/drm/intel/issues/2029
[i915#2055]: https://gitlab.freedesktop.org/drm/intel/issues/2055
[i915#2122]: https://gitlab.freedesktop.org/drm/intel/issues/2122
[i915#2278]: https://gitlab.freedesktop.org/drm/intel/issues/2278
[i915#2374]: https://gitlab.freedesktop.org/drm/intel/issues/2374
[i915#2389]: https://gitlab.freedesktop.org/drm/intel/issues/2389
[i915#2424]: https://gitlab.freedesktop.org/drm/intel/issues/2424
[i915#265]: https://gitlab.freedesktop.org/drm/intel/issues/265
[i915#300]: https://gitlab.freedesktop.org/drm/intel/issues/300
[i915#31]: https://gitlab.freedesktop.org/drm/intel/issues/31
[i915#454]: https://gitlab.freedesktop.org/drm/intel/issues/454
[i915#54]: https://gitlab.freedesktop.org/drm/intel/issues/54
[i915#588]: https://gitlab.freedesktop.org/drm/intel/issues/588
[i915#636]: https://gitlab.freedesktop.org/drm/intel/issues/636
[i915#658]: https://gitlab.freedesktop.org/drm/intel/issues/658
[i915#750]: https://gitlab.freedesktop.org/drm/intel/issues/750
[i915#79]: https://gitlab.freedesktop.org/drm/intel/issues/79
[i915#95]: https://gitlab.freedesktop.org/drm/intel/issues/95
[i915#96]: https://gitlab.freedesktop.org/drm/intel/issues/96
Participating hosts (12 -> 11)
------------------------------
Missing (1): pig-snb-2600
Build changes
-------------
* Linux: CI_DRM_9002 -> Patchwork_18484
CI-20190529: 20190529
CI_DRM_9002: 575f7eba4c8b1a1f5bf95ca2e9e7bee055fea079 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5781: 66766dd7cd99465d977ac07db8a2413dbbfe8d84 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_18484: c643941caadff5070f14e0b2fc5c64600cb1c0fe @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18484/index.html
[-- Attachment #1.2: Type: text/html, Size: 22291 bytes --]
[-- Attachment #2: Type: text/plain, Size: 160 bytes --]
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915/tgl, rkl: Make Wa_1606700617/22010271021 permanent
2020-09-11 22:11 [Intel-gfx] [PATCH] drm/i915/tgl, rkl: Make Wa_1606700617/22010271021 permanent Swathi Dhanavanthri
2020-09-11 23:00 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork
2020-09-12 0:02 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
@ 2020-09-12 1:10 ` Rodrigo Vivi
2020-09-12 4:00 ` Dhanavanthri, Swathi
2 siblings, 1 reply; 7+ messages in thread
From: Rodrigo Vivi @ 2020-09-12 1:10 UTC (permalink / raw)
To: Swathi Dhanavanthri; +Cc: intel-gfx
On Fri, Sep 11, 2020 at 03:11:58PM -0700, Swathi Dhanavanthri wrote:
> This workaround applies to all TGL and RKL steppings.
>
> Signed-off-by: Swathi Dhanavanthri <swathi.dhanavanthri@intel.com>
> ---
> drivers/gpu/drm/i915/gt/intel_workarounds.c | 7 ++++---
> 1 file changed, 4 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/gt/intel_workarounds.c b/drivers/gpu/drm/i915/gt/intel_workarounds.c
> index 39817c5a7058..6c580d0d9ea8 100644
> --- a/drivers/gpu/drm/i915/gt/intel_workarounds.c
> +++ b/drivers/gpu/drm/i915/gt/intel_workarounds.c
> @@ -1729,10 +1729,11 @@ rcs_engine_wa_init(struct intel_engine_cs *engine, struct i915_wa_list *wal)
> GEN6_RC_SLEEP_PSMI_CONTROL,
> GEN12_WAIT_FOR_EVENT_POWER_DOWN_DISABLE |
> GEN8_RC_SEMA_IDLE_MSG_DISABLE);
> - }
>
> - if (IS_TGL_U(i915) || IS_TGL_Y(i915)) {
please notice this function is called for other gens.
In case you need to extend this to other platforms, please add them
to the if instead of removing the if.
> - /* Wa_1606700617:tgl */
> + /*
> + * Wa_1606700617:tgl
> + * Wa_22010271021:tgl,rkl
> + */
> wa_masked_en(wal,
> GEN9_CS_DEBUG_MODE1,
> FF_DOP_CLOCK_GATE_DISABLE);
> --
> 2.20.1
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915/tgl, rkl: Make Wa_1606700617/22010271021 permanent
2020-09-12 1:10 ` [Intel-gfx] [PATCH] " Rodrigo Vivi
@ 2020-09-12 4:00 ` Dhanavanthri, Swathi
2020-09-14 20:05 ` Vivi, Rodrigo
0 siblings, 1 reply; 7+ messages in thread
From: Dhanavanthri, Swathi @ 2020-09-12 4:00 UTC (permalink / raw)
To: Vivi, Rodrigo; +Cc: intel-gfx
It is in the if statement: if (IS_ROCKETLAKE(i915) || IS_TIGERLAKE(i915)) {
-----Original Message-----
From: Rodrigo Vivi <rodrigo.vivi@intel.com>
Sent: Friday, September 11, 2020 6:10 PM
To: Dhanavanthri, Swathi <swathi.dhanavanthri@intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [Intel-gfx] [PATCH] drm/i915/tgl, rkl: Make Wa_1606700617/22010271021 permanent
On Fri, Sep 11, 2020 at 03:11:58PM -0700, Swathi Dhanavanthri wrote:
> This workaround applies to all TGL and RKL steppings.
>
> Signed-off-by: Swathi Dhanavanthri <swathi.dhanavanthri@intel.com>
> ---
> drivers/gpu/drm/i915/gt/intel_workarounds.c | 7 ++++---
> 1 file changed, 4 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/gt/intel_workarounds.c
> b/drivers/gpu/drm/i915/gt/intel_workarounds.c
> index 39817c5a7058..6c580d0d9ea8 100644
> --- a/drivers/gpu/drm/i915/gt/intel_workarounds.c
> +++ b/drivers/gpu/drm/i915/gt/intel_workarounds.c
> @@ -1729,10 +1729,11 @@ rcs_engine_wa_init(struct intel_engine_cs *engine, struct i915_wa_list *wal)
> GEN6_RC_SLEEP_PSMI_CONTROL,
> GEN12_WAIT_FOR_EVENT_POWER_DOWN_DISABLE |
> GEN8_RC_SEMA_IDLE_MSG_DISABLE);
> - }
>
> - if (IS_TGL_U(i915) || IS_TGL_Y(i915)) {
please notice this function is called for other gens.
In case you need to extend this to other platforms, please add them to the if instead of removing the if.
> - /* Wa_1606700617:tgl */
> + /*
> + * Wa_1606700617:tgl
> + * Wa_22010271021:tgl,rkl
> + */
> wa_masked_en(wal,
> GEN9_CS_DEBUG_MODE1,
> FF_DOP_CLOCK_GATE_DISABLE);
> --
> 2.20.1
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915/tgl, rkl: Make Wa_1606700617/22010271021 permanent
2020-09-12 4:00 ` Dhanavanthri, Swathi
@ 2020-09-14 20:05 ` Vivi, Rodrigo
2020-09-14 23:56 ` Vivi, Rodrigo
0 siblings, 1 reply; 7+ messages in thread
From: Vivi, Rodrigo @ 2020-09-14 20:05 UTC (permalink / raw)
To: Dhanavanthri, Swathi; +Cc: intel-gfx
> On Sep 11, 2020, at 9:00 PM, Dhanavanthri, Swathi <swathi.dhanavanthri@intel.com> wrote:
>
> It is in the if statement: if (IS_ROCKETLAKE(i915) || IS_TIGERLAKE(i915)) {
duh! sorry...
more below:
>
> -----Original Message-----
> From: Rodrigo Vivi <rodrigo.vivi@intel.com>
> Sent: Friday, September 11, 2020 6:10 PM
> To: Dhanavanthri, Swathi <swathi.dhanavanthri@intel.com>
> Cc: intel-gfx@lists.freedesktop.org
> Subject: Re: [Intel-gfx] [PATCH] drm/i915/tgl, rkl: Make Wa_1606700617/22010271021 permanent
>
> On Fri, Sep 11, 2020 at 03:11:58PM -0700, Swathi Dhanavanthri wrote:
>> This workaround applies to all TGL and RKL steppings.
>>
>> Signed-off-by: Swathi Dhanavanthri <swathi.dhanavanthri@intel.com>
>> ---
>> drivers/gpu/drm/i915/gt/intel_workarounds.c | 7 ++++---
>> 1 file changed, 4 insertions(+), 3 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/i915/gt/intel_workarounds.c
>> b/drivers/gpu/drm/i915/gt/intel_workarounds.c
>> index 39817c5a7058..6c580d0d9ea8 100644
>> --- a/drivers/gpu/drm/i915/gt/intel_workarounds.c
>> +++ b/drivers/gpu/drm/i915/gt/intel_workarounds.c
>> @@ -1729,10 +1729,11 @@ rcs_engine_wa_init(struct intel_engine_cs *engine, struct i915_wa_list *wal)
>> GEN6_RC_SLEEP_PSMI_CONTROL,
>> GEN12_WAIT_FOR_EVENT_POWER_DOWN_DISABLE |
>> GEN8_RC_SEMA_IDLE_MSG_DISABLE);
>> - }
now I noticed this ^ :)
>>
>> - if (IS_TGL_U(i915) || IS_TGL_Y(i915)) {
>
> please notice this function is called for other gens.
> In case you need to extend this to other platforms, please add them to the if instead of removing the if.
>
>> - /* Wa_1606700617:tgl */
>> + /*
>> + * Wa_1606700617:tgl
>> + * Wa_22010271021:tgl,rkl
1. This HSD only mentions TGL-U. No mention to RKL.
2. No mention to anything related to this clock gate.
3. Actually no W/a description at all and no sw_impact at all. But It links to another entry 22010288313,
which describes the w/a as a 3dstate ff one...
What am I missing here?
Thanks,
Rodrigo.
>> + */
>> wa_masked_en(wal,
>> GEN9_CS_DEBUG_MODE1,
>> FF_DOP_CLOCK_GATE_DISABLE);
>> --
>> 2.20.1
>>
>> _______________________________________________
>> Intel-gfx mailing list
>> Intel-gfx@lists.freedesktop.org
>> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915/tgl, rkl: Make Wa_1606700617/22010271021 permanent
2020-09-14 20:05 ` Vivi, Rodrigo
@ 2020-09-14 23:56 ` Vivi, Rodrigo
0 siblings, 0 replies; 7+ messages in thread
From: Vivi, Rodrigo @ 2020-09-14 23:56 UTC (permalink / raw)
To: Dhanavanthri, Swathi; +Cc: intel-gfx
> On Sep 14, 2020, at 1:05 PM, Vivi, Rodrigo <rodrigo.vivi@intel.com> wrote:
>
>
>
>> On Sep 11, 2020, at 9:00 PM, Dhanavanthri, Swathi <swathi.dhanavanthri@intel.com> wrote:
>>
>> It is in the if statement: if (IS_ROCKETLAKE(i915) || IS_TIGERLAKE(i915)) {
>
> duh! sorry...
>
> more below:
>
>>
>> -----Original Message-----
>> From: Rodrigo Vivi <rodrigo.vivi@intel.com>
>> Sent: Friday, September 11, 2020 6:10 PM
>> To: Dhanavanthri, Swathi <swathi.dhanavanthri@intel.com>
>> Cc: intel-gfx@lists.freedesktop.org
>> Subject: Re: [Intel-gfx] [PATCH] drm/i915/tgl, rkl: Make Wa_1606700617/22010271021 permanent
>>
>> On Fri, Sep 11, 2020 at 03:11:58PM -0700, Swathi Dhanavanthri wrote:
>>> This workaround applies to all TGL and RKL steppings.
>>>
>>> Signed-off-by: Swathi Dhanavanthri <swathi.dhanavanthri@intel.com>
>>> ---
>>> drivers/gpu/drm/i915/gt/intel_workarounds.c | 7 ++++---
>>> 1 file changed, 4 insertions(+), 3 deletions(-)
>>>
>>> diff --git a/drivers/gpu/drm/i915/gt/intel_workarounds.c
>>> b/drivers/gpu/drm/i915/gt/intel_workarounds.c
>>> index 39817c5a7058..6c580d0d9ea8 100644
>>> --- a/drivers/gpu/drm/i915/gt/intel_workarounds.c
>>> +++ b/drivers/gpu/drm/i915/gt/intel_workarounds.c
>>> @@ -1729,10 +1729,11 @@ rcs_engine_wa_init(struct intel_engine_cs *engine, struct i915_wa_list *wal)
>>> GEN6_RC_SLEEP_PSMI_CONTROL,
>>> GEN12_WAIT_FOR_EVENT_POWER_DOWN_DISABLE |
>>> GEN8_RC_SEMA_IDLE_MSG_DISABLE);
>>> - }
>
> now I noticed this ^ :)
>
>>>
>>> - if (IS_TGL_U(i915) || IS_TGL_Y(i915)) {
>>
>> please notice this function is called for other gens.
>> In case you need to extend this to other platforms, please add them to the if instead of removing the if.
>>
>>> - /* Wa_1606700617:tgl */
>>> + /*
>>> + * Wa_1606700617:tgl
>>> + * Wa_22010271021:tgl,rkl
>
> 1. This HSD only mentions TGL-U. No mention to RKL.
> 2. No mention to anything related to this clock gate.
> 3. Actually no W/a description at all and no sw_impact at all. But It links to another entry 22010288313,
> which describes the w/a as a 3dstate ff one...
>
> What am I missing here?
missing that old bspec page of course. Thanks for pointing it out...
Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
>
> Thanks,
> Rodrigo.
>
>>> + */
>>> wa_masked_en(wal,
>>> GEN9_CS_DEBUG_MODE1,
>>> FF_DOP_CLOCK_GATE_DISABLE);
>>> --
>>> 2.20.1
>>>
>>> _______________________________________________
>>> Intel-gfx mailing list
>>> Intel-gfx@lists.freedesktop.org
>>> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2020-09-14 23:56 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-09-11 22:11 [Intel-gfx] [PATCH] drm/i915/tgl, rkl: Make Wa_1606700617/22010271021 permanent Swathi Dhanavanthri
2020-09-11 23:00 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork
2020-09-12 0:02 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
2020-09-12 1:10 ` [Intel-gfx] [PATCH] " Rodrigo Vivi
2020-09-12 4:00 ` Dhanavanthri, Swathi
2020-09-14 20:05 ` Vivi, Rodrigo
2020-09-14 23:56 ` Vivi, Rodrigo
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.