All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH 1/1] net: use log_err() for 'No ethernet found' message
@ 2020-09-14  9:00 Heinrich Schuchardt
  2020-09-17  1:10 ` Simon Glass
  2020-10-01 14:10 ` Tom Rini
  0 siblings, 2 replies; 3+ messages in thread
From: Heinrich Schuchardt @ 2020-09-14  9:00 UTC (permalink / raw)
  To: u-boot

Write the 'No ethernet found' message via the log drivers. This allows
suppressing it during output via the syslog driver.

This fixes the problem reported in:

[PATCH 0/4] log: Fix the syslog spam when running tests
https://lists.denx.de/pipermail/u-boot/2020-September/426343.html

Reported-by: Simon Glass <sjg@chromium.org>
Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
---
 net/eth-uclass.c | 6 +++---
 net/eth_legacy.c | 4 ++--
 2 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/net/eth-uclass.c b/net/eth-uclass.c
index 0d9b75a9a2..396418eb39 100644
--- a/net/eth-uclass.c
+++ b/net/eth-uclass.c
@@ -273,7 +273,7 @@ int eth_init(void)
 	if (!current) {
 		current = eth_get_dev();
 		if (!current) {
-			printf("No ethernet found.\n");
+			log_err("No ethernet found.\n");
 			return -ENODEV;
 		}
 	}
@@ -414,7 +414,7 @@ int eth_initialize(void)
 	 */
 	uclass_first_device_check(UCLASS_ETH, &dev);
 	if (!dev) {
-		printf("No ethernet found.\n");
+		log_err("No ethernet found.\n");
 		bootstage_error(BOOTSTAGE_ID_NET_ETH_START);
 	} else {
 		char *ethprime = env_get("ethprime");
@@ -449,7 +449,7 @@ int eth_initialize(void)
 		} while (dev);

 		if (!num_devices)
-			printf("No ethernet found.\n");
+			log_err("No ethernet found.\n");
 		putc('\n');
 	}

diff --git a/net/eth_legacy.c b/net/eth_legacy.c
index 992d1880bf..6e0c058761 100644
--- a/net/eth_legacy.c
+++ b/net/eth_legacy.c
@@ -261,7 +261,7 @@ int eth_initialize(void)
 	}

 	if (!eth_devices) {
-		puts("No ethernet found.\n");
+		log_err("No ethernet found.\n");
 		bootstage_error(BOOTSTAGE_ID_NET_ETH_START);
 	} else {
 		struct eth_device *dev = eth_devices;
@@ -319,7 +319,7 @@ int eth_init(void)
 	struct eth_device *old_current;

 	if (!eth_current) {
-		puts("No ethernet found.\n");
+		log_err("No ethernet found.\n");
 		return -ENODEV;
 	}

--
2.28.0

^ permalink raw reply related	[flat|nested] 3+ messages in thread
* [PATCH 1/1] net: use log_err() for 'No ethernet found' message
  2020-09-14  9:00 [PATCH 1/1] net: use log_err() for 'No ethernet found' message Heinrich Schuchardt
@ 2020-09-17  1:10 ` Simon Glass
  2020-10-01 14:10 ` Tom Rini
  1 sibling, 0 replies; 3+ messages in thread
From: Simon Glass @ 2020-09-17  1:10 UTC (permalink / raw)
  To: u-boot

On Mon, 14 Sep 2020 at 03:00, Heinrich Schuchardt <xypron.glpk@gmx.de> wrote:
>
> Write the 'No ethernet found' message via the log drivers. This allows
> suppressing it during output via the syslog driver.
>
> This fixes the problem reported in:
>
> [PATCH 0/4] log: Fix the syslog spam when running tests
> https://lists.denx.de/pipermail/u-boot/2020-September/426343.html
>
> Reported-by: Simon Glass <sjg@chromium.org>
> Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
> ---
>  net/eth-uclass.c | 6 +++---
>  net/eth_legacy.c | 4 ++--
>  2 files changed, 5 insertions(+), 5 deletions(-)

Reviewed-by: Simon Glass <sjg@chromium.org>

^ permalink raw reply	[flat|nested] 3+ messages in thread
* [PATCH 1/1] net: use log_err() for 'No ethernet found' message
  2020-09-14  9:00 [PATCH 1/1] net: use log_err() for 'No ethernet found' message Heinrich Schuchardt
  2020-09-17  1:10 ` Simon Glass
@ 2020-10-01 14:10 ` Tom Rini
  1 sibling, 0 replies; 3+ messages in thread
From: Tom Rini @ 2020-10-01 14:10 UTC (permalink / raw)
  To: u-boot

On Mon, Sep 14, 2020 at 11:00:18AM +0200, Heinrich Schuchardt wrote:

> Write the 'No ethernet found' message via the log drivers. This allows
> suppressing it during output via the syslog driver.
> 
> This fixes the problem reported in:
> 
> [PATCH 0/4] log: Fix the syslog spam when running tests
> https://lists.denx.de/pipermail/u-boot/2020-September/426343.html
> 
> Reported-by: Simon Glass <sjg@chromium.org>
> Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
> Reviewed-by: Simon Glass <sjg@chromium.org>

Applied to u-boot/next, thanks!

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20201001/88f879ce/attachment.sig>

^ permalink raw reply	[flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-10-01 14:10 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-09-14  9:00 [PATCH 1/1] net: use log_err() for 'No ethernet found' message Heinrich Schuchardt
2020-09-17  1:10 ` Simon Glass
2020-10-01 14:10 ` Tom Rini

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.