* [PATCH leds] dt-bindings: leds: cznic,turris-omnia-leds: fix error in binding
@ 2020-09-15 0:54 Marek Behún
2020-09-15 21:22 ` Rob Herring
2020-09-16 3:02 ` Rob Herring
0 siblings, 2 replies; 4+ messages in thread
From: Marek Behún @ 2020-09-15 0:54 UTC (permalink / raw)
To: linux-leds; +Cc: Marek Behún, Rob Herring, devicetree, Pavel Machek
There is a bug in the device tree binding for cznic,turris-omnia-leds
which causes make dt_binding_check to complain.
The reason is that the multi-led property binding's regular expression
does not contain the `@` character, while the example nodes do.
Fix this, and also allow for longer address in property name.
Signed-off-by: Marek Behún <marek.behun@nic.cz>
Cc: Rob Herring <robh+dt@kernel.org>
Cc: devicetree@vger.kernel.org
Cc: Pavel Machek <pavel@ucw.cz>
---
.../devicetree/bindings/leds/cznic,turris-omnia-leds.yaml | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/leds/cznic,turris-omnia-leds.yaml b/Documentation/devicetree/bindings/leds/cznic,turris-omnia-leds.yaml
index 24ad1446445ea..486ab27d75f2f 100644
--- a/Documentation/devicetree/bindings/leds/cznic,turris-omnia-leds.yaml
+++ b/Documentation/devicetree/bindings/leds/cznic,turris-omnia-leds.yaml
@@ -30,7 +30,7 @@ properties:
const: 0
patternProperties:
- "^multi-led[0-9a-f]$":
+ "^multi-led@[0-9a-f]+$":
type: object
allOf:
- $ref: leds-class-multicolor.yaml#
--
2.26.2
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH leds] dt-bindings: leds: cznic,turris-omnia-leds: fix error in binding
2020-09-15 0:54 [PATCH leds] dt-bindings: leds: cznic,turris-omnia-leds: fix error in binding Marek Behún
@ 2020-09-15 21:22 ` Rob Herring
2020-09-15 23:41 ` Marek Behun
2020-09-16 3:02 ` Rob Herring
1 sibling, 1 reply; 4+ messages in thread
From: Rob Herring @ 2020-09-15 21:22 UTC (permalink / raw)
To: Marek Behún; +Cc: linux-leds, devicetree, Pavel Machek
On Tue, Sep 15, 2020 at 02:54:26AM +0200, Marek Behún wrote:
> There is a bug in the device tree binding for cznic,turris-omnia-leds
> which causes make dt_binding_check to complain.
>
> The reason is that the multi-led property binding's regular expression
> does not contain the `@` character, while the example nodes do.
>
> Fix this, and also allow for longer address in property name.
>
> Signed-off-by: Marek Behún <marek.behun@nic.cz>
> Cc: Rob Herring <robh+dt@kernel.org>
> Cc: devicetree@vger.kernel.org
> Cc: Pavel Machek <pavel@ucw.cz>
> ---
> .../devicetree/bindings/leds/cznic,turris-omnia-leds.yaml | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/leds/cznic,turris-omnia-leds.yaml b/Documentation/devicetree/bindings/leds/cznic,turris-omnia-leds.yaml
> index 24ad1446445ea..486ab27d75f2f 100644
> --- a/Documentation/devicetree/bindings/leds/cznic,turris-omnia-leds.yaml
> +++ b/Documentation/devicetree/bindings/leds/cznic,turris-omnia-leds.yaml
> @@ -30,7 +30,7 @@ properties:
> const: 0
>
> patternProperties:
> - "^multi-led[0-9a-f]$":
> + "^multi-led@[0-9a-f]+$":
There are only 12 LEDs on the device based on the description and 'reg',
so 'b' is the max unit-address.
I can fixup when applying: "^multi-led@[0-9a-b]$"
> type: object
> allOf:
> - $ref: leds-class-multicolor.yaml#
> --
> 2.26.2
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH leds] dt-bindings: leds: cznic,turris-omnia-leds: fix error in binding
2020-09-15 21:22 ` Rob Herring
@ 2020-09-15 23:41 ` Marek Behun
0 siblings, 0 replies; 4+ messages in thread
From: Marek Behun @ 2020-09-15 23:41 UTC (permalink / raw)
To: Rob Herring; +Cc: linux-leds, devicetree, Pavel Machek
On Tue, 15 Sep 2020 15:22:58 -0600
Rob Herring <robh@kernel.org> wrote:
> On Tue, Sep 15, 2020 at 02:54:26AM +0200, Marek Behún wrote:
> > There is a bug in the device tree binding for cznic,turris-omnia-leds
> > which causes make dt_binding_check to complain.
> >
> > The reason is that the multi-led property binding's regular expression
> > does not contain the `@` character, while the example nodes do.
> >
> > Fix this, and also allow for longer address in property name.
> >
> > Signed-off-by: Marek Behún <marek.behun@nic.cz>
> > Cc: Rob Herring <robh+dt@kernel.org>
> > Cc: devicetree@vger.kernel.org
> > Cc: Pavel Machek <pavel@ucw.cz>
> > ---
> > .../devicetree/bindings/leds/cznic,turris-omnia-leds.yaml | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/Documentation/devicetree/bindings/leds/cznic,turris-omnia-leds.yaml b/Documentation/devicetree/bindings/leds/cznic,turris-omnia-leds.yaml
> > index 24ad1446445ea..486ab27d75f2f 100644
> > --- a/Documentation/devicetree/bindings/leds/cznic,turris-omnia-leds.yaml
> > +++ b/Documentation/devicetree/bindings/leds/cznic,turris-omnia-leds.yaml
> > @@ -30,7 +30,7 @@ properties:
> > const: 0
> >
> > patternProperties:
> > - "^multi-led[0-9a-f]$":
> > + "^multi-led@[0-9a-f]+$":
>
> There are only 12 LEDs on the device based on the description and 'reg',
> so 'b' is the max unit-address.
>
> I can fixup when applying: "^multi-led@[0-9a-b]$"
>
Please do, thanks.
Marek
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH leds] dt-bindings: leds: cznic,turris-omnia-leds: fix error in binding
2020-09-15 0:54 [PATCH leds] dt-bindings: leds: cznic,turris-omnia-leds: fix error in binding Marek Behún
2020-09-15 21:22 ` Rob Herring
@ 2020-09-16 3:02 ` Rob Herring
1 sibling, 0 replies; 4+ messages in thread
From: Rob Herring @ 2020-09-16 3:02 UTC (permalink / raw)
To: Marek Behún; +Cc: linux-leds, Pavel Machek, Rob Herring, devicetree
On Tue, 15 Sep 2020 02:54:26 +0200, Marek Behún wrote:
> There is a bug in the device tree binding for cznic,turris-omnia-leds
> which causes make dt_binding_check to complain.
>
> The reason is that the multi-led property binding's regular expression
> does not contain the `@` character, while the example nodes do.
>
> Fix this, and also allow for longer address in property name.
>
> Signed-off-by: Marek Behún <marek.behun@nic.cz>
> Cc: Rob Herring <robh+dt@kernel.org>
> Cc: devicetree@vger.kernel.org
> Cc: Pavel Machek <pavel@ucw.cz>
> ---
> .../devicetree/bindings/leds/cznic,turris-omnia-leds.yaml | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
Applied, thanks!
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-09-16 3:02 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-09-15 0:54 [PATCH leds] dt-bindings: leds: cznic,turris-omnia-leds: fix error in binding Marek Behún
2020-09-15 21:22 ` Rob Herring
2020-09-15 23:41 ` Marek Behun
2020-09-16 3:02 ` Rob Herring
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.