All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] ssb: Remove meaningless jump label to simplify the code
@ 2020-09-15  2:03 Jing Xiangfeng
  2020-09-21 13:01 ` Kalle Valo
  0 siblings, 1 reply; 2+ messages in thread
From: Jing Xiangfeng @ 2020-09-15  2:03 UTC (permalink / raw)
  To: m; +Cc: linux-wireless, linux-kernel, jingxiangfeng

The out jump label has nothing to do. So remove it to simplify the code.

Signed-off-by: Jing Xiangfeng <jingxiangfeng@huawei.com>
---
 drivers/ssb/pci.c | 7 +------
 1 file changed, 1 insertion(+), 6 deletions(-)

diff --git a/drivers/ssb/pci.c b/drivers/ssb/pci.c
index 7c3ae52f2b15..dac54041ad8d 100644
--- a/drivers/ssb/pci.c
+++ b/drivers/ssb/pci.c
@@ -1164,17 +1164,12 @@ void ssb_pci_exit(struct ssb_bus *bus)
 int ssb_pci_init(struct ssb_bus *bus)
 {
 	struct pci_dev *pdev;
-	int err;
 
 	if (bus->bustype != SSB_BUSTYPE_PCI)
 		return 0;
 
 	pdev = bus->host_pci;
 	mutex_init(&bus->sprom_mutex);
-	err = device_create_file(&pdev->dev, &dev_attr_ssb_sprom);
-	if (err)
-		goto out;
 
-out:
-	return err;
+	return device_create_file(&pdev->dev, &dev_attr_ssb_sprom);
 }
-- 
2.17.1


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] ssb: Remove meaningless jump label to simplify the code
  2020-09-15  2:03 [PATCH] ssb: Remove meaningless jump label to simplify the code Jing Xiangfeng
@ 2020-09-21 13:01 ` Kalle Valo
  0 siblings, 0 replies; 2+ messages in thread
From: Kalle Valo @ 2020-09-21 13:01 UTC (permalink / raw)
  To: Jing Xiangfeng; +Cc: m, linux-wireless, linux-kernel, jingxiangfeng

Jing Xiangfeng <jingxiangfeng@huawei.com> wrote:

> The out jump label has nothing to do. So remove it to simplify the code.
> 
> Signed-off-by: Jing Xiangfeng <jingxiangfeng@huawei.com>

Patch applied to wireless-drivers-next.git, thanks.

41650c45fbd2 ssb: Remove meaningless jump label to simplify the code

-- 
https://patchwork.kernel.org/patch/11775319/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2020-09-21 13:11 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-09-15  2:03 [PATCH] ssb: Remove meaningless jump label to simplify the code Jing Xiangfeng
2020-09-21 13:01 ` Kalle Valo

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.