All of lore.kernel.org
 help / color / mirror / Atom feed
From: Oscar Salvador <osalvador@suse.de>
To: Laurent Dufour <ldufour@linux.ibm.com>
Cc: akpm@linux-foundation.org, David Hildenbrand <david@redhat.com>,
	mhocko@suse.com, Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	linux-mm@kvack.org, "Rafael J . Wysocki" <rafael@kernel.org>,
	nathanl@linux.ibm.com, cheloha@linux.ibm.com,
	Tony Luck <tony.luck@intel.com>,
	Fenghua Yu <fenghua.yu@intel.com>,
	linux-ia64@vger.kernel.org, linux-kernel@vger.kernel.org,
	stable@vger.kernel.org
Subject: Re: [PATCH v3 3/3] mm: don't panic when links can't be created in sysfs
Date: Tue, 15 Sep 2020 12:33:27 +0200	[thread overview]
Message-ID: <20200915103327.GC30015@linux> (raw)
In-Reply-To: <20200915094143.79181-4-ldufour@linux.ibm.com>

On Tue, Sep 15, 2020 at 11:41:43AM +0200, Laurent Dufour wrote:
> At boot time, or when doing memory hot-add operations, if the links in
> sysfs can't be created, the system is still able to run, so just report the
> error in the kernel log rather than BUG_ON and potentially make system
> unusable because the callpath can be called with locks held.
> 
> Since the number of memory blocks managed could be high, the messages are
> rate limited.
> 
> As a consequence, link_mem_sections() has no status to report anymore.
> 
> Signed-off-by: Laurent Dufour <ldufour@linux.ibm.com>
> Acked-by: Michal Hocko <mhocko@suse.com>
> Acked-by: David Hildenbrand <david@redhat.com>
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

Reviewed-by: Oscar Salvador <osalvador@suse.de>

-- 
Oscar Salvador
SUSE L3

WARNING: multiple messages have this Message-ID (diff)
From: Oscar Salvador <osalvador@suse.de>
To: Laurent Dufour <ldufour@linux.ibm.com>
Cc: akpm@linux-foundation.org, David Hildenbrand <david@redhat.com>,
	mhocko@suse.com, Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	linux-mm@kvack.org, "Rafael J . Wysocki" <rafael@kernel.org>,
	nathanl@linux.ibm.com, cheloha@linux.ibm.com,
	Tony Luck <tony.luck@intel.com>,
	Fenghua Yu <fenghua.yu@intel.com>,
	linux-ia64@vger.kernel.org, linux-kernel@vger.kernel.org,
	stable@vger.kernel.org
Subject: Re: [PATCH v3 3/3] mm: don't panic when links can't be created in sysfs
Date: Tue, 15 Sep 2020 10:33:27 +0000	[thread overview]
Message-ID: <20200915103327.GC30015@linux> (raw)
In-Reply-To: <20200915094143.79181-4-ldufour@linux.ibm.com>

On Tue, Sep 15, 2020 at 11:41:43AM +0200, Laurent Dufour wrote:
> At boot time, or when doing memory hot-add operations, if the links in
> sysfs can't be created, the system is still able to run, so just report the
> error in the kernel log rather than BUG_ON and potentially make system
> unusable because the callpath can be called with locks held.
> 
> Since the number of memory blocks managed could be high, the messages are
> rate limited.
> 
> As a consequence, link_mem_sections() has no status to report anymore.
> 
> Signed-off-by: Laurent Dufour <ldufour@linux.ibm.com>
> Acked-by: Michal Hocko <mhocko@suse.com>
> Acked-by: David Hildenbrand <david@redhat.com>
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

Reviewed-by: Oscar Salvador <osalvador@suse.de>

-- 
Oscar Salvador
SUSE L3

  reply	other threads:[~2020-09-15 10:33 UTC|newest]

Thread overview: 40+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-15  9:41 [PATCH v3 0/3] mm: fix memory to node bad links in sysfs Laurent Dufour
2020-09-15  9:41 ` Laurent Dufour
2020-09-15  9:41 ` [PATCH v3 1/3] mm: replace memmap_context by memplug_context Laurent Dufour
2020-09-15  9:41   ` Laurent Dufour
2020-09-15 10:17   ` David Hildenbrand
2020-09-15 10:17     ` David Hildenbrand
2020-09-15 10:28   ` Oscar Salvador
2020-09-15 10:28     ` Oscar Salvador
2020-09-15 12:15   ` Michal Hocko
2020-09-15 12:15     ` Michal Hocko
2020-09-15 13:26     ` [PATCH v3 1/3] mm: replace memmap_context by meminit_context Laurent Dufour
2020-09-15 13:26       ` Laurent Dufour
2020-09-15 13:35       ` Michal Hocko
2020-09-15 13:35         ` Michal Hocko
2020-09-16  6:33       ` Greg Kroah-Hartman
2020-09-16  6:33         ` Greg Kroah-Hartman
2020-09-16  7:29         ` Laurent Dufour
2020-09-16  7:29           ` Laurent Dufour
2020-09-16  7:40           ` Greg Kroah-Hartman
2020-09-16  7:40             ` Greg Kroah-Hartman
2020-09-16  7:47             ` Laurent Dufour
2020-09-16  7:47               ` Laurent Dufour
2020-09-16  7:52               ` David Hildenbrand
2020-09-16  7:52                 ` David Hildenbrand
2020-09-16 16:09                 ` Laurent Dufour
2020-09-16 16:09                   ` Laurent Dufour
2020-09-16 23:37                   ` Andrew Morton
2020-09-16 23:37                     ` Andrew Morton
2020-09-17  8:00                     ` Laurent Dufour
2020-09-17  8:00                       ` Laurent Dufour
2020-09-15  9:41 ` [PATCH v3 2/3] mm: don't rely on system state to detect hot-plug operations Laurent Dufour
2020-09-15  9:41   ` Laurent Dufour
2020-09-15 10:31   ` Oscar Salvador
2020-09-15 10:31     ` Oscar Salvador
2020-09-15 12:19   ` Michal Hocko
2020-09-15 12:19     ` Michal Hocko
2020-09-15  9:41 ` [PATCH v3 3/3] mm: don't panic when links can't be created in sysfs Laurent Dufour
2020-09-15  9:41   ` Laurent Dufour
2020-09-15 10:33   ` Oscar Salvador [this message]
2020-09-15 10:33     ` Oscar Salvador

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200915103327.GC30015@linux \
    --to=osalvador@suse.de \
    --cc=akpm@linux-foundation.org \
    --cc=cheloha@linux.ibm.com \
    --cc=david@redhat.com \
    --cc=fenghua.yu@intel.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=ldufour@linux.ibm.com \
    --cc=linux-ia64@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mhocko@suse.com \
    --cc=nathanl@linux.ibm.com \
    --cc=rafael@kernel.org \
    --cc=stable@vger.kernel.org \
    --cc=tony.luck@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.