All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] spi: bcm2835: mark polling_limit_us as static
@ 2020-09-15 13:23 ` Marc Kleine-Budde
  0 siblings, 0 replies; 8+ messages in thread
From: Marc Kleine-Budde @ 2020-09-15 13:23 UTC (permalink / raw)
  To: Mark Brown
  Cc: Nicolas Saenz Julienne, Florian Fainelli, Ray Jui, Scott Branden,
	bcm-kernel-feedback-list, linux-spi, linux-rpi-kernel,
	linux-arm-kernel, kernel, Marc Kleine-Budde

This patch marks the global variable "polling_limit_us" as static.

Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
---
 drivers/spi/spi-bcm2835.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/spi/spi-bcm2835.c b/drivers/spi/spi-bcm2835.c
index c45d76c848c8..41986ac0fbfb 100644
--- a/drivers/spi/spi-bcm2835.c
+++ b/drivers/spi/spi-bcm2835.c
@@ -75,7 +75,7 @@
 #define DRV_NAME	"spi-bcm2835"
 
 /* define polling limits */
-unsigned int polling_limit_us = 30;
+static unsigned int polling_limit_us = 30;
 module_param(polling_limit_us, uint, 0664);
 MODULE_PARM_DESC(polling_limit_us,
 		 "time in us to run a transfer in polling mode\n");
-- 
2.28.0


^ permalink raw reply related	[flat|nested] 8+ messages in thread
* [PATCH] spi: bcm2835: mark polling_limit_us as static
@ 2020-09-15 13:23 ` Marc Kleine-Budde
  0 siblings, 0 replies; 8+ messages in thread
From: Marc Kleine-Budde @ 2020-09-15 13:23 UTC (permalink / raw)
  To: Mark Brown
  Cc: linux-arm-kernel, Florian Fainelli, Scott Branden, Ray Jui,
	linux-spi, bcm-kernel-feedback-list, linux-rpi-kernel, kernel,
	Marc Kleine-Budde, Nicolas Saenz Julienne

This patch marks the global variable "polling_limit_us" as static.

Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
---
 drivers/spi/spi-bcm2835.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/spi/spi-bcm2835.c b/drivers/spi/spi-bcm2835.c
index c45d76c848c8..41986ac0fbfb 100644
--- a/drivers/spi/spi-bcm2835.c
+++ b/drivers/spi/spi-bcm2835.c
@@ -75,7 +75,7 @@
 #define DRV_NAME	"spi-bcm2835"
 
 /* define polling limits */
-unsigned int polling_limit_us = 30;
+static unsigned int polling_limit_us = 30;
 module_param(polling_limit_us, uint, 0664);
 MODULE_PARM_DESC(polling_limit_us,
 		 "time in us to run a transfer in polling mode\n");
-- 
2.28.0


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply related	[flat|nested] 8+ messages in thread
* Re: [PATCH] spi: bcm2835: mark polling_limit_us as static
  2020-09-15 13:23 ` Marc Kleine-Budde
@ 2020-09-15 14:08   ` Mark Brown
  -1 siblings, 0 replies; 8+ messages in thread
From: Mark Brown @ 2020-09-15 14:08 UTC (permalink / raw)
  To: Marc Kleine-Budde
  Cc: Nicolas Saenz Julienne, Florian Fainelli, Ray Jui, Scott Branden,
	bcm-kernel-feedback-list, linux-spi, linux-rpi-kernel,
	linux-arm-kernel, kernel

[-- Attachment #1: Type: text/plain, Size: 186 bytes --]

On Tue, Sep 15, 2020 at 03:23:11PM +0200, Marc Kleine-Budde wrote:
> This patch marks the global variable "polling_limit_us" as static.

Thanks but I applied a patch for this yesterday.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 8+ messages in thread
* Re: [PATCH] spi: bcm2835: mark polling_limit_us as static
@ 2020-09-15 14:08   ` Mark Brown
  0 siblings, 0 replies; 8+ messages in thread
From: Mark Brown @ 2020-09-15 14:08 UTC (permalink / raw)
  To: Marc Kleine-Budde
  Cc: linux-arm-kernel, Florian Fainelli, Scott Branden, Ray Jui,
	linux-spi, bcm-kernel-feedback-list, linux-rpi-kernel, kernel,
	Nicolas Saenz Julienne


[-- Attachment #1.1: Type: text/plain, Size: 186 bytes --]

On Tue, Sep 15, 2020 at 03:23:11PM +0200, Marc Kleine-Budde wrote:
> This patch marks the global variable "polling_limit_us" as static.

Thanks but I applied a patch for this yesterday.

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

[-- Attachment #2: Type: text/plain, Size: 176 bytes --]

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 8+ messages in thread
* Re: [PATCH] spi: bcm2835: mark polling_limit_us as static
  2020-09-15 14:08   ` Mark Brown
@ 2020-09-15 14:34     ` Marc Kleine-Budde
  -1 siblings, 0 replies; 8+ messages in thread
From: Marc Kleine-Budde @ 2020-09-15 14:34 UTC (permalink / raw)
  To: Mark Brown
  Cc: linux-arm-kernel, Florian Fainelli, Scott Branden, Ray Jui,
	linux-spi, bcm-kernel-feedback-list, linux-rpi-kernel, kernel,
	Nicolas Saenz Julienne


[-- Attachment #1.1: Type: text/plain, Size: 599 bytes --]

On 9/15/20 4:08 PM, Mark Brown wrote:
> On Tue, Sep 15, 2020 at 03:23:11PM +0200, Marc Kleine-Budde wrote:
>> This patch marks the global variable "polling_limit_us" as static.
> 
> Thanks but I applied a patch for this yesterday.

Doh! I rebased to current linus/master, which doesn't contain the patch yet :)

Marc

-- 
Pengutronix e.K.                 | Marc Kleine-Budde           |
Embedded Linux                   | https://www.pengutronix.de  |
Vertretung West/Dortmund         | Phone: +49-231-2826-924     |
Amtsgericht Hildesheim, HRA 2686 | Fax:   +49-5121-206917-5555 |


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 8+ messages in thread
* Re: [PATCH] spi: bcm2835: mark polling_limit_us as static
@ 2020-09-15 14:34     ` Marc Kleine-Budde
  0 siblings, 0 replies; 8+ messages in thread
From: Marc Kleine-Budde @ 2020-09-15 14:34 UTC (permalink / raw)
  To: Mark Brown
  Cc: Florian Fainelli, Scott Branden, Ray Jui, linux-spi,
	Nicolas Saenz Julienne, bcm-kernel-feedback-list,
	linux-rpi-kernel, kernel, linux-arm-kernel


[-- Attachment #1.1.1: Type: text/plain, Size: 599 bytes --]

On 9/15/20 4:08 PM, Mark Brown wrote:
> On Tue, Sep 15, 2020 at 03:23:11PM +0200, Marc Kleine-Budde wrote:
>> This patch marks the global variable "polling_limit_us" as static.
> 
> Thanks but I applied a patch for this yesterday.

Doh! I rebased to current linus/master, which doesn't contain the patch yet :)

Marc

-- 
Pengutronix e.K.                 | Marc Kleine-Budde           |
Embedded Linux                   | https://www.pengutronix.de  |
Vertretung West/Dortmund         | Phone: +49-231-2826-924     |
Amtsgericht Hildesheim, HRA 2686 | Fax:   +49-5121-206917-5555 |


[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

[-- Attachment #2: Type: text/plain, Size: 176 bytes --]

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 8+ messages in thread
* Re: [PATCH] spi: bcm2835: mark polling_limit_us as static
  2020-09-15 14:34     ` Marc Kleine-Budde
@ 2020-09-15 15:48       ` Mark Brown
  -1 siblings, 0 replies; 8+ messages in thread
From: Mark Brown @ 2020-09-15 15:48 UTC (permalink / raw)
  To: Marc Kleine-Budde
  Cc: linux-arm-kernel, Florian Fainelli, Scott Branden, Ray Jui,
	linux-spi, bcm-kernel-feedback-list, linux-rpi-kernel, kernel,
	Nicolas Saenz Julienne

[-- Attachment #1: Type: text/plain, Size: 398 bytes --]

On Tue, Sep 15, 2020 at 04:34:41PM +0200, Marc Kleine-Budde wrote:
> On 9/15/20 4:08 PM, Mark Brown wrote:

> > Thanks but I applied a patch for this yesterday.

> Doh! I rebased to current linus/master, which doesn't contain the patch yet :)

Oh, the issue affects mainline rather than just -next - I've applied it
for -next rather than as a fix, better move it over.  Thanks for letting
me know!

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 8+ messages in thread
* Re: [PATCH] spi: bcm2835: mark polling_limit_us as static
@ 2020-09-15 15:48       ` Mark Brown
  0 siblings, 0 replies; 8+ messages in thread
From: Mark Brown @ 2020-09-15 15:48 UTC (permalink / raw)
  To: Marc Kleine-Budde
  Cc: Florian Fainelli, Scott Branden, Ray Jui, linux-spi,
	Nicolas Saenz Julienne, bcm-kernel-feedback-list,
	linux-rpi-kernel, kernel, linux-arm-kernel


[-- Attachment #1.1: Type: text/plain, Size: 398 bytes --]

On Tue, Sep 15, 2020 at 04:34:41PM +0200, Marc Kleine-Budde wrote:
> On 9/15/20 4:08 PM, Mark Brown wrote:

> > Thanks but I applied a patch for this yesterday.

> Doh! I rebased to current linus/master, which doesn't contain the patch yet :)

Oh, the issue affects mainline rather than just -next - I've applied it
for -next rather than as a fix, better move it over.  Thanks for letting
me know!

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

[-- Attachment #2: Type: text/plain, Size: 176 bytes --]

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 8+ messages in thread
end of thread, other threads:[~2020-09-16  0:37 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-09-15 13:23 [PATCH] spi: bcm2835: mark polling_limit_us as static Marc Kleine-Budde
2020-09-15 13:23 ` Marc Kleine-Budde
2020-09-15 14:08 ` Mark Brown
2020-09-15 14:08   ` Mark Brown
2020-09-15 14:34   ` Marc Kleine-Budde
2020-09-15 14:34     ` Marc Kleine-Budde
2020-09-15 15:48     ` Mark Brown
2020-09-15 15:48       ` Mark Brown

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.