* [PATCH v5 0/1] generic: add test for boundary in xfs_attr_shortform_verify
@ 2020-09-15 13:26 Pavel Reichl
2020-09-15 13:26 ` [PATCH v5 1/1] " Pavel Reichl
0 siblings, 1 reply; 3+ messages in thread
From: Pavel Reichl @ 2020-09-15 13:26 UTC (permalink / raw)
To: fstests
Add test for XFS bug that corrupted metadata if extended attribute name
of length 1 was used.
V4 did the following changes:
1) replaced the system-wide cache drop and sleep by _scratch_cycle_mount
2) output of getfattr is grepped for attribute name to simplify expected
output
3) dropped explicit _check_scratch_fs
4) renamed the test from 609 to 611 - to resolve the conflict after the
recent update of master branch.
V5 did the following changes:
* dropped the the _scratch_unmount and the relevant comment
Pavel Reichl (1):
generic: add test for boundary in xfs_attr_shortform_verify
tests/generic/611 | 58 +++++++++++++++++++++++++++++++++++++++++++
tests/generic/611.out | 2 ++
tests/generic/group | 1 +
3 files changed, 61 insertions(+)
create mode 100755 tests/generic/611
create mode 100644 tests/generic/611.out
--
2.26.2
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH v5 1/1] generic: add test for boundary in xfs_attr_shortform_verify
2020-09-15 13:26 [PATCH v5 0/1] generic: add test for boundary in xfs_attr_shortform_verify Pavel Reichl
@ 2020-09-15 13:26 ` Pavel Reichl
2020-09-16 1:44 ` Zorro Lang
0 siblings, 1 reply; 3+ messages in thread
From: Pavel Reichl @ 2020-09-15 13:26 UTC (permalink / raw)
To: fstests
Add a regression test to check that the boundary test
for the fixed-offset parts of xfs_attr_sf_entry
in xfs_attr_shortform_verify is not off by one.
This can be shown by:
touch file
setfattr -n user.a file
With help from Zorro. Thanks very much.
Signed-off-by: Pavel Reichl <preichl@redhat.com>
---
tests/generic/611 | 58 +++++++++++++++++++++++++++++++++++++++++++
tests/generic/611.out | 2 ++
tests/generic/group | 1 +
3 files changed, 61 insertions(+)
create mode 100755 tests/generic/611
create mode 100644 tests/generic/611.out
diff --git a/tests/generic/611 b/tests/generic/611
new file mode 100755
index 00000000..069db6f9
--- /dev/null
+++ b/tests/generic/611
@@ -0,0 +1,58 @@
+#! /bin/bash
+# SPDX-License-Identifier: GPL-2.0
+# Copyright (c) 2020 Red Hat, Inc. All Rights Reserved.
+#
+# FS QA Test 611
+#
+# Verify that metadata won't get corrupted when extended attribute
+# name of size one is set.
+#
+# This test verifies the problem fixed in kernel with commit
+# f4020438fab0 ("xfs: fix boundary test in xfs_attr_shortform_verify")
+
+seq=`basename $0`
+seqres=$RESULT_DIR/$seq
+echo "QA output created by $seq"
+
+here=`pwd`
+tmp=/tmp/$$
+status=1 # failure is the default!
+trap "_cleanup; exit \$status" 0 1 2 3 15
+
+_cleanup()
+{
+ cd /
+ rm -f $tmp.*
+}
+
+# get standard environment, filters and checks
+. ./common/rc
+. ./common/filter
+. ./common/attr
+
+# remove previous $seqres.full before test
+rm -f $seqres.full
+
+# real QA test starts here
+
+_supported_fs generic
+_supported_os Linux
+_require_scratch
+_require_attrs
+
+_scratch_mkfs > $seqres.full 2>&1
+_scratch_mount
+
+localfile="${SCRATCH_MNT}/testfile"
+
+touch "${localfile}"
+"${SETFATTR_PROG}" -n user.a "${localfile}"
+
+# Make sure that changes are written to disk
+_scratch_cycle_mount
+
+# If the target bug isn't fixed, getfattr fails
+${GETFATTR_PROG} --absolute-names -n user.a $localfile | grep 'user.a'
+
+status=0
+exit
diff --git a/tests/generic/611.out b/tests/generic/611.out
new file mode 100644
index 00000000..1ab12434
--- /dev/null
+++ b/tests/generic/611.out
@@ -0,0 +1,2 @@
+QA output created by 611
+user.a=""
diff --git a/tests/generic/group b/tests/generic/group
index 8eba6c98..4af4b494 100644
--- a/tests/generic/group
+++ b/tests/generic/group
@@ -613,3 +613,4 @@
608 auto attr quick dax
609 auto quick rw
610 auto quick prealloc zero
+611 auto quick attr
--
2.26.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v5 1/1] generic: add test for boundary in xfs_attr_shortform_verify
2020-09-15 13:26 ` [PATCH v5 1/1] " Pavel Reichl
@ 2020-09-16 1:44 ` Zorro Lang
0 siblings, 0 replies; 3+ messages in thread
From: Zorro Lang @ 2020-09-16 1:44 UTC (permalink / raw)
To: fstests
On Tue, Sep 15, 2020 at 03:26:51PM +0200, Pavel Reichl wrote:
> Add a regression test to check that the boundary test
> for the fixed-offset parts of xfs_attr_sf_entry
> in xfs_attr_shortform_verify is not off by one.
>
> This can be shown by:
>
> touch file
> setfattr -n user.a file
>
> With help from Zorro. Thanks very much.
>
> Signed-off-by: Pavel Reichl <preichl@redhat.com>
> ---
Looks good to me,
Reviewed-by: Zorro Lang <zlang@redhat.com>
> tests/generic/611 | 58 +++++++++++++++++++++++++++++++++++++++++++
> tests/generic/611.out | 2 ++
> tests/generic/group | 1 +
> 3 files changed, 61 insertions(+)
> create mode 100755 tests/generic/611
> create mode 100644 tests/generic/611.out
>
> diff --git a/tests/generic/611 b/tests/generic/611
> new file mode 100755
> index 00000000..069db6f9
> --- /dev/null
> +++ b/tests/generic/611
> @@ -0,0 +1,58 @@
> +#! /bin/bash
> +# SPDX-License-Identifier: GPL-2.0
> +# Copyright (c) 2020 Red Hat, Inc. All Rights Reserved.
> +#
> +# FS QA Test 611
> +#
> +# Verify that metadata won't get corrupted when extended attribute
> +# name of size one is set.
> +#
> +# This test verifies the problem fixed in kernel with commit
> +# f4020438fab0 ("xfs: fix boundary test in xfs_attr_shortform_verify")
> +
> +seq=`basename $0`
> +seqres=$RESULT_DIR/$seq
> +echo "QA output created by $seq"
> +
> +here=`pwd`
> +tmp=/tmp/$$
> +status=1 # failure is the default!
> +trap "_cleanup; exit \$status" 0 1 2 3 15
> +
> +_cleanup()
> +{
> + cd /
> + rm -f $tmp.*
> +}
> +
> +# get standard environment, filters and checks
> +. ./common/rc
> +. ./common/filter
> +. ./common/attr
> +
> +# remove previous $seqres.full before test
> +rm -f $seqres.full
> +
> +# real QA test starts here
> +
> +_supported_fs generic
> +_supported_os Linux
> +_require_scratch
> +_require_attrs
> +
> +_scratch_mkfs > $seqres.full 2>&1
> +_scratch_mount
> +
> +localfile="${SCRATCH_MNT}/testfile"
> +
> +touch "${localfile}"
> +"${SETFATTR_PROG}" -n user.a "${localfile}"
> +
> +# Make sure that changes are written to disk
> +_scratch_cycle_mount
> +
> +# If the target bug isn't fixed, getfattr fails
> +${GETFATTR_PROG} --absolute-names -n user.a $localfile | grep 'user.a'
> +
> +status=0
> +exit
> diff --git a/tests/generic/611.out b/tests/generic/611.out
> new file mode 100644
> index 00000000..1ab12434
> --- /dev/null
> +++ b/tests/generic/611.out
> @@ -0,0 +1,2 @@
> +QA output created by 611
> +user.a=""
> diff --git a/tests/generic/group b/tests/generic/group
> index 8eba6c98..4af4b494 100644
> --- a/tests/generic/group
> +++ b/tests/generic/group
> @@ -613,3 +613,4 @@
> 608 auto attr quick dax
> 609 auto quick rw
> 610 auto quick prealloc zero
> +611 auto quick attr
> --
> 2.26.2
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-09-16 1:31 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-09-15 13:26 [PATCH v5 0/1] generic: add test for boundary in xfs_attr_shortform_verify Pavel Reichl
2020-09-15 13:26 ` [PATCH v5 1/1] " Pavel Reichl
2020-09-16 1:44 ` Zorro Lang
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.