* [PATCH v5] mm/vmscan: add a fatal signals check in drop_slab_node
@ 2020-09-16 2:53 zangchunxin
2020-09-16 6:08 ` Michal Hocko
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: zangchunxin @ 2020-09-16 2:53 UTC (permalink / raw)
To: akpm
Cc: chris, vbabka, mhocko, linux-mm, linux-kernel, Chunxin Zang, Muchun Song
From: Chunxin Zang <zangchunxin@bytedance.com>
On our server, there are about 10k memcg in one machine. They use memory
very frequently. We have observed that drop_caches can take a
considerable amount of time, and can't stop it.
There are two reasons:
1. There is somebody constantly generating more objects to reclaim
on drop_caches, result the 'freed' always bigger than 10.
2. The process has no chance to process signals.
We can get the following info through 'ps':
root:~# ps -aux | grep drop
root 357956 ... R Aug25 21119854:55 echo 3 > /proc/sys/vm/drop_caches
root 1771385 ... R Aug16 21146421:17 echo 3 > /proc/sys/vm/drop_caches
Add a bail out on the fatal signals in the main loop so that the
operation can be terminated by userspace.
Signed-off-by: Chunxin Zang <zangchunxin@bytedance.com>
Signed-off-by: Muchun Song <songmuchun@bytedance.com>
---
changelogs in v5:
1) v4 patch used wrong branch, very apologies about that.
changelogs in v4:
changelogs in v3:
1) Fix some descriptive problems pointed out by Michal Hocko.
v2 named: mm/vmscan: fix infinite loop in drop_slab_node
changelogs in v2:
1) via check fatal signal break loop.
mm/vmscan.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/mm/vmscan.c b/mm/vmscan.c
index b6d84326bdf2..c3ed8b45d264 100644
--- a/mm/vmscan.c
+++ b/mm/vmscan.c
@@ -704,6 +704,9 @@ void drop_slab_node(int nid)
do {
struct mem_cgroup *memcg = NULL;
+ if (fatal_signal_pending(current))
+ return;
+
freed = 0;
memcg = mem_cgroup_iter(NULL, NULL, NULL);
do {
--
2.11.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH v5] mm/vmscan: add a fatal signals check in drop_slab_node
2020-09-16 2:53 [PATCH v5] mm/vmscan: add a fatal signals check in drop_slab_node zangchunxin
@ 2020-09-16 6:08 ` Michal Hocko
2020-09-16 11:24 ` Chris Down
2020-09-16 13:17 ` David Hildenbrand
2 siblings, 0 replies; 4+ messages in thread
From: Michal Hocko @ 2020-09-16 6:08 UTC (permalink / raw)
To: zangchunxin; +Cc: akpm, chris, vbabka, linux-mm, linux-kernel, Muchun Song
On Wed 16-09-20 10:53:59, zangchunxin@bytedance.com wrote:
> From: Chunxin Zang <zangchunxin@bytedance.com>
>
> On our server, there are about 10k memcg in one machine. They use memory
> very frequently. We have observed that drop_caches can take a
> considerable amount of time, and can't stop it.
>
> There are two reasons:
> 1. There is somebody constantly generating more objects to reclaim
> on drop_caches, result the 'freed' always bigger than 10.
> 2. The process has no chance to process signals.
>
> We can get the following info through 'ps':
>
> root:~# ps -aux | grep drop
> root 357956 ... R Aug25 21119854:55 echo 3 > /proc/sys/vm/drop_caches
> root 1771385 ... R Aug16 21146421:17 echo 3 > /proc/sys/vm/drop_caches
>
> Add a bail out on the fatal signals in the main loop so that the
> operation can be terminated by userspace.
>
> Signed-off-by: Chunxin Zang <zangchunxin@bytedance.com>
> Signed-off-by: Muchun Song <songmuchun@bytedance.com>
Acked-by: Michal Hocko <mhocko@suse.com>
> ---
> changelogs in v5:
> 1) v4 patch used wrong branch, very apologies about that.
>
> changelogs in v4:
> changelogs in v3:
> 1) Fix some descriptive problems pointed out by Michal Hocko.
> v2 named: mm/vmscan: fix infinite loop in drop_slab_node
>
> changelogs in v2:
> 1) via check fatal signal break loop.
>
> mm/vmscan.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/mm/vmscan.c b/mm/vmscan.c
> index b6d84326bdf2..c3ed8b45d264 100644
> --- a/mm/vmscan.c
> +++ b/mm/vmscan.c
> @@ -704,6 +704,9 @@ void drop_slab_node(int nid)
> do {
> struct mem_cgroup *memcg = NULL;
>
> + if (fatal_signal_pending(current))
> + return;
> +
> freed = 0;
> memcg = mem_cgroup_iter(NULL, NULL, NULL);
> do {
> --
> 2.11.0
>
--
Michal Hocko
SUSE Labs
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v5] mm/vmscan: add a fatal signals check in drop_slab_node
2020-09-16 2:53 [PATCH v5] mm/vmscan: add a fatal signals check in drop_slab_node zangchunxin
2020-09-16 6:08 ` Michal Hocko
@ 2020-09-16 11:24 ` Chris Down
2020-09-16 13:17 ` David Hildenbrand
2 siblings, 0 replies; 4+ messages in thread
From: Chris Down @ 2020-09-16 11:24 UTC (permalink / raw)
To: zangchunxin; +Cc: akpm, vbabka, mhocko, linux-mm, linux-kernel, Muchun Song
zangchunxin@bytedance.com writes:
>From: Chunxin Zang <zangchunxin@bytedance.com>
>
>On our server, there are about 10k memcg in one machine. They use memory
>very frequently. We have observed that drop_caches can take a
>considerable amount of time, and can't stop it.
>
>There are two reasons:
>1. There is somebody constantly generating more objects to reclaim
> on drop_caches, result the 'freed' always bigger than 10.
>2. The process has no chance to process signals.
>
>We can get the following info through 'ps':
>
> root:~# ps -aux | grep drop
> root 357956 ... R Aug25 21119854:55 echo 3 > /proc/sys/vm/drop_caches
> root 1771385 ... R Aug16 21146421:17 echo 3 > /proc/sys/vm/drop_caches
>
>Add a bail out on the fatal signals in the main loop so that the
>operation can be terminated by userspace.
>
>Signed-off-by: Chunxin Zang <zangchunxin@bytedance.com>
>Signed-off-by: Muchun Song <songmuchun@bytedance.com>
Acked-by: Chris Down <chris@chrisdown.name>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v5] mm/vmscan: add a fatal signals check in drop_slab_node
2020-09-16 2:53 [PATCH v5] mm/vmscan: add a fatal signals check in drop_slab_node zangchunxin
2020-09-16 6:08 ` Michal Hocko
2020-09-16 11:24 ` Chris Down
@ 2020-09-16 13:17 ` David Hildenbrand
2 siblings, 0 replies; 4+ messages in thread
From: David Hildenbrand @ 2020-09-16 13:17 UTC (permalink / raw)
To: zangchunxin, akpm
Cc: chris, vbabka, mhocko, linux-mm, linux-kernel, Muchun Song
On 16.09.20 04:53, zangchunxin@bytedance.com wrote:
> From: Chunxin Zang <zangchunxin@bytedance.com>
>
> On our server, there are about 10k memcg in one machine. They use memory
> very frequently. We have observed that drop_caches can take a
> considerable amount of time, and can't stop it.
>
> There are two reasons:
> 1. There is somebody constantly generating more objects to reclaim
> on drop_caches, result the 'freed' always bigger than 10.
> 2. The process has no chance to process signals.
>
> We can get the following info through 'ps':
>
> root:~# ps -aux | grep drop
> root 357956 ... R Aug25 21119854:55 echo 3 > /proc/sys/vm/drop_caches
> root 1771385 ... R Aug16 21146421:17 echo 3 > /proc/sys/vm/drop_caches
>
> Add a bail out on the fatal signals in the main loop so that the
> operation can be terminated by userspace.
>
> Signed-off-by: Chunxin Zang <zangchunxin@bytedance.com>
> Signed-off-by: Muchun Song <songmuchun@bytedance.com>
^ he did not actually send that, no? Maybe co-developed-by ?
--
Thanks,
David / dhildenb
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-09-16 19:09 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-09-16 2:53 [PATCH v5] mm/vmscan: add a fatal signals check in drop_slab_node zangchunxin
2020-09-16 6:08 ` Michal Hocko
2020-09-16 11:24 ` Chris Down
2020-09-16 13:17 ` David Hildenbrand
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.