* [PATCH v2] ARM: zx: remove redundant dev_err call in zx296702_pd_probe()
@ 2020-09-16 6:20 ` Qinglang Miao
0 siblings, 0 replies; 2+ messages in thread
From: Qinglang Miao @ 2020-09-16 6:20 UTC (permalink / raw)
To: Jun Nie, Shawn Guo, Russell King
Cc: linux-arm-kernel, linux-kernel, Qinglang Miao
There is an error message within devm_ioremap_resource
already, so remove the dev_err call to avoid redundant
error message.
Signed-off-by: Qinglang Miao <miaoqinglang@huawei.com>
---
arch/arm/mach-zx/zx296702-pm-domain.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/arch/arm/mach-zx/zx296702-pm-domain.c b/arch/arm/mach-zx/zx296702-pm-domain.c
index 7a08bf9dd..ac44ea8e6 100644
--- a/arch/arm/mach-zx/zx296702-pm-domain.c
+++ b/arch/arm/mach-zx/zx296702-pm-domain.c
@@ -169,10 +169,8 @@ static int zx296702_pd_probe(struct platform_device *pdev)
}
pcubase = devm_ioremap_resource(&pdev->dev, res);
- if (IS_ERR(pcubase)) {
- dev_err(&pdev->dev, "ioremap fail.\n");
+ if (IS_ERR(pcubase))
return -EIO;
- }
for (i = 0; i < ARRAY_SIZE(zx296702_pm_domains); ++i)
pm_genpd_init(zx296702_pm_domains[i], NULL, false);
--
2.23.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [PATCH v2] ARM: zx: remove redundant dev_err call in zx296702_pd_probe()
@ 2020-09-16 6:20 ` Qinglang Miao
0 siblings, 0 replies; 2+ messages in thread
From: Qinglang Miao @ 2020-09-16 6:20 UTC (permalink / raw)
To: Jun Nie, Shawn Guo, Russell King
Cc: Qinglang Miao, linux-kernel, linux-arm-kernel
There is an error message within devm_ioremap_resource
already, so remove the dev_err call to avoid redundant
error message.
Signed-off-by: Qinglang Miao <miaoqinglang@huawei.com>
---
arch/arm/mach-zx/zx296702-pm-domain.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/arch/arm/mach-zx/zx296702-pm-domain.c b/arch/arm/mach-zx/zx296702-pm-domain.c
index 7a08bf9dd..ac44ea8e6 100644
--- a/arch/arm/mach-zx/zx296702-pm-domain.c
+++ b/arch/arm/mach-zx/zx296702-pm-domain.c
@@ -169,10 +169,8 @@ static int zx296702_pd_probe(struct platform_device *pdev)
}
pcubase = devm_ioremap_resource(&pdev->dev, res);
- if (IS_ERR(pcubase)) {
- dev_err(&pdev->dev, "ioremap fail.\n");
+ if (IS_ERR(pcubase))
return -EIO;
- }
for (i = 0; i < ARRAY_SIZE(zx296702_pm_domains); ++i)
pm_genpd_init(zx296702_pm_domains[i], NULL, false);
--
2.23.0
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-09-16 6:21 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-09-16 6:20 [PATCH v2] ARM: zx: remove redundant dev_err call in zx296702_pd_probe() Qinglang Miao
2020-09-16 6:20 ` Qinglang Miao
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.