* [PATCH -next] s390/ap: remove unnecessary spin_lock_init()
@ 2020-09-16 6:21 ` Qinglang Miao
0 siblings, 0 replies; 3+ messages in thread
From: Qinglang Miao @ 2020-09-16 6:21 UTC (permalink / raw)
To: Harald Freudenberger, Heiko Carstens, Vasily Gorbik,
Christian Borntraeger
Cc: linux-s390, linux-kernel, Qinglang Miao
The spinlock ap_poll_timer_lock is initialized statically. It is
unnecessary to initialize by spin_lock_init().
Signed-off-by: Qinglang Miao <miaoqinglang@huawei.com>
---
drivers/s390/crypto/ap_bus.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/s390/crypto/ap_bus.c b/drivers/s390/crypto/ap_bus.c
index 24a1940b8..231a98c91 100644
--- a/drivers/s390/crypto/ap_bus.c
+++ b/drivers/s390/crypto/ap_bus.c
@@ -1575,7 +1575,6 @@ static int __init ap_module_init(void)
*/
if (MACHINE_IS_VM)
poll_timeout = 1500000;
- spin_lock_init(&ap_poll_timer_lock);
hrtimer_init(&ap_poll_timer, CLOCK_MONOTONIC, HRTIMER_MODE_ABS);
ap_poll_timer.function = ap_poll_timeout;
--
2.23.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [PATCH -next] s390/ap: remove unnecessary spin_lock_init()
@ 2020-09-16 6:21 ` Qinglang Miao
0 siblings, 0 replies; 3+ messages in thread
From: Qinglang Miao @ 2020-09-16 6:21 UTC (permalink / raw)
To: Harald Freudenberger, Heiko Carstens, Vasily Gorbik,
Christian Borntraeger
Cc: linux-s390, linux-kernel, Qinglang Miao
The spinlock ap_poll_timer_lock is initialized statically. It is
unnecessary to initialize by spin_lock_init().
Signed-off-by: Qinglang Miao <miaoqinglang@huawei.com>
---
drivers/s390/crypto/ap_bus.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/s390/crypto/ap_bus.c b/drivers/s390/crypto/ap_bus.c
index 24a1940b8..231a98c91 100644
--- a/drivers/s390/crypto/ap_bus.c
+++ b/drivers/s390/crypto/ap_bus.c
@@ -1575,7 +1575,6 @@ static int __init ap_module_init(void)
*/
if (MACHINE_IS_VM)
poll_timeout = 1500000;
- spin_lock_init(&ap_poll_timer_lock);
hrtimer_init(&ap_poll_timer, CLOCK_MONOTONIC, HRTIMER_MODE_ABS);
ap_poll_timer.function = ap_poll_timeout;
--
2.23.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH -next] s390/ap: remove unnecessary spin_lock_init()
2020-09-16 6:21 ` Qinglang Miao
(?)
@ 2020-09-16 12:20 ` Heiko Carstens
-1 siblings, 0 replies; 3+ messages in thread
From: Heiko Carstens @ 2020-09-16 12:20 UTC (permalink / raw)
To: Qinglang Miao
Cc: Harald Freudenberger, Vasily Gorbik, Christian Borntraeger,
linux-s390, linux-kernel
On Wed, Sep 16, 2020 at 02:21:30PM +0800, Qinglang Miao wrote:
> The spinlock ap_poll_timer_lock is initialized statically. It is
> unnecessary to initialize by spin_lock_init().
>
> Signed-off-by: Qinglang Miao <miaoqinglang@huawei.com>
> ---
> drivers/s390/crypto/ap_bus.c | 1 -
> 1 file changed, 1 deletion(-)
Applied, thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-09-16 17:16 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-09-16 6:21 [PATCH -next] s390/ap: remove unnecessary spin_lock_init() Qinglang Miao
2020-09-16 6:21 ` Qinglang Miao
2020-09-16 12:20 ` Heiko Carstens
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.