All of lore.kernel.org
 help / color / mirror / Atom feed
* [RFC PATCH] travis.yml: Drop the default softmmu builds
@ 2020-08-05 18:54 Thomas Huth
  2020-09-05 12:15 ` Thomas Huth
  2020-09-16 13:16 ` Daniel P. Berrangé
  0 siblings, 2 replies; 7+ messages in thread
From: Thomas Huth @ 2020-08-05 18:54 UTC (permalink / raw)
  To: qemu-devel, Alex Bennée; +Cc: Fam Zheng, Philippe Mathieu-Daudé

The total runtime of all Travis jobs is very long and we are testing
all softmmu targets in the gitlab-CI already - so we can speed up the
Travis testing a little bit by not testing the softmmu targets here
anymore.

Signed-off-by: Thomas Huth <thuth@redhat.com>
---
 Well, ok, we do not test all the softmmu targets on gitlab-CI with
 that same ancient version of Ubuntu ... but do we still care about
 testing all softmmut targets on Ubuntu Xenial at all? ... at least
 according to our support policy, we do not care about Xenial anymore.

 .travis.yml | 14 --------------
 1 file changed, 14 deletions(-)

diff --git a/.travis.yml b/.travis.yml
index 6695c0620f..18290bc51d 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -123,20 +123,6 @@ jobs:
         - CONFIG="--disable-system --static"
         - CACHE_NAME="${TRAVIS_BRANCH}-linux-gcc-default"
 
-
-    # we split the system builds as it takes a while to build them all
-    - name: "GCC (main-softmmu)"
-      env:
-        - CONFIG="--disable-user --target-list=${MAIN_SOFTMMU_TARGETS}"
-        - CACHE_NAME="${TRAVIS_BRANCH}-linux-gcc-default"
-
-
-    - name: "GCC (other-softmmu)"
-      env:
-       - CONFIG="--disable-user --target-list-exclude=${MAIN_SOFTMMU_TARGETS}"
-        - CACHE_NAME="${TRAVIS_BRANCH}-linux-gcc-default"
-
-
     # Just build tools and run minimal unit and softfloat checks
     - name: "GCC check-softfloat (user)"
       env:
-- 
2.18.1



^ permalink raw reply related	[flat|nested] 7+ messages in thread

* Re: [RFC PATCH] travis.yml: Drop the default softmmu builds
  2020-08-05 18:54 [RFC PATCH] travis.yml: Drop the default softmmu builds Thomas Huth
@ 2020-09-05 12:15 ` Thomas Huth
  2020-09-16 13:12   ` Thomas Huth
  2020-09-16 13:16 ` Daniel P. Berrangé
  1 sibling, 1 reply; 7+ messages in thread
From: Thomas Huth @ 2020-09-05 12:15 UTC (permalink / raw)
  To: qemu-devel, Alex Bennée; +Cc: Fam Zheng, Philippe Mathieu-Daudé

On 05/08/2020 20.54, Thomas Huth wrote:
> The total runtime of all Travis jobs is very long and we are testing
> all softmmu targets in the gitlab-CI already - so we can speed up the
> Travis testing a little bit by not testing the softmmu targets here
> anymore.
> 
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
>  Well, ok, we do not test all the softmmu targets on gitlab-CI with
>  that same ancient version of Ubuntu ... but do we still care about
>  testing all softmmut targets on Ubuntu Xenial at all? ... at least
>  according to our support policy, we do not care about Xenial anymore.
> 
>  .travis.yml | 14 --------------
>  1 file changed, 14 deletions(-)
> 
> diff --git a/.travis.yml b/.travis.yml
> index 6695c0620f..18290bc51d 100644
> --- a/.travis.yml
> +++ b/.travis.yml
> @@ -123,20 +123,6 @@ jobs:
>          - CONFIG="--disable-system --static"
>          - CACHE_NAME="${TRAVIS_BRANCH}-linux-gcc-default"
>  
> -
> -    # we split the system builds as it takes a while to build them all
> -    - name: "GCC (main-softmmu)"
> -      env:
> -        - CONFIG="--disable-user --target-list=${MAIN_SOFTMMU_TARGETS}"
> -        - CACHE_NAME="${TRAVIS_BRANCH}-linux-gcc-default"
> -
> -
> -    - name: "GCC (other-softmmu)"
> -      env:
> -       - CONFIG="--disable-user --target-list-exclude=${MAIN_SOFTMMU_TARGETS}"
> -        - CACHE_NAME="${TRAVIS_BRANCH}-linux-gcc-default"
> -
> -
>      # Just build tools and run minimal unit and softfloat checks
>      - name: "GCC check-softfloat (user)"
>        env:
> 

Ping?

 Thomas



^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [RFC PATCH] travis.yml: Drop the default softmmu builds
  2020-09-05 12:15 ` Thomas Huth
@ 2020-09-16 13:12   ` Thomas Huth
  2020-09-16 13:22     ` Alex Bennée
  0 siblings, 1 reply; 7+ messages in thread
From: Thomas Huth @ 2020-09-16 13:12 UTC (permalink / raw)
  To: qemu-devel, Alex Bennée, Philippe Mathieu-Daudé; +Cc: Fam Zheng

On 05/09/2020 14.15, Thomas Huth wrote:
> On 05/08/2020 20.54, Thomas Huth wrote:
>> The total runtime of all Travis jobs is very long and we are testing
>> all softmmu targets in the gitlab-CI already - so we can speed up the
>> Travis testing a little bit by not testing the softmmu targets here
>> anymore.
>>
>> Signed-off-by: Thomas Huth <thuth@redhat.com>
>> ---
>>  Well, ok, we do not test all the softmmu targets on gitlab-CI with
>>  that same ancient version of Ubuntu ... but do we still care about
>>  testing all softmmut targets on Ubuntu Xenial at all? ... at least
>>  according to our support policy, we do not care about Xenial anymore.
>>
>>  .travis.yml | 14 --------------
>>  1 file changed, 14 deletions(-)
>>
>> diff --git a/.travis.yml b/.travis.yml
>> index 6695c0620f..18290bc51d 100644
>> --- a/.travis.yml
>> +++ b/.travis.yml
>> @@ -123,20 +123,6 @@ jobs:
>>          - CONFIG="--disable-system --static"
>>          - CACHE_NAME="${TRAVIS_BRANCH}-linux-gcc-default"
>>  
>> -
>> -    # we split the system builds as it takes a while to build them all
>> -    - name: "GCC (main-softmmu)"
>> -      env:
>> -        - CONFIG="--disable-user --target-list=${MAIN_SOFTMMU_TARGETS}"
>> -        - CACHE_NAME="${TRAVIS_BRANCH}-linux-gcc-default"
>> -
>> -
>> -    - name: "GCC (other-softmmu)"
>> -      env:
>> -       - CONFIG="--disable-user --target-list-exclude=${MAIN_SOFTMMU_TARGETS}"
>> -        - CACHE_NAME="${TRAVIS_BRANCH}-linux-gcc-default"
>> -
>> -
>>      # Just build tools and run minimal unit and softfloat checks
>>      - name: "GCC check-softfloat (user)"
>>        env:
>>
> 
> Ping?

Ping^2 ... Alex, Philippe, any opinions on this patch?

 Thomas



^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [RFC PATCH] travis.yml: Drop the default softmmu builds
  2020-08-05 18:54 [RFC PATCH] travis.yml: Drop the default softmmu builds Thomas Huth
  2020-09-05 12:15 ` Thomas Huth
@ 2020-09-16 13:16 ` Daniel P. Berrangé
  2020-09-16 13:42   ` Philippe Mathieu-Daudé
  1 sibling, 1 reply; 7+ messages in thread
From: Daniel P. Berrangé @ 2020-09-16 13:16 UTC (permalink / raw)
  To: Thomas Huth
  Cc: Fam Zheng, Philippe Mathieu-Daudé, Alex Bennée, qemu-devel

On Wed, Aug 05, 2020 at 08:54:03PM +0200, Thomas Huth wrote:
> The total runtime of all Travis jobs is very long and we are testing
> all softmmu targets in the gitlab-CI already - so we can speed up the
> Travis testing a little bit by not testing the softmmu targets here
> anymore.
> 
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
>  Well, ok, we do not test all the softmmu targets on gitlab-CI with
>  that same ancient version of Ubuntu ... but do we still care about
>  testing all softmmut targets on Ubuntu Xenial at all? ... at least
>  according to our support policy, we do not care about Xenial anymore.

Yep, we explicitly don't care about Xenial. Even if we did care about
Xenial, we could put such a job on GitLab CI instead.

IIUC, the main unique feature wrt Travis vs GitLab are potential for
non-x86 hardware testing, and functional use of KVM. So if the job
isn't using one of the unique Travis features, we should cull it
from Travis and GitLab if the job is still appicable.

>  .travis.yml | 14 --------------
>  1 file changed, 14 deletions(-)

Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>



Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|



^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [RFC PATCH] travis.yml: Drop the default softmmu builds
  2020-09-16 13:12   ` Thomas Huth
@ 2020-09-16 13:22     ` Alex Bennée
  2020-09-16 13:30       ` Thomas Huth
  0 siblings, 1 reply; 7+ messages in thread
From: Alex Bennée @ 2020-09-16 13:22 UTC (permalink / raw)
  To: Thomas Huth; +Cc: Fam Zheng, Philippe Mathieu-Daudé, qemu-devel


Thomas Huth <thuth@redhat.com> writes:

> On 05/09/2020 14.15, Thomas Huth wrote:
>> On 05/08/2020 20.54, Thomas Huth wrote:
>>> The total runtime of all Travis jobs is very long and we are testing
>>> all softmmu targets in the gitlab-CI already - so we can speed up the
>>> Travis testing a little bit by not testing the softmmu targets here
>>> anymore.
>>>
>>> Signed-off-by: Thomas Huth <thuth@redhat.com>
>>> ---
>>>  Well, ok, we do not test all the softmmu targets on gitlab-CI with
>>>  that same ancient version of Ubuntu ... but do we still care about
>>>  testing all softmmut targets on Ubuntu Xenial at all? ... at least
>>>  according to our support policy, we do not care about Xenial anymore.
>>>
>>>  .travis.yml | 14 --------------
>>>  1 file changed, 14 deletions(-)
>>>
>>> diff --git a/.travis.yml b/.travis.yml
>>> index 6695c0620f..18290bc51d 100644
>>> --- a/.travis.yml
>>> +++ b/.travis.yml
>>> @@ -123,20 +123,6 @@ jobs:
>>>          - CONFIG="--disable-system --static"
>>>          - CACHE_NAME="${TRAVIS_BRANCH}-linux-gcc-default"
>>>  
>>> -
>>> -    # we split the system builds as it takes a while to build them all
>>> -    - name: "GCC (main-softmmu)"
>>> -      env:
>>> -        - CONFIG="--disable-user --target-list=${MAIN_SOFTMMU_TARGETS}"
>>> -        - CACHE_NAME="${TRAVIS_BRANCH}-linux-gcc-default"
>>> -
>>> -
>>> -    - name: "GCC (other-softmmu)"
>>> -      env:
>>> -       - CONFIG="--disable-user --target-list-exclude=${MAIN_SOFTMMU_TARGETS}"
>>> -        - CACHE_NAME="${TRAVIS_BRANCH}-linux-gcc-default"
>>> -
>>> -
>>>      # Just build tools and run minimal unit and softfloat checks
>>>      - name: "GCC check-softfloat (user)"
>>>        env:
>>>
>> 
>> Ping?
>
> Ping^2 ... Alex, Philippe, any opinions on this patch?

I'm agnostic on this. Is it worth slightly reducing our coverage for ~50
minutes of runtime out of 10 hours? I guess it would be a bit greener.

Acked-by: Alex Bennée <alex.bennee@linaro.org>

-- 
Alex Bennée


^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [RFC PATCH] travis.yml: Drop the default softmmu builds
  2020-09-16 13:22     ` Alex Bennée
@ 2020-09-16 13:30       ` Thomas Huth
  0 siblings, 0 replies; 7+ messages in thread
From: Thomas Huth @ 2020-09-16 13:30 UTC (permalink / raw)
  To: Alex Bennée; +Cc: Fam Zheng, Philippe Mathieu-Daudé, qemu-devel

On 16/09/2020 15.22, Alex Bennée wrote:
> 
> Thomas Huth <thuth@redhat.com> writes:
> 
>> On 05/09/2020 14.15, Thomas Huth wrote:
>>> On 05/08/2020 20.54, Thomas Huth wrote:
>>>> The total runtime of all Travis jobs is very long and we are testing
>>>> all softmmu targets in the gitlab-CI already - so we can speed up the
>>>> Travis testing a little bit by not testing the softmmu targets here
>>>> anymore.
>>>>
>>>> Signed-off-by: Thomas Huth <thuth@redhat.com>
>>>> ---
>>>>  Well, ok, we do not test all the softmmu targets on gitlab-CI with
>>>>  that same ancient version of Ubuntu ... but do we still care about
>>>>  testing all softmmut targets on Ubuntu Xenial at all? ... at least
>>>>  according to our support policy, we do not care about Xenial anymore.
>>>>
>>>>  .travis.yml | 14 --------------
>>>>  1 file changed, 14 deletions(-)
>>>>
>>>> diff --git a/.travis.yml b/.travis.yml
>>>> index 6695c0620f..18290bc51d 100644
>>>> --- a/.travis.yml
>>>> +++ b/.travis.yml
>>>> @@ -123,20 +123,6 @@ jobs:
>>>>          - CONFIG="--disable-system --static"
>>>>          - CACHE_NAME="${TRAVIS_BRANCH}-linux-gcc-default"
>>>>  
>>>> -
>>>> -    # we split the system builds as it takes a while to build them all
>>>> -    - name: "GCC (main-softmmu)"
>>>> -      env:
>>>> -        - CONFIG="--disable-user --target-list=${MAIN_SOFTMMU_TARGETS}"
>>>> -        - CACHE_NAME="${TRAVIS_BRANCH}-linux-gcc-default"
>>>> -
>>>> -
>>>> -    - name: "GCC (other-softmmu)"
>>>> -      env:
>>>> -       - CONFIG="--disable-user --target-list-exclude=${MAIN_SOFTMMU_TARGETS}"
>>>> -        - CACHE_NAME="${TRAVIS_BRANCH}-linux-gcc-default"
>>>> -
>>>> -
>>>>      # Just build tools and run minimal unit and softfloat checks
>>>>      - name: "GCC check-softfloat (user)"
>>>>        env:
>>>>
>>>
>>> Ping?
>>
>> Ping^2 ... Alex, Philippe, any opinions on this patch?
> 
> I'm agnostic on this. Is it worth slightly reducing our coverage for ~50
> minutes of runtime out of 10 hours? I guess it would be a bit greener.

For the last Travis run that succeeded for me, I've got:

 Ran for 1 hr 48 min 32 sec
 Total time 7 hrs 58 min 6 sec

That means the total run time was less than 2h, it's just the total
summed up time of all jobs that is ~8h.

Since both Gitlab und Cirrus jobs finish within one hour, it would be
very convenient to have Travis also finish within one hour, so once
you've pushed your branches to gitlab and github, you could be sure to
get an answer from these three CI systems within 1 hour.

> Acked-by: Alex Bennée <alex.bennee@linaro.org>

Thanks!

  Thomas



^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [RFC PATCH] travis.yml: Drop the default softmmu builds
  2020-09-16 13:16 ` Daniel P. Berrangé
@ 2020-09-16 13:42   ` Philippe Mathieu-Daudé
  0 siblings, 0 replies; 7+ messages in thread
From: Philippe Mathieu-Daudé @ 2020-09-16 13:42 UTC (permalink / raw)
  To: Daniel P. Berrangé, Thomas Huth
  Cc: Fam Zheng, Alex Bennée, qemu-devel

On 9/16/20 3:16 PM, Daniel P. Berrangé wrote:
> On Wed, Aug 05, 2020 at 08:54:03PM +0200, Thomas Huth wrote:
>> The total runtime of all Travis jobs is very long and we are testing
>> all softmmu targets in the gitlab-CI already - so we can speed up the
>> Travis testing a little bit by not testing the softmmu targets here
>> anymore.
>>
>> Signed-off-by: Thomas Huth <thuth@redhat.com>
>> ---
>>  Well, ok, we do not test all the softmmu targets on gitlab-CI with
>>  that same ancient version of Ubuntu ... but do we still care about
>>  testing all softmmut targets on Ubuntu Xenial at all? ... at least
>>  according to our support policy, we do not care about Xenial anymore.
> 
> Yep, we explicitly don't care about Xenial. Even if we did care about
> Xenial, we could put such a job on GitLab CI instead.
> 
> IIUC, the main unique feature wrt Travis vs GitLab are potential for
> non-x86 hardware testing, and functional use of KVM. So if the job
> isn't using one of the unique Travis features, we should cull it
> from Travis and GitLab if the job is still appicable.

Agreed.

Acked-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
(Sorry for missing this patch)

> 
>>  .travis.yml | 14 --------------
>>  1 file changed, 14 deletions(-)
> 
> Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
> 
> 
> 
> Regards,
> Daniel
> 



^ permalink raw reply	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2020-09-16 13:43 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-08-05 18:54 [RFC PATCH] travis.yml: Drop the default softmmu builds Thomas Huth
2020-09-05 12:15 ` Thomas Huth
2020-09-16 13:12   ` Thomas Huth
2020-09-16 13:22     ` Alex Bennée
2020-09-16 13:30       ` Thomas Huth
2020-09-16 13:16 ` Daniel P. Berrangé
2020-09-16 13:42   ` Philippe Mathieu-Daudé

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.