* [Buildroot] [PATCH] package/18xx-ti-utils: update makefile in order to compile wlconf
@ 2020-09-16 13:58 Miken Valabdas
2020-09-16 14:57 ` Thomas Petazzoni
0 siblings, 1 reply; 8+ messages in thread
From: Miken Valabdas @ 2020-09-16 13:58 UTC (permalink / raw)
To: buildroot
Signed-off-by: Miken Valabdas <mvalabdas@distech-controls.com>
---
package/18xx-ti-utils/18xx-ti-utils.mk | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/package/18xx-ti-utils/18xx-ti-utils.mk b/package/18xx-ti-utils/18xx-ti-utils.mk
index d1f0388c3a..41ce8ab973 100644
--- a/package/18xx-ti-utils/18xx-ti-utils.mk
+++ b/package/18xx-ti-utils/18xx-ti-utils.mk
@@ -21,6 +21,11 @@ define 18XX_TI_UTILS_BUILD_CMDS
NFSROOT="$(STAGING_DIR)" NLVER=3 $(MAKE) -C $(@D) \
CFLAGS="$(TARGET_CFLAGS) $(18XX_TI_UTILS_CFLAGS)" \
$(18XX_TI_UTILS_BUILD_TARGET)
+
+ $(TARGET_MAKE_ENV) CROSS_COMPILE=$(TARGET_CROSS) \
+ NFSROOT="$(STAGING_DIR)" NLVER=3 $(MAKE) -C $(@D)/wlconf \
+ CFLAGS="$(TARGET_CFLAGS) $(18XX_TI_UTILS_CFLAGS)" \
+ $(18XX_TI_UTILS_BUILD_TARGET)
endef
define 18XX_TI_UTILS_INSTALL_TARGET_CMDS
--
2.17.1
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [Buildroot] [PATCH] package/18xx-ti-utils: update makefile in order to compile wlconf
2020-09-16 13:58 [Buildroot] [PATCH] package/18xx-ti-utils: update makefile in order to compile wlconf Miken Valabdas
@ 2020-09-16 14:57 ` Thomas Petazzoni
2020-09-16 16:14 ` Valabdas, Miken
0 siblings, 1 reply; 8+ messages in thread
From: Thomas Petazzoni @ 2020-09-16 14:57 UTC (permalink / raw)
To: buildroot
Hello Miken,
Thanks for your contribution!
On Wed, 16 Sep 2020 09:58:34 -0400
Miken Valabdas via buildroot <buildroot@busybox.net> wrote:
> Signed-off-by: Miken Valabdas <mvalabdas@distech-controls.com>
> ---
> package/18xx-ti-utils/18xx-ti-utils.mk | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/package/18xx-ti-utils/18xx-ti-utils.mk b/package/18xx-ti-utils/18xx-ti-utils.mk
> index d1f0388c3a..41ce8ab973 100644
> --- a/package/18xx-ti-utils/18xx-ti-utils.mk
> +++ b/package/18xx-ti-utils/18xx-ti-utils.mk
> @@ -21,6 +21,11 @@ define 18XX_TI_UTILS_BUILD_CMDS
> NFSROOT="$(STAGING_DIR)" NLVER=3 $(MAKE) -C $(@D) \
> CFLAGS="$(TARGET_CFLAGS) $(18XX_TI_UTILS_CFLAGS)" \
> $(18XX_TI_UTILS_BUILD_TARGET)
> +
> + $(TARGET_MAKE_ENV) CROSS_COMPILE=$(TARGET_CROSS) \
> + NFSROOT="$(STAGING_DIR)" NLVER=3 $(MAKE) -C $(@D)/wlconf \
> + CFLAGS="$(TARGET_CFLAGS) $(18XX_TI_UTILS_CFLAGS)" \
> + $(18XX_TI_UTILS_BUILD_TARGET)
So this is going to build another tool, but you haven't changed the
18XX_TI_UTILS_INSTALL_TARGET_CMDS to also install it. So how is this
tool going to be practically useful ?
Thanks!
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
^ permalink raw reply [flat|nested] 8+ messages in thread
* [Buildroot] [PATCH] package/18xx-ti-utils: update makefile in order to compile wlconf
2020-09-16 14:57 ` Thomas Petazzoni
@ 2020-09-16 16:14 ` Valabdas, Miken
2020-09-16 16:28 ` Thomas Petazzoni
0 siblings, 1 reply; 8+ messages in thread
From: Valabdas, Miken @ 2020-09-16 16:14 UTC (permalink / raw)
To: buildroot
Hello Thomas,
Thanks for your message.
The reason why I haven't changed the 18XX_TI_UTILS_INSTALL_TARGET_CMDS is because this tool will be used in a host computer (not on the target board) in conjunction with BR2_ROOTFS_POST_IMAGE_SCRIPT.
In resume, this tool will be used by a script through BR2_ROOTFS_POST_IMAGE_SCRIPT. The script itself will install the appropriate output (after doing some stuffs).
Thanks!
Miken
-----Original Message-----
From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Sent: 16 septembre 2020 10:57
To: Valabdas, Miken <mvalabdas@distech-controls.com>
Cc: buildroot at buildroot.org
Subject: Re: [Buildroot] [PATCH] package/18xx-ti-utils: update makefile in order to compile wlconf
Hello Miken,
Thanks for your contribution!
On Wed, 16 Sep 2020 09:58:34 -0400
Miken Valabdas via buildroot <buildroot@busybox.net> wrote:
> Signed-off-by: Miken Valabdas <mvalabdas@distech-controls.com>
> ---
> package/18xx-ti-utils/18xx-ti-utils.mk | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/package/18xx-ti-utils/18xx-ti-utils.mk
> b/package/18xx-ti-utils/18xx-ti-utils.mk
> index d1f0388c3a..41ce8ab973 100644
> --- a/package/18xx-ti-utils/18xx-ti-utils.mk
> +++ b/package/18xx-ti-utils/18xx-ti-utils.mk
> @@ -21,6 +21,11 @@ define 18XX_TI_UTILS_BUILD_CMDS
> NFSROOT="$(STAGING_DIR)" NLVER=3 $(MAKE) -C $(@D) \
> CFLAGS="$(TARGET_CFLAGS) $(18XX_TI_UTILS_CFLAGS)" \
> $(18XX_TI_UTILS_BUILD_TARGET)
> +
> + $(TARGET_MAKE_ENV) CROSS_COMPILE=$(TARGET_CROSS) \
> + NFSROOT="$(STAGING_DIR)" NLVER=3 $(MAKE) -C $(@D)/wlconf \
> + CFLAGS="$(TARGET_CFLAGS) $(18XX_TI_UTILS_CFLAGS)" \
> + $(18XX_TI_UTILS_BUILD_TARGET)
So this is going to build another tool, but you haven't changed the 18XX_TI_UTILS_INSTALL_TARGET_CMDS to also install it. So how is this tool going to be practically useful ?
Thanks!
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://urldefense.com/v3/__https://bootlin.com__;!!Po4YltK3bPMkYw!nIVmpi0i8yXDE-CppSCDd56kOjhCnuUXrq0QLj-UBQgyigt5BaYRYF8QHgYt3qmOJ1jr2Fkv$
^ permalink raw reply [flat|nested] 8+ messages in thread
* [Buildroot] [PATCH] package/18xx-ti-utils: update makefile in order to compile wlconf
2020-09-16 16:14 ` Valabdas, Miken
@ 2020-09-16 16:28 ` Thomas Petazzoni
2020-09-16 18:52 ` Valabdas, Miken
0 siblings, 1 reply; 8+ messages in thread
From: Thomas Petazzoni @ 2020-09-16 16:28 UTC (permalink / raw)
To: buildroot
Hello,
On Wed, 16 Sep 2020 16:14:07 +0000
"Valabdas, Miken" <mvalabdas@distech-controls.com> wrote:
> Thanks for your message.
>
> The reason why I haven't changed the
> 18XX_TI_UTILS_INSTALL_TARGET_CMDS is because this tool will be used
> in a host computer (not on the target board) in conjunction with
> BR2_ROOTFS_POST_IMAGE_SCRIPT.
>
> In resume, this tool will be used by a script through
> BR2_ROOTFS_POST_IMAGE_SCRIPT. The script itself will install the
> appropriate output (after doing some stuffs).
OK, so this tool is built with the host compiler, and runs on the host
machine. It seems weird as you're passing CFLAGS="$(TARGET_CFLAGS) ..."
for example.
Also, a host tool should be installed in $(HOST_DIR)/bin or
$(HOST_DIR)/sbin.
Best regards,
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
^ permalink raw reply [flat|nested] 8+ messages in thread
* [Buildroot] [PATCH] package/18xx-ti-utils: update makefile in order to compile wlconf
2020-09-16 16:28 ` Thomas Petazzoni
@ 2020-09-16 18:52 ` Valabdas, Miken
0 siblings, 0 replies; 8+ messages in thread
From: Valabdas, Miken @ 2020-09-16 18:52 UTC (permalink / raw)
To: buildroot
Hello,
I see, I will change accordingly. Thanks for your input.
Regards,
Miken.
mvalabdas at distech-controls.com
-----Original Message-----
From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Sent: 16 septembre 2020 12:29
To: Valabdas, Miken <mvalabdas@distech-controls.com>
Cc: buildroot at buildroot.org
Subject: Re: [Buildroot] [PATCH] package/18xx-ti-utils: update makefile in order to compile wlconf
Hello,
On Wed, 16 Sep 2020 16:14:07 +0000
"Valabdas, Miken" <mvalabdas@distech-controls.com> wrote:
> Thanks for your message.
>
> The reason why I haven't changed the
> 18XX_TI_UTILS_INSTALL_TARGET_CMDS is because this tool will be used in
> a host computer (not on the target board) in conjunction with
> BR2_ROOTFS_POST_IMAGE_SCRIPT.
>
> In resume, this tool will be used by a script through
> BR2_ROOTFS_POST_IMAGE_SCRIPT. The script itself will install the
> appropriate output (after doing some stuffs).
OK, so this tool is built with the host compiler, and runs on the host machine. It seems weird as you're passing CFLAGS="$(TARGET_CFLAGS) ..."
for example.
Also, a host tool should be installed in $(HOST_DIR)/bin or $(HOST_DIR)/sbin.
Best regards,
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://urldefense.com/v3/__https://bootlin.com__;!!Po4YltK3bPMkYw!jjfxu5py5t8nd8ucVhSs2-N5n3EdfjudvNwyVbcc5lGNbET1KSf4rOMlgzqqIxvs7YGLi0TO$
^ permalink raw reply [flat|nested] 8+ messages in thread
* [Buildroot] [PATCH] package/18xx-ti-utils: update makefile in order to compile wlconf
@ 2020-09-16 20:35 Miken Valabdas
0 siblings, 0 replies; 8+ messages in thread
From: Miken Valabdas @ 2020-09-16 20:35 UTC (permalink / raw)
To: buildroot
Signed-off-by: Miken Valabdas <mvalabdas@distech-controls.com>
---
Changes v1 -> v2:
- adjust compilation parameters
---
package/18xx-ti-utils/18xx-ti-utils.mk | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/package/18xx-ti-utils/18xx-ti-utils.mk b/package/18xx-ti-utils/18xx-ti-utils.mk
index d1f0388c3a..afe07ba227 100644
--- a/package/18xx-ti-utils/18xx-ti-utils.mk
+++ b/package/18xx-ti-utils/18xx-ti-utils.mk
@@ -21,10 +21,15 @@ define 18XX_TI_UTILS_BUILD_CMDS
NFSROOT="$(STAGING_DIR)" NLVER=3 $(MAKE) -C $(@D) \
CFLAGS="$(TARGET_CFLAGS) $(18XX_TI_UTILS_CFLAGS)" \
$(18XX_TI_UTILS_BUILD_TARGET)
+
+ $(HOST_MAKE_ENV) $(MAKE) -C $(@D)/wlconf \
+ CC="$(HOSTCC)" \
+ CFLAGS="$(HOST_CFLAGS)" \
endef
define 18XX_TI_UTILS_INSTALL_TARGET_CMDS
$(INSTALL) -m 0755 $(@D)/calibrator $(TARGET_DIR)/usr/bin/calibrator
+ $(INSTALL) -m 0755 $(@D)/wlconf/wlconf $(HOST_DIR)/bin/wlconf
endef
$(eval $(generic-package))
--
2.17.1
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [Buildroot] [PATCH] package/18xx-ti-utils: update makefile in order to compile wlconf
@ 2020-09-16 21:01 Miken Valabdas
2020-09-17 20:15 ` Thomas Petazzoni
0 siblings, 1 reply; 8+ messages in thread
From: Miken Valabdas @ 2020-09-16 21:01 UTC (permalink / raw)
To: buildroot
Signed-off-by: Miken Valabdas <mvalabdas@distech-controls.com>
---
Change v2 -> v3:
- typo
Changes v1 -> v2:
- adjust compilation parameters
---
package/18xx-ti-utils/18xx-ti-utils.mk | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/package/18xx-ti-utils/18xx-ti-utils.mk b/package/18xx-ti-utils/18xx-ti-utils.mk
index d1f0388c3a..cbd5096eed 100644
--- a/package/18xx-ti-utils/18xx-ti-utils.mk
+++ b/package/18xx-ti-utils/18xx-ti-utils.mk
@@ -21,10 +21,16 @@ define 18XX_TI_UTILS_BUILD_CMDS
NFSROOT="$(STAGING_DIR)" NLVER=3 $(MAKE) -C $(@D) \
CFLAGS="$(TARGET_CFLAGS) $(18XX_TI_UTILS_CFLAGS)" \
$(18XX_TI_UTILS_BUILD_TARGET)
+
+ $(HOST_MAKE_ENV) $(MAKE) -C $(@D)/wlconf \
+ CC="$(HOSTCC)" \
+ CFLAGS="$(HOST_CFLAGS)"
+
endef
define 18XX_TI_UTILS_INSTALL_TARGET_CMDS
$(INSTALL) -m 0755 $(@D)/calibrator $(TARGET_DIR)/usr/bin/calibrator
+ $(INSTALL) -m 0755 $(@D)/wlconf/wlconf $(HOST_DIR)/bin/wlconf
endef
$(eval $(generic-package))
--
2.17.1
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [Buildroot] [PATCH] package/18xx-ti-utils: update makefile in order to compile wlconf
2020-09-16 21:01 Miken Valabdas
@ 2020-09-17 20:15 ` Thomas Petazzoni
0 siblings, 0 replies; 8+ messages in thread
From: Thomas Petazzoni @ 2020-09-17 20:15 UTC (permalink / raw)
To: buildroot
On Wed, 16 Sep 2020 17:01:46 -0400
Miken Valabdas via buildroot <buildroot@busybox.net> wrote:
> Signed-off-by: Miken Valabdas <mvalabdas@distech-controls.com>
> ---
> Change v2 -> v3:
> - typo
> Changes v1 -> v2:
> - adjust compilation parameters
> ---
> package/18xx-ti-utils/18xx-ti-utils.mk | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/package/18xx-ti-utils/18xx-ti-utils.mk b/package/18xx-ti-utils/18xx-ti-utils.mk
> index d1f0388c3a..cbd5096eed 100644
> --- a/package/18xx-ti-utils/18xx-ti-utils.mk
> +++ b/package/18xx-ti-utils/18xx-ti-utils.mk
> @@ -21,10 +21,16 @@ define 18XX_TI_UTILS_BUILD_CMDS
> NFSROOT="$(STAGING_DIR)" NLVER=3 $(MAKE) -C $(@D) \
> CFLAGS="$(TARGET_CFLAGS) $(18XX_TI_UTILS_CFLAGS)" \
> $(18XX_TI_UTILS_BUILD_TARGET)
> +
> + $(HOST_MAKE_ENV) $(MAKE) -C $(@D)/wlconf \
> + CC="$(HOSTCC)" \
> + CFLAGS="$(HOST_CFLAGS)"
I've replaced CC and CFLAGS here by $(HOST_CONFIGURE_OPTS)
> +
There was some trailing white space here, so I've simply dropped this
line.
Applied to master with those changes, and a slightly improved commit
log.
Thanks!
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2020-09-17 20:15 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-09-16 13:58 [Buildroot] [PATCH] package/18xx-ti-utils: update makefile in order to compile wlconf Miken Valabdas
2020-09-16 14:57 ` Thomas Petazzoni
2020-09-16 16:14 ` Valabdas, Miken
2020-09-16 16:28 ` Thomas Petazzoni
2020-09-16 18:52 ` Valabdas, Miken
2020-09-16 20:35 Miken Valabdas
2020-09-16 21:01 Miken Valabdas
2020-09-17 20:15 ` Thomas Petazzoni
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.