From: kernel test robot <lkp@intel.com>
To: Hao Luo <haoluo@google.com>,
netdev@vger.kernel.org, bpf@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org
Cc: kbuild-all@lists.01.org, Shuah Khan <skhan@linuxfoundation.org>,
Alexei Starovoitov <ast@kernel.org>,
Andrii Nakryiko <andriin@fb.com>,
Daniel Borkmann <daniel@iogearbox.net>,
Martin KaFai Lau <kafai@fb.com>, Song Liu <songliubraving@fb.com>
Subject: Re: [PATCH bpf-next v3 4/6] bpf: Introduce bpf_per_cpu_ptr()
Date: Thu, 17 Sep 2020 09:14:11 +0800 [thread overview]
Message-ID: <202009170943.rYEs5XMN%lkp@intel.com> (raw)
In-Reply-To: <20200916223512.2885524-5-haoluo@google.com>
[-- Attachment #1: Type: text/plain, Size: 2623 bytes --]
Hi Hao,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on bpf-next/master]
url: https://github.com/0day-ci/linux/commits/Hao-Luo/bpf-BTF-support-for-ksyms/20200917-064052
base: https://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf-next.git master
config: powerpc-randconfig-s032-20200916 (attached as .config)
compiler: powerpc64-linux-gcc (GCC) 9.3.0
reproduce:
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# apt-get install sparse
# sparse version: v0.6.2-201-g24bdaac6-dirty
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' ARCH=powerpc
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
sparse warnings: (new ones prefixed by >>)
>> kernel/bpf/helpers.c:631:31: sparse: sparse: incorrect type in initializer (different address spaces) @@ expected void const [noderef] __percpu *__vpp_verify @@ got void const * @@
>> kernel/bpf/helpers.c:631:31: sparse: expected void const [noderef] __percpu *__vpp_verify
>> kernel/bpf/helpers.c:631:31: sparse: got void const *
# https://github.com/0day-ci/linux/commit/3f6ea3c1c73efe466a96ff7499219fe3b03b8f48
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Hao-Luo/bpf-BTF-support-for-ksyms/20200917-064052
git checkout 3f6ea3c1c73efe466a96ff7499219fe3b03b8f48
vim +631 kernel/bpf/helpers.c
625
626 BPF_CALL_2(bpf_per_cpu_ptr, const void *, ptr, u32, cpu)
627 {
628 if (cpu >= nr_cpu_ids)
629 return (unsigned long)NULL;
630
> 631 return (unsigned long)per_cpu_ptr(ptr, cpu);
632 }
633
634 const struct bpf_func_proto bpf_per_cpu_ptr_proto = {
635 .func = bpf_per_cpu_ptr,
636 .gpl_only = false,
637 .ret_type = RET_PTR_TO_MEM_OR_BTF_ID_OR_NULL,
638 .arg1_type = ARG_PTR_TO_PERCPU_BTF_ID,
639 .arg2_type = ARG_ANYTHING,
640 };
641
> 642 const struct bpf_func_proto bpf_get_current_task_proto __weak;
643 const struct bpf_func_proto bpf_probe_read_user_proto __weak;
644 const struct bpf_func_proto bpf_probe_read_user_str_proto __weak;
645 const struct bpf_func_proto bpf_probe_read_kernel_proto __weak;
646 const struct bpf_func_proto bpf_probe_read_kernel_str_proto __weak;
647
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 28957 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: kernel test robot <lkp@intel.com>
To: kbuild-all@lists.01.org
Subject: Re: [PATCH bpf-next v3 4/6] bpf: Introduce bpf_per_cpu_ptr()
Date: Thu, 17 Sep 2020 09:14:11 +0800 [thread overview]
Message-ID: <202009170943.rYEs5XMN%lkp@intel.com> (raw)
In-Reply-To: <20200916223512.2885524-5-haoluo@google.com>
[-- Attachment #1: Type: text/plain, Size: 2686 bytes --]
Hi Hao,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on bpf-next/master]
url: https://github.com/0day-ci/linux/commits/Hao-Luo/bpf-BTF-support-for-ksyms/20200917-064052
base: https://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf-next.git master
config: powerpc-randconfig-s032-20200916 (attached as .config)
compiler: powerpc64-linux-gcc (GCC) 9.3.0
reproduce:
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# apt-get install sparse
# sparse version: v0.6.2-201-g24bdaac6-dirty
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' ARCH=powerpc
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
sparse warnings: (new ones prefixed by >>)
>> kernel/bpf/helpers.c:631:31: sparse: sparse: incorrect type in initializer (different address spaces) @@ expected void const [noderef] __percpu *__vpp_verify @@ got void const * @@
>> kernel/bpf/helpers.c:631:31: sparse: expected void const [noderef] __percpu *__vpp_verify
>> kernel/bpf/helpers.c:631:31: sparse: got void const *
# https://github.com/0day-ci/linux/commit/3f6ea3c1c73efe466a96ff7499219fe3b03b8f48
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Hao-Luo/bpf-BTF-support-for-ksyms/20200917-064052
git checkout 3f6ea3c1c73efe466a96ff7499219fe3b03b8f48
vim +631 kernel/bpf/helpers.c
625
626 BPF_CALL_2(bpf_per_cpu_ptr, const void *, ptr, u32, cpu)
627 {
628 if (cpu >= nr_cpu_ids)
629 return (unsigned long)NULL;
630
> 631 return (unsigned long)per_cpu_ptr(ptr, cpu);
632 }
633
634 const struct bpf_func_proto bpf_per_cpu_ptr_proto = {
635 .func = bpf_per_cpu_ptr,
636 .gpl_only = false,
637 .ret_type = RET_PTR_TO_MEM_OR_BTF_ID_OR_NULL,
638 .arg1_type = ARG_PTR_TO_PERCPU_BTF_ID,
639 .arg2_type = ARG_ANYTHING,
640 };
641
> 642 const struct bpf_func_proto bpf_get_current_task_proto __weak;
643 const struct bpf_func_proto bpf_probe_read_user_proto __weak;
644 const struct bpf_func_proto bpf_probe_read_user_str_proto __weak;
645 const struct bpf_func_proto bpf_probe_read_kernel_proto __weak;
646 const struct bpf_func_proto bpf_probe_read_kernel_str_proto __weak;
647
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 28957 bytes --]
next prev parent reply other threads:[~2020-09-17 1:18 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-16 22:35 [PATCH bpf-next v3 0/6] bpf: BTF support for ksyms Hao Luo
2020-09-16 22:35 ` [PATCH bpf-next v3 1/6] bpf: Introduce pseudo_btf_id Hao Luo
2020-09-21 17:46 ` Andrii Nakryiko
2020-09-16 22:35 ` [PATCH bpf-next v3 2/6] bpf/libbpf: BTF support for typed ksyms Hao Luo
2020-09-21 17:52 ` Andrii Nakryiko
2020-09-16 22:35 ` [PATCH bpf-next v3 3/6] selftests/bpf: ksyms_btf to test " Hao Luo
2020-09-21 17:57 ` Andrii Nakryiko
2020-09-16 22:35 ` [PATCH bpf-next v3 4/6] bpf: Introduce bpf_per_cpu_ptr() Hao Luo
2020-09-17 1:14 ` kernel test robot [this message]
2020-09-17 1:14 ` kernel test robot
2020-09-17 19:12 ` Hao Luo
2020-09-17 19:12 ` Hao Luo
2020-09-21 18:11 ` Andrii Nakryiko
2020-09-29 23:53 ` Hao Luo
2020-09-29 23:53 ` Hao Luo
2020-09-21 18:08 ` Andrii Nakryiko
2020-09-29 23:52 ` Hao Luo
2020-09-16 22:35 ` [PATCH bpf-next v3 5/6] bpf: Introduce bpf_this_cpu_ptr() Hao Luo
2020-09-16 22:35 ` [PATCH bpf-next v3 6/6] bpf/selftests: Test for bpf_per_cpu_ptr() and bpf_this_cpu_ptr() Hao Luo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202009170943.rYEs5XMN%lkp@intel.com \
--to=lkp@intel.com \
--cc=andriin@fb.com \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=haoluo@google.com \
--cc=kafai@fb.com \
--cc=kbuild-all@lists.01.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=skhan@linuxfoundation.org \
--cc=songliubraving@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.