* [PATCH net-next] ionic: add DIMLIB to Kconfig
@ 2020-09-17 18:42 Shannon Nelson
2020-09-17 19:02 ` Jakub Kicinski
0 siblings, 1 reply; 6+ messages in thread
From: Shannon Nelson @ 2020-09-17 18:42 UTC (permalink / raw)
To: netdev, davem; +Cc: Shannon Nelson
>> ld.lld: error: undefined symbol: net_dim_get_rx_moderation
>>> referenced by ionic_lif.c:52 (drivers/net/ethernet/pensando/ionic/ionic_lif.c:52)
>>> net/ethernet/pensando/ionic/ionic_lif.o:(ionic_dim_work) in archive drivers/built-in.a
--
>> ld.lld: error: undefined symbol: net_dim
>>> referenced by ionic_txrx.c:456 (drivers/net/ethernet/pensando/ionic/ionic_txrx.c:456)
>>> net/ethernet/pensando/ionic/ionic_txrx.o:(ionic_dim_update) in archive drivers/built-in.a
Fixes: 04a834592bf5 ("ionic: dynamic interrupt moderation")
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Shannon Nelson <snelson@pensando.io>
---
drivers/net/ethernet/pensando/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/ethernet/pensando/Kconfig b/drivers/net/ethernet/pensando/Kconfig
index 76f8cc502bf9..5f8b0bb3af6e 100644
--- a/drivers/net/ethernet/pensando/Kconfig
+++ b/drivers/net/ethernet/pensando/Kconfig
@@ -21,6 +21,7 @@ config IONIC
tristate "Pensando Ethernet IONIC Support"
depends on 64BIT && PCI
select NET_DEVLINK
+ select DIMLIB
help
This enables the support for the Pensando family of Ethernet
adapters. More specific information on this driver can be
--
2.17.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH net-next] ionic: add DIMLIB to Kconfig
2020-09-17 18:42 [PATCH net-next] ionic: add DIMLIB to Kconfig Shannon Nelson
@ 2020-09-17 19:02 ` Jakub Kicinski
2020-09-17 19:08 ` Shannon Nelson
0 siblings, 1 reply; 6+ messages in thread
From: Jakub Kicinski @ 2020-09-17 19:02 UTC (permalink / raw)
To: Shannon Nelson; +Cc: netdev, davem
On Thu, 17 Sep 2020 11:42:43 -0700 Shannon Nelson wrote:
> >> ld.lld: error: undefined symbol: net_dim_get_rx_moderation
> >>> referenced by ionic_lif.c:52 (drivers/net/ethernet/pensando/ionic/ionic_lif.c:52)
> >>> net/ethernet/pensando/ionic/ionic_lif.o:(ionic_dim_work) in archive drivers/built-in.a
> --
This is going to cut off the commit message when patch is applied.
> >> ld.lld: error: undefined symbol: net_dim
> >>> referenced by ionic_txrx.c:456 (drivers/net/ethernet/pensando/ionic/ionic_txrx.c:456)
> >>> net/ethernet/pensando/ionic/ionic_txrx.o:(ionic_dim_update) in archive drivers/built-in.a
>
> Fixes: 04a834592bf5 ("ionic: dynamic interrupt moderation")
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Shannon Nelson <snelson@pensando.io>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH net-next] ionic: add DIMLIB to Kconfig
2020-09-17 19:02 ` Jakub Kicinski
@ 2020-09-17 19:08 ` Shannon Nelson
2020-09-17 20:02 ` Jakub Kicinski
0 siblings, 1 reply; 6+ messages in thread
From: Shannon Nelson @ 2020-09-17 19:08 UTC (permalink / raw)
To: Jakub Kicinski; +Cc: netdev, davem
On 9/17/20 12:02 PM, Jakub Kicinski wrote:
> On Thu, 17 Sep 2020 11:42:43 -0700 Shannon Nelson wrote:
>>>> ld.lld: error: undefined symbol: net_dim_get_rx_moderation
>> >>> referenced by ionic_lif.c:52 (drivers/net/ethernet/pensando/ionic/ionic_lif.c:52)
>> >>> net/ethernet/pensando/ionic/ionic_lif.o:(ionic_dim_work) in archive drivers/built-in.a
>> --
> This is going to cut off the commit message when patch is applied.
Isn't the trigger a three dash string? It is only two dashes, not
three, and "git am" seems to work correctly for me. Is there a
different mechanism I need to watch out for?
sln
>
>>>> ld.lld: error: undefined symbol: net_dim
>> >>> referenced by ionic_txrx.c:456 (drivers/net/ethernet/pensando/ionic/ionic_txrx.c:456)
>> >>> net/ethernet/pensando/ionic/ionic_txrx.o:(ionic_dim_update) in archive drivers/built-in.a
>>
>> Fixes: 04a834592bf5 ("ionic: dynamic interrupt moderation")
>> Reported-by: kernel test robot <lkp@intel.com>
>> Signed-off-by: Shannon Nelson <snelson@pensando.io>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH net-next] ionic: add DIMLIB to Kconfig
2020-09-17 19:08 ` Shannon Nelson
@ 2020-09-17 20:02 ` Jakub Kicinski
2020-09-17 20:10 ` David Miller
2020-09-17 20:30 ` Shannon Nelson
0 siblings, 2 replies; 6+ messages in thread
From: Jakub Kicinski @ 2020-09-17 20:02 UTC (permalink / raw)
To: Shannon Nelson; +Cc: netdev, davem
On Thu, 17 Sep 2020 12:08:45 -0700 Shannon Nelson wrote:
> On 9/17/20 12:02 PM, Jakub Kicinski wrote:
> > On Thu, 17 Sep 2020 11:42:43 -0700 Shannon Nelson wrote:
> >>>> ld.lld: error: undefined symbol: net_dim_get_rx_moderation
> >> >>> referenced by ionic_lif.c:52 (drivers/net/ethernet/pensando/ionic/ionic_lif.c:52)
> >> >>> net/ethernet/pensando/ionic/ionic_lif.o:(ionic_dim_work) in archive drivers/built-in.a
> >> --
> > This is going to cut off the commit message when patch is applied.
>
> Isn't the trigger a three dash string? It is only two dashes, not
> three, and "git am" seems to work correctly for me. Is there a
> different mechanism I need to watch out for?
I got a verify_signoff failure on this patch:
Commit a92faed54662 ("ionic: add DIMLIB to Kconfig")
author Signed-off-by missing
author email: snelson@pensando.io
And in the tree I can see the commit got cut off.
Maybe it's some extra mangling my bot does. In any case, I wanted to
at least give Dave a heads up.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH net-next] ionic: add DIMLIB to Kconfig
2020-09-17 20:02 ` Jakub Kicinski
@ 2020-09-17 20:10 ` David Miller
2020-09-17 20:30 ` Shannon Nelson
1 sibling, 0 replies; 6+ messages in thread
From: David Miller @ 2020-09-17 20:10 UTC (permalink / raw)
To: kuba; +Cc: snelson, netdev
From: Jakub Kicinski <kuba@kernel.org>
Date: Thu, 17 Sep 2020 13:02:31 -0700
> On Thu, 17 Sep 2020 12:08:45 -0700 Shannon Nelson wrote:
>> On 9/17/20 12:02 PM, Jakub Kicinski wrote:
>> > On Thu, 17 Sep 2020 11:42:43 -0700 Shannon Nelson wrote:
>> >>>> ld.lld: error: undefined symbol: net_dim_get_rx_moderation
>> >> >>> referenced by ionic_lif.c:52 (drivers/net/ethernet/pensando/ionic/ionic_lif.c:52)
>> >> >>> net/ethernet/pensando/ionic/ionic_lif.o:(ionic_dim_work) in archive drivers/built-in.a
>> >> --
>> > This is going to cut off the commit message when patch is applied.
>>
>> Isn't the trigger a three dash string? It is only two dashes, not
>> three, and "git am" seems to work correctly for me. Is there a
>> different mechanism I need to watch out for?
>
> I got a verify_signoff failure on this patch:
>
> Commit a92faed54662 ("ionic: add DIMLIB to Kconfig")
> author Signed-off-by missing
> author email: snelson@pensando.io
>
> And in the tree I can see the commit got cut off.
>
> Maybe it's some extra mangling my bot does. In any case, I wanted to
> at least give Dave a heads up.
Thanks I'll watch carefully when applying this :)
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH net-next] ionic: add DIMLIB to Kconfig
2020-09-17 20:02 ` Jakub Kicinski
2020-09-17 20:10 ` David Miller
@ 2020-09-17 20:30 ` Shannon Nelson
1 sibling, 0 replies; 6+ messages in thread
From: Shannon Nelson @ 2020-09-17 20:30 UTC (permalink / raw)
To: Jakub Kicinski; +Cc: netdev, davem
On 9/17/20 1:02 PM, Jakub Kicinski wrote:
> On Thu, 17 Sep 2020 12:08:45 -0700 Shannon Nelson wrote:
>> On 9/17/20 12:02 PM, Jakub Kicinski wrote:
>>> On Thu, 17 Sep 2020 11:42:43 -0700 Shannon Nelson wrote:
>>>>>> ld.lld: error: undefined symbol: net_dim_get_rx_moderation
>>>> >>> referenced by ionic_lif.c:52 (drivers/net/ethernet/pensando/ionic/ionic_lif.c:52)
>>>> >>> net/ethernet/pensando/ionic/ionic_lif.o:(ionic_dim_work) in archive drivers/built-in.a
>>>> --
>>> This is going to cut off the commit message when patch is applied.
>> Isn't the trigger a three dash string? It is only two dashes, not
>> three, and "git am" seems to work correctly for me. Is there a
>> different mechanism I need to watch out for?
> I got a verify_signoff failure on this patch:
>
> Commit a92faed54662 ("ionic: add DIMLIB to Kconfig")
> author Signed-off-by missing
> author email: snelson@pensando.io
>
> And in the tree I can see the commit got cut off.
>
> Maybe it's some extra mangling my bot does. In any case, I wanted to
> at least give Dave a heads up.
Okay, thanks for the note. I'll respin without the dashes.
sln
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2020-09-17 20:30 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-09-17 18:42 [PATCH net-next] ionic: add DIMLIB to Kconfig Shannon Nelson
2020-09-17 19:02 ` Jakub Kicinski
2020-09-17 19:08 ` Shannon Nelson
2020-09-17 20:02 ` Jakub Kicinski
2020-09-17 20:10 ` David Miller
2020-09-17 20:30 ` Shannon Nelson
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.