From: Russell King - ARM Linux admin <linux@armlinux.org.uk>
To: Christoph Hellwig <hch@lst.de>
Cc: Aaro Koskinen <aaro.koskinen@iki.fi>,
Tony Lindgren <tony@atomide.com>,
Robin Murphy <robin.murphy@arm.com>,
iommu@lists.linux-foundation.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org,
linux-usb@vger.kernel.org
Subject: Re: [PATCH 2/4] ARM/footbridge: switch to use dma_direct_set_offset for lbus DMA offsets
Date: Thu, 17 Sep 2020 19:53:40 +0100 [thread overview]
Message-ID: <20200917185340.GC1559@shell.armlinux.org.uk> (raw)
In-Reply-To: <20200917173229.3311382-3-hch@lst.de>
On Thu, Sep 17, 2020 at 07:32:27PM +0200, Christoph Hellwig wrote:
> static int __init cats_pci_init(void)
> {
> - if (machine_is_cats())
> - pci_common_init(&cats_pci);
> + if (!machine_is_cats())
> + return 0;
> + bus_register_notifier(&pci_bus_type, &footbridge_pci_dma_nb);
> + pci_common_init(&cats_pci);
I'd prefer these things to retain a positive-logic construct, so:
if (machine_is_cats()) {
bus_register_notifier(&pci_bus_type, &footbridge_pci_dma_nb);
pci_common_init(&cats_pci);
}
It's the same number of lines.
Otherwise, I think it's fine. I'll try to find some spare time to give
it a go on a Netwinder.
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!
WARNING: multiple messages have this Message-ID (diff)
From: Russell King - ARM Linux admin <linux@armlinux.org.uk>
To: Christoph Hellwig <hch@lst.de>
Cc: Aaro Koskinen <aaro.koskinen@iki.fi>,
Tony Lindgren <tony@atomide.com>,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
iommu@lists.linux-foundation.org, linux-omap@vger.kernel.org,
Robin Murphy <robin.murphy@arm.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 2/4] ARM/footbridge: switch to use dma_direct_set_offset for lbus DMA offsets
Date: Thu, 17 Sep 2020 19:53:40 +0100 [thread overview]
Message-ID: <20200917185340.GC1559@shell.armlinux.org.uk> (raw)
In-Reply-To: <20200917173229.3311382-3-hch@lst.de>
On Thu, Sep 17, 2020 at 07:32:27PM +0200, Christoph Hellwig wrote:
> static int __init cats_pci_init(void)
> {
> - if (machine_is_cats())
> - pci_common_init(&cats_pci);
> + if (!machine_is_cats())
> + return 0;
> + bus_register_notifier(&pci_bus_type, &footbridge_pci_dma_nb);
> + pci_common_init(&cats_pci);
I'd prefer these things to retain a positive-logic construct, so:
if (machine_is_cats()) {
bus_register_notifier(&pci_bus_type, &footbridge_pci_dma_nb);
pci_common_init(&cats_pci);
}
It's the same number of lines.
Otherwise, I think it's fine. I'll try to find some spare time to give
it a go on a Netwinder.
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
WARNING: multiple messages have this Message-ID (diff)
From: Russell King - ARM Linux admin <linux@armlinux.org.uk>
To: Christoph Hellwig <hch@lst.de>
Cc: Aaro Koskinen <aaro.koskinen@iki.fi>,
Tony Lindgren <tony@atomide.com>,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
iommu@lists.linux-foundation.org, linux-omap@vger.kernel.org,
Robin Murphy <robin.murphy@arm.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 2/4] ARM/footbridge: switch to use dma_direct_set_offset for lbus DMA offsets
Date: Thu, 17 Sep 2020 19:53:40 +0100 [thread overview]
Message-ID: <20200917185340.GC1559@shell.armlinux.org.uk> (raw)
In-Reply-To: <20200917173229.3311382-3-hch@lst.de>
On Thu, Sep 17, 2020 at 07:32:27PM +0200, Christoph Hellwig wrote:
> static int __init cats_pci_init(void)
> {
> - if (machine_is_cats())
> - pci_common_init(&cats_pci);
> + if (!machine_is_cats())
> + return 0;
> + bus_register_notifier(&pci_bus_type, &footbridge_pci_dma_nb);
> + pci_common_init(&cats_pci);
I'd prefer these things to retain a positive-logic construct, so:
if (machine_is_cats()) {
bus_register_notifier(&pci_bus_type, &footbridge_pci_dma_nb);
pci_common_init(&cats_pci);
}
It's the same number of lines.
Otherwise, I think it's fine. I'll try to find some spare time to give
it a go on a Netwinder.
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-09-17 18:54 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-17 17:32 RFC: remove the need for <asm/dma-direct.h> on ARM Christoph Hellwig
2020-09-17 17:32 ` Christoph Hellwig
2020-09-17 17:32 ` Christoph Hellwig
2020-09-17 17:32 ` [PATCH 1/4] ARM/omap1: switch to use dma_direct_set_offset for lbus DMA offsets Christoph Hellwig
2020-09-17 17:32 ` Christoph Hellwig
2020-09-17 17:32 ` Christoph Hellwig
2020-09-18 5:49 ` Tony Lindgren
2020-09-18 5:49 ` Tony Lindgren
2020-09-18 5:49 ` Tony Lindgren
2020-09-19 22:29 ` Janusz Krzysztofik
2020-09-19 22:29 ` Janusz Krzysztofik
2020-09-19 22:29 ` Janusz Krzysztofik
2020-09-21 6:44 ` Tony Lindgren
2020-09-21 6:44 ` Tony Lindgren
2020-09-21 6:44 ` Tony Lindgren
2020-09-21 6:47 ` Christoph Hellwig
2020-09-21 6:47 ` Christoph Hellwig
2020-09-21 6:47 ` Christoph Hellwig
2020-09-23 10:05 ` Russell King - ARM Linux admin
2020-09-23 10:05 ` Russell King - ARM Linux admin
2020-09-23 10:05 ` Russell King - ARM Linux admin
2020-09-25 4:16 ` Christoph Hellwig
2020-09-25 4:16 ` Christoph Hellwig
2020-09-25 4:16 ` Christoph Hellwig
2020-09-17 17:32 ` [PATCH 2/4] ARM/footbridge: " Christoph Hellwig
2020-09-17 17:32 ` Christoph Hellwig
2020-09-17 17:32 ` Christoph Hellwig
2020-09-17 18:53 ` Russell King - ARM Linux admin [this message]
2020-09-17 18:53 ` Russell King - ARM Linux admin
2020-09-17 18:53 ` Russell King - ARM Linux admin
2020-09-17 17:32 ` [PATCH 3/4] ARM/dma-mapping: don't handle NULL devices in dma-direct.h Christoph Hellwig
2020-09-17 17:32 ` Christoph Hellwig
2020-09-17 17:32 ` Christoph Hellwig
2020-09-17 18:50 ` Russell King - ARM Linux admin
2020-09-17 18:50 ` Russell King - ARM Linux admin
2020-09-17 18:50 ` Russell King - ARM Linux admin
2020-09-18 5:10 ` Christoph Hellwig
2020-09-18 5:10 ` Christoph Hellwig
2020-09-18 5:10 ` Christoph Hellwig
2020-09-17 17:32 ` [PATCH 4/4] ARM/dma-mapping: remove the arm specific phys to dma translation helpers Christoph Hellwig
2020-09-17 17:32 ` Christoph Hellwig
2020-09-17 17:32 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200917185340.GC1559@shell.armlinux.org.uk \
--to=linux@armlinux.org.uk \
--cc=aaro.koskinen@iki.fi \
--cc=hch@lst.de \
--cc=iommu@lists.linux-foundation.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=robin.murphy@arm.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.