* [PATCH net-next 0/1] net/smc: fix 2020-09-17
@ 2020-09-17 20:46 Karsten Graul
2020-09-17 20:46 ` [PATCH net-next 1/1] net/smc: fix double kfree in smc_listen_work() Karsten Graul
0 siblings, 1 reply; 3+ messages in thread
From: Karsten Graul @ 2020-09-17 20:46 UTC (permalink / raw)
To: davem; +Cc: netdev, linux-s390, heiko.carstens, raspl, ubraun
Please apply the following patch for smc to netdev's net-next tree.
The patch fixes a problem reported by Dan. Because the fixed patch is
still only in net-next tree I am sending this fix to net-next.
Ursula Braun (1):
net/smc: fix double kfree in smc_listen_work()
net/smc/af_smc.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
--
2.17.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH net-next 1/1] net/smc: fix double kfree in smc_listen_work()
2020-09-17 20:46 [PATCH net-next 0/1] net/smc: fix 2020-09-17 Karsten Graul
@ 2020-09-17 20:46 ` Karsten Graul
2020-09-18 1:04 ` David Miller
0 siblings, 1 reply; 3+ messages in thread
From: Karsten Graul @ 2020-09-17 20:46 UTC (permalink / raw)
To: davem; +Cc: netdev, linux-s390, heiko.carstens, raspl, ubraun
From: Ursula Braun <ubraun@linux.ibm.com>
If smc_listen_rmda_finish() returns with an error, the storage
addressed by 'buf' is freed a second time.
Consolidate freeing under a common label and jump to that label.
Fixes: 6bb14e48ee8d ("net/smc: dynamic allocation of CLC proposal buffer")
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Ursula Braun <ubraun@linux.ibm.com>
Signed-off-by: Karsten Graul <kgraul@linux.ibm.com>
---
net/smc/af_smc.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/net/smc/af_smc.c b/net/smc/af_smc.c
index f5bececfedaa..ed8f97166be9 100644
--- a/net/smc/af_smc.c
+++ b/net/smc/af_smc.c
@@ -1371,7 +1371,6 @@ static void smc_listen_work(struct work_struct *work)
}
/* finish worker */
- kfree(buf);
if (!ism_supported) {
rc = smc_listen_rdma_finish(new_smc, &cclc,
ini.first_contact_local);
@@ -1381,12 +1380,13 @@ static void smc_listen_work(struct work_struct *work)
}
smc_conn_save_peer_info(new_smc, &cclc);
smc_listen_out_connected(new_smc);
- return;
+ goto out_free;
out_unlock:
mutex_unlock(&smc_server_lgr_pending);
out_decl:
smc_listen_decline(new_smc, rc, ini.first_contact_local);
+out_free:
kfree(buf);
}
--
2.17.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH net-next 1/1] net/smc: fix double kfree in smc_listen_work()
2020-09-17 20:46 ` [PATCH net-next 1/1] net/smc: fix double kfree in smc_listen_work() Karsten Graul
@ 2020-09-18 1:04 ` David Miller
0 siblings, 0 replies; 3+ messages in thread
From: David Miller @ 2020-09-18 1:04 UTC (permalink / raw)
To: kgraul; +Cc: netdev, linux-s390, heiko.carstens, raspl, ubraun
From: Karsten Graul <kgraul@linux.ibm.com>
Date: Thu, 17 Sep 2020 22:46:02 +0200
> From: Ursula Braun <ubraun@linux.ibm.com>
>
> If smc_listen_rmda_finish() returns with an error, the storage
> addressed by 'buf' is freed a second time.
> Consolidate freeing under a common label and jump to that label.
>
> Fixes: 6bb14e48ee8d ("net/smc: dynamic allocation of CLC proposal buffer")
> Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
> Signed-off-by: Ursula Braun <ubraun@linux.ibm.com>
> Signed-off-by: Karsten Graul <kgraul@linux.ibm.com>
Applied.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-09-18 1:04 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-09-17 20:46 [PATCH net-next 0/1] net/smc: fix 2020-09-17 Karsten Graul
2020-09-17 20:46 ` [PATCH net-next 1/1] net/smc: fix double kfree in smc_listen_work() Karsten Graul
2020-09-18 1:04 ` David Miller
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.