From: Steven Rostedt <rostedt@goodmis.org>
To: Marco Elver <elver@google.com>
Cc: Eric Dumazet <edumazet@google.com>,
Peter Zijlstra <peterz@infradead.org>,
LKML <linux-kernel@vger.kernel.org>,
David Miller <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>, netdev <netdev@vger.kernel.org>
Subject: Re: [PATCH] random32: Use rcuidle variant for tracepoint
Date: Thu, 17 Sep 2020 21:21:01 -0400 [thread overview]
Message-ID: <20200917212101.53287f29@rorschach.local.home> (raw)
In-Reply-To: <20200821153532.GA3205540@elver.google.com>
[ Late reply, due to Plumbers followed by a much needed vacation and
then drowning in 3 weeks of unread email! ]
On Fri, 21 Aug 2020 17:35:32 +0200
Marco Elver <elver@google.com> wrote:
> So, if the _rcuidle() variant here doesn't break your usecase, there
> should be no harm in using the _rcuidle() variant. This also lifts the
> restriction on where prandom_u32() is usable to what it was before,
> which should be any context.
>
> Steven, Peter: What's the downside to of _rcuidle()?
_rcuidle() only has a slightly more overhead in the tracing path (it's
no different when not tracing). There's not a issue with _rcuidle()
itself. The issue is that we need to have it. We'd like it to be that
rcu *is* watching always except for a very minimal locations when
switching context (kernel to and from user and running to and from
idle), and then we just don't let tracing or anything that needs rcu in
those locations.
But for your patch:
Acked-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
-- Steve
next prev parent reply other threads:[~2020-09-18 1:21 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-21 6:30 [PATCH] random32: Use rcuidle variant for tracepoint Marco Elver
2020-08-21 8:58 ` Marco Elver
2020-08-21 8:59 ` peterz
2020-08-21 15:06 ` Eric Dumazet
2020-08-21 15:35 ` Marco Elver
2020-09-18 1:21 ` Steven Rostedt [this message]
2020-08-21 15:38 ` Steven Rostedt
2020-08-21 15:41 ` Steven Rostedt
2020-08-21 18:38 ` Peter Zijlstra
2020-10-09 7:58 ` [tip: locking/core] kcsan: Use tracing-safe version of prandom tip-bot2 for Marco Elver
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200917212101.53287f29@rorschach.local.home \
--to=rostedt@goodmis.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=elver@google.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.