All of lore.kernel.org
 help / color / mirror / Atom feed
From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Tomi Valkeinen <tomi.valkeinen@ti.com>
Cc: dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org,
	Rob Herring <robh+dt@kernel.org>, Jyri Sarha <jsarha@ti.com>,
	Tero Kristo <t-kristo@ti.com>, Nishanth Menon <nm@ti.com>,
	Rob Herring <robh@kernel.org>
Subject: Re: [PATCH v3 1/2] dt-bindings: display: ti,am65x-dss: add missing properties to dt-schema
Date: Fri, 18 Sep 2020 04:18:23 +0300	[thread overview]
Message-ID: <20200918011823.GD589@pendragon.ideasonboard.com> (raw)
In-Reply-To: <20200916131009.221252-2-tomi.valkeinen@ti.com>

Hi Tomi,

Thank you for the patch.

On Wed, Sep 16, 2020 at 04:10:08PM +0300, Tomi Valkeinen wrote:
> Add assigned-clocks, assigned-clock-parents and dma-coherent optional
> properties.
> 
> Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ti.com>
> Reviewed-by: Rob Herring <robh@kernel.org>
> ---
>  .../devicetree/bindings/display/ti/ti,am65x-dss.yaml  | 11 +++++++++++
>  1 file changed, 11 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/display/ti/ti,am65x-dss.yaml b/Documentation/devicetree/bindings/display/ti/ti,am65x-dss.yaml
> index 4f9185462ed3..4dc30738ee57 100644
> --- a/Documentation/devicetree/bindings/display/ti/ti,am65x-dss.yaml
> +++ b/Documentation/devicetree/bindings/display/ti/ti,am65x-dss.yaml
> @@ -55,6 +55,14 @@ properties:
>        - const: vp1
>        - const: vp2
>  
> +  assigned-clocks:
> +    minItems: 1
> +    maxItems: 3
> +
> +  assigned-clock-parents:
> +    minItems: 1
> +    maxItems: 3
> +

Those properties can occur in any node that has clocks. Do we need to
specify them explicitly in every schema ?

>    interrupts:
>      maxItems: 1
>  
> @@ -62,6 +70,9 @@ properties:
>      maxItems: 1
>      description: phandle to the associated power domain
>  
> +  dma-coherent:
> +    type: boolean
> +
>    ports:
>      type: object
>      description:

-- 
Regards,

Laurent Pinchart

WARNING: multiple messages have this Message-ID (diff)
From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Tomi Valkeinen <tomi.valkeinen@ti.com>
Cc: Nishanth Menon <nm@ti.com>,
	devicetree@vger.kernel.org, Jyri Sarha <jsarha@ti.com>,
	Tero Kristo <t-kristo@ti.com>, Rob Herring <robh+dt@kernel.org>,
	dri-devel@lists.freedesktop.org
Subject: Re: [PATCH v3 1/2] dt-bindings: display: ti,am65x-dss: add missing properties to dt-schema
Date: Fri, 18 Sep 2020 04:18:23 +0300	[thread overview]
Message-ID: <20200918011823.GD589@pendragon.ideasonboard.com> (raw)
In-Reply-To: <20200916131009.221252-2-tomi.valkeinen@ti.com>

Hi Tomi,

Thank you for the patch.

On Wed, Sep 16, 2020 at 04:10:08PM +0300, Tomi Valkeinen wrote:
> Add assigned-clocks, assigned-clock-parents and dma-coherent optional
> properties.
> 
> Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ti.com>
> Reviewed-by: Rob Herring <robh@kernel.org>
> ---
>  .../devicetree/bindings/display/ti/ti,am65x-dss.yaml  | 11 +++++++++++
>  1 file changed, 11 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/display/ti/ti,am65x-dss.yaml b/Documentation/devicetree/bindings/display/ti/ti,am65x-dss.yaml
> index 4f9185462ed3..4dc30738ee57 100644
> --- a/Documentation/devicetree/bindings/display/ti/ti,am65x-dss.yaml
> +++ b/Documentation/devicetree/bindings/display/ti/ti,am65x-dss.yaml
> @@ -55,6 +55,14 @@ properties:
>        - const: vp1
>        - const: vp2
>  
> +  assigned-clocks:
> +    minItems: 1
> +    maxItems: 3
> +
> +  assigned-clock-parents:
> +    minItems: 1
> +    maxItems: 3
> +

Those properties can occur in any node that has clocks. Do we need to
specify them explicitly in every schema ?

>    interrupts:
>      maxItems: 1
>  
> @@ -62,6 +70,9 @@ properties:
>      maxItems: 1
>      description: phandle to the associated power domain
>  
> +  dma-coherent:
> +    type: boolean
> +
>    ports:
>      type: object
>      description:

-- 
Regards,

Laurent Pinchart
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

  reply	other threads:[~2020-09-18  1:18 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-16 13:10 [PATCH v3 0/2] Fixes for am65x and j721e dss dt-schema Tomi Valkeinen
2020-09-16 13:10 ` Tomi Valkeinen
2020-09-16 13:10 ` [PATCH v3 1/2] dt-bindings: display: ti,am65x-dss: add missing properties to dt-schema Tomi Valkeinen
2020-09-16 13:10   ` [PATCH v3 1/2] dt-bindings: display: ti, am65x-dss: " Tomi Valkeinen
2020-09-18  1:18   ` Laurent Pinchart [this message]
2020-09-18  1:18     ` [PATCH v3 1/2] dt-bindings: display: ti,am65x-dss: " Laurent Pinchart
2020-09-18  8:12     ` Tomi Valkeinen
2020-09-18  8:12       ` Tomi Valkeinen
2020-09-16 13:10 ` [PATCH v3 2/2] dt-bindings: display: ti,j721e-dss: " Tomi Valkeinen
2020-09-16 13:10   ` [PATCH v3 2/2] dt-bindings: display: ti, j721e-dss: " Tomi Valkeinen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200918011823.GD589@pendragon.ideasonboard.com \
    --to=laurent.pinchart@ideasonboard.com \
    --cc=devicetree@vger.kernel.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=jsarha@ti.com \
    --cc=nm@ti.com \
    --cc=robh+dt@kernel.org \
    --cc=robh@kernel.org \
    --cc=t-kristo@ti.com \
    --cc=tomi.valkeinen@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.