* [PATCH RESEND] ntfs: drop unneeded semi-colons
@ 2020-09-18 1:20 Randy Dunlap
2020-09-18 13:51 ` Anton Altaparmakov
0 siblings, 1 reply; 2+ messages in thread
From: Randy Dunlap @ 2020-09-18 1:20 UTC (permalink / raw)
To: linux-kernel
Cc: Randy Dunlap, Anton Altaparmakov, linux-ntfs-dev, Andrew Morton
Coccinelle scripts report:
fs/ntfs/lcnalloc.c:902:2-3: Unneeded semicolon
fs/ntfs/super.c:1615:2-3: Unneeded semicolon
fs/ntfs/super.c:1684:2-3: Unneeded semicolon
so remove the extraneous semicolons.
Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Cc: Anton Altaparmakov <anton@tuxera.com>
Cc: linux-ntfs-dev@lists.sourceforge.net
Cc: Andrew Morton <akpm@linux-foundation.org>
---
Adding Andrew to recipients, otherwise this patch is lost/ignored.
fs/ntfs/lcnalloc.c | 2 +-
fs/ntfs/super.c | 4 ++--
2 files changed, 3 insertions(+), 3 deletions(-)
--- linux-next-20200917.orig/fs/ntfs/lcnalloc.c
+++ linux-next-20200917/fs/ntfs/lcnalloc.c
@@ -899,7 +899,7 @@ s64 __ntfs_cluster_free(ntfs_inode *ni,
}
/* We have freed @to_free real clusters. */
real_freed = to_free;
- };
+ }
/* Go to the next run and adjust the number of clusters left to free. */
++rl;
if (count >= 0)
--- linux-next-20200917.orig/fs/ntfs/super.c
+++ linux-next-20200917/fs/ntfs/super.c
@@ -1612,7 +1612,7 @@ read_partial_attrdef_page:
memcpy((u8*)vol->attrdef + (index++ << PAGE_SHIFT),
page_address(page), size);
ntfs_unmap_page(page);
- };
+ }
if (size == PAGE_SIZE) {
size = i_size & ~PAGE_MASK;
if (size)
@@ -1681,7 +1681,7 @@ read_partial_upcase_page:
memcpy((char*)vol->upcase + (index++ << PAGE_SHIFT),
page_address(page), size);
ntfs_unmap_page(page);
- };
+ }
if (size == PAGE_SIZE) {
size = i_size & ~PAGE_MASK;
if (size)
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH RESEND] ntfs: drop unneeded semi-colons
2020-09-18 1:20 [PATCH RESEND] ntfs: drop unneeded semi-colons Randy Dunlap
@ 2020-09-18 13:51 ` Anton Altaparmakov
0 siblings, 0 replies; 2+ messages in thread
From: Anton Altaparmakov @ 2020-09-18 13:51 UTC (permalink / raw)
To: Randy Dunlap; +Cc: LKML, linux-ntfs-dev, Andrew Morton
Hi Randy,
Sorry, I don't know how I missed those originally.
Andrew, please could you add this to your tree for merging with Linus as well?
And again, please feel free to add: Acked-by: Anton Altaparmakov <anton@tuxera.com>
Thanks a lot!
Best regards,
Anton
> On 18 Sep 2020, at 02:20, Randy Dunlap <rdunlap@infradead.org> wrote:
>
> Coccinelle scripts report:
>
> fs/ntfs/lcnalloc.c:902:2-3: Unneeded semicolon
> fs/ntfs/super.c:1615:2-3: Unneeded semicolon
> fs/ntfs/super.c:1684:2-3: Unneeded semicolon
>
> so remove the extraneous semicolons.
>
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Cc: Anton Altaparmakov <anton@tuxera.com>
> Cc: linux-ntfs-dev@lists.sourceforge.net
> Cc: Andrew Morton <akpm@linux-foundation.org>
> ---
> Adding Andrew to recipients, otherwise this patch is lost/ignored.
>
> fs/ntfs/lcnalloc.c | 2 +-
> fs/ntfs/super.c | 4 ++--
> 2 files changed, 3 insertions(+), 3 deletions(-)
>
> --- linux-next-20200917.orig/fs/ntfs/lcnalloc.c
> +++ linux-next-20200917/fs/ntfs/lcnalloc.c
> @@ -899,7 +899,7 @@ s64 __ntfs_cluster_free(ntfs_inode *ni,
> }
> /* We have freed @to_free real clusters. */
> real_freed = to_free;
> - };
> + }
> /* Go to the next run and adjust the number of clusters left to free. */
> ++rl;
> if (count >= 0)
> --- linux-next-20200917.orig/fs/ntfs/super.c
> +++ linux-next-20200917/fs/ntfs/super.c
> @@ -1612,7 +1612,7 @@ read_partial_attrdef_page:
> memcpy((u8*)vol->attrdef + (index++ << PAGE_SHIFT),
> page_address(page), size);
> ntfs_unmap_page(page);
> - };
> + }
> if (size == PAGE_SIZE) {
> size = i_size & ~PAGE_MASK;
> if (size)
> @@ -1681,7 +1681,7 @@ read_partial_upcase_page:
> memcpy((char*)vol->upcase + (index++ << PAGE_SHIFT),
> page_address(page), size);
> ntfs_unmap_page(page);
> - };
> + }
> if (size == PAGE_SIZE) {
> size = i_size & ~PAGE_MASK;
> if (size)
--
Anton Altaparmakov <anton at tuxera.com> (replace at with @)
Lead in File System Development, Tuxera Inc., http://www.tuxera.com/
Linux NTFS maintainer
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-09-18 14:32 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-09-18 1:20 [PATCH RESEND] ntfs: drop unneeded semi-colons Randy Dunlap
2020-09-18 13:51 ` Anton Altaparmakov
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.