[dhowells-fs:rxrpc-rxgk 15/17] net/rxrpc/server_key.c:82:10: warning: ordered comparison of pointer with integer zero

[dhowells-fs:rxrpc-rxgk 15/17] net/rxrpc/server_key.c:82:10: warning: ordered comparison of pointer with integer zero

[kernel test robot]

[-- Attachment #1: Type: text/plain, Size: 2340 bytes --]

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/dhowells/linux-fs.git rxrpc-rxgk
head:   587caf020a85547c72e7e578382360f01bc7690b
commit: 72a954e6016000c505dad7f37a2035fa097fbd11 [15/17] rxrpc: Hand server key parsing off to the security class
config: openrisc-randconfig-r002-20200917 (attached as .config)
compiler: or1k-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        git checkout 72a954e6016000c505dad7f37a2035fa097fbd11
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=openrisc 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

   net/rxrpc/server_key.c: In function 'rxrpc_preparse_s':
>> net/rxrpc/server_key.c:82:10: warning: ordered comparison of pointer with integer zero [-Wextra]
      82 |  if (sec < 0)
         |          ^

# https://git.kernel.org/pub/scm/linux/kernel/git/dhowells/linux-fs.git/commit/?id=72a954e6016000c505dad7f37a2035fa097fbd11
git remote add dhowells-fs https://git.kernel.org/pub/scm/linux/kernel/git/dhowells/linux-fs.git
git fetch --no-tags dhowells-fs rxrpc-rxgk
git checkout 72a954e6016000c505dad7f37a2035fa097fbd11
vim +82 net/rxrpc/server_key.c

    63	
    64	/*
    65	 * Preparse a server secret key.
    66	 */
    67	static int rxrpc_preparse_s(struct key_preparsed_payload *prep)
    68	{
    69		const struct rxrpc_security *sec;
    70		unsigned int service, sec_class;
    71		int n;
    72	
    73		_enter("%zu", prep->datalen);
    74	
    75		if (!prep->orig_description)
    76			return -EINVAL;
    77	
    78		if (sscanf(prep->orig_description, "%u:%u%n", &service, &sec_class, &n) != 2)
    79			return -EINVAL;
    80	
    81		sec = rxrpc_security_lookup(sec_class);
  > 82		if (sec < 0)
    83			return -ENOPKG;
    84	
    85		prep->payload.data[1] = (struct rxrpc_security *)sec;
    86	
    87		return sec->preparse_server_key(prep);
    88	}
    89	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 27795 bytes --]