* [PATCH] checkpatch: avoid error on cover letter files
@ 2020-09-17 17:02 Stefano Garzarella
2020-09-17 17:44 ` Philippe Mathieu-Daudé
0 siblings, 1 reply; 4+ messages in thread
From: Stefano Garzarella @ 2020-09-17 17:02 UTC (permalink / raw)
To: qemu-devel
Cc: Paolo Bonzini, Dr. David Alan Gilbert,
Philippe Mathieu-Daudé,
Stefan Hajnoczi, Michael S. Tsirkin
Running checkpatch on a directory that contains a cover letter reports
this error:
Checking /tmp/tmpbnngauy3/0000-cover-letter.patch...
ERROR: Does not appear to be a unified-diff format patch
total: 1 errors, 0 warnings, 0 lines checked
Let's skip cover letter as it is already done in the Linux kernel.
Signed-off-by: Stefano Garzarella <sgarzare@redhat.com>
---
scripts/checkpatch.pl | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index bd3faa154c..3c898f878a 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -3005,7 +3005,7 @@ sub process {
return 1;
}
- if (!$is_patch) {
+ if (!$is_patch && $filename !~ /cover-letter\.patch$/) {
ERROR("Does not appear to be a unified-diff format patch\n");
}
--
2.26.2
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] checkpatch: avoid error on cover letter files
2020-09-17 17:02 [PATCH] checkpatch: avoid error on cover letter files Stefano Garzarella
@ 2020-09-17 17:44 ` Philippe Mathieu-Daudé
2020-09-18 7:05 ` Stefano Garzarella
0 siblings, 1 reply; 4+ messages in thread
From: Philippe Mathieu-Daudé @ 2020-09-17 17:44 UTC (permalink / raw)
To: Stefano Garzarella, qemu-devel
Cc: Paolo Bonzini, Dr. David Alan Gilbert, Stefan Hajnoczi,
Michael S. Tsirkin
On 9/17/20 7:02 PM, Stefano Garzarella wrote:
> Running checkpatch on a directory that contains a cover letter reports
> this error:
>
> Checking /tmp/tmpbnngauy3/0000-cover-letter.patch...
> ERROR: Does not appear to be a unified-diff format patch
>
> total: 1 errors, 0 warnings, 0 lines checked
>
> Let's skip cover letter as it is already done in the Linux kernel.
.. "commits 06330fc40e3f ("checkpatch: avoid NOT_UNIFIED_DIFF errors
on cover-letter.patch files") and a08ffbef4ab7 ("checkpatch: fix
ignoring cover-letter logic")."
Maybe complete with that ^^^ ?
Regardless:
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
>
> Signed-off-by: Stefano Garzarella <sgarzare@redhat.com>
> ---
> scripts/checkpatch.pl | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
> index bd3faa154c..3c898f878a 100755
> --- a/scripts/checkpatch.pl
> +++ b/scripts/checkpatch.pl
> @@ -3005,7 +3005,7 @@ sub process {
> return 1;
> }
>
> - if (!$is_patch) {
> + if (!$is_patch && $filename !~ /cover-letter\.patch$/) {
> ERROR("Does not appear to be a unified-diff format patch\n");
> }
>
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] checkpatch: avoid error on cover letter files
2020-09-17 17:44 ` Philippe Mathieu-Daudé
@ 2020-09-18 7:05 ` Stefano Garzarella
2020-09-18 8:06 ` Paolo Bonzini
0 siblings, 1 reply; 4+ messages in thread
From: Stefano Garzarella @ 2020-09-18 7:05 UTC (permalink / raw)
To: Philippe Mathieu-Daudé
Cc: Paolo Bonzini, Michael S. Tsirkin, qemu-devel, Stefan Hajnoczi,
Dr. David Alan Gilbert
On Thu, Sep 17, 2020 at 07:44:21PM +0200, Philippe Mathieu-Daudé wrote:
> On 9/17/20 7:02 PM, Stefano Garzarella wrote:
> > Running checkpatch on a directory that contains a cover letter reports
> > this error:
> >
> > Checking /tmp/tmpbnngauy3/0000-cover-letter.patch...
> > ERROR: Does not appear to be a unified-diff format patch
> >
> > total: 1 errors, 0 warnings, 0 lines checked
> >
> > Let's skip cover letter as it is already done in the Linux kernel.
>
> .. "commits 06330fc40e3f ("checkpatch: avoid NOT_UNIFIED_DIFF errors
> on cover-letter.patch files") and a08ffbef4ab7 ("checkpatch: fix
> ignoring cover-letter logic")."
>
> Maybe complete with that ^^^ ?
Yes, it's better ;-)
Should I send a v2 or can be updated when queueing?
>
> Regardless:
> Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Thanks!
Stefano
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] checkpatch: avoid error on cover letter files
2020-09-18 7:05 ` Stefano Garzarella
@ 2020-09-18 8:06 ` Paolo Bonzini
0 siblings, 0 replies; 4+ messages in thread
From: Paolo Bonzini @ 2020-09-18 8:06 UTC (permalink / raw)
To: Stefano Garzarella, Philippe Mathieu-Daudé
Cc: Michael S. Tsirkin, qemu-devel, Stefan Hajnoczi, Dr. David Alan Gilbert
On 18/09/20 09:05, Stefano Garzarella wrote:
> On Thu, Sep 17, 2020 at 07:44:21PM +0200, Philippe Mathieu-Daudé wrote:
>> On 9/17/20 7:02 PM, Stefano Garzarella wrote:
>>> Running checkpatch on a directory that contains a cover letter reports
>>> this error:
>>>
>>> Checking /tmp/tmpbnngauy3/0000-cover-letter.patch...
>>> ERROR: Does not appear to be a unified-diff format patch
>>>
>>> total: 1 errors, 0 warnings, 0 lines checked
>>>
>>> Let's skip cover letter as it is already done in the Linux kernel.
>>
>> .. "commits 06330fc40e3f ("checkpatch: avoid NOT_UNIFIED_DIFF errors
>> on cover-letter.patch files") and a08ffbef4ab7 ("checkpatch: fix
>> ignoring cover-letter logic")."
>>
>> Maybe complete with that ^^^ ?
>
> Yes, it's better ;-)
>
> Should I send a v2 or can be updated when queueing?
>
>>
>> Regardless:
>> Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
>
> Thanks!
>
> Stefano
>
Queued with the fixed message, thanks.
Paolo
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-09-18 8:09 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-09-17 17:02 [PATCH] checkpatch: avoid error on cover letter files Stefano Garzarella
2020-09-17 17:44 ` Philippe Mathieu-Daudé
2020-09-18 7:05 ` Stefano Garzarella
2020-09-18 8:06 ` Paolo Bonzini
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.