* [PATCH -next] rapidio: Remove set but not used variable 'rc'
@ 2020-09-18 7:18 Zheng Yongjun
2020-09-18 7:47 ` Greg KH
0 siblings, 1 reply; 4+ messages in thread
From: Zheng Yongjun @ 2020-09-18 7:18 UTC (permalink / raw)
To: davem, UNGLinuxDriver, kuba, netdev, linux-usb, linux-kernel
Cc: Zheng Yongjun
Fixes gcc '-Wunused-but-set-variable' warning:
drivers/rapidio/rio_cm.c: In function rio_txcq_handler:
drivers/rapidio/rio_cm.c:673:7: warning: variable ‘rc’ set but not used [-Wunused-but-set-variable]
rc is never used, so remove it.
Signed-off-by: Zheng Yongjun <zhengyongjun3@huawei.com>
---
drivers/rapidio/rio_cm.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/rapidio/rio_cm.c b/drivers/rapidio/rio_cm.c
index 50ec53d67a4c..545693bd86a3 100644
--- a/drivers/rapidio/rio_cm.c
+++ b/drivers/rapidio/rio_cm.c
@@ -670,12 +670,11 @@ static void rio_txcq_handler(struct cm_dev *cm, int slot)
*/
if (!list_empty(&cm->tx_reqs) && (cm->tx_cnt < RIOCM_TX_RING_SIZE)) {
struct tx_req *req, *_req;
- int rc;
list_for_each_entry_safe(req, _req, &cm->tx_reqs, node) {
list_del(&req->node);
cm->tx_buf[cm->tx_slot] = req->buffer;
- rc = rio_add_outb_message(cm->mport, req->rdev, cmbox,
+ rio_add_outb_message(cm->mport, req->rdev, cmbox,
req->buffer, req->len);
kfree(req->buffer);
kfree(req);
--
2.17.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH -next] rapidio: Remove set but not used variable 'rc'
2020-09-18 7:18 [PATCH -next] rapidio: Remove set but not used variable 'rc' Zheng Yongjun
@ 2020-09-18 7:47 ` Greg KH
0 siblings, 0 replies; 4+ messages in thread
From: Greg KH @ 2020-09-18 7:47 UTC (permalink / raw)
To: Zheng Yongjun
Cc: davem, UNGLinuxDriver, kuba, netdev, linux-usb, linux-kernel
On Fri, Sep 18, 2020 at 03:18:44PM +0800, Zheng Yongjun wrote:
> Fixes gcc '-Wunused-but-set-variable' warning:
>
> drivers/rapidio/rio_cm.c: In function rio_txcq_handler:
> drivers/rapidio/rio_cm.c:673:7: warning: variable ‘rc’ set but not used [-Wunused-but-set-variable]
>
> rc is never used, so remove it.
>
> Signed-off-by: Zheng Yongjun <zhengyongjun3@huawei.com>
> ---
> drivers/rapidio/rio_cm.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/rapidio/rio_cm.c b/drivers/rapidio/rio_cm.c
> index 50ec53d67a4c..545693bd86a3 100644
> --- a/drivers/rapidio/rio_cm.c
> +++ b/drivers/rapidio/rio_cm.c
> @@ -670,12 +670,11 @@ static void rio_txcq_handler(struct cm_dev *cm, int slot)
> */
> if (!list_empty(&cm->tx_reqs) && (cm->tx_cnt < RIOCM_TX_RING_SIZE)) {
> struct tx_req *req, *_req;
> - int rc;
>
> list_for_each_entry_safe(req, _req, &cm->tx_reqs, node) {
> list_del(&req->node);
> cm->tx_buf[cm->tx_slot] = req->buffer;
> - rc = rio_add_outb_message(cm->mport, req->rdev, cmbox,
> + rio_add_outb_message(cm->mport, req->rdev, cmbox,
> req->buffer, req->len);
That's not the only place in this file where this call is made, and the
return value is ignored.
It should be fixed up to properly check that return value, not ignore
it. Can you do that instead for the places this is called?
thanks,
greg k-h
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH -next] rapidio: Remove set but not used variable 'rc'
@ 2020-09-18 7:17 Zheng Yongjun
0 siblings, 0 replies; 4+ messages in thread
From: Zheng Yongjun @ 2020-09-18 7:17 UTC (permalink / raw)
To: jejb, martin.petersen, linux-scsi, linux-kernel; +Cc: Zheng Yongjun
Fixes gcc '-Wunused-but-set-variable' warning:
drivers/rapidio/rio_cm.c: In function rio_txcq_handler:
drivers/rapidio/rio_cm.c:673:7: warning: variable ‘rc’ set but not used [-Wunused-but-set-variable]
rc is never used, so remove it.
Signed-off-by: Zheng Yongjun <zhengyongjun3@huawei.com>
---
drivers/rapidio/rio_cm.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/rapidio/rio_cm.c b/drivers/rapidio/rio_cm.c
index 50ec53d67a4c..545693bd86a3 100644
--- a/drivers/rapidio/rio_cm.c
+++ b/drivers/rapidio/rio_cm.c
@@ -670,12 +670,11 @@ static void rio_txcq_handler(struct cm_dev *cm, int slot)
*/
if (!list_empty(&cm->tx_reqs) && (cm->tx_cnt < RIOCM_TX_RING_SIZE)) {
struct tx_req *req, *_req;
- int rc;
list_for_each_entry_safe(req, _req, &cm->tx_reqs, node) {
list_del(&req->node);
cm->tx_buf[cm->tx_slot] = req->buffer;
- rc = rio_add_outb_message(cm->mport, req->rdev, cmbox,
+ rio_add_outb_message(cm->mport, req->rdev, cmbox,
req->buffer, req->len);
kfree(req->buffer);
kfree(req);
--
2.17.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH -next] rapidio: Remove set but not used variable 'rc'
@ 2020-09-18 7:16 Zheng Yongjun
0 siblings, 0 replies; 4+ messages in thread
From: Zheng Yongjun @ 2020-09-18 7:16 UTC (permalink / raw)
To: mporter, alex.bou9, linux-kernel; +Cc: Zheng Yongjun
Fixes gcc '-Wunused-but-set-variable' warning:
drivers/rapidio/rio_cm.c: In function rio_txcq_handler:
drivers/rapidio/rio_cm.c:673:7: warning: variable ‘rc’ set but not used [-Wunused-but-set-variable]
rc is never used, so remove it.
Signed-off-by: Zheng Yongjun <zhengyongjun3@huawei.com>
---
drivers/rapidio/rio_cm.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/rapidio/rio_cm.c b/drivers/rapidio/rio_cm.c
index 50ec53d67a4c..545693bd86a3 100644
--- a/drivers/rapidio/rio_cm.c
+++ b/drivers/rapidio/rio_cm.c
@@ -670,12 +670,11 @@ static void rio_txcq_handler(struct cm_dev *cm, int slot)
*/
if (!list_empty(&cm->tx_reqs) && (cm->tx_cnt < RIOCM_TX_RING_SIZE)) {
struct tx_req *req, *_req;
- int rc;
list_for_each_entry_safe(req, _req, &cm->tx_reqs, node) {
list_del(&req->node);
cm->tx_buf[cm->tx_slot] = req->buffer;
- rc = rio_add_outb_message(cm->mport, req->rdev, cmbox,
+ rio_add_outb_message(cm->mport, req->rdev, cmbox,
req->buffer, req->len);
kfree(req->buffer);
kfree(req);
--
2.17.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-09-18 7:47 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-09-18 7:18 [PATCH -next] rapidio: Remove set but not used variable 'rc' Zheng Yongjun
2020-09-18 7:47 ` Greg KH
-- strict thread matches above, loose matches on Subject: below --
2020-09-18 7:17 Zheng Yongjun
2020-09-18 7:16 Zheng Yongjun
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.