[jpirko-mlxsw:jiri_devel_xmrouter 35/41] drivers/net/ethernet/mellanox/mlxsw/spectrum_router_xm.c:278:55: warning: Either the condition '!fib_entry' is redundant or there is possible null pointer dereference: fib_entry.

[jpirko-mlxsw:jiri_devel_xmrouter 35/41] drivers/net/ethernet/mellanox/mlxsw/spectrum_router_xm.c:278:55: warning: Either the condition '!fib_entry' is redundant or there is possible null pointer dereference: fib_entry.

[kernel test robot]

[-- Attachment #1: Type: text/plain, Size: 4465 bytes --]

CC: kbuild-all(a)lists.01.org
TO: Jiri Pirko <jiri@nvidia.com>

tree:   https://github.com/jpirko/linux_mlxsw jiri_devel_xmrouter
head:   a95f3d521b1e9bbc77c40307be176fd19ea723dd
commit: e474e0427362f198d903b58664e4fabb533cd5e6 [35/41] mlxsw: spectrum_router_xm: Implement L-value tracking for M-index
:::::: branch date: 21 hours ago
:::::: commit date: 2 days ago
compiler: sparc64-linux-gcc (GCC) 9.3.0

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>


cppcheck warnings: (new ones prefixed by >>)

>> drivers/net/ethernet/mellanox/mlxsw/spectrum_router_xm.c:278:55: warning: Either the condition '!fib_entry' is redundant or there is possible null pointer dereference: fib_entry. [nullPointerRedundantCheck]
    struct mlxsw_sp_router_xm_ltable_node *ltable_node = fib_entry->ltable_node;
                                                         ^
   drivers/net/ethernet/mellanox/mlxsw/spectrum_router_xm.c:282:6: note: Assuming that condition '!fib_entry' is not redundant
    if (!fib_entry || !fib_entry->ltable_node)
        ^
   drivers/net/ethernet/mellanox/mlxsw/spectrum_router_xm.c:278:55: note: Null pointer dereference
    struct mlxsw_sp_router_xm_ltable_node *ltable_node = fib_entry->ltable_node;
                                                         ^
   drivers/net/ethernet/mellanox/mlxsw/spectrum_router_xm.c:280:14: warning: Either the condition '!fib_entry' is redundant or there is possible null pointer dereference: fib_entry. [nullPointerRedundantCheck]
    u8 lvalue = fib_entry->lvalue;
                ^
   drivers/net/ethernet/mellanox/mlxsw/spectrum_router_xm.c:282:6: note: Assuming that condition '!fib_entry' is not redundant
    if (!fib_entry || !fib_entry->ltable_node)
        ^
   drivers/net/ethernet/mellanox/mlxsw/spectrum_router_xm.c:280:14: note: Null pointer dereference
    u8 lvalue = fib_entry->lvalue;
                ^

# https://github.com/jpirko/linux_mlxsw/commit/e474e0427362f198d903b58664e4fabb533cd5e6
git remote add jpirko-mlxsw https://github.com/jpirko/linux_mlxsw
git fetch --no-tags jpirko-mlxsw jiri_devel_xmrouter
git checkout e474e0427362f198d903b58664e4fabb533cd5e6
vim +278 drivers/net/ethernet/mellanox/mlxsw/spectrum_router_xm.c

e474e0427362f19 Jiri Pirko 2020-07-17  274  
e474e0427362f19 Jiri Pirko 2020-07-17  275  static void mlxsw_sp_router_xm_ml_entry_del(struct mlxsw_sp *mlxsw_sp,
e474e0427362f19 Jiri Pirko 2020-07-17  276  					    struct mlxsw_sp_router_xm_fib_entry *fib_entry)
e474e0427362f19 Jiri Pirko 2020-07-17  277  {
e474e0427362f19 Jiri Pirko 2020-07-17 @278  	struct mlxsw_sp_router_xm_ltable_node *ltable_node = fib_entry->ltable_node;
e474e0427362f19 Jiri Pirko 2020-07-17  279  	struct mlxsw_sp_router_xm *router_xm = mlxsw_sp->router->xm;
e474e0427362f19 Jiri Pirko 2020-07-17  280  	u8 lvalue = fib_entry->lvalue;
e474e0427362f19 Jiri Pirko 2020-07-17  281  
e474e0427362f19 Jiri Pirko 2020-07-17  282  	if (!fib_entry || !fib_entry->ltable_node)
e474e0427362f19 Jiri Pirko 2020-07-17  283  		return;
e474e0427362f19 Jiri Pirko 2020-07-17  284  
e474e0427362f19 Jiri Pirko 2020-07-17  285  	ltable_node->lvalue_ref[lvalue]--;
e474e0427362f19 Jiri Pirko 2020-07-17  286  	if (lvalue == ltable_node->current_lvalue && lvalue &&
e474e0427362f19 Jiri Pirko 2020-07-17  287  	    !ltable_node->lvalue_ref[lvalue]) {
e474e0427362f19 Jiri Pirko 2020-07-17  288  		u8 new_lvalue = lvalue - 1;
e474e0427362f19 Jiri Pirko 2020-07-17  289  
e474e0427362f19 Jiri Pirko 2020-07-17  290  		/* Find the biggest L-value left out there. */
e474e0427362f19 Jiri Pirko 2020-07-17  291  		while (new_lvalue > 0 && !ltable_node->lvalue_ref[lvalue])
e474e0427362f19 Jiri Pirko 2020-07-17  292  			new_lvalue--;
e474e0427362f19 Jiri Pirko 2020-07-17  293  
e474e0427362f19 Jiri Pirko 2020-07-17  294  		ltable_node->current_lvalue = new_lvalue;
e474e0427362f19 Jiri Pirko 2020-07-17  295  		mlxsw_sp_router_xm_ltable_lvalue_set(mlxsw_sp, ltable_node);
e474e0427362f19 Jiri Pirko 2020-07-17  296  	}
e474e0427362f19 Jiri Pirko 2020-07-17  297  
e474e0427362f19 Jiri Pirko 2020-07-17  298  	mlxsw_sp_router_xm_ltable_node_put(router_xm, ltable_node);
e474e0427362f19 Jiri Pirko 2020-07-17  299  }
e474e0427362f19 Jiri Pirko 2020-07-17  300  

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org