* [PATCH][next] drm/panel: fix null pointer dereference on pointer mode
@ 2020-09-18 15:51 ` Colin King
0 siblings, 0 replies; 9+ messages in thread
From: Colin King @ 2020-09-18 15:51 UTC (permalink / raw)
To: Guido Günther, Purism Kernel Team, Thierry Reding,
Sam Ravnborg, David Airlie, Daniel Vetter, dri-devel,
linux-kernel
Cc: kernel-janitors
From: Colin Ian King <colin.king@canonical.com>
Currently a null pointer check on pointer mode is passing mode to
function drm_mode_vrefresh and this causes a null pointer dereference
on mode. Fix this by not calling drm_mode_vrefresh since the call
is only required for error reporting.
Addresses-Coverity: ("Dereference after null check")
Fixes: 72967d5616d3 ("drm/panel: Add panel driver for the Mantix MLAF057WE51-X DSI panel")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
drivers/gpu/drm/panel/panel-mantix-mlaf057we51.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/panel/panel-mantix-mlaf057we51.c b/drivers/gpu/drm/panel/panel-mantix-mlaf057we51.c
index 3482e28e30fc..be4761a643f9 100644
--- a/drivers/gpu/drm/panel/panel-mantix-mlaf057we51.c
+++ b/drivers/gpu/drm/panel/panel-mantix-mlaf057we51.c
@@ -202,9 +202,8 @@ static int mantix_get_modes(struct drm_panel *panel,
mode = drm_mode_duplicate(connector->dev, &default_mode);
if (!mode) {
- dev_err(ctx->dev, "Failed to add mode %ux%u@%u\n",
- default_mode.hdisplay, default_mode.vdisplay,
- drm_mode_vrefresh(mode));
+ dev_err(ctx->dev, "Failed to add mode %ux%u\n",
+ default_mode.hdisplay, default_mode.vdisplay);
return -ENOMEM;
}
--
2.27.0
^ permalink raw reply related [flat|nested] 9+ messages in thread
* [PATCH][next] drm/panel: fix null pointer dereference on pointer mode
@ 2020-09-18 15:51 ` Colin King
0 siblings, 0 replies; 9+ messages in thread
From: Colin King @ 2020-09-18 15:51 UTC (permalink / raw)
To: Guido Günther, Purism Kernel Team, Thierry Reding,
Sam Ravnborg, David Airlie, Daniel Vetter, dri-devel,
linux-kernel
Cc: kernel-janitors
From: Colin Ian King <colin.king@canonical.com>
Currently a null pointer check on pointer mode is passing mode to
function drm_mode_vrefresh and this causes a null pointer dereference
on mode. Fix this by not calling drm_mode_vrefresh since the call
is only required for error reporting.
Addresses-Coverity: ("Dereference after null check")
Fixes: 72967d5616d3 ("drm/panel: Add panel driver for the Mantix MLAF057WE51-X DSI panel")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
drivers/gpu/drm/panel/panel-mantix-mlaf057we51.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/panel/panel-mantix-mlaf057we51.c b/drivers/gpu/drm/panel/panel-mantix-mlaf057we51.c
index 3482e28e30fc..be4761a643f9 100644
--- a/drivers/gpu/drm/panel/panel-mantix-mlaf057we51.c
+++ b/drivers/gpu/drm/panel/panel-mantix-mlaf057we51.c
@@ -202,9 +202,8 @@ static int mantix_get_modes(struct drm_panel *panel,
mode = drm_mode_duplicate(connector->dev, &default_mode);
if (!mode) {
- dev_err(ctx->dev, "Failed to add mode %ux%u@%u\n",
- default_mode.hdisplay, default_mode.vdisplay,
- drm_mode_vrefresh(mode));
+ dev_err(ctx->dev, "Failed to add mode %ux%u\n",
+ default_mode.hdisplay, default_mode.vdisplay);
return -ENOMEM;
}
--
2.27.0
^ permalink raw reply related [flat|nested] 9+ messages in thread
* [PATCH][next] drm/panel: fix null pointer dereference on pointer mode
@ 2020-09-18 15:51 ` Colin King
0 siblings, 0 replies; 9+ messages in thread
From: Colin King @ 2020-09-18 15:51 UTC (permalink / raw)
To: Guido Günther, Purism Kernel Team, Thierry Reding,
Sam Ravnborg, David Airlie, Daniel Vetter, dri-devel,
linux-kernel
Cc: kernel-janitors
From: Colin Ian King <colin.king@canonical.com>
Currently a null pointer check on pointer mode is passing mode to
function drm_mode_vrefresh and this causes a null pointer dereference
on mode. Fix this by not calling drm_mode_vrefresh since the call
is only required for error reporting.
Addresses-Coverity: ("Dereference after null check")
Fixes: 72967d5616d3 ("drm/panel: Add panel driver for the Mantix MLAF057WE51-X DSI panel")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
drivers/gpu/drm/panel/panel-mantix-mlaf057we51.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/panel/panel-mantix-mlaf057we51.c b/drivers/gpu/drm/panel/panel-mantix-mlaf057we51.c
index 3482e28e30fc..be4761a643f9 100644
--- a/drivers/gpu/drm/panel/panel-mantix-mlaf057we51.c
+++ b/drivers/gpu/drm/panel/panel-mantix-mlaf057we51.c
@@ -202,9 +202,8 @@ static int mantix_get_modes(struct drm_panel *panel,
mode = drm_mode_duplicate(connector->dev, &default_mode);
if (!mode) {
- dev_err(ctx->dev, "Failed to add mode %ux%u@%u\n",
- default_mode.hdisplay, default_mode.vdisplay,
- drm_mode_vrefresh(mode));
+ dev_err(ctx->dev, "Failed to add mode %ux%u\n",
+ default_mode.hdisplay, default_mode.vdisplay);
return -ENOMEM;
}
--
2.27.0
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [PATCH][next] drm/panel: fix null pointer dereference on pointer mode
2020-09-18 15:51 ` Colin King
(?)
@ 2020-09-18 16:22 ` Guido Günther
-1 siblings, 0 replies; 9+ messages in thread
From: Guido Günther @ 2020-09-18 16:22 UTC (permalink / raw)
To: Colin King
Cc: Purism Kernel Team, Thierry Reding, Sam Ravnborg, David Airlie,
Daniel Vetter, dri-devel, linux-kernel, kernel-janitors
Hi,
On Fri, Sep 18, 2020 at 04:51:36PM +0100, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Currently a null pointer check on pointer mode is passing mode to
> function drm_mode_vrefresh and this causes a null pointer dereference
> on mode. Fix this by not calling drm_mode_vrefresh since the call
> is only required for error reporting.
>
> Addresses-Coverity: ("Dereference after null check")
> Fixes: 72967d5616d3 ("drm/panel: Add panel driver for the Mantix MLAF057WE51-X DSI panel")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
> drivers/gpu/drm/panel/panel-mantix-mlaf057we51.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/panel/panel-mantix-mlaf057we51.c b/drivers/gpu/drm/panel/panel-mantix-mlaf057we51.c
> index 3482e28e30fc..be4761a643f9 100644
> --- a/drivers/gpu/drm/panel/panel-mantix-mlaf057we51.c
> +++ b/drivers/gpu/drm/panel/panel-mantix-mlaf057we51.c
> @@ -202,9 +202,8 @@ static int mantix_get_modes(struct drm_panel *panel,
>
> mode = drm_mode_duplicate(connector->dev, &default_mode);
> if (!mode) {
> - dev_err(ctx->dev, "Failed to add mode %ux%u@%u\n",
> - default_mode.hdisplay, default_mode.vdisplay,
> - drm_mode_vrefresh(mode));
> + dev_err(ctx->dev, "Failed to add mode %ux%u\n",
> + default_mode.hdisplay, default_mode.vdisplay);
> return -ENOMEM;
> }
drm_mode_vrefresh(&default_mode) gives some more clue what's going on -
I have had a fix queued up in my tree already but if you send a v2
that's fine.
Thanks!
-- Guido
>
> --
> 2.27.0
>
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH][next] drm/panel: fix null pointer dereference on pointer mode
@ 2020-09-18 16:22 ` Guido Günther
0 siblings, 0 replies; 9+ messages in thread
From: Guido Günther @ 2020-09-18 16:22 UTC (permalink / raw)
To: Colin King
Cc: Purism Kernel Team, David Airlie, kernel-janitors, linux-kernel,
dri-devel, Thierry Reding, Sam Ravnborg
Hi,
On Fri, Sep 18, 2020 at 04:51:36PM +0100, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Currently a null pointer check on pointer mode is passing mode to
> function drm_mode_vrefresh and this causes a null pointer dereference
> on mode. Fix this by not calling drm_mode_vrefresh since the call
> is only required for error reporting.
>
> Addresses-Coverity: ("Dereference after null check")
> Fixes: 72967d5616d3 ("drm/panel: Add panel driver for the Mantix MLAF057WE51-X DSI panel")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
> drivers/gpu/drm/panel/panel-mantix-mlaf057we51.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/panel/panel-mantix-mlaf057we51.c b/drivers/gpu/drm/panel/panel-mantix-mlaf057we51.c
> index 3482e28e30fc..be4761a643f9 100644
> --- a/drivers/gpu/drm/panel/panel-mantix-mlaf057we51.c
> +++ b/drivers/gpu/drm/panel/panel-mantix-mlaf057we51.c
> @@ -202,9 +202,8 @@ static int mantix_get_modes(struct drm_panel *panel,
>
> mode = drm_mode_duplicate(connector->dev, &default_mode);
> if (!mode) {
> - dev_err(ctx->dev, "Failed to add mode %ux%u@%u\n",
> - default_mode.hdisplay, default_mode.vdisplay,
> - drm_mode_vrefresh(mode));
> + dev_err(ctx->dev, "Failed to add mode %ux%u\n",
> + default_mode.hdisplay, default_mode.vdisplay);
> return -ENOMEM;
> }
drm_mode_vrefresh(&default_mode) gives some more clue what's going on -
I have had a fix queued up in my tree already but if you send a v2
that's fine.
Thanks!
-- Guido
>
> --
> 2.27.0
>
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH][next] drm/panel: fix null pointer dereference on pointer mode
@ 2020-09-18 16:22 ` Guido Günther
0 siblings, 0 replies; 9+ messages in thread
From: Guido Günther @ 2020-09-18 16:22 UTC (permalink / raw)
To: Colin King
Cc: Purism Kernel Team, David Airlie, kernel-janitors, linux-kernel,
dri-devel, Thierry Reding, Sam Ravnborg
Hi,
On Fri, Sep 18, 2020 at 04:51:36PM +0100, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Currently a null pointer check on pointer mode is passing mode to
> function drm_mode_vrefresh and this causes a null pointer dereference
> on mode. Fix this by not calling drm_mode_vrefresh since the call
> is only required for error reporting.
>
> Addresses-Coverity: ("Dereference after null check")
> Fixes: 72967d5616d3 ("drm/panel: Add panel driver for the Mantix MLAF057WE51-X DSI panel")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
> drivers/gpu/drm/panel/panel-mantix-mlaf057we51.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/panel/panel-mantix-mlaf057we51.c b/drivers/gpu/drm/panel/panel-mantix-mlaf057we51.c
> index 3482e28e30fc..be4761a643f9 100644
> --- a/drivers/gpu/drm/panel/panel-mantix-mlaf057we51.c
> +++ b/drivers/gpu/drm/panel/panel-mantix-mlaf057we51.c
> @@ -202,9 +202,8 @@ static int mantix_get_modes(struct drm_panel *panel,
>
> mode = drm_mode_duplicate(connector->dev, &default_mode);
> if (!mode) {
> - dev_err(ctx->dev, "Failed to add mode %ux%u@%u\n",
> - default_mode.hdisplay, default_mode.vdisplay,
> - drm_mode_vrefresh(mode));
> + dev_err(ctx->dev, "Failed to add mode %ux%u\n",
> + default_mode.hdisplay, default_mode.vdisplay);
> return -ENOMEM;
> }
drm_mode_vrefresh(&default_mode) gives some more clue what's going on -
I have had a fix queued up in my tree already but if you send a v2
that's fine.
Thanks!
-- Guido
>
> --
> 2.27.0
>
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH][next] drm/panel: fix null pointer dereference on pointer mode
2020-09-18 16:22 ` Guido Günther
(?)
@ 2020-09-18 16:39 ` Colin Ian King
-1 siblings, 0 replies; 9+ messages in thread
From: Colin Ian King @ 2020-09-18 16:39 UTC (permalink / raw)
To: Guido Günther
Cc: Purism Kernel Team, Thierry Reding, Sam Ravnborg, David Airlie,
Daniel Vetter, dri-devel, linux-kernel, kernel-janitors
On 18/09/2020 17:22, Guido Günther wrote:
> Hi,
> On Fri, Sep 18, 2020 at 04:51:36PM +0100, Colin King wrote:
>> From: Colin Ian King <colin.king@canonical.com>
>>
>> Currently a null pointer check on pointer mode is passing mode to
>> function drm_mode_vrefresh and this causes a null pointer dereference
>> on mode. Fix this by not calling drm_mode_vrefresh since the call
>> is only required for error reporting.
>>
>> Addresses-Coverity: ("Dereference after null check")
>> Fixes: 72967d5616d3 ("drm/panel: Add panel driver for the Mantix MLAF057WE51-X DSI panel")
>> Signed-off-by: Colin Ian King <colin.king@canonical.com>
>> ---
>> drivers/gpu/drm/panel/panel-mantix-mlaf057we51.c | 5 ++---
>> 1 file changed, 2 insertions(+), 3 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/panel/panel-mantix-mlaf057we51.c b/drivers/gpu/drm/panel/panel-mantix-mlaf057we51.c
>> index 3482e28e30fc..be4761a643f9 100644
>> --- a/drivers/gpu/drm/panel/panel-mantix-mlaf057we51.c
>> +++ b/drivers/gpu/drm/panel/panel-mantix-mlaf057we51.c
>> @@ -202,9 +202,8 @@ static int mantix_get_modes(struct drm_panel *panel,
>>
>> mode = drm_mode_duplicate(connector->dev, &default_mode);
>> if (!mode) {
>> - dev_err(ctx->dev, "Failed to add mode %ux%u@%u\n",
>> - default_mode.hdisplay, default_mode.vdisplay,
>> - drm_mode_vrefresh(mode));
>> + dev_err(ctx->dev, "Failed to add mode %ux%u\n",
>> + default_mode.hdisplay, default_mode.vdisplay);
>> return -ENOMEM;
>> }
>
> drm_mode_vrefresh(&default_mode) gives some more clue what's going on -
> I have had a fix queued up in my tree already but if you send a v2
> that's fine.
I'll defer to your queued up fix.
>
> Thanks!
> -- Guido
>
>>
>> --
>> 2.27.0
>>
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH][next] drm/panel: fix null pointer dereference on pointer mode
@ 2020-09-18 16:39 ` Colin Ian King
0 siblings, 0 replies; 9+ messages in thread
From: Colin Ian King @ 2020-09-18 16:39 UTC (permalink / raw)
To: Guido Günther
Cc: Purism Kernel Team, David Airlie, kernel-janitors, linux-kernel,
dri-devel, Thierry Reding, Sam Ravnborg
On 18/09/2020 17:22, Guido Günther wrote:
> Hi,
> On Fri, Sep 18, 2020 at 04:51:36PM +0100, Colin King wrote:
>> From: Colin Ian King <colin.king@canonical.com>
>>
>> Currently a null pointer check on pointer mode is passing mode to
>> function drm_mode_vrefresh and this causes a null pointer dereference
>> on mode. Fix this by not calling drm_mode_vrefresh since the call
>> is only required for error reporting.
>>
>> Addresses-Coverity: ("Dereference after null check")
>> Fixes: 72967d5616d3 ("drm/panel: Add panel driver for the Mantix MLAF057WE51-X DSI panel")
>> Signed-off-by: Colin Ian King <colin.king@canonical.com>
>> ---
>> drivers/gpu/drm/panel/panel-mantix-mlaf057we51.c | 5 ++---
>> 1 file changed, 2 insertions(+), 3 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/panel/panel-mantix-mlaf057we51.c b/drivers/gpu/drm/panel/panel-mantix-mlaf057we51.c
>> index 3482e28e30fc..be4761a643f9 100644
>> --- a/drivers/gpu/drm/panel/panel-mantix-mlaf057we51.c
>> +++ b/drivers/gpu/drm/panel/panel-mantix-mlaf057we51.c
>> @@ -202,9 +202,8 @@ static int mantix_get_modes(struct drm_panel *panel,
>>
>> mode = drm_mode_duplicate(connector->dev, &default_mode);
>> if (!mode) {
>> - dev_err(ctx->dev, "Failed to add mode %ux%u@%u\n",
>> - default_mode.hdisplay, default_mode.vdisplay,
>> - drm_mode_vrefresh(mode));
>> + dev_err(ctx->dev, "Failed to add mode %ux%u\n",
>> + default_mode.hdisplay, default_mode.vdisplay);
>> return -ENOMEM;
>> }
>
> drm_mode_vrefresh(&default_mode) gives some more clue what's going on -
> I have had a fix queued up in my tree already but if you send a v2
> that's fine.
I'll defer to your queued up fix.
>
> Thanks!
> -- Guido
>
>>
>> --
>> 2.27.0
>>
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH][next] drm/panel: fix null pointer dereference on pointer mode
@ 2020-09-18 16:39 ` Colin Ian King
0 siblings, 0 replies; 9+ messages in thread
From: Colin Ian King @ 2020-09-18 16:39 UTC (permalink / raw)
To: Guido Günther
Cc: Purism Kernel Team, David Airlie, kernel-janitors, linux-kernel,
dri-devel, Thierry Reding, Sam Ravnborg
On 18/09/2020 17:22, Guido Günther wrote:
> Hi,
> On Fri, Sep 18, 2020 at 04:51:36PM +0100, Colin King wrote:
>> From: Colin Ian King <colin.king@canonical.com>
>>
>> Currently a null pointer check on pointer mode is passing mode to
>> function drm_mode_vrefresh and this causes a null pointer dereference
>> on mode. Fix this by not calling drm_mode_vrefresh since the call
>> is only required for error reporting.
>>
>> Addresses-Coverity: ("Dereference after null check")
>> Fixes: 72967d5616d3 ("drm/panel: Add panel driver for the Mantix MLAF057WE51-X DSI panel")
>> Signed-off-by: Colin Ian King <colin.king@canonical.com>
>> ---
>> drivers/gpu/drm/panel/panel-mantix-mlaf057we51.c | 5 ++---
>> 1 file changed, 2 insertions(+), 3 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/panel/panel-mantix-mlaf057we51.c b/drivers/gpu/drm/panel/panel-mantix-mlaf057we51.c
>> index 3482e28e30fc..be4761a643f9 100644
>> --- a/drivers/gpu/drm/panel/panel-mantix-mlaf057we51.c
>> +++ b/drivers/gpu/drm/panel/panel-mantix-mlaf057we51.c
>> @@ -202,9 +202,8 @@ static int mantix_get_modes(struct drm_panel *panel,
>>
>> mode = drm_mode_duplicate(connector->dev, &default_mode);
>> if (!mode) {
>> - dev_err(ctx->dev, "Failed to add mode %ux%u@%u\n",
>> - default_mode.hdisplay, default_mode.vdisplay,
>> - drm_mode_vrefresh(mode));
>> + dev_err(ctx->dev, "Failed to add mode %ux%u\n",
>> + default_mode.hdisplay, default_mode.vdisplay);
>> return -ENOMEM;
>> }
>
> drm_mode_vrefresh(&default_mode) gives some more clue what's going on -
> I have had a fix queued up in my tree already but if you send a v2
> that's fine.
I'll defer to your queued up fix.
>
> Thanks!
> -- Guido
>
>>
>> --
>> 2.27.0
>>
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2020-09-18 16:39 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-09-18 15:51 [PATCH][next] drm/panel: fix null pointer dereference on pointer mode Colin King
2020-09-18 15:51 ` Colin King
2020-09-18 15:51 ` Colin King
2020-09-18 16:22 ` Guido Günther
2020-09-18 16:22 ` Guido Günther
2020-09-18 16:22 ` Guido Günther
2020-09-18 16:39 ` Colin Ian King
2020-09-18 16:39 ` Colin Ian King
2020-09-18 16:39 ` Colin Ian King
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.