* [PATCH v2 1/2] dt-bindings: leds: add LED_FUNCTION for wlan2g/wlan5g
@ 2020-09-19 17:27 Adrian Schmutzler
2020-09-19 17:27 ` [PATCH v2 2/2] dt-bindings: leds: add LED_FUNCTION_RSSI Adrian Schmutzler
2020-09-19 21:45 ` [PATCH v2 1/2] dt-bindings: leds: add LED_FUNCTION for wlan2g/wlan5g Adrian Schmutzler
0 siblings, 2 replies; 5+ messages in thread
From: Adrian Schmutzler @ 2020-09-19 17:27 UTC (permalink / raw)
To: Rob Herring, Pavel Machek, Dan Murphy, Linus Walleij, devicetree,
Adrian Schmutzler
Many consumer "routers" have dedicated LEDs for specific WiFi bands,
e.g. one for 2.4 GHz and one for 5 GHz. These LEDs specifically
indicate the state of the relevant band, so the latter should be
included in the function name. LED_FUNCTION_WLAN will remain for
general cases or when the LED is used for more than one band.
This essentially is equivalent to how we use LED_FUNCTION_LAN and
LED_FUNCTION_WAN instead of just having LED_FUNCTION_ETHERNET.
Signed-off-by: Adrian Schmutzler <freifunk@adrianschmutzler.de>
---
Changes in v2:
- Without typo this time. Sorry.
---
include/dt-bindings/leds/common.h | 2 ++
1 file changed, 2 insertions(+)
diff --git a/include/dt-bindings/leds/common.h b/include/dt-bindings/leds/common.h
index 52b619d44ba2..debbd406ff17 100644
--- a/include/dt-bindings/leds/common.h
+++ b/include/dt-bindings/leds/common.h
@@ -89,6 +89,8 @@
#define LED_FUNCTION_USB "usb"
#define LED_FUNCTION_WAN "wan"
#define LED_FUNCTION_WLAN "wlan"
+#define LED_FUNCTION_WLAN2G "wlan2g"
+#define LED_FUNCTION_WLAN5G "wlan5g"
#define LED_FUNCTION_WPS "wps"
#endif /* __DT_BINDINGS_LEDS_H */
--
2.20.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH v2 2/2] dt-bindings: leds: add LED_FUNCTION_RSSI
2020-09-19 17:27 [PATCH v2 1/2] dt-bindings: leds: add LED_FUNCTION for wlan2g/wlan5g Adrian Schmutzler
@ 2020-09-19 17:27 ` Adrian Schmutzler
2020-09-19 21:45 ` [PATCH v2 1/2] dt-bindings: leds: add LED_FUNCTION for wlan2g/wlan5g Adrian Schmutzler
1 sibling, 0 replies; 5+ messages in thread
From: Adrian Schmutzler @ 2020-09-19 17:27 UTC (permalink / raw)
To: Rob Herring, Pavel Machek, Dan Murphy, Linus Walleij, devicetree,
Adrian Schmutzler
Several consumer "routers" and CPE devices have dedicated LEDs to
show the received signal strength indicator (RSSI). This is
different from the "WLAN" LEDs that just show enabled/disabled
state and sometimes rx/tx activity.
Add a LED function for these LEDs.
Signed-off-by: Adrian Schmutzler <freifunk@adrianschmutzler.de>
---
Changes in v2:
none
---
include/dt-bindings/leds/common.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/include/dt-bindings/leds/common.h b/include/dt-bindings/leds/common.h
index debbd406ff17..c4821a44e422 100644
--- a/include/dt-bindings/leds/common.h
+++ b/include/dt-bindings/leds/common.h
@@ -81,6 +81,7 @@
#define LED_FUNCTION_MTD "mtd"
#define LED_FUNCTION_PANIC "panic"
#define LED_FUNCTION_PROGRAMMING "programming"
+#define LED_FUNCTION_RSSI "rssi"
#define LED_FUNCTION_RX "rx"
#define LED_FUNCTION_SD "sd"
#define LED_FUNCTION_STANDBY "standby"
--
2.20.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* RE: [PATCH v2 1/2] dt-bindings: leds: add LED_FUNCTION for wlan2g/wlan5g
2020-09-19 17:27 [PATCH v2 1/2] dt-bindings: leds: add LED_FUNCTION for wlan2g/wlan5g Adrian Schmutzler
2020-09-19 17:27 ` [PATCH v2 2/2] dt-bindings: leds: add LED_FUNCTION_RSSI Adrian Schmutzler
@ 2020-09-19 21:45 ` Adrian Schmutzler
2020-09-23 21:04 ` Rob Herring
1 sibling, 1 reply; 5+ messages in thread
From: Adrian Schmutzler @ 2020-09-19 21:45 UTC (permalink / raw)
To: 'Rob Herring', 'Pavel Machek',
'Dan Murphy', 'Linus Walleij',
devicetree
[-- Attachment #1: Type: text/plain, Size: 1887 bytes --]
> -----Original Message-----
> From: Adrian Schmutzler [mailto:freifunk@adrianschmutzler.de]
> Sent: Samstag, 19. September 2020 19:28
> To: Rob Herring <robh+dt@kernel.org>; Pavel Machek <pavel@ucw.cz>; Dan
> Murphy <dmurphy@ti.com>; Linus Walleij <linus.walleij@linaro.org>;
> devicetree@vger.kernel.org; Adrian Schmutzler
> <freifunk@adrianschmutzler.de>
> Subject: [PATCH v2 1/2] dt-bindings: leds: add LED_FUNCTION for
> wlan2g/wlan5g
>
> Many consumer "routers" have dedicated LEDs for specific WiFi bands, e.g.
> one for 2.4 GHz and one for 5 GHz. These LEDs specifically indicate the state
> of the relevant band, so the latter should be included in the function name.
> LED_FUNCTION_WLAN will remain for general cases or when the LED is used
> for more than one band.
>
> This essentially is equivalent to how we use LED_FUNCTION_LAN and
> LED_FUNCTION_WAN instead of just having LED_FUNCTION_ETHERNET.
I only just became aware of the linux-leds@vger.kernel.org mailing list, and resubmitted there.
Sorry for the noise. Maybe get_maintainers.sh should be updated for this file.
Best
Adrian
>
> Signed-off-by: Adrian Schmutzler <freifunk@adrianschmutzler.de>
>
> ---
>
> Changes in v2:
> - Without typo this time. Sorry.
> ---
> include/dt-bindings/leds/common.h | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/include/dt-bindings/leds/common.h b/include/dt-
> bindings/leds/common.h
> index 52b619d44ba2..debbd406ff17 100644
> --- a/include/dt-bindings/leds/common.h
> +++ b/include/dt-bindings/leds/common.h
> @@ -89,6 +89,8 @@
> #define LED_FUNCTION_USB "usb"
> #define LED_FUNCTION_WAN "wan"
> #define LED_FUNCTION_WLAN "wlan"
> +#define LED_FUNCTION_WLAN2G "wlan2g"
> +#define LED_FUNCTION_WLAN5G "wlan5g"
> #define LED_FUNCTION_WPS "wps"
>
> #endif /* __DT_BINDINGS_LEDS_H */
> --
> 2.20.1
[-- Attachment #2: openpgp-digital-signature.asc --]
[-- Type: application/pgp-signature, Size: 834 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v2 1/2] dt-bindings: leds: add LED_FUNCTION for wlan2g/wlan5g
2020-09-19 21:45 ` [PATCH v2 1/2] dt-bindings: leds: add LED_FUNCTION for wlan2g/wlan5g Adrian Schmutzler
@ 2020-09-23 21:04 ` Rob Herring
0 siblings, 0 replies; 5+ messages in thread
From: Rob Herring @ 2020-09-23 21:04 UTC (permalink / raw)
To: Adrian Schmutzler
Cc: 'Pavel Machek', 'Dan Murphy',
'Linus Walleij',
devicetree
On Sat, Sep 19, 2020 at 11:45:18PM +0200, Adrian Schmutzler wrote:
> > -----Original Message-----
> > From: Adrian Schmutzler [mailto:freifunk@adrianschmutzler.de]
> > Sent: Samstag, 19. September 2020 19:28
> > To: Rob Herring <robh+dt@kernel.org>; Pavel Machek <pavel@ucw.cz>; Dan
> > Murphy <dmurphy@ti.com>; Linus Walleij <linus.walleij@linaro.org>;
> > devicetree@vger.kernel.org; Adrian Schmutzler
> > <freifunk@adrianschmutzler.de>
> > Subject: [PATCH v2 1/2] dt-bindings: leds: add LED_FUNCTION for
> > wlan2g/wlan5g
> >
> > Many consumer "routers" have dedicated LEDs for specific WiFi bands, e.g.
> > one for 2.4 GHz and one for 5 GHz. These LEDs specifically indicate the state
> > of the relevant band, so the latter should be included in the function name.
> > LED_FUNCTION_WLAN will remain for general cases or when the LED is used
> > for more than one band.
> >
> > This essentially is equivalent to how we use LED_FUNCTION_LAN and
> > LED_FUNCTION_WAN instead of just having LED_FUNCTION_ETHERNET.
>
> I only just became aware of the linux-leds@vger.kernel.org mailing list, and resubmitted there.
It should both there and the DT list.
> Sorry for the noise. Maybe get_maintainers.sh should be updated for this file.
Patches welcome.
Rob
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH v2 1/2] dt-bindings: leds: add LED_FUNCTION for wlan2g/wlan5g
@ 2020-09-19 19:24 Adrian Schmutzler
2020-09-19 19:24 ` [PATCH v2 2/2] dt-bindings: leds: add LED_FUNCTION_RSSI Adrian Schmutzler
0 siblings, 1 reply; 5+ messages in thread
From: Adrian Schmutzler @ 2020-09-19 19:24 UTC (permalink / raw)
To: linux-leds, Adrian Schmutzler
Many consumer "routers" have dedicated LEDs for specific WiFi bands,
e.g. one for 2.4 GHz and one for 5 GHz. These LEDs specifically
indicate the state of the relevant band, so the latter should be
included in the function name. LED_FUNCTION_WLAN will remain for
general cases or when the LED is used for more than one band.
This essentially is equivalent to how we use LED_FUNCTION_LAN and
LED_FUNCTION_WAN instead of just having LED_FUNCTION_ETHERNET.
Signed-off-by: Adrian Schmutzler <freifunk@adrianschmutzler.de>
---
Changes in v2:
- Without typo this time. Sorry.
---
include/dt-bindings/leds/common.h | 2 ++
1 file changed, 2 insertions(+)
diff --git a/include/dt-bindings/leds/common.h b/include/dt-bindings/leds/common.h
index 52b619d44ba2..debbd406ff17 100644
--- a/include/dt-bindings/leds/common.h
+++ b/include/dt-bindings/leds/common.h
@@ -89,6 +89,8 @@
#define LED_FUNCTION_USB "usb"
#define LED_FUNCTION_WAN "wan"
#define LED_FUNCTION_WLAN "wlan"
+#define LED_FUNCTION_WLAN2G "wlan2g"
+#define LED_FUNCTION_WLAN5G "wlan5g"
#define LED_FUNCTION_WPS "wps"
#endif /* __DT_BINDINGS_LEDS_H */
--
2.20.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH v2 2/2] dt-bindings: leds: add LED_FUNCTION_RSSI
2020-09-19 19:24 Adrian Schmutzler
@ 2020-09-19 19:24 ` Adrian Schmutzler
0 siblings, 0 replies; 5+ messages in thread
From: Adrian Schmutzler @ 2020-09-19 19:24 UTC (permalink / raw)
To: linux-leds, Adrian Schmutzler
Several consumer "routers" and CPE devices have dedicated LEDs to
show the received signal strength indicator (RSSI). This is
different from the "WLAN" LEDs that just show enabled/disabled
state and sometimes rx/tx activity.
Add a LED function for these LEDs.
Signed-off-by: Adrian Schmutzler <freifunk@adrianschmutzler.de>
---
Changes in v2:
none
---
include/dt-bindings/leds/common.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/include/dt-bindings/leds/common.h b/include/dt-bindings/leds/common.h
index debbd406ff17..c4821a44e422 100644
--- a/include/dt-bindings/leds/common.h
+++ b/include/dt-bindings/leds/common.h
@@ -81,6 +81,7 @@
#define LED_FUNCTION_MTD "mtd"
#define LED_FUNCTION_PANIC "panic"
#define LED_FUNCTION_PROGRAMMING "programming"
+#define LED_FUNCTION_RSSI "rssi"
#define LED_FUNCTION_RX "rx"
#define LED_FUNCTION_SD "sd"
#define LED_FUNCTION_STANDBY "standby"
--
2.20.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
end of thread, other threads:[~2020-09-23 21:04 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-09-19 17:27 [PATCH v2 1/2] dt-bindings: leds: add LED_FUNCTION for wlan2g/wlan5g Adrian Schmutzler
2020-09-19 17:27 ` [PATCH v2 2/2] dt-bindings: leds: add LED_FUNCTION_RSSI Adrian Schmutzler
2020-09-19 21:45 ` [PATCH v2 1/2] dt-bindings: leds: add LED_FUNCTION for wlan2g/wlan5g Adrian Schmutzler
2020-09-23 21:04 ` Rob Herring
2020-09-19 19:24 Adrian Schmutzler
2020-09-19 19:24 ` [PATCH v2 2/2] dt-bindings: leds: add LED_FUNCTION_RSSI Adrian Schmutzler
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.