* [PATCH] i2c: nvidia-gpu: use dev_info for timeout error
@ 2020-09-21 17:34 Ajay Gupta
2020-09-21 18:08 ` Wolfram Sang
0 siblings, 1 reply; 3+ messages in thread
From: Ajay Gupta @ 2020-09-21 17:34 UTC (permalink / raw)
To: wsa; +Cc: linux-i2c, Ajay Gupta
From: Ajay Gupta <ajayg@nvidia.com>
Timeout error may be seen due to missing i2c client such as
USB Type-C UCSI controller on some NVIDIA GPU card. Currently
we don't have a correct way to identify these cards.
Tools like Plymouth (splashscreen) doesn't like dev_err so
changing timeout status log to dev_info.
Bug information:
https://bugzilla.kernel.org/show_bug.cgi?id=206653
Signed-off-by: Ajay Gupta <ajayg@nvidia.com>
---
drivers/i2c/busses/i2c-nvidia-gpu.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/i2c/busses/i2c-nvidia-gpu.c b/drivers/i2c/busses/i2c-nvidia-gpu.c
index f480105000b8..17a8cefe5c45 100644
--- a/drivers/i2c/busses/i2c-nvidia-gpu.c
+++ b/drivers/i2c/busses/i2c-nvidia-gpu.c
@@ -85,7 +85,7 @@ static int gpu_i2c_check_status(struct gpu_i2c_dev *i2cd)
500, 1000 * USEC_PER_MSEC);
if (ret) {
- dev_err(i2cd->dev, "i2c timeout error %x\n", val);
+ dev_info(i2cd->dev, "i2c timeout error %x\n", val);
return -ETIMEDOUT;
}
--
2.17.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] i2c: nvidia-gpu: use dev_info for timeout error
2020-09-21 17:34 [PATCH] i2c: nvidia-gpu: use dev_info for timeout error Ajay Gupta
@ 2020-09-21 18:08 ` Wolfram Sang
2020-09-21 19:36 ` Ajay Gupta
0 siblings, 1 reply; 3+ messages in thread
From: Wolfram Sang @ 2020-09-21 18:08 UTC (permalink / raw)
To: Ajay Gupta; +Cc: linux-i2c, Ajay Gupta
[-- Attachment #1: Type: text/plain, Size: 656 bytes --]
On Mon, Sep 21, 2020 at 10:34:26AM -0700, Ajay Gupta wrote:
> From: Ajay Gupta <ajayg@nvidia.com>
>
> Timeout error may be seen due to missing i2c client such as
> USB Type-C UCSI controller on some NVIDIA GPU card. Currently
> we don't have a correct way to identify these cards.
>
> Tools like Plymouth (splashscreen) doesn't like dev_err so
> changing timeout status log to dev_info.
>
> Bug information:
> https://bugzilla.kernel.org/show_bug.cgi?id=206653
>
> Signed-off-by: Ajay Gupta <ajayg@nvidia.com>
Hmm, a KERN_INFO message saying "error" does not make much sense. Maybe
this is an argument to simply remove the message?
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
* RE: [PATCH] i2c: nvidia-gpu: use dev_info for timeout error
2020-09-21 18:08 ` Wolfram Sang
@ 2020-09-21 19:36 ` Ajay Gupta
0 siblings, 0 replies; 3+ messages in thread
From: Ajay Gupta @ 2020-09-21 19:36 UTC (permalink / raw)
To: Wolfram Sang, Ajay Gupta; +Cc: linux-i2c
Hi Wolfram,
> -----Original Message-----
> From: Wolfram Sang <wsa@the-dreams.de>
> Sent: Monday, September 21, 2020 11:09 AM
> To: Ajay Gupta <ajaykuee@gmail.com>
> Cc: linux-i2c@vger.kernel.org; Ajay Gupta <ajayg@nvidia.com>
> Subject: Re: [PATCH] i2c: nvidia-gpu: use dev_info for timeout error
>
> On Mon, Sep 21, 2020 at 10:34:26AM -0700, Ajay Gupta wrote:
> > From: Ajay Gupta <ajayg@nvidia.com>
> >
> > Timeout error may be seen due to missing i2c client such as USB Type-C
> > UCSI controller on some NVIDIA GPU card. Currently we don't have a
> > correct way to identify these cards.
> >
> > Tools like Plymouth (splashscreen) doesn't like dev_err so changing
> > timeout status log to dev_info.
> >
> > Bug information:
> > https://bugzilla.kernel.org/show_bug.cgi?id=206653
> >
> > Signed-off-by: Ajay Gupta <ajayg@nvidia.com>
>
> Hmm, a KERN_INFO message saying "error" does not make much sense.
> Maybe this is an argument to simply remove the message?
Sounds good. Client driver anyways gets probe error in case of a real i2c
timeout with an existing i2c device and that can help debug.
Thanks
>nvpublic
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-09-21 19:36 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-09-21 17:34 [PATCH] i2c: nvidia-gpu: use dev_info for timeout error Ajay Gupta
2020-09-21 18:08 ` Wolfram Sang
2020-09-21 19:36 ` Ajay Gupta
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.