Re: [RFC PATCH 22/41] random: introduce arch_has_sp800_90b_random_seed()

From: kernel test robot <lkp@intel.com>
To: kbuild-all@lists.01.org
Subject: Re: [RFC PATCH 22/41] random: introduce arch_has_sp800_90b_random_seed()
Date: Mon, 21 Sep 2020 20:18:11 +0800	[thread overview]
Message-ID: <202009212021.lGmKPZJ4%lkp@intel.com> (raw)
In-Reply-To: <20200921075857.4424-23-nstange@suse.de>

[-- Attachment #1: Type: text/plain, Size: 4213 bytes --]

Hi Nicolai,

[FYI, it's a private test report for your RFC patch.]
[auto build test ERROR on char-misc/char-misc-testing]
[also build test ERROR on arm64/for-next/core powerpc/next s390/features tip/x86/core linus/master v5.9-rc6 next-20200921]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Nicolai-Stange/random-possible-ways-towards-NIST-SP800-90B-compliance/20200921-160315
base:   https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/char-misc.git 8fd0e2a6df262539eaa28b0a2364cca10d1dc662
config: arm64-allyesconfig (attached as .config)
compiler: aarch64-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=arm64 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

   In file included from include/linux/random.h:121,
                    from arch/arm64/include/asm/pointer_auth.h:6,
                    from arch/arm64/include/asm/processor.h:39,
                    from include/linux/mutex.h:19,
                    from include/linux/kernfs.h:12,
                    from include/linux/sysfs.h:16,
                    from include/linux/kobject.h:20,
                    from include/linux/of.h:17,
                    from include/linux/irqdomain.h:35,
                    from include/linux/acpi.h:13,
                    from include/acpi/apei.h:9,
                    from include/acpi/ghes.h:5,
                    from include/linux/arm_sdei.h:8,
                    from arch/arm64/kernel/asm-offsets.c:10:
>> arch/arm64/include/asm/archrandom.h:45:8: error: unknown type name 'inine'
      45 | static inine bool arch_has_sp800_90b_random_seed(void)
         |        ^~~~~
>> arch/arm64/include/asm/archrandom.h:45:19: error: expected '=', ',', ';', 'asm' or '__attribute__' before 'arch_has_sp800_90b_random_seed'
      45 | static inine bool arch_has_sp800_90b_random_seed(void)
         |                   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   make[2]: *** [scripts/Makefile.build:117: arch/arm64/kernel/asm-offsets.s] Error 1
   make[2]: Target '__build' not remade because of errors.
   make[1]: *** [Makefile:1198: prepare0] Error 2
   make[1]: Target 'prepare' not remade because of errors.
   make: *** [Makefile:185: __sub-make] Error 2
   make: Target 'prepare' not remade because of errors.

# https://github.com/0day-ci/linux/commit/af235fdbda320942f96e2530990620871f47c9d0
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Nicolai-Stange/random-possible-ways-towards-NIST-SP800-90B-compliance/20200921-160315
git checkout af235fdbda320942f96e2530990620871f47c9d0
vim +/inine +45 arch/arm64/include/asm/archrandom.h

    34	
    35	static inline bool arch_has_random_seed(void)
    36	{
    37		/*
    38		 * Only support the generic interface after we have detected
    39		 * the system wide capability, avoiding complexity with the
    40		 * cpufeature code and with potential scheduling between CPUs
    41		 * with and without the feature.
    42		 */
    43		return cpus_have_const_cap(ARM64_HAS_RNG);
    44	}
  > 45	static inine bool arch_has_sp800_90b_random_seed(void)
    46	{
    47		/*
    48		 * Section K.12.1 from the Arm Architecture Reference Manual
    49		 * Armv8" (DDI0487F) sounds like RNDRRS could qualify as a
    50		 * NIST SP800-90C NRBG, but we're currently using RNDR only.
    51		 */
    52		return false;
    53	}
    54	static inline bool __must_check arch_get_random_long(unsigned long *v)
    55	{
    56		return false;
    57	}
    58	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 74130 bytes --]