All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jakub Kicinski <kuba@kernel.org>
To: "Brown, Aaron F" <aaron.f.brown@intel.com>
Cc: "davem@davemloft.net" <davem@davemloft.net>,
	"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
	"intel-wired-lan@lists.osuosl.org"
	<intel-wired-lan@lists.osuosl.org>
Subject: Re: [Intel-wired-lan] [PATCH net-next v1 4/7] selftests: net: add a test for shared UDP tunnel info tables
Date: Tue, 22 Sep 2020 11:35:57 -0700	[thread overview]
Message-ID: <20200922113557.15a95bf4@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> (raw)
In-Reply-To: <DM6PR11MB289053EE6E23D53BD4D2126BBC3B0@DM6PR11MB2890.namprd11.prod.outlook.com>

On Tue, 22 Sep 2020 17:34:41 +0000 Brown, Aaron F wrote:
> I should have tunneling enabled as modules, config I was using in
> it's entirety (started with a `make localmodconfig` on a Red Hat
> EL8.x box then started adding modules as needed, so I expect I am
> missing something :)  config follows:

No luck :(

# ./udp_tunnel_nic.sh 
PASSED all 435 checks

Since your failures are on port 1 - which is the config where the
driver sleeps I wonder if this is not a race condition of some sort.

Could you try poking at the values in function check_tables?
The sleep lengths and the retries?

WARNING: multiple messages have this Message-ID (diff)
From: Jakub Kicinski <kuba@kernel.org>
To: intel-wired-lan@osuosl.org
Subject: [Intel-wired-lan] [PATCH net-next v1 4/7] selftests: net: add a test for shared UDP tunnel info tables
Date: Tue, 22 Sep 2020 11:35:57 -0700	[thread overview]
Message-ID: <20200922113557.15a95bf4@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> (raw)
In-Reply-To: <DM6PR11MB289053EE6E23D53BD4D2126BBC3B0@DM6PR11MB2890.namprd11.prod.outlook.com>

On Tue, 22 Sep 2020 17:34:41 +0000 Brown, Aaron F wrote:
> I should have tunneling enabled as modules, config I was using in
> it's entirety (started with a `make localmodconfig` on a Red Hat
> EL8.x box then started adding modules as needed, so I expect I am
> missing something :)  config follows:

No luck :(

# ./udp_tunnel_nic.sh 
PASSED all 435 checks

Since your failures are on port 1 - which is the config where the
driver sleeps I wonder if this is not a race condition of some sort.

Could you try poking at the values in function check_tables?
The sleep lengths and the retries?

  reply	other threads:[~2020-09-22 18:36 UTC|newest]

Thread overview: 44+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-22  1:27 [PATCH net-next v1 0/7] udp_tunnel: convert Intel drivers with shared tables Jakub Kicinski
2020-07-22  1:27 ` [Intel-wired-lan] " Jakub Kicinski
2020-07-22  1:27 ` [PATCH net-next v1 1/7] udp_tunnel: add the ability to share port tables Jakub Kicinski
2020-07-22  1:27   ` [Intel-wired-lan] " Jakub Kicinski
2020-07-22  1:27 ` [PATCH net-next v1 2/7] netdevsim: add warnings on unexpected UDP tunnel port errors Jakub Kicinski
2020-07-22  1:27   ` [Intel-wired-lan] " Jakub Kicinski
2020-07-22  1:27 ` [PATCH net-next v1 3/7] netdevsim: shared UDP tunnel port table support Jakub Kicinski
2020-07-22  1:27   ` [Intel-wired-lan] " Jakub Kicinski
2020-07-22  1:27 ` [PATCH net-next v1 4/7] selftests: net: add a test for shared UDP tunnel info tables Jakub Kicinski
2020-07-22  1:27   ` [Intel-wired-lan] " Jakub Kicinski
2020-09-19  7:23   ` Brown, Aaron F
2020-09-19  7:23     ` Brown, Aaron F
2020-09-21 21:44     ` Jakub Kicinski
2020-09-21 21:44       ` Jakub Kicinski
2020-09-22 17:34       ` Brown, Aaron F
2020-09-22 17:34         ` Brown, Aaron F
2020-09-22 18:35         ` Jakub Kicinski [this message]
2020-09-22 18:35           ` Jakub Kicinski
2020-09-24 22:25       ` Nguyen, Anthony L
2020-09-24 22:25         ` Nguyen, Anthony L
2020-09-24 22:28         ` Jakub Kicinski
2020-09-24 22:28           ` Jakub Kicinski
2020-07-22  1:27 ` [PATCH net-next v1 5/7] i40e: convert to new udp_tunnel infrastructure Jakub Kicinski
2020-07-22  1:27   ` [Intel-wired-lan] " Jakub Kicinski
2020-09-19  7:04   ` Brown, Aaron F
2020-09-19  7:04     ` Brown, Aaron F
2020-07-22  1:27 ` [PATCH net-next v1 6/7] ice: remove unused args from ice_get_open_tunnel_port() Jakub Kicinski
2020-07-22  1:27   ` [Intel-wired-lan] " Jakub Kicinski
2020-09-19  5:40   ` Brown, Aaron F
2020-09-19  5:40     ` [Intel-wired-lan] " Brown, Aaron F
2020-07-22  1:27 ` [PATCH net-next v1 7/7] ice: convert to new udp_tunnel infrastructure Jakub Kicinski
2020-07-22  1:27   ` [Intel-wired-lan] " Jakub Kicinski
2020-09-19  5:42   ` Brown, Aaron F
2020-09-19  5:42     ` [Intel-wired-lan] " Brown, Aaron F
2020-07-22 21:22 ` [PATCH net-next v1 0/7] udp_tunnel: convert Intel drivers with shared tables Nguyen, Anthony L
2020-07-22 21:22   ` [Intel-wired-lan] " Nguyen, Anthony L
2020-07-23 20:06   ` Nguyen, Anthony L
2020-07-23 20:06     ` [Intel-wired-lan] " Nguyen, Anthony L
2020-07-23 20:17     ` David Miller
2020-07-23 20:17       ` [Intel-wired-lan] " David Miller
2020-09-03 23:22     ` Jakub Kicinski
2020-09-03 23:22       ` [Intel-wired-lan] " Jakub Kicinski
2020-09-04 16:12       ` Nguyen, Anthony L
2020-09-04 16:12         ` [Intel-wired-lan] " Nguyen, Anthony L

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200922113557.15a95bf4@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com \
    --to=kuba@kernel.org \
    --cc=aaron.f.brown@intel.com \
    --cc=davem@davemloft.net \
    --cc=intel-wired-lan@lists.osuosl.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.