* [PATCH] migration: increase max-bandwidth to 128 MiB/s (1 Gib/s)
@ 2020-09-21 14:49 Laurent Vivier
2020-09-22 0:46 ` David Gibson
` (3 more replies)
0 siblings, 4 replies; 5+ messages in thread
From: Laurent Vivier @ 2020-09-21 14:49 UTC (permalink / raw)
To: qemu-devel
Cc: Daniel P . Berrangé,
Juan Quintela, Greg Kurz, Dr. David Alan Gilbert,
Andrea Bolognani, David Gibson, Frediano Ziglio
max-bandwidth is set by default to 32 MiB/s (256 Mib/s)
since 2008 (5bb7910af031c).
Most of the CPUs can dirty memory faster than that now,
and this is clearly a problem with POWER where the page
size is 64 kiB and not 4 KiB.
Signed-off-by: Laurent Vivier <lvivier@redhat.com>
---
migration/migration.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/migration/migration.c b/migration/migration.c
index 58a5452471f9..1c4174947181 100644
--- a/migration/migration.c
+++ b/migration/migration.c
@@ -57,7 +57,7 @@
#include "qemu/queue.h"
#include "multifd.h"
-#define MAX_THROTTLE (32 << 20) /* Migration transfer speed throttling */
+#define MAX_THROTTLE (128 << 20) /* Migration transfer speed throttling */
/* Amount of time to allocate to each "chunk" of bandwidth-throttled
* data. */
--
2.26.2
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] migration: increase max-bandwidth to 128 MiB/s (1 Gib/s)
2020-09-21 14:49 [PATCH] migration: increase max-bandwidth to 128 MiB/s (1 Gib/s) Laurent Vivier
@ 2020-09-22 0:46 ` David Gibson
2020-09-22 7:02 ` Greg Kurz
` (2 subsequent siblings)
3 siblings, 0 replies; 5+ messages in thread
From: David Gibson @ 2020-09-22 0:46 UTC (permalink / raw)
To: Laurent Vivier
Cc: Daniel P . Berrangé,
Juan Quintela, Greg Kurz, qemu-devel, Andrea Bolognani,
David Gibson, Dr. David Alan Gilbert, Frediano Ziglio
[-- Attachment #1: Type: text/plain, Size: 1228 bytes --]
On Mon, Sep 21, 2020 at 04:49:57PM +0200, Laurent Vivier wrote:
> max-bandwidth is set by default to 32 MiB/s (256 Mib/s)
> since 2008 (5bb7910af031c).
>
> Most of the CPUs can dirty memory faster than that now,
> and this is clearly a problem with POWER where the page
> size is 64 kiB and not 4 KiB.
>
> Signed-off-by: Laurent Vivier <lvivier@redhat.com>
Reviewed-by: David Gibson <david@gibson.dropbear.id.au>
> ---
> migration/migration.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/migration/migration.c b/migration/migration.c
> index 58a5452471f9..1c4174947181 100644
> --- a/migration/migration.c
> +++ b/migration/migration.c
> @@ -57,7 +57,7 @@
> #include "qemu/queue.h"
> #include "multifd.h"
>
> -#define MAX_THROTTLE (32 << 20) /* Migration transfer speed throttling */
> +#define MAX_THROTTLE (128 << 20) /* Migration transfer speed throttling */
>
> /* Amount of time to allocate to each "chunk" of bandwidth-throttled
> * data. */
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] migration: increase max-bandwidth to 128 MiB/s (1 Gib/s)
2020-09-21 14:49 [PATCH] migration: increase max-bandwidth to 128 MiB/s (1 Gib/s) Laurent Vivier
2020-09-22 0:46 ` David Gibson
@ 2020-09-22 7:02 ` Greg Kurz
2020-09-22 12:11 ` Dr. David Alan Gilbert
2020-09-23 19:02 ` Dr. David Alan Gilbert
3 siblings, 0 replies; 5+ messages in thread
From: Greg Kurz @ 2020-09-22 7:02 UTC (permalink / raw)
To: Laurent Vivier
Cc: Daniel P . Berrangé,
Juan Quintela, qemu-devel, Andrea Bolognani, David Gibson,
Dr. David Alan Gilbert, Frediano Ziglio
On Mon, 21 Sep 2020 16:49:57 +0200
Laurent Vivier <lvivier@redhat.com> wrote:
> max-bandwidth is set by default to 32 MiB/s (256 Mib/s)
> since 2008 (5bb7910af031c).
>
> Most of the CPUs can dirty memory faster than that now,
> and this is clearly a problem with POWER where the page
> size is 64 kiB and not 4 KiB.
>
> Signed-off-by: Laurent Vivier <lvivier@redhat.com>
> ---
Reviewed-by: Greg Kurz <groug@kaod.org>
> migration/migration.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/migration/migration.c b/migration/migration.c
> index 58a5452471f9..1c4174947181 100644
> --- a/migration/migration.c
> +++ b/migration/migration.c
> @@ -57,7 +57,7 @@
> #include "qemu/queue.h"
> #include "multifd.h"
>
> -#define MAX_THROTTLE (32 << 20) /* Migration transfer speed throttling */
> +#define MAX_THROTTLE (128 << 20) /* Migration transfer speed throttling */
>
> /* Amount of time to allocate to each "chunk" of bandwidth-throttled
> * data. */
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] migration: increase max-bandwidth to 128 MiB/s (1 Gib/s)
2020-09-21 14:49 [PATCH] migration: increase max-bandwidth to 128 MiB/s (1 Gib/s) Laurent Vivier
2020-09-22 0:46 ` David Gibson
2020-09-22 7:02 ` Greg Kurz
@ 2020-09-22 12:11 ` Dr. David Alan Gilbert
2020-09-23 19:02 ` Dr. David Alan Gilbert
3 siblings, 0 replies; 5+ messages in thread
From: Dr. David Alan Gilbert @ 2020-09-22 12:11 UTC (permalink / raw)
To: Laurent Vivier
Cc: Daniel P . Berrangé,
Juan Quintela, Greg Kurz, qemu-devel, Andrea Bolognani,
David Gibson, Frediano Ziglio
* Laurent Vivier (lvivier@redhat.com) wrote:
> max-bandwidth is set by default to 32 MiB/s (256 Mib/s)
> since 2008 (5bb7910af031c).
>
> Most of the CPUs can dirty memory faster than that now,
> and this is clearly a problem with POWER where the page
> size is 64 kiB and not 4 KiB.
>
> Signed-off-by: Laurent Vivier <lvivier@redhat.com>
Thanks,
Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
in another 12 years we can increase it by 8x again!
> ---
> migration/migration.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/migration/migration.c b/migration/migration.c
> index 58a5452471f9..1c4174947181 100644
> --- a/migration/migration.c
> +++ b/migration/migration.c
> @@ -57,7 +57,7 @@
> #include "qemu/queue.h"
> #include "multifd.h"
>
> -#define MAX_THROTTLE (32 << 20) /* Migration transfer speed throttling */
> +#define MAX_THROTTLE (128 << 20) /* Migration transfer speed throttling */
>
> /* Amount of time to allocate to each "chunk" of bandwidth-throttled
> * data. */
> --
> 2.26.2
>
--
Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] migration: increase max-bandwidth to 128 MiB/s (1 Gib/s)
2020-09-21 14:49 [PATCH] migration: increase max-bandwidth to 128 MiB/s (1 Gib/s) Laurent Vivier
` (2 preceding siblings ...)
2020-09-22 12:11 ` Dr. David Alan Gilbert
@ 2020-09-23 19:02 ` Dr. David Alan Gilbert
3 siblings, 0 replies; 5+ messages in thread
From: Dr. David Alan Gilbert @ 2020-09-23 19:02 UTC (permalink / raw)
To: Laurent Vivier
Cc: Daniel P . Berrangé,
Juan Quintela, Greg Kurz, qemu-devel, Andrea Bolognani,
David Gibson, Frediano Ziglio
* Laurent Vivier (lvivier@redhat.com) wrote:
> max-bandwidth is set by default to 32 MiB/s (256 Mib/s)
> since 2008 (5bb7910af031c).
>
> Most of the CPUs can dirty memory faster than that now,
> and this is clearly a problem with POWER where the page
> size is 64 kiB and not 4 KiB.
>
> Signed-off-by: Laurent Vivier <lvivier@redhat.com>
Queued
> ---
> migration/migration.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/migration/migration.c b/migration/migration.c
> index 58a5452471f9..1c4174947181 100644
> --- a/migration/migration.c
> +++ b/migration/migration.c
> @@ -57,7 +57,7 @@
> #include "qemu/queue.h"
> #include "multifd.h"
>
> -#define MAX_THROTTLE (32 << 20) /* Migration transfer speed throttling */
> +#define MAX_THROTTLE (128 << 20) /* Migration transfer speed throttling */
>
> /* Amount of time to allocate to each "chunk" of bandwidth-throttled
> * data. */
> --
> 2.26.2
>
>
--
Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2020-09-23 19:04 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-09-21 14:49 [PATCH] migration: increase max-bandwidth to 128 MiB/s (1 Gib/s) Laurent Vivier
2020-09-22 0:46 ` David Gibson
2020-09-22 7:02 ` Greg Kurz
2020-09-22 12:11 ` Dr. David Alan Gilbert
2020-09-23 19:02 ` Dr. David Alan Gilbert
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.