* [PATCH 0/1] nvmet: add ZNS passthru support
@ 2020-09-22 21:17 Chaitanya Kulkarni
2020-09-22 21:17 ` [PATCH 1/1] nvmet: add passthru ZNS support Chaitanya Kulkarni
0 siblings, 1 reply; 3+ messages in thread
From: Chaitanya Kulkarni @ 2020-09-22 21:17 UTC (permalink / raw)
To: linux-nvme; +Cc: keith.busch, hch, Chaitanya Kulkarni, sagi
Hi,
This patch adds a support for NVMeOF ZNS passthru.
I've tested this with zonefs tests [1] and fio verify test, all the
basic tests seems to pass at this point.
Regards,
Chaitanya
* Changes from RFC :-
1. Rebase and test the code on nvme-5.10 branch.
ZoneFS Test log :-
Passthru Setup :-
cat /sys/kernel/config/nvmet/subsystems/pt/passthru/device_path
/dev/nvme0
# nvme list | tr -s ' ' ' '
Node SN Model Namespace Usage Format FW Rev
/dev/nvme0n1 deadbeef QEMU NVMe Ctrl 1 1.07 GB / 1.07 GB 512 B + 0 B 1.0
/dev/nvme1n1 deadbeef QEMU NVMe Ctrl 1 1.07 GB / 1.07 GB 512 B + 0 B 1.0
1. ZoneFS Tests on local ZNS controller :-
# ./zonefs-tests.sh /dev/nvme0n1
zonefs-tests on /dev/nvme0n1:
8 zones (0 conventional zones, 8 sequential zones)
262144 512B sectors per zone (128 MiB)
Running tests
Test 0010: mkzonefs (options) ... PASS
Test 0011: mkzonefs (force format) ... PASS
Test 0012: mkzonefs (invalid device) ... PASS
Test 0013: mkzonefs (super block zone state) ... PASS
Test 0020: mount (default) ... PASS
Test 0021: mount (invalid device) ... PASS
Test 0022: mount (check mount directory sub-directories) ... PASS
Test 0023: mount (options) ... PASS
Test 0030: Number of files (default) ... PASS
Test 0031: Number of files (aggr_cnv) ... skip
Test 0032: Number of files using stat (default) ... PASS
Test 0033: Number of files using stat (aggr_cnv) ... PASS
Test 0034: Number of blocks using stat (default) ... PASS
Test 0035: Number of blocks using stat (aggr_cnv) ... PASS
Test 0040: Files permissions (default) ... PASS
Test 0041: Files permissions (aggr_cnv) ... skip
Test 0042: Files permissions (set value) ... PASS
Test 0043: Files permissions (set value + aggr_cnv) ... skip
Test 0050: Files owner (default) ... PASS
Test 0051: Files owner (aggr_cnv) ... skip
Test 0052: Files owner (set value) ... PASS
Test 0053: Files owner (set value + aggr_cnv) ... skip
Test 0060: Files size (default) ... PASS
Test 0061: Files size (aggr_cnv) ... skip
Test 0070: Conventional file truncate ... skip
Test 0071: Conventional file truncate (aggr_cnv) ... skip
Test 0072: Conventional file unlink ... skip
Test 0073: Conventional file unlink (aggr_cnv) ... skip
Test 0074: Conventional file random write ... skip
Test 0075: Conventional file random write (direct) ... skip
Test 0076: Conventional file random write (aggr_cnv) ... skip
Test 0077: Conventional file random write (aggr_cnv, direct) ... skip
Test 0078: Conventional file mmap read/write ... skip
Test 0079: Conventional file mmap read/write (aggr_cnv) ... skip
Test 0080: Sequential file truncate ... PASS
Test 0081: Sequential file unlink ... PASS
Test 0082: Sequential file buffered write IO ... PASS
Test 0083: Sequential file overwrite ... PASS
Test 0084: Sequential file unaligned write (sync IO) ... PASS
Test 0085: Sequential file unaligned write (async IO) ... PASS
Test 0086: Sequential file append (sync) ... PASS
Test 0087: Sequential file append (async) ... PASS
Test 0088: Sequential file random read ... PASS
43 / 43 tests passed
2. ZoneFS Tests on NVMeOF passthru ZNS controller :-
# ./zonefs-tests.sh /dev/nvme1n1
zonefs-tests on /dev/nvme1n1:
8 zones (0 conventional zones, 8 sequential zones)
262144 512B sectors per zone (128 MiB)
Running tests
Test 0010: mkzonefs (options) ... PASS
Test 0011: mkzonefs (force format) ... PASS
Test 0012: mkzonefs (invalid device) ... PASS
Test 0013: mkzonefs (super block zone state) ... PASS
Test 0020: mount (default) ... PASS
Test 0021: mount (invalid device) ... PASS
Test 0022: mount (check mount directory sub-directories) ... PASS
Test 0023: mount (options) ... PASS
Test 0030: Number of files (default) ... PASS
Test 0031: Number of files (aggr_cnv) ... skip
Test 0032: Number of files using stat (default) ... PASS
Test 0033: Number of files using stat (aggr_cnv) ... PASS
Test 0034: Number of blocks using stat (default) ... PASS
Test 0035: Number of blocks using stat (aggr_cnv) ... PASS
Test 0040: Files permissions (default) ... PASS
Test 0041: Files permissions (aggr_cnv) ... skip
Test 0042: Files permissions (set value) ... PASS
Test 0043: Files permissions (set value + aggr_cnv) ... skip
Test 0050: Files owner (default) ... PASS
Test 0051: Files owner (aggr_cnv) ... skip
Test 0052: Files owner (set value) ... PASS
Test 0053: Files owner (set value + aggr_cnv) ... skip
Test 0060: Files size (default) ... PASS
Test 0061: Files size (aggr_cnv) ... skip
Test 0070: Conventional file truncate ... skip
Test 0071: Conventional file truncate (aggr_cnv) ... skip
Test 0072: Conventional file unlink ... skip
Test 0073: Conventional file unlink (aggr_cnv) ... skip
Test 0074: Conventional file random write ... skip
Test 0075: Conventional file random write (direct) ... skip
Test 0076: Conventional file random write (aggr_cnv) ... skip
Test 0077: Conventional file random write (aggr_cnv, direct) ... skip
Test 0078: Conventional file mmap read/write ... skip
Test 0079: Conventional file mmap read/write (aggr_cnv) ... skip
Test 0080: Sequential file truncate ... PASS
Test 0081: Sequential file unlink ... PASS
Test 0082: Sequential file buffered write IO ... PASS
Test 0083: Sequential file overwrite ... PASS
Test 0084: Sequential file unaligned write (sync IO) ... PASS
Test 0085: Sequential file unaligned write (async IO) ... PASS
Test 0086: Sequential file append (sync) ... PASS
Test 0087: Sequential file append (async) ... PASS
Test 0088: Sequential file random read ... PASS
43 / 43 tests passed
3. Fio Verify est on local ZNS controller :-
# blkzone reset /dev/nvme0n1
# fio --name=zbc --filename=/dev/nvme0n1 --direct=1 \
--zonemode=zbd --offset=0 --size=1G --verify=crc32c \
--norandommap --randrepeat=0 --ioengine=libaio --iodepth=2 \
--rw=write --bs=4k
zbc: (g=0): rw=write, bs=(R) 4096B-4096B, (W) 4096B-4096B, (T) 4096B-4096B, ioengine=libaio, iodepth=2
fio-3.23
Starting 1 process
Jobs: 1 (f=1): [V(1)][100.0%][r=78.5MiB/s][r=20.1k IOPS][eta 00m:00s]
zbc: (groupid=0, jobs=1): err= 0: pid=5891: Tue Sep 22 14:12:49 2020
read: IOPS=22.5k, BW=87.7MiB/s (91.0MB/s)(1024MiB/11672msec)
slat (usec): min=6, max=8227, avg=28.80, stdev=31.86
clat (usec): min=11, max=8232, avg=58.35, stdev=34.31
lat (usec): min=40, max=16233, avg=87.33, stdev=49.29
clat percentiles (usec):
| 1.00th=[ 14], 5.00th=[ 27], 10.00th=[ 42], 20.00th=[ 47],
| 30.00th=[ 51], 40.00th=[ 55], 50.00th=[ 58], 60.00th=[ 62],
| 70.00th=[ 68], 80.00th=[ 72], 90.00th=[ 78], 95.00th=[ 84],
| 99.00th=[ 94], 99.50th=[ 100], 99.90th=[ 147], 99.95th=[ 229],
| 99.99th=[ 1369]
write: IOPS=12.5k, BW=48.9MiB/s (51.3MB/s)(1024MiB/20927msec); 0 zone resets
slat (usec): min=2, max=5430, avg=23.51, stdev=17.70
clat (usec): min=20, max=57609, avg=134.48, stdev=347.06
lat (usec): min=66, max=57640, avg=158.20, stdev=350.30
clat percentiles (usec):
| 1.00th=[ 70], 5.00th=[ 92], 10.00th=[ 97], 20.00th=[ 101],
| 30.00th=[ 103], 40.00th=[ 105], 50.00th=[ 108], 60.00th=[ 110],
| 70.00th=[ 113], 80.00th=[ 116], 90.00th=[ 123], 95.00th=[ 131],
| 99.00th=[ 225], 99.50th=[ 3687], 99.90th=[ 4146], 99.95th=[ 4228],
| 99.99th=[ 4621]
bw ( KiB/s): min=39496, max=59097, per=99.57%, avg=49889.90, stdev=4282.32, samples=42
iops : min= 9874, max=14774, avg=12472.33, stdev=1070.61, samples=42
lat (usec) : 20=1.45%, 50=12.34%, 100=45.22%, 250=40.51%, 500=0.13%
lat (usec) : 750=0.01%, 1000=0.01%
lat (msec) : 2=0.01%, 4=0.19%, 10=0.14%, 100=0.01%
cpu : usr=8.97%, sys=32.57%, ctx=598567, majf=0, minf=6263
IO depths : 1=0.1%, 2=100.0%, 4=0.0%, 8=0.0%, 16=0.0%, 32=0.0%, >=64=0.0%
submit : 0=0.0%, 4=100.0%, 8=0.0%, 16=0.0%, 32=0.0%, 64=0.0%, >=64=0.0%
complete : 0=0.0%, 4=100.0%, 8=0.0%, 16=0.0%, 32=0.0%, 64=0.0%, >=64=0.0%
issued rwts: total=262144,262144,0,0 short=0,0,0,0 dropped=0,0,0,0
latency : target=0, window=0, percentile=100.00%, depth=2
Run status group 0 (all jobs):
READ: bw=87.7MiB/s (91.0MB/s), 87.7MiB/s-87.7MiB/s (91.0MB/s-91.0MB/s), io=1024MiB (1074MB), run=11672-11672msec
WRITE: bw=48.9MiB/s (51.3MB/s), 48.9MiB/s-48.9MiB/s (51.3MB/s-51.3MB/s), io=1024MiB (1074MB), run=20927-20927msec
Disk stats (read/write):
nvme0n1: ios=262238/261055, merge=0/1089, ticks=16283/29978, in_queue=46261, util=99.58%
4. Fio Verify Test on NVMeOF passthru ZNS controller :-
# blkzone reset /dev/nvme1n1
# fio --name=zbc --filename=/dev/nvme1n1 --direct=1 \
--zonemode=zbd --offset=0 --size=1G --verify=crc32c \
--norandommap --randrepeat=0 --ioengine=libaio --iodepth=2 \
--rw=write --bs=4k
zbc: (g=0): rw=write, bs=(R) 4096B-4096B, (W) 4096B-4096B, (T) 4096B-4096B, ioengine=libaio, iodepth=2
fio-3.23
Starting 1 process
Jobs: 1 (f=1): [f(1)][100.0%][r=79.9MiB/s][r=20.4k IOPS][eta 00m:00s]
zbc: (groupid=0, jobs=1): err= 0: pid=5920: Tue Sep 22 14:13:37 2020
read: IOPS=20.5k, BW=80.0MiB/s (83.9MB/s)(1024MiB/12796msec)
slat (nsec): min=1092, max=7885.8k, avg=21165.61, stdev=26763.49
clat (usec): min=8, max=12153, avg=74.35, stdev=71.02
lat (usec): min=57, max=12297, avg=95.73, stdev=76.20
clat percentiles (usec):
| 1.00th=[ 34], 5.00th=[ 58], 10.00th=[ 62], 20.00th=[ 67],
| 30.00th=[ 69], 40.00th=[ 71], 50.00th=[ 73], 60.00th=[ 76],
| 70.00th=[ 78], 80.00th=[ 80], 90.00th=[ 85], 95.00th=[ 91],
| 99.00th=[ 115], 99.50th=[ 135], 99.90th=[ 247], 99.95th=[ 351],
| 99.99th=[ 3163]
write: IOPS=11.4k, BW=44.5MiB/s (46.6MB/s)(1024MiB/23037msec); 8 zone resets
slat (usec): min=2, max=4465, avg=23.01, stdev=15.57
clat (usec): min=29, max=9558, avg=150.97, stdev=291.69
lat (usec): min=70, max=9579, avg=174.21, stdev=295.29
clat percentiles (usec):
| 1.00th=[ 84], 5.00th=[ 102], 10.00th=[ 106], 20.00th=[ 111],
| 30.00th=[ 114], 40.00th=[ 117], 50.00th=[ 120], 60.00th=[ 123],
| 70.00th=[ 129], 80.00th=[ 149], 90.00th=[ 169], 95.00th=[ 182],
| 99.00th=[ 255], 99.50th=[ 3425], 99.90th=[ 4178], 99.95th=[ 4228],
| 99.99th=[ 4424]
bw ( KiB/s): min=22848, max=53112, per=100.00%, avg=45573.72, stdev=5809.92, samples=46
iops : min= 5712, max=13278, avg=11393.35, stdev=1452.45, samples=46
lat (usec) : 10=0.01%, 20=0.19%, 50=0.54%, 100=49.83%, 250=48.87%
lat (usec) : 500=0.21%, 750=0.01%, 1000=0.01%
lat (msec) : 2=0.01%, 4=0.20%, 10=0.12%, 20=0.01%
cpu : usr=11.76%, sys=11.13%, ctx=907150, majf=0, minf=6260
IO depths : 1=0.1%, 2=100.0%, 4=0.0%, 8=0.0%, 16=0.0%, 32=0.0%, >=64=0.0%
submit : 0=0.0%, 4=100.0%, 8=0.0%, 16=0.0%, 32=0.0%, 64=0.0%, >=64=0.0%
complete : 0=0.0%, 4=100.0%, 8=0.0%, 16=0.0%, 32=0.0%, 64=0.0%, >=64=0.0%
issued rwts: total=262144,262144,0,0 short=0,0,0,0 dropped=0,0,0,0
latency : target=0, window=0, percentile=100.00%, depth=2
Run status group 0 (all jobs):
READ: bw=80.0MiB/s (83.9MB/s), 80.0MiB/s-80.0MiB/s (83.9MB/s-83.9MB/s), io=1024MiB (1074MB), run=12796-12796msec
WRITE: bw=44.5MiB/s (46.6MB/s), 44.5MiB/s-44.5MiB/s (46.6MB/s-46.6MB/s), io=1024MiB (1074MB), run=23037-23037msec
Disk stats (read/write):
nvme1n1: ios=261998/261085, merge=201/1067, ticks=17605/34341, in_queue=51947, util=98.20%
Chaitanya Kulkarni (1):
nvmet: add passthru ZNS support
drivers/nvme/target/passthru.c | 16 ++++++++++++++++
1 file changed, 16 insertions(+)
--
2.22.1
_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH 1/1] nvmet: add passthru ZNS support
2020-09-22 21:17 [PATCH 0/1] nvmet: add ZNS passthru support Chaitanya Kulkarni
@ 2020-09-22 21:17 ` Chaitanya Kulkarni
2020-09-24 5:07 ` Christoph Hellwig
0 siblings, 1 reply; 3+ messages in thread
From: Chaitanya Kulkarni @ 2020-09-22 21:17 UTC (permalink / raw)
To: linux-nvme; +Cc: keith.busch, hch, Chaitanya Kulkarni, sagi
In the default passthru implementation NVMeOF target passthru ctrl is
not capable of handling Zoned Namespaces (ZNS).
Update the nvmet_parse_pasthru_admin_cmd() to allow
NVME_ID_CNS_CS_CTRL/NVME_CIS_ZNS and NVME_ID_CNS_CS_NS/NVME_CIS_ZNS.
With this addition NVMeOF Passthru allows Zoned Namespaces.
Signed-off-by: Chaitanya Kulkarni <chaitanya.kulkarni@wdc.com>
---
drivers/nvme/target/passthru.c | 16 ++++++++++++++++
1 file changed, 16 insertions(+)
diff --git a/drivers/nvme/target/passthru.c b/drivers/nvme/target/passthru.c
index e3a5f8499a0b..56c571052216 100644
--- a/drivers/nvme/target/passthru.c
+++ b/drivers/nvme/target/passthru.c
@@ -456,10 +456,26 @@ u16 nvmet_parse_passthru_admin_cmd(struct nvmet_req *req)
req->execute = nvmet_passthru_execute_cmd;
req->p.use_workqueue = true;
return NVME_SC_SUCCESS;
+ case NVME_ID_CNS_CS_CTRL:
+ switch (req->cmd->identify.csi) {
+ case NVME_CSI_ZNS:
+ req->execute = nvmet_passthru_execute_cmd;
+ req->p.use_workqueue = true;
+ return NVME_SC_SUCCESS;
+ }
+ return NVME_SC_INVALID_OPCODE | NVME_SC_DNR;
case NVME_ID_CNS_NS:
req->execute = nvmet_passthru_execute_cmd;
req->p.use_workqueue = true;
return NVME_SC_SUCCESS;
+ case NVME_ID_CNS_CS_NS:
+ switch (req->cmd->identify.csi) {
+ case NVME_CSI_ZNS:
+ req->execute = nvmet_passthru_execute_cmd;
+ req->p.use_workqueue = true;
+ return NVME_SC_SUCCESS;
+ }
+ return NVME_SC_INVALID_OPCODE | NVME_SC_DNR;
default:
return nvmet_setup_passthru_command(req);
}
--
2.22.1
_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH 1/1] nvmet: add passthru ZNS support
2020-09-22 21:17 ` [PATCH 1/1] nvmet: add passthru ZNS support Chaitanya Kulkarni
@ 2020-09-24 5:07 ` Christoph Hellwig
0 siblings, 0 replies; 3+ messages in thread
From: Christoph Hellwig @ 2020-09-24 5:07 UTC (permalink / raw)
To: Chaitanya Kulkarni; +Cc: keith.busch, hch, linux-nvme, sagi
Thanks,
applied to nvme-5.10.
_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-09-24 5:07 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-09-22 21:17 [PATCH 0/1] nvmet: add ZNS passthru support Chaitanya Kulkarni
2020-09-22 21:17 ` [PATCH 1/1] nvmet: add passthru ZNS support Chaitanya Kulkarni
2020-09-24 5:07 ` Christoph Hellwig
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.