* [meta-cgl][PATCH] ucarp: fix build error with gcc-10
@ 2020-09-23 7:56 Chen Qi
2020-09-23 8:55 ` [yocto] " Bas Mevissen
0 siblings, 1 reply; 4+ messages in thread
From: Chen Qi @ 2020-09-23 7:56 UTC (permalink / raw)
To: yocto
gcc-10 uses '-fno-common' by default, causing multiple definition
error. Use '-fcommon' to fix this problem.
Signed-off-by: Chen Qi <Qi.Chen@windriver.com>
---
meta-cgl-common/recipes-cgl/ucarp/ucarp_1.5.2.bb | 3 +++
1 file changed, 3 insertions(+)
diff --git a/meta-cgl-common/recipes-cgl/ucarp/ucarp_1.5.2.bb b/meta-cgl-common/recipes-cgl/ucarp/ucarp_1.5.2.bb
index d17baa0..87e5ada 100644
--- a/meta-cgl-common/recipes-cgl/ucarp/ucarp_1.5.2.bb
+++ b/meta-cgl-common/recipes-cgl/ucarp/ucarp_1.5.2.bb
@@ -37,6 +37,9 @@ SYSTEMD_AUTO_ENABLE = "disable"
export FETCHCMD_wget = "/usr/bin/env wget --secure-protocol=TLSv1_2 -t 2 -T 30 --passive-ftp --no-check-certificate"
EXTRA_OECONF += "--sysconfdir=${sysconfdir}/${BPN}"
+# Fix build error with gcc-10
+CFLAGS_append = " -fcommon"
+
# fix the perms for config.rpath
do_configure_prepend() {
chmod 755 ${S}/config.rpath
--
2.17.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [yocto] [meta-cgl][PATCH] ucarp: fix build error with gcc-10
2020-09-23 7:56 [meta-cgl][PATCH] ucarp: fix build error with gcc-10 Chen Qi
@ 2020-09-23 8:55 ` Bas Mevissen
2020-09-23 9:36 ` Chen Qi
0 siblings, 1 reply; 4+ messages in thread
From: Bas Mevissen @ 2020-09-23 8:55 UTC (permalink / raw)
To: Chen Qi; +Cc: yocto
On 2020-09-23 09:56, Chen Qi wrote:
> gcc-10 uses '-fno-common' by default, causing multiple definition
> error. Use '-fcommon' to fix this problem.
>
> Signed-off-by: Chen Qi <Qi.Chen@windriver.com>
> ---
> meta-cgl-common/recipes-cgl/ucarp/ucarp_1.5.2.bb | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/meta-cgl-common/recipes-cgl/ucarp/ucarp_1.5.2.bb
> b/meta-cgl-common/recipes-cgl/ucarp/ucarp_1.5.2.bb
> index d17baa0..87e5ada 100644
> --- a/meta-cgl-common/recipes-cgl/ucarp/ucarp_1.5.2.bb
> +++ b/meta-cgl-common/recipes-cgl/ucarp/ucarp_1.5.2.bb
> @@ -37,6 +37,9 @@ SYSTEMD_AUTO_ENABLE = "disable"
> export FETCHCMD_wget = "/usr/bin/env wget --secure-protocol=TLSv1_2
> -t 2 -T 30 --passive-ftp --no-check-certificate"
> EXTRA_OECONF += "--sysconfdir=${sysconfdir}/${BPN}"
>
> +# Fix build error with gcc-10
> +CFLAGS_append = " -fcommon"
> +
Why are you not patching the source to use "extern" where it is needed,
like in pacemaker? How many errors does ucarp give?
Then it might also a patch that upstream will take, solving the issue
forever in a proper way.
> # fix the perms for config.rpath
> do_configure_prepend() {
> chmod 755 ${S}/config.rpath
>
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [yocto] [meta-cgl][PATCH] ucarp: fix build error with gcc-10
2020-09-23 8:55 ` [yocto] " Bas Mevissen
@ 2020-09-23 9:36 ` Chen Qi
2020-09-23 9:37 ` Bas Mevissen
0 siblings, 1 reply; 4+ messages in thread
From: Chen Qi @ 2020-09-23 9:36 UTC (permalink / raw)
To: Bas Mevissen; +Cc: yocto
On 09/23/2020 04:55 PM, Bas Mevissen wrote:
> On 2020-09-23 09:56, Chen Qi wrote:
>> gcc-10 uses '-fno-common' by default, causing multiple definition
>> error. Use '-fcommon' to fix this problem.
>>
>> Signed-off-by: Chen Qi <Qi.Chen@windriver.com>
>> ---
>> meta-cgl-common/recipes-cgl/ucarp/ucarp_1.5.2.bb | 3 +++
>> 1 file changed, 3 insertions(+)
>>
>> diff --git a/meta-cgl-common/recipes-cgl/ucarp/ucarp_1.5.2.bb
>> b/meta-cgl-common/recipes-cgl/ucarp/ucarp_1.5.2.bb
>> index d17baa0..87e5ada 100644
>> --- a/meta-cgl-common/recipes-cgl/ucarp/ucarp_1.5.2.bb
>> +++ b/meta-cgl-common/recipes-cgl/ucarp/ucarp_1.5.2.bb
>> @@ -37,6 +37,9 @@ SYSTEMD_AUTO_ENABLE = "disable"
>> export FETCHCMD_wget = "/usr/bin/env wget --secure-protocol=TLSv1_2
>> -t 2 -T 30 --passive-ftp --no-check-certificate"
>> EXTRA_OECONF += "--sysconfdir=${sysconfdir}/${BPN}"
>>
>> +# Fix build error with gcc-10
>> +CFLAGS_append = " -fcommon"
>> +
>
> Why are you not patching the source to use "extern" where it is
> needed, like in pacemaker? How many errors does ucarp give?
> Then it might also a patch that upstream will take, solving the issue
> forever in a proper way.
>
Could you please send out one?
>> # fix the perms for config.rpath
>> do_configure_prepend() {
>> chmod 755 ${S}/config.rpath
>>
>>
>
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [yocto] [meta-cgl][PATCH] ucarp: fix build error with gcc-10
2020-09-23 9:36 ` Chen Qi
@ 2020-09-23 9:37 ` Bas Mevissen
0 siblings, 0 replies; 4+ messages in thread
From: Bas Mevissen @ 2020-09-23 9:37 UTC (permalink / raw)
To: ChenQi; +Cc: yocto
On 2020-09-23 11:36, ChenQi wrote:
> On 09/23/2020 04:55 PM, Bas Mevissen wrote:
>> On 2020-09-23 09:56, Chen Qi wrote:
>>> gcc-10 uses '-fno-common' by default, causing multiple definition
>>> error. Use '-fcommon' to fix this problem.
>>>
>>> Signed-off-by: Chen Qi <Qi.Chen@windriver.com>
>>> ---
>>> meta-cgl-common/recipes-cgl/ucarp/ucarp_1.5.2.bb | 3 +++
>>> 1 file changed, 3 insertions(+)
>>>
>>> diff --git a/meta-cgl-common/recipes-cgl/ucarp/ucarp_1.5.2.bb
>>> b/meta-cgl-common/recipes-cgl/ucarp/ucarp_1.5.2.bb
>>> index d17baa0..87e5ada 100644
>>> --- a/meta-cgl-common/recipes-cgl/ucarp/ucarp_1.5.2.bb
>>> +++ b/meta-cgl-common/recipes-cgl/ucarp/ucarp_1.5.2.bb
>>> @@ -37,6 +37,9 @@ SYSTEMD_AUTO_ENABLE = "disable"
>>> export FETCHCMD_wget = "/usr/bin/env wget --secure-protocol=TLSv1_2
>>> -t 2 -T 30 --passive-ftp --no-check-certificate"
>>> EXTRA_OECONF += "--sysconfdir=${sysconfdir}/${BPN}"
>>>
>>> +# Fix build error with gcc-10
>>> +CFLAGS_append = " -fcommon"
>>> +
>>
>> Why are you not patching the source to use "extern" where it is
>> needed, like in pacemaker? How many errors does ucarp give?
>> Then it might also a patch that upstream will take, solving the issue
>> forever in a proper way.
>>
>
> Could you please send out one?
>
I don't have a tree with this layer in front of me. I just reviewed your
proposed fix by setting the compiler flag, while you demonstrated in the
pacemaker patch that the issue is easily solved by adding some "exern"s
where they need to be. So I wondered why you didn't do that for ucarp.
>>> # fix the perms for config.rpath
>>> do_configure_prepend() {
>>> chmod 755 ${S}/config.rpath
>>>
>>>
>>
>>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-09-23 9:37 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-09-23 7:56 [meta-cgl][PATCH] ucarp: fix build error with gcc-10 Chen Qi
2020-09-23 8:55 ` [yocto] " Bas Mevissen
2020-09-23 9:36 ` Chen Qi
2020-09-23 9:37 ` Bas Mevissen
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.