Re: [PATCH v13 0/2] pwm: intel: Add PWM driver for a new SoC

From: Thierry Reding <thierry.reding@gmail.com>
To: Rahul Tanwar <rahul.tanwar@linux.intel.com>
Cc: u.kleine-koenig@pengutronix.de, linux-pwm@vger.kernel.org,
	lee.jones@linaro.org, p.zabel@pengutronix.de, robh+dt@kernel.org,
	linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
	andriy.shevchenko@intel.com, songjun.Wu@intel.com,
	cheol.yong.kim@intel.com, qi-ming.wu@intel.com,
	rahul.tanwar.linux@gmail.com, rtanwar@maxlinear.com
Subject: Re: [PATCH v13 0/2] pwm: intel: Add PWM driver for a new SoC
Date: Wed, 23 Sep 2020 13:49:04 +0200	[thread overview]
Message-ID: <20200923114904.GC1846003@ulmo> (raw)
In-Reply-To: <cover.1600158087.git.rahul.tanwar@linux.intel.com>

[-- Attachment #1: Type: text/plain, Size: 4140 bytes --]

On Tue, Sep 15, 2020 at 04:23:35PM +0800, Rahul Tanwar wrote:
> Patch 1 adds dt binding document in YAML format.
> Patch 2 add PWM fan controller driver for LGM SoC.
> 
> v13:
> - Address below review concerns (Philipp Zabel)
>  * Make unnecessary 2 line comment as 1 line comment.
>  * Move reset_deassert at the last after clk_enable.
>  * Remove unnecessary return ret statement from .remove()
> - Move platform_set_drvdata() at the top of probe. 
> 
> v12:
> - Rebase to linux 5.9-rc4
> - Add Reviewed-by tags from Andy Shevchenko & Rob Herring.
> 
> v11:
> - Address below review concerns (Andy Shevchenko)
>   * Fix a issue with dev_err_probe() usage & improve the usage.
>   * Fix & improve a ordering issue with clk_enable/disable &
>     reset_control assert/deassert.
> 
> v10:
> - Removed unused of_device.h and added platform_device.h
>   & mod_devicetable.h
> 
> v9:
> - Address code quality related review concerns (Andy Shevchenko)
> - Use devm_add_action_or_reset() instead of explicit unwind calls.
> 
> v8:
> - Remove fan related optional properties usage, keep
>   them as default. If needed, change pwm-fan driver
>   separately in future to add them as generic properties.
> 
> v7:
> - Address code quality related review concerns.
> - Rename fan related property to pwm-*.
> - Fix one make dt_binding_check reported error.
> 
> v6:
> - Readjust .apply op as per review feedback.
> - Add back pwm-cells property to resolve make dt_binding_check error.
>   pwm-cells is a required property for PWM driver.
> - Add back fan related optional properties.
> 
> v5:
> - Address below review concerns from Uwe Kleine-K?nig.
>   * Improve comments about Limitations.
>   * Use return value of regmap_update_bits if container function returns
>     error code.
>   * Modify .apply op to have strict checking for fixed period supported
>     by PWM HW.
>   * Use u64 as type when use min_t for duty_cycle.
>   * Add reset_control_assert() in failure case in probe where it was missing
>     earlier.
> - Remove fan specific optional properties from pwm dt binding document (Rob Herring)
> 
> v4:
> - Address below review concerns from Uwe Kleine-K?nig.
>   * Improve notes and limitations comments.
>   * Add common prefixes for all #defines.
>   * Modify/Improve logic in .apply & .get_state ops as advised.
>   * Skip error messages in probe when error is -EPROBE_DEFER.
>   * Add dependencies in Kconfig (OF & HAS_IOMEM) and add select REGMAP_MMIO.
>   * Address other code quality related review concerns.
> - Fix make dt_binding_check reported error in YAML file.
> 
> v3:
> - Address below review concerns from Uwe Kleine-K?nig.
>   * Remove fan rpm calibration task from the driver.
>   * Modify apply op as per the review feedback.
>   * Add roundup & round down where necessary.
>   * Address other misc code quality related review concerns.
>   * Use devm_reset_control_get_exclusive(). (Philipp Zabel)
>   * Improve dt binding document.
> 
> v2:
> - Address below review concerns from Uwe Kleine-K?nig.
>   * Add notes and limitations about PWM HW.
>   * Rename all functions and structure to lgm_pwm_* 
>   * Readjust space aligninment in structure fields to single space.
>   * Switch to using apply instead of config/enable/disable.
>   * Address other code quality related concerns.
>   * Rebase to 5.8-rc1.
> - Address review concerns in dt binding YAML from Rob Herring.
> 
> v1:
> - Initial version.
> 
> 
> Rahul Tanwar (2):
>   Add DT bindings YAML schema for PWM fan controller of LGM SoC
>   Add PWM fan controller driver for LGM SoC
> 
>  .../devicetree/bindings/pwm/intel,lgm-pwm.yaml     |  44 ++++
>  drivers/pwm/Kconfig                                |  11 +
>  drivers/pwm/Makefile                               |   1 +
>  drivers/pwm/pwm-intel-lgm.c                        | 246 +++++++++++++++++++++
>  4 files changed, 302 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/pwm/intel,lgm-pwm.yaml
>  create mode 100644 drivers/pwm/pwm-intel-lgm.c

Applied, thanks.

Thierry

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]