All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jaegeuk Kim <jaegeuk@kernel.org>
To: Chao Yu <yuchao0@huawei.com>
Cc: linux-f2fs-devel@lists.sourceforge.net,
	linux-kernel@vger.kernel.org, chao@kernel.org
Subject: Re: [PATCH] f2fs: compress: fix to disallow enabling compress on non-empty file
Date: Thu, 24 Sep 2020 13:03:05 -0700	[thread overview]
Message-ID: <20200924200305.GA2568648@google.com> (raw)
In-Reply-To: <20200918030349.19667-1-yuchao0@huawei.com>

On 09/18, Chao Yu wrote:
> Compressed inode and normal inode has different layout, so we should
> disallow enabling compress on non-empty file to avoid race condition
> during inode .i_addr array parsing and updating.
> 
> Signed-off-by: Chao Yu <yuchao0@huawei.com>
> ---
>  fs/f2fs/file.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/fs/f2fs/file.c b/fs/f2fs/file.c
> index 58e464cc15f0..139fdfc1dc55 100644
> --- a/fs/f2fs/file.c
> +++ b/fs/f2fs/file.c
> @@ -1821,6 +1821,8 @@ static int f2fs_setflags_common(struct inode *inode, u32 iflags, u32 mask)
>  		if (iflags & F2FS_COMPR_FL) {
>  			if (!f2fs_may_compress(inode))
>  				return -EINVAL;
> +			if (inode->i_size)

Changed like this.

+                       if (S_ISREG(inode->i_mode) && inode->i_size)


> +				return -EINVAL;
>  
>  			set_compress_context(inode);
>  		}
> -- 
> 2.26.2

WARNING: multiple messages have this Message-ID (diff)
From: Jaegeuk Kim <jaegeuk@kernel.org>
To: Chao Yu <yuchao0@huawei.com>
Cc: linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net
Subject: Re: [f2fs-dev] [PATCH] f2fs: compress: fix to disallow enabling compress on non-empty file
Date: Thu, 24 Sep 2020 13:03:05 -0700	[thread overview]
Message-ID: <20200924200305.GA2568648@google.com> (raw)
In-Reply-To: <20200918030349.19667-1-yuchao0@huawei.com>

On 09/18, Chao Yu wrote:
> Compressed inode and normal inode has different layout, so we should
> disallow enabling compress on non-empty file to avoid race condition
> during inode .i_addr array parsing and updating.
> 
> Signed-off-by: Chao Yu <yuchao0@huawei.com>
> ---
>  fs/f2fs/file.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/fs/f2fs/file.c b/fs/f2fs/file.c
> index 58e464cc15f0..139fdfc1dc55 100644
> --- a/fs/f2fs/file.c
> +++ b/fs/f2fs/file.c
> @@ -1821,6 +1821,8 @@ static int f2fs_setflags_common(struct inode *inode, u32 iflags, u32 mask)
>  		if (iflags & F2FS_COMPR_FL) {
>  			if (!f2fs_may_compress(inode))
>  				return -EINVAL;
> +			if (inode->i_size)

Changed like this.

+                       if (S_ISREG(inode->i_mode) && inode->i_size)


> +				return -EINVAL;
>  
>  			set_compress_context(inode);
>  		}
> -- 
> 2.26.2


_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel

  reply	other threads:[~2020-09-24 20:03 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-18  3:03 [PATCH] f2fs: compress: fix to disallow enabling compress on non-empty file Chao Yu
2020-09-18  3:03 ` [f2fs-dev] " Chao Yu
2020-09-24 20:03 ` Jaegeuk Kim [this message]
2020-09-24 20:03   ` Jaegeuk Kim
2020-09-25  0:57   ` Chao Yu
2020-09-25  0:57     ` [f2fs-dev] " Chao Yu
2020-09-25  9:10     ` Chao Yu
2020-09-25 17:07       ` Jaegeuk Kim
2020-09-25 23:16         ` Chao Yu
2020-09-25 23:23           ` Jaegeuk Kim
2020-09-25 23:26             ` Jaegeuk Kim
2020-09-25 23:51               ` Chao Yu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200924200305.GA2568648@google.com \
    --to=jaegeuk@kernel.org \
    --cc=chao@kernel.org \
    --cc=linux-f2fs-devel@lists.sourceforge.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=yuchao0@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.