From: Maxime Ripard <maxime@cerno.tech> To: Dave Stevenson <dave.stevenson@raspberrypi.com> Cc: Tim Gover <tim.gover@raspberrypi.com>, DRI Development <dri-devel@lists.freedesktop.org>, Eric Anholt <eric@anholt.net>, bcm-kernel-feedback-list@broadcom.com, linux-rpi-kernel@lists.infradead.org, Phil Elwell <phil@raspberrypi.com>, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v2 1/2] drm/vc4: crtc: Rework a bit the CRTC state code Date: Fri, 25 Sep 2020 13:38:40 +0200 [thread overview] Message-ID: <20200925113840.nemma2q7stujf57f@gilmour.lan> (raw) In-Reply-To: <CAPY8ntAjiBeAoB=PZzNWW_5Vi3ZstXnD59GSkPXoeBj4XbGt0Q@mail.gmail.com> Hi Dave, On Wed, Sep 23, 2020 at 03:59:04PM +0100, Dave Stevenson wrote: > Hi Maxime > > On Wed, 23 Sep 2020 at 09:40, Maxime Ripard <maxime@cerno.tech> wrote: > > > > The current CRTC state reset hook in vc4 allocates a vc4_crtc_state > > structure as a drm_crtc_state, and relies on the fact that vc4_crtc_state > > embeds drm_crtc_state as its first member, and therefore can be safely > > casted. > > s/casted/cast > > > However, this is pretty fragile especially since there's no check for this > > in place, and we're going to need to access vc4_crtc_state member at reset > > so this looks like a good occasion to make it more robust. > > > > Signed-off-by: Maxime Ripard <maxime@cerno.tech> > > Tested-by: Dave Stevenson <dave.stevenson@raspberrypi.com> > > Based on the issue I perceived with the previous patch, I'm happy. I > haven't thought about how the framework handles losing the state, but > that's not the driver's problem. > > There is still an implicit assumption that drm_crtc_state is the first > member from the implementation of to_vc4_crtc_state in vc4_drv.h. To > make it even more robust that could be a container_of instead. I > haven't checked for any other places that make the assumption though. Good catch, I'll send another patch to fix it > Reviewed-by: Dave Stevenson <dave.stevenson@raspberrypi.com> Does it apply to the second patch as well? Thanks! Maxime _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Maxime Ripard <maxime@cerno.tech> To: Dave Stevenson <dave.stevenson@raspberrypi.com> Cc: Tim Gover <tim.gover@raspberrypi.com>, DRI Development <dri-devel@lists.freedesktop.org>, bcm-kernel-feedback-list@broadcom.com, linux-rpi-kernel@lists.infradead.org, Phil Elwell <phil@raspberrypi.com>, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v2 1/2] drm/vc4: crtc: Rework a bit the CRTC state code Date: Fri, 25 Sep 2020 13:38:40 +0200 [thread overview] Message-ID: <20200925113840.nemma2q7stujf57f@gilmour.lan> (raw) In-Reply-To: <CAPY8ntAjiBeAoB=PZzNWW_5Vi3ZstXnD59GSkPXoeBj4XbGt0Q@mail.gmail.com> Hi Dave, On Wed, Sep 23, 2020 at 03:59:04PM +0100, Dave Stevenson wrote: > Hi Maxime > > On Wed, 23 Sep 2020 at 09:40, Maxime Ripard <maxime@cerno.tech> wrote: > > > > The current CRTC state reset hook in vc4 allocates a vc4_crtc_state > > structure as a drm_crtc_state, and relies on the fact that vc4_crtc_state > > embeds drm_crtc_state as its first member, and therefore can be safely > > casted. > > s/casted/cast > > > However, this is pretty fragile especially since there's no check for this > > in place, and we're going to need to access vc4_crtc_state member at reset > > so this looks like a good occasion to make it more robust. > > > > Signed-off-by: Maxime Ripard <maxime@cerno.tech> > > Tested-by: Dave Stevenson <dave.stevenson@raspberrypi.com> > > Based on the issue I perceived with the previous patch, I'm happy. I > haven't thought about how the framework handles losing the state, but > that's not the driver's problem. > > There is still an implicit assumption that drm_crtc_state is the first > member from the implementation of to_vc4_crtc_state in vc4_drv.h. To > make it even more robust that could be a container_of instead. I > haven't checked for any other places that make the assumption though. Good catch, I'll send another patch to fix it > Reviewed-by: Dave Stevenson <dave.stevenson@raspberrypi.com> Does it apply to the second patch as well? Thanks! Maxime _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2020-09-25 11:40 UTC|newest] Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-09-23 8:40 [PATCH v2 1/2] drm/vc4: crtc: Rework a bit the CRTC state code Maxime Ripard 2020-09-23 8:40 ` Maxime Ripard 2020-09-23 8:40 ` [PATCH v2 2/2] drm/vc4: crtc: Keep the previously assigned HVS FIFO Maxime Ripard 2020-09-23 8:40 ` Maxime Ripard 2020-09-25 12:05 ` Dave Stevenson 2020-09-25 12:05 ` Dave Stevenson 2020-09-23 14:59 ` [PATCH v2 1/2] drm/vc4: crtc: Rework a bit the CRTC state code Dave Stevenson 2020-09-23 14:59 ` Dave Stevenson 2020-09-23 15:41 ` Daniel Vetter 2020-09-23 15:41 ` Daniel Vetter 2020-09-25 11:38 ` Maxime Ripard [this message] 2020-09-25 11:38 ` Maxime Ripard 2020-09-25 11:47 ` Dave Stevenson 2020-09-25 11:47 ` Dave Stevenson 2020-09-25 14:57 ` Maxime Ripard 2020-09-25 14:57 ` Maxime Ripard
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20200925113840.nemma2q7stujf57f@gilmour.lan \ --to=maxime@cerno.tech \ --cc=bcm-kernel-feedback-list@broadcom.com \ --cc=dave.stevenson@raspberrypi.com \ --cc=dri-devel@lists.freedesktop.org \ --cc=eric@anholt.net \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-rpi-kernel@lists.infradead.org \ --cc=phil@raspberrypi.com \ --cc=tim.gover@raspberrypi.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.