From: Jason Gunthorpe <jgg@nvidia.com>
To: Leon Romanovsky <leon@kernel.org>
Cc: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>,
Christoph Hellwig <hch@lst.de>,
Doug Ledford <dledford@redhat.com>, <linux-rdma@vger.kernel.org>,
<intel-gfx@lists.freedesktop.org>,
"Roland Scheidegger" <sroland@vmware.com>,
<dri-devel@lists.freedesktop.org>,
"David Airlie" <airlied@linux.ie>,
VMware Graphics <linux-graphics-maintainer@vmware.com>,
Maor Gottlieb <maorg@nvidia.com>,
Maor Gottlieb <maorg@mellanox.com>
Subject: Re: [Intel-gfx] [PATCH rdma-next v3 1/2] lib/scatterlist: Add support in dynamic allocation of SG table from pages
Date: Fri, 25 Sep 2020 08:55:44 -0300 [thread overview]
Message-ID: <20200925115544.GY9475@nvidia.com> (raw)
In-Reply-To: <20200925071330.GA2280698@unreal>
On Fri, Sep 25, 2020 at 10:13:30AM +0300, Leon Romanovsky wrote:
> > > diff --git a/tools/testing/scatterlist/main.c b/tools/testing/scatterlist/main.c
> > > index 0a1464181226..4899359a31ac 100644
> > > +++ b/tools/testing/scatterlist/main.c
> > > @@ -55,14 +55,13 @@ int main(void)
> > > for (i = 0, test = tests; test->expected_segments; test++, i++) {
> > > struct page *pages[MAX_PAGES];
> > > struct sg_table st;
> > > - int ret;
> > > + struct scatterlist *sg;
> > >
> > > set_pages(pages, test->pfn, test->num_pages);
> > >
> > > - ret = __sg_alloc_table_from_pages(&st, pages, test->num_pages,
> > > - 0, test->size, test->max_seg,
> > > - GFP_KERNEL);
> > > - assert(ret == test->alloc_ret);
> > > + sg = __sg_alloc_table_from_pages(&st, pages, test->num_pages, 0,
> > > + test->size, test->max_seg, NULL, 0, GFP_KERNEL);
> > > + assert(PTR_ERR_OR_ZERO(sg) == test->alloc_ret);
> >
> > Some test coverage for relatively complex code would be very welcomed. Since
> > the testing framework is already there, even if it bit-rotted a bit, but
> > shouldn't be hard to fix.
> >
> > A few tests to check append/grow works as expected, in terms of how the end
> > table looks like given the initial state and some different page patterns
> > added to it. And both crossing and not crossing into sg chaining scenarios.
>
> This function is basic for all RDMA devices and we are pretty confident
> that the old and new flows are tested thoroughly.
Well, since 0-day is reporting that __i915_gem_userptr_alloc_pages is
crashing on this, it probably does need some tests :\
Jason
WARNING: multiple messages have this Message-ID (diff)
From: Jason Gunthorpe <jgg@nvidia.com>
To: Leon Romanovsky <leon@kernel.org>
Cc: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>,
linux-rdma@vger.kernel.org, intel-gfx@lists.freedesktop.org,
Roland Scheidegger <sroland@vmware.com>,
dri-devel@lists.freedesktop.org,
Maor Gottlieb <maorg@mellanox.com>,
David Airlie <airlied@linux.ie>,
Doug Ledford <dledford@redhat.com>,
VMware Graphics <linux-graphics-maintainer@vmware.com>,
Maor Gottlieb <maorg@nvidia.com>, Christoph Hellwig <hch@lst.de>
Subject: Re: [Intel-gfx] [PATCH rdma-next v3 1/2] lib/scatterlist: Add support in dynamic allocation of SG table from pages
Date: Fri, 25 Sep 2020 08:55:44 -0300 [thread overview]
Message-ID: <20200925115544.GY9475@nvidia.com> (raw)
In-Reply-To: <20200925071330.GA2280698@unreal>
On Fri, Sep 25, 2020 at 10:13:30AM +0300, Leon Romanovsky wrote:
> > > diff --git a/tools/testing/scatterlist/main.c b/tools/testing/scatterlist/main.c
> > > index 0a1464181226..4899359a31ac 100644
> > > +++ b/tools/testing/scatterlist/main.c
> > > @@ -55,14 +55,13 @@ int main(void)
> > > for (i = 0, test = tests; test->expected_segments; test++, i++) {
> > > struct page *pages[MAX_PAGES];
> > > struct sg_table st;
> > > - int ret;
> > > + struct scatterlist *sg;
> > >
> > > set_pages(pages, test->pfn, test->num_pages);
> > >
> > > - ret = __sg_alloc_table_from_pages(&st, pages, test->num_pages,
> > > - 0, test->size, test->max_seg,
> > > - GFP_KERNEL);
> > > - assert(ret == test->alloc_ret);
> > > + sg = __sg_alloc_table_from_pages(&st, pages, test->num_pages, 0,
> > > + test->size, test->max_seg, NULL, 0, GFP_KERNEL);
> > > + assert(PTR_ERR_OR_ZERO(sg) == test->alloc_ret);
> >
> > Some test coverage for relatively complex code would be very welcomed. Since
> > the testing framework is already there, even if it bit-rotted a bit, but
> > shouldn't be hard to fix.
> >
> > A few tests to check append/grow works as expected, in terms of how the end
> > table looks like given the initial state and some different page patterns
> > added to it. And both crossing and not crossing into sg chaining scenarios.
>
> This function is basic for all RDMA devices and we are pretty confident
> that the old and new flows are tested thoroughly.
Well, since 0-day is reporting that __i915_gem_userptr_alloc_pages is
crashing on this, it probably does need some tests :\
Jason
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
WARNING: multiple messages have this Message-ID (diff)
From: Jason Gunthorpe <jgg@nvidia.com>
To: Leon Romanovsky <leon@kernel.org>
Cc: linux-rdma@vger.kernel.org, intel-gfx@lists.freedesktop.org,
Roland Scheidegger <sroland@vmware.com>,
dri-devel@lists.freedesktop.org,
Maor Gottlieb <maorg@mellanox.com>,
David Airlie <airlied@linux.ie>,
Doug Ledford <dledford@redhat.com>,
VMware Graphics <linux-graphics-maintainer@vmware.com>,
Maor Gottlieb <maorg@nvidia.com>, Christoph Hellwig <hch@lst.de>
Subject: Re: [Intel-gfx] [PATCH rdma-next v3 1/2] lib/scatterlist: Add support in dynamic allocation of SG table from pages
Date: Fri, 25 Sep 2020 08:55:44 -0300 [thread overview]
Message-ID: <20200925115544.GY9475@nvidia.com> (raw)
In-Reply-To: <20200925071330.GA2280698@unreal>
On Fri, Sep 25, 2020 at 10:13:30AM +0300, Leon Romanovsky wrote:
> > > diff --git a/tools/testing/scatterlist/main.c b/tools/testing/scatterlist/main.c
> > > index 0a1464181226..4899359a31ac 100644
> > > +++ b/tools/testing/scatterlist/main.c
> > > @@ -55,14 +55,13 @@ int main(void)
> > > for (i = 0, test = tests; test->expected_segments; test++, i++) {
> > > struct page *pages[MAX_PAGES];
> > > struct sg_table st;
> > > - int ret;
> > > + struct scatterlist *sg;
> > >
> > > set_pages(pages, test->pfn, test->num_pages);
> > >
> > > - ret = __sg_alloc_table_from_pages(&st, pages, test->num_pages,
> > > - 0, test->size, test->max_seg,
> > > - GFP_KERNEL);
> > > - assert(ret == test->alloc_ret);
> > > + sg = __sg_alloc_table_from_pages(&st, pages, test->num_pages, 0,
> > > + test->size, test->max_seg, NULL, 0, GFP_KERNEL);
> > > + assert(PTR_ERR_OR_ZERO(sg) == test->alloc_ret);
> >
> > Some test coverage for relatively complex code would be very welcomed. Since
> > the testing framework is already there, even if it bit-rotted a bit, but
> > shouldn't be hard to fix.
> >
> > A few tests to check append/grow works as expected, in terms of how the end
> > table looks like given the initial state and some different page patterns
> > added to it. And both crossing and not crossing into sg chaining scenarios.
>
> This function is basic for all RDMA devices and we are pretty confident
> that the old and new flows are tested thoroughly.
Well, since 0-day is reporting that __i915_gem_userptr_alloc_pages is
crashing on this, it probably does need some tests :\
Jason
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2020-09-25 11:56 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-22 8:39 [PATCH rdma-next v3 0/2] Dynamicaly allocate SG table from the pages Leon Romanovsky
2020-09-22 8:39 ` [Intel-gfx] " Leon Romanovsky
2020-09-22 8:39 ` Leon Romanovsky
2020-09-22 8:39 ` [PATCH rdma-next v3 1/2] lib/scatterlist: Add support in dynamic allocation of SG table from pages Leon Romanovsky
2020-09-22 8:39 ` [Intel-gfx] " Leon Romanovsky
2020-09-22 8:39 ` Leon Romanovsky
2020-09-23 5:42 ` Christoph Hellwig
2020-09-23 5:42 ` [Intel-gfx] " Christoph Hellwig
2020-09-24 8:21 ` Tvrtko Ursulin
2020-09-24 8:21 ` Tvrtko Ursulin
2020-09-25 7:13 ` Leon Romanovsky
2020-09-25 7:13 ` Leon Romanovsky
2020-09-25 7:13 ` Leon Romanovsky
2020-09-25 11:41 ` Tvrtko Ursulin
2020-09-25 11:41 ` Tvrtko Ursulin
2020-09-25 11:58 ` Jason Gunthorpe
2020-09-25 11:58 ` Jason Gunthorpe
2020-09-25 11:58 ` Jason Gunthorpe
2020-09-25 12:29 ` Tvrtko Ursulin
2020-09-25 12:29 ` Tvrtko Ursulin
2020-09-25 12:29 ` Tvrtko Ursulin
2020-09-25 12:34 ` Jason Gunthorpe
2020-09-25 12:34 ` Jason Gunthorpe
2020-09-25 12:34 ` Jason Gunthorpe
2020-09-25 12:13 ` Maor Gottlieb
2020-09-25 12:13 ` Maor Gottlieb
2020-09-25 12:13 ` Maor Gottlieb
2020-09-25 11:55 ` Jason Gunthorpe [this message]
2020-09-25 11:55 ` Jason Gunthorpe
2020-09-25 11:55 ` Jason Gunthorpe
2020-09-25 12:18 ` Maor Gottlieb
2020-09-25 12:18 ` Maor Gottlieb
2020-09-25 12:18 ` Maor Gottlieb
2020-09-25 12:33 ` Tvrtko Ursulin
2020-09-25 12:33 ` Tvrtko Ursulin
2020-09-25 12:33 ` Tvrtko Ursulin
2020-09-25 13:39 ` Maor Gottlieb
2020-09-25 13:39 ` Maor Gottlieb
2020-09-25 13:39 ` Maor Gottlieb
2020-09-25 13:54 ` Tvrtko Ursulin
2020-09-25 13:54 ` Tvrtko Ursulin
2020-09-25 13:54 ` Tvrtko Ursulin
2020-09-22 8:39 ` [PATCH rdma-next v3 2/2] RDMA/umem: Move to allocate " Leon Romanovsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200925115544.GY9475@nvidia.com \
--to=jgg@nvidia.com \
--cc=airlied@linux.ie \
--cc=dledford@redhat.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=hch@lst.de \
--cc=intel-gfx@lists.freedesktop.org \
--cc=leon@kernel.org \
--cc=linux-graphics-maintainer@vmware.com \
--cc=linux-rdma@vger.kernel.org \
--cc=maorg@mellanox.com \
--cc=maorg@nvidia.com \
--cc=sroland@vmware.com \
--cc=tvrtko.ursulin@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.