* [PATCH] Documentation/llvm: Fix clang target examples
@ 2020-09-25 15:21 Florian Fainelli
2020-09-25 18:52 ` Nick Desaulniers
2020-09-26 2:11 ` Nathan Chancellor
0 siblings, 2 replies; 4+ messages in thread
From: Florian Fainelli @ 2020-09-25 15:21 UTC (permalink / raw)
To: linux-kernel, linux-kbuild
Cc: Florian Fainelli, Nathan Chancellor, Nick Desaulniers,
Masahiro Yamada, Michal Marek, Jonathan Corbet, Kees Cook,
Sedat Dilek, open list:CLANG/LLVM BUILD SUPPORT,
open list:DOCUMENTATION
clang --target=<triple> is how we can specify a particular toolchain
triple to be use, fix the two occurences in the documentation.
Fixes: fcf1b6a35c16 ("Documentation/llvm: add documentation on building w/ Clang/LLVM")
Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
---
Documentation/kbuild/llvm.rst | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/Documentation/kbuild/llvm.rst b/Documentation/kbuild/llvm.rst
index 334df758dce3..dae90c21aed3 100644
--- a/Documentation/kbuild/llvm.rst
+++ b/Documentation/kbuild/llvm.rst
@@ -39,10 +39,10 @@ which can help simplify cross compiling. ::
ARCH=arm64 CROSS_COMPILE=aarch64-linux-gnu- make CC=clang
``CROSS_COMPILE`` is not used to prefix the Clang compiler binary, instead
-``CROSS_COMPILE`` is used to set a command line flag: ``--target <triple>``. For
+``CROSS_COMPILE`` is used to set a command line flag: ``--target=<triple>``. For
example: ::
- clang --target aarch64-linux-gnu foo.c
+ clang --target=aarch64-linux-gnu foo.c
LLVM Utilities
--------------
--
2.25.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] Documentation/llvm: Fix clang target examples
2020-09-25 15:21 [PATCH] Documentation/llvm: Fix clang target examples Florian Fainelli
@ 2020-09-25 18:52 ` Nick Desaulniers
2020-09-26 4:55 ` Masahiro Yamada
2020-09-26 2:11 ` Nathan Chancellor
1 sibling, 1 reply; 4+ messages in thread
From: Nick Desaulniers @ 2020-09-25 18:52 UTC (permalink / raw)
To: Florian Fainelli, Masahiro Yamada
Cc: LKML, Linux Kbuild mailing list, Nathan Chancellor, Michal Marek,
Jonathan Corbet, Kees Cook, Sedat Dilek,
open list:CLANG/LLVM BUILD SUPPORT, open list:DOCUMENTATION
On Fri, Sep 25, 2020 at 8:21 AM Florian Fainelli <f.fainelli@gmail.com> wrote:
>
> clang --target=<triple> is how we can specify a particular toolchain
> triple to be use, fix the two occurences in the documentation.
Ah right, my mistake. It's either double dash+equals, or single
dash+space. Thanks for the patch. Masahiro, would you mind picking
this up?
Reviewed-by: Nick Desaulniers <ndesaulniers@google.com>
>
> Fixes: fcf1b6a35c16 ("Documentation/llvm: add documentation on building w/ Clang/LLVM")
> Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
> ---
> Documentation/kbuild/llvm.rst | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/kbuild/llvm.rst b/Documentation/kbuild/llvm.rst
> index 334df758dce3..dae90c21aed3 100644
> --- a/Documentation/kbuild/llvm.rst
> +++ b/Documentation/kbuild/llvm.rst
> @@ -39,10 +39,10 @@ which can help simplify cross compiling. ::
> ARCH=arm64 CROSS_COMPILE=aarch64-linux-gnu- make CC=clang
>
> ``CROSS_COMPILE`` is not used to prefix the Clang compiler binary, instead
> -``CROSS_COMPILE`` is used to set a command line flag: ``--target <triple>``. For
> +``CROSS_COMPILE`` is used to set a command line flag: ``--target=<triple>``. For
> example: ::
>
> - clang --target aarch64-linux-gnu foo.c
> + clang --target=aarch64-linux-gnu foo.c
>
> LLVM Utilities
> --------------
> --
> 2.25.1
>
--
Thanks,
~Nick Desaulniers
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] Documentation/llvm: Fix clang target examples
2020-09-25 18:52 ` Nick Desaulniers
@ 2020-09-26 4:55 ` Masahiro Yamada
0 siblings, 0 replies; 4+ messages in thread
From: Masahiro Yamada @ 2020-09-26 4:55 UTC (permalink / raw)
To: Nick Desaulniers
Cc: Florian Fainelli, LKML, Linux Kbuild mailing list,
Nathan Chancellor, Michal Marek, Jonathan Corbet, Kees Cook,
Sedat Dilek, open list:CLANG/LLVM BUILD SUPPORT,
open list:DOCUMENTATION
On Sat, Sep 26, 2020 at 3:52 AM Nick Desaulniers
<ndesaulniers@google.com> wrote:
>
> On Fri, Sep 25, 2020 at 8:21 AM Florian Fainelli <f.fainelli@gmail.com> wrote:
> >
> > clang --target=<triple> is how we can specify a particular toolchain
> > triple to be use, fix the two occurences in the documentation.
>
> Ah right, my mistake. It's either double dash+equals, or single
> dash+space. Thanks for the patch. Masahiro, would you mind picking
> this up?
Sure.
Applied to linux-kbuild/fixes. Thanks.
> Reviewed-by: Nick Desaulniers <ndesaulniers@google.com>
>
> >
> > Fixes: fcf1b6a35c16 ("Documentation/llvm: add documentation on building w/ Clang/LLVM")
> > Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
> > ---
> > Documentation/kbuild/llvm.rst | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/Documentation/kbuild/llvm.rst b/Documentation/kbuild/llvm.rst
> > index 334df758dce3..dae90c21aed3 100644
> > --- a/Documentation/kbuild/llvm.rst
> > +++ b/Documentation/kbuild/llvm.rst
> > @@ -39,10 +39,10 @@ which can help simplify cross compiling. ::
> > ARCH=arm64 CROSS_COMPILE=aarch64-linux-gnu- make CC=clang
> >
> > ``CROSS_COMPILE`` is not used to prefix the Clang compiler binary, instead
> > -``CROSS_COMPILE`` is used to set a command line flag: ``--target <triple>``. For
> > +``CROSS_COMPILE`` is used to set a command line flag: ``--target=<triple>``. For
> > example: ::
> >
> > - clang --target aarch64-linux-gnu foo.c
> > + clang --target=aarch64-linux-gnu foo.c
> >
> > LLVM Utilities
> > --------------
> > --
> > 2.25.1
> >
>
>
> --
> Thanks,
> ~Nick Desaulniers
--
Best Regards
Masahiro Yamada
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] Documentation/llvm: Fix clang target examples
2020-09-25 15:21 [PATCH] Documentation/llvm: Fix clang target examples Florian Fainelli
2020-09-25 18:52 ` Nick Desaulniers
@ 2020-09-26 2:11 ` Nathan Chancellor
1 sibling, 0 replies; 4+ messages in thread
From: Nathan Chancellor @ 2020-09-26 2:11 UTC (permalink / raw)
To: Florian Fainelli
Cc: linux-kernel, linux-kbuild, Nick Desaulniers, Masahiro Yamada,
Michal Marek, Jonathan Corbet, Kees Cook, Sedat Dilek,
open list:CLANG/LLVM BUILD SUPPORT, open list:DOCUMENTATION
On Fri, Sep 25, 2020 at 08:21:14AM -0700, Florian Fainelli wrote:
> clang --target=<triple> is how we can specify a particular toolchain
> triple to be use, fix the two occurences in the documentation.
>
> Fixes: fcf1b6a35c16 ("Documentation/llvm: add documentation on building w/ Clang/LLVM")
> Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
Reviewed-by: Nathan Chancellor <natechancellor@gmail.com>
Thank you for the patch!
> ---
> Documentation/kbuild/llvm.rst | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/kbuild/llvm.rst b/Documentation/kbuild/llvm.rst
> index 334df758dce3..dae90c21aed3 100644
> --- a/Documentation/kbuild/llvm.rst
> +++ b/Documentation/kbuild/llvm.rst
> @@ -39,10 +39,10 @@ which can help simplify cross compiling. ::
> ARCH=arm64 CROSS_COMPILE=aarch64-linux-gnu- make CC=clang
>
> ``CROSS_COMPILE`` is not used to prefix the Clang compiler binary, instead
> -``CROSS_COMPILE`` is used to set a command line flag: ``--target <triple>``. For
> +``CROSS_COMPILE`` is used to set a command line flag: ``--target=<triple>``. For
> example: ::
>
> - clang --target aarch64-linux-gnu foo.c
> + clang --target=aarch64-linux-gnu foo.c
>
> LLVM Utilities
> --------------
> --
> 2.25.1
>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-09-26 4:56 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-09-25 15:21 [PATCH] Documentation/llvm: Fix clang target examples Florian Fainelli
2020-09-25 18:52 ` Nick Desaulniers
2020-09-26 4:55 ` Masahiro Yamada
2020-09-26 2:11 ` Nathan Chancellor
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.