From: Krzysztof Kozlowski <krzk@kernel.org>
To: Randy Dunlap <rdunlap@infradead.org>
Cc: linux-kernel@vger.kernel.org, Kevin Hilman <khilman@baylibre.com>,
linux-amlogic@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
Ulf Hansson <ulf.hansson@linaro.org>,
linux-mmc@vger.kernel.org
Subject: Re: [PATCH] mmc: host: fix depends for MMC_MESON_GX w/ COMPILE_TEST
Date: Fri, 25 Sep 2020 19:04:49 +0200 [thread overview]
Message-ID: <20200925170449.GA18717@kozik-lap> (raw)
In-Reply-To: <20200925164323.29843-1-rdunlap@infradead.org>
On Fri, Sep 25, 2020 at 09:43:23AM -0700, Randy Dunlap wrote:
> Fix build errors for meson-gx-mmc.c when CONFIG_COMMON_CLK is not
> set/enabled. This can happen when COMPILE_TEST is set/enabled.
>
> ERROR: modpost: "clk_divider_ops" [drivers/mmc/host/meson-gx-mmc.ko] undefined!
> ERROR: modpost: "devm_clk_register" [drivers/mmc/host/meson-gx-mmc.ko] undefined!
> ERROR: modpost: "clk_mux_ops" [drivers/mmc/host/meson-gx-mmc.ko] undefined!
> ERROR: modpost: "__clk_get_name" [drivers/mmc/host/meson-gx-mmc.ko] undefined!
>
> Fixes: 54d8454436a2 ("mmc: host: Enable compile testing of multiple drivers")
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Cc: Kevin Hilman <khilman@baylibre.com>
> Cc: linux-amlogic@lists.infradead.org
> Cc: linux-arm-kernel@lists.infradead.org
> Cc: Ulf Hansson <ulf.hansson@linaro.org>
> Cc: linux-mmc@vger.kernel.org
> Cc: Krzysztof Kozlowski <krzk@kernel.org>
> ---
> drivers/mmc/host/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> --- linux-next-20200925.orig/drivers/mmc/host/Kconfig
> +++ linux-next-20200925/drivers/mmc/host/Kconfig
> @@ -425,6 +425,7 @@ config MMC_SDHCI_IPROC
> config MMC_MESON_GX
> tristate "Amlogic S905/GX*/AXG SD/MMC Host Controller support"
> depends on ARCH_MESON|| COMPILE_TEST
> + depends on COMMON_CLK
I received a report from kbuild about this when I posted the patchset
but somehow I was not able to reproduce it... or I skipped this for
reason I do not remember now, my bad.
Anyway, thanks for fixing, looks ok:
Reviewed-by: Krzysztof Kozlowski <krzk@kernel.org>
Also please for the credits (as Kbuild did report it to me):
Reported-by: kernel test robot <lkp@intel.com>
Best regards,
Krzysztof
> help
> This selects support for the Amlogic SD/MMC Host Controller
> found on the S905/GX*/AXG family of SoCs. This controller is
WARNING: multiple messages have this Message-ID (diff)
From: Krzysztof Kozlowski <krzk@kernel.org>
To: Randy Dunlap <rdunlap@infradead.org>
Cc: Ulf Hansson <ulf.hansson@linaro.org>,
Kevin Hilman <khilman@baylibre.com>,
linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-amlogic@lists.infradead.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] mmc: host: fix depends for MMC_MESON_GX w/ COMPILE_TEST
Date: Fri, 25 Sep 2020 19:04:49 +0200 [thread overview]
Message-ID: <20200925170449.GA18717@kozik-lap> (raw)
In-Reply-To: <20200925164323.29843-1-rdunlap@infradead.org>
On Fri, Sep 25, 2020 at 09:43:23AM -0700, Randy Dunlap wrote:
> Fix build errors for meson-gx-mmc.c when CONFIG_COMMON_CLK is not
> set/enabled. This can happen when COMPILE_TEST is set/enabled.
>
> ERROR: modpost: "clk_divider_ops" [drivers/mmc/host/meson-gx-mmc.ko] undefined!
> ERROR: modpost: "devm_clk_register" [drivers/mmc/host/meson-gx-mmc.ko] undefined!
> ERROR: modpost: "clk_mux_ops" [drivers/mmc/host/meson-gx-mmc.ko] undefined!
> ERROR: modpost: "__clk_get_name" [drivers/mmc/host/meson-gx-mmc.ko] undefined!
>
> Fixes: 54d8454436a2 ("mmc: host: Enable compile testing of multiple drivers")
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Cc: Kevin Hilman <khilman@baylibre.com>
> Cc: linux-amlogic@lists.infradead.org
> Cc: linux-arm-kernel@lists.infradead.org
> Cc: Ulf Hansson <ulf.hansson@linaro.org>
> Cc: linux-mmc@vger.kernel.org
> Cc: Krzysztof Kozlowski <krzk@kernel.org>
> ---
> drivers/mmc/host/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> --- linux-next-20200925.orig/drivers/mmc/host/Kconfig
> +++ linux-next-20200925/drivers/mmc/host/Kconfig
> @@ -425,6 +425,7 @@ config MMC_SDHCI_IPROC
> config MMC_MESON_GX
> tristate "Amlogic S905/GX*/AXG SD/MMC Host Controller support"
> depends on ARCH_MESON|| COMPILE_TEST
> + depends on COMMON_CLK
I received a report from kbuild about this when I posted the patchset
but somehow I was not able to reproduce it... or I skipped this for
reason I do not remember now, my bad.
Anyway, thanks for fixing, looks ok:
Reviewed-by: Krzysztof Kozlowski <krzk@kernel.org>
Also please for the credits (as Kbuild did report it to me):
Reported-by: kernel test robot <lkp@intel.com>
Best regards,
Krzysztof
> help
> This selects support for the Amlogic SD/MMC Host Controller
> found on the S905/GX*/AXG family of SoCs. This controller is
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Krzysztof Kozlowski <krzk@kernel.org>
To: Randy Dunlap <rdunlap@infradead.org>
Cc: Ulf Hansson <ulf.hansson@linaro.org>,
Kevin Hilman <khilman@baylibre.com>,
linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-amlogic@lists.infradead.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] mmc: host: fix depends for MMC_MESON_GX w/ COMPILE_TEST
Date: Fri, 25 Sep 2020 19:04:49 +0200 [thread overview]
Message-ID: <20200925170449.GA18717@kozik-lap> (raw)
In-Reply-To: <20200925164323.29843-1-rdunlap@infradead.org>
On Fri, Sep 25, 2020 at 09:43:23AM -0700, Randy Dunlap wrote:
> Fix build errors for meson-gx-mmc.c when CONFIG_COMMON_CLK is not
> set/enabled. This can happen when COMPILE_TEST is set/enabled.
>
> ERROR: modpost: "clk_divider_ops" [drivers/mmc/host/meson-gx-mmc.ko] undefined!
> ERROR: modpost: "devm_clk_register" [drivers/mmc/host/meson-gx-mmc.ko] undefined!
> ERROR: modpost: "clk_mux_ops" [drivers/mmc/host/meson-gx-mmc.ko] undefined!
> ERROR: modpost: "__clk_get_name" [drivers/mmc/host/meson-gx-mmc.ko] undefined!
>
> Fixes: 54d8454436a2 ("mmc: host: Enable compile testing of multiple drivers")
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Cc: Kevin Hilman <khilman@baylibre.com>
> Cc: linux-amlogic@lists.infradead.org
> Cc: linux-arm-kernel@lists.infradead.org
> Cc: Ulf Hansson <ulf.hansson@linaro.org>
> Cc: linux-mmc@vger.kernel.org
> Cc: Krzysztof Kozlowski <krzk@kernel.org>
> ---
> drivers/mmc/host/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> --- linux-next-20200925.orig/drivers/mmc/host/Kconfig
> +++ linux-next-20200925/drivers/mmc/host/Kconfig
> @@ -425,6 +425,7 @@ config MMC_SDHCI_IPROC
> config MMC_MESON_GX
> tristate "Amlogic S905/GX*/AXG SD/MMC Host Controller support"
> depends on ARCH_MESON|| COMPILE_TEST
> + depends on COMMON_CLK
I received a report from kbuild about this when I posted the patchset
but somehow I was not able to reproduce it... or I skipped this for
reason I do not remember now, my bad.
Anyway, thanks for fixing, looks ok:
Reviewed-by: Krzysztof Kozlowski <krzk@kernel.org>
Also please for the credits (as Kbuild did report it to me):
Reported-by: kernel test robot <lkp@intel.com>
Best regards,
Krzysztof
> help
> This selects support for the Amlogic SD/MMC Host Controller
> found on the S905/GX*/AXG family of SoCs. This controller is
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
next prev parent reply other threads:[~2020-09-25 17:04 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-25 16:43 [PATCH] mmc: host: fix depends for MMC_MESON_GX w/ COMPILE_TEST Randy Dunlap
2020-09-25 16:43 ` Randy Dunlap
2020-09-25 16:43 ` Randy Dunlap
2020-09-25 17:04 ` Krzysztof Kozlowski [this message]
2020-09-25 17:04 ` Krzysztof Kozlowski
2020-09-25 17:04 ` Krzysztof Kozlowski
2020-09-28 10:34 ` Ulf Hansson
2020-09-28 10:34 ` Ulf Hansson
2020-09-28 10:34 ` Ulf Hansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200925170449.GA18717@kozik-lap \
--to=krzk@kernel.org \
--cc=khilman@baylibre.com \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=rdunlap@infradead.org \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.