[PATCH] generic/611: remove _supported_os line

[PATCH] generic/611: remove _supported_os line

[Zorro Lang]

The current xfstests doesn't support _supported_os() function, the
generic/611 always hit an error:

  xfstests-dev/tests/generic/611: line 39: _supported_os: command not found

So remove the "_supported_os Linux" line directly.

Signed-off-by: Zorro Lang <zlang@redhat.com>
---
 tests/generic/611 | 1 -
 1 file changed, 1 deletion(-)

diff --git a/tests/generic/611 b/tests/generic/611
index 069db6f9..f4158bb3 100755
--- a/tests/generic/611
+++ b/tests/generic/611
@@ -36,7 +36,6 @@ rm -f $seqres.full
 # real QA test starts here
 
 _supported_fs generic
-_supported_os Linux
 _require_scratch
 _require_attrs
 
-- 
2.20.1

Re: [PATCH] generic/611: remove _supported_os line

[Pavel Reichl]

Hi,

Looks good to me,

Reviewed-by: Pavel Reichl <preichl@redhat.com>

Re: [PATCH] generic/611: remove _supported_os line

[Xiao Yang]

On 2020/9/21 12:31, Zorro Lang wrote:
> The current xfstests doesn't support _supported_os() function, the
> generic/611 always hit an error:
>
>   xfstests-dev/tests/generic/611: line 39: _supported_os: command not found
>
> So remove the "_supported_os Linux" line directly.
Hi Zorro,

It seems better to add a fix tag:
Fixes: a860a167d87a ("common: kill _supported_os")

Other than that it is fine for me. :-)
Reviewed-by: Xiao Yang <yangx.jy@cn.fujitsu.com>

Best Regards,
Xiao Yang
> Signed-off-by: Zorro Lang <zlang@redhat.com>
> ---
>  tests/generic/611 | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/tests/generic/611 b/tests/generic/611
> index 069db6f9..f4158bb3 100755
> --- a/tests/generic/611
> +++ b/tests/generic/611
> @@ -36,7 +36,6 @@ rm -f $seqres.full
>  # real QA test starts here
>  
>  _supported_fs generic
> -_supported_os Linux
>  _require_scratch
>  _require_attrs
>  

Re: [PATCH] generic/611: remove _supported_os line

[Eryu Guan]

On Tue, Sep 22, 2020 at 04:49:34PM +0800, Xiao Yang wrote:
> On 2020/9/21 12:31, Zorro Lang wrote:
> > The current xfstests doesn't support _supported_os() function, the
> > generic/611 always hit an error:
> >
> >   xfstests-dev/tests/generic/611: line 39: _supported_os: command not found
> >
> > So remove the "_supported_os Linux" line directly.
> Hi Zorro,
> 
> It seems better to add a fix tag:
> Fixes: a860a167d87a ("common: kill _supported_os")

Actually it was my fault, not the above commit, I applied the new test
first, then applied above commit, which of cource didn't handle
generic/611..

> 
> Other than that it is fine for me. :-)
> Reviewed-by: Xiao Yang <yangx.jy@cn.fujitsu.com>

Thanks for the fix and review!

Eryu

> 
> Best Regards,
> Xiao Yang
> > Signed-off-by: Zorro Lang <zlang@redhat.com>
> > ---
> >  tests/generic/611 | 1 -
> >  1 file changed, 1 deletion(-)
> >
> > diff --git a/tests/generic/611 b/tests/generic/611
> > index 069db6f9..f4158bb3 100755
> > --- a/tests/generic/611
> > +++ b/tests/generic/611
> > @@ -36,7 +36,6 @@ rm -f $seqres.full
> >  # real QA test starts here
> >  
> >  _supported_fs generic
> > -_supported_os Linux
> >  _require_scratch
> >  _require_attrs
> >  
> 
>