* [PATCH] hw/usb: Use lock guard macros
@ 2020-09-23 13:43 Amey Narkhede
2020-09-23 14:39 ` Philippe Mathieu-Daudé
2020-09-28 13:15 ` Gerd Hoffmann
0 siblings, 2 replies; 3+ messages in thread
From: Amey Narkhede @ 2020-09-23 13:43 UTC (permalink / raw)
To: qemu-devel; +Cc: Amey Narkhede, Gerd Hoffmann
Use qemu LOCK_GUARD macros from "qemu/lockable.h" in
hw/usb/ccid-card-emulated.c, saves manual unlock calls.
Signed-off-by: Amey Narkhede <ameynarkhede03@gmail.com>
---
hw/usb/ccid-card-emulated.c | 54 ++++++++++++++++++-------------------
1 file changed, 27 insertions(+), 27 deletions(-)
diff --git a/hw/usb/ccid-card-emulated.c b/hw/usb/ccid-card-emulated.c
index 3083124556..7ee3563f89 100644
--- a/hw/usb/ccid-card-emulated.c
+++ b/hw/usb/ccid-card-emulated.c
@@ -30,6 +30,7 @@
#include <libcacard.h>
#include "qemu/thread.h"
+#include "qemu/lockable.h"
#include "qemu/main-loop.h"
#include "qemu/module.h"
#include "ccid.h"
@@ -243,34 +244,34 @@ static void *handle_apdu_thread(void* arg)
card->quit_apdu_thread = 0; /* debugging */
break;
}
- qemu_mutex_lock(&card->vreader_mutex);
- while (!QSIMPLEQ_EMPTY(&card->guest_apdu_list)) {
- event = QSIMPLEQ_FIRST(&card->guest_apdu_list);
- assert((unsigned long)event > 1000);
- QSIMPLEQ_REMOVE_HEAD(&card->guest_apdu_list, entry);
- if (event->p.data.type != EMUL_GUEST_APDU) {
- DPRINTF(card, 1, "unexpected message in handle_apdu_thread\n");
- g_free(event);
- continue;
- }
- if (card->reader == NULL) {
- DPRINTF(card, 1, "reader is NULL\n");
+ WITH_QEMU_LOCK_GUARD(&card->vreader_mutex) {
+ while (!QSIMPLEQ_EMPTY(&card->guest_apdu_list)) {
+ event = QSIMPLEQ_FIRST(&card->guest_apdu_list);
+ assert((unsigned long)event > 1000);
+ QSIMPLEQ_REMOVE_HEAD(&card->guest_apdu_list, entry);
+ if (event->p.data.type != EMUL_GUEST_APDU) {
+ DPRINTF(card, 1, "unexpected message in handle_apdu_thread\n");
+ g_free(event);
+ continue;
+ }
+ if (card->reader == NULL) {
+ DPRINTF(card, 1, "reader is NULL\n");
+ g_free(event);
+ continue;
+ }
+ recv_len = sizeof(recv_data);
+ reader_status = vreader_xfr_bytes(card->reader,
+ event->p.data.data, event->p.data.len,
+ recv_data, &recv_len);
+ DPRINTF(card, 2, "got back apdu of length %d\n", recv_len);
+ if (reader_status == VREADER_OK) {
+ emulated_push_response_apdu(card, recv_data, recv_len);
+ } else {
+ emulated_push_error(card, reader_status);
+ }
g_free(event);
- continue;
}
- recv_len = sizeof(recv_data);
- reader_status = vreader_xfr_bytes(card->reader,
- event->p.data.data, event->p.data.len,
- recv_data, &recv_len);
- DPRINTF(card, 2, "got back apdu of length %d\n", recv_len);
- if (reader_status == VREADER_OK) {
- emulated_push_response_apdu(card, recv_data, recv_len);
- } else {
- emulated_push_error(card, reader_status);
- }
- g_free(event);
}
- qemu_mutex_unlock(&card->vreader_mutex);
}
return NULL;
}
@@ -365,7 +366,7 @@ static void card_event_handler(EventNotifier *notifier)
EmulEvent *event, *next;
event_notifier_test_and_clear(&card->notifier);
- qemu_mutex_lock(&card->event_list_mutex);
+ QEMU_LOCK_GUARD(&card->event_list_mutex);
QSIMPLEQ_FOREACH_SAFE(event, &card->event_list, entry, next) {
DPRINTF(card, 2, "event %s\n", emul_event_to_string(event->p.gen.type));
switch (event->p.gen.type) {
@@ -398,7 +399,6 @@ static void card_event_handler(EventNotifier *notifier)
g_free(event);
}
QSIMPLEQ_INIT(&card->event_list);
- qemu_mutex_unlock(&card->event_list_mutex);
}
static int init_event_notifier(EmulatedState *card, Error **errp)
--
2.28.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] hw/usb: Use lock guard macros
2020-09-23 13:43 [PATCH] hw/usb: Use lock guard macros Amey Narkhede
@ 2020-09-23 14:39 ` Philippe Mathieu-Daudé
2020-09-28 13:15 ` Gerd Hoffmann
1 sibling, 0 replies; 3+ messages in thread
From: Philippe Mathieu-Daudé @ 2020-09-23 14:39 UTC (permalink / raw)
To: Amey Narkhede, qemu-devel; +Cc: Gerd Hoffmann
On 9/23/20 3:43 PM, Amey Narkhede wrote:
> Use qemu LOCK_GUARD macros from "qemu/lockable.h" in
> hw/usb/ccid-card-emulated.c, saves manual unlock calls.
>
> Signed-off-by: Amey Narkhede <ameynarkhede03@gmail.com>
> ---
> hw/usb/ccid-card-emulated.c | 54 ++++++++++++++++++-------------------
> 1 file changed, 27 insertions(+), 27 deletions(-)
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] hw/usb: Use lock guard macros
2020-09-23 13:43 [PATCH] hw/usb: Use lock guard macros Amey Narkhede
2020-09-23 14:39 ` Philippe Mathieu-Daudé
@ 2020-09-28 13:15 ` Gerd Hoffmann
1 sibling, 0 replies; 3+ messages in thread
From: Gerd Hoffmann @ 2020-09-28 13:15 UTC (permalink / raw)
To: Amey Narkhede; +Cc: qemu-devel
On Wed, Sep 23, 2020 at 07:13:27PM +0530, Amey Narkhede wrote:
> Use qemu LOCK_GUARD macros from "qemu/lockable.h" in
> hw/usb/ccid-card-emulated.c, saves manual unlock calls.
>
> Signed-off-by: Amey Narkhede <ameynarkhede03@gmail.com>
Added to usb queue.
thanks,
Gerd
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-09-28 13:28 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-09-23 13:43 [PATCH] hw/usb: Use lock guard macros Amey Narkhede
2020-09-23 14:39 ` Philippe Mathieu-Daudé
2020-09-28 13:15 ` Gerd Hoffmann
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.