* + fs_parse-mark-fs_param_bad_value-as-static.patch added to -mm tree
@ 2020-09-28 23:38 akpm
0 siblings, 0 replies; only message in thread
From: akpm @ 2020-09-28 23:38 UTC (permalink / raw)
To: luojiaxing, mm-commits
The patch titled
Subject: fs_parse: mark fs_param_bad_value() as static
has been added to the -mm tree. Its filename is
fs_parse-mark-fs_param_bad_value-as-static.patch
This patch should soon appear at
https://ozlabs.org/~akpm/mmots/broken-out/fs_parse-mark-fs_param_bad_value-as-static.patch
and later at
https://ozlabs.org/~akpm/mmotm/broken-out/fs_parse-mark-fs_param_bad_value-as-static.patch
Before you just go and hit "reply", please:
a) Consider who else should be cc'ed
b) Prefer to cc a suitable mailing list as well
c) Ideally: find the original patch on the mailing list and do a
reply-to-all to that, adding suitable additional cc's
*** Remember to use Documentation/process/submit-checklist.rst when testing your code ***
The -mm tree is included into linux-next and is updated
there every 3-4 working days
------------------------------------------------------
From: Luo Jiaxing <luojiaxing@huawei.com>
Subject: fs_parse: mark fs_param_bad_value() as static
We found the following warning when build kernel with W=1:
fs/fs_parser.c:192:5: warning: no previous prototype for `fs_param_bad_value' [-Wmissing-prototypes]
int fs_param_bad_value(struct p_log *log, struct fs_parameter *param)
^
CC drivers/usb/gadget/udc/snps_udc_core.o
And no header file define a prototype for this function, so we should mark
it as static.
Link: https://lkml.kernel.org/r/1601293463-25763-1-git-send-email-luojiaxing@huawei.com
Signed-off-by: Luo Jiaxing <luojiaxing@huawei.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---
fs/fs_parser.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- a/fs/fs_parser.c~fs_parse-mark-fs_param_bad_value-as-static
+++ a/fs/fs_parser.c
@@ -189,7 +189,7 @@ out:
}
EXPORT_SYMBOL(fs_lookup_param);
-int fs_param_bad_value(struct p_log *log, struct fs_parameter *param)
+static int fs_param_bad_value(struct p_log *log, struct fs_parameter *param)
{
return inval_plog(log, "Bad value for '%s'", param->key);
}
_
Patches currently in -mm which might be from luojiaxing@huawei.com are
fs_parse-mark-fs_param_bad_value-as-static.patch
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2020-09-28 23:38 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-09-28 23:38 + fs_parse-mark-fs_param_bad_value-as-static.patch added to -mm tree akpm
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.