All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Michael S. Tsirkin" <mst@redhat.com>
To: Eli Cohen <elic@nvidia.com>
Cc: Leon Romanovsky <leonro@nvidia.com>,
	Randy Dunlap <rdunlap@infradead.org>,
	virtualization@lists.linux-foundation.org,
	LKML <linux-kernel@vger.kernel.org>,
	"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
	Jason Wang <jasowang@redhat.com>,
	Saeed Mahameed <saeedm@nvidia.com>
Subject: Re: [PATCH v3 -next] vdpa: mlx5: change Kconfig depends to fix build errors
Date: Tue, 29 Sep 2020 02:10:53 -0400	[thread overview]
Message-ID: <20200929021030-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <20200929060142.GA120395@mtl-vdi-166.wap.labs.mlnx>

On Tue, Sep 29, 2020 at 09:01:42AM +0300, Eli Cohen wrote:
> On Fri, Sep 25, 2020 at 06:20:45AM -0400, Michael S. Tsirkin wrote:
> > > > 
> > > > Hmm other drivers select VHOST_IOTLB, why not do the same?
> > > 
> > > I can't see another driver doing that.
> > 
> > Well grep VHOST_IOTLB and you will see some examples.
> 
> $ git grep -wn VHOST_IOTLB
> drivers/vhost/Kconfig:2:config VHOST_IOTLB
> drivers/vhost/Kconfig:11:       select VHOST_IOTLB
> drivers/vhost/Kconfig:18:       select VHOST_IOTLB
> 
> What am I missing here?

Nothing, there's a select here as expected.

> > > Perhaps I can set dependency on
> > > VHOST which by itself depends on VHOST_IOTLB?
> > 
> > VHOST is processing virtio in the kernel. You don't really need that
> > for mlx, do you?
> > 
> > > > 
> > > > 
> > > > > >  	help
> > > > > >  	  Support library for Mellanox VDPA drivers. Provides code that is
> > > > > >
> > > > 
> > 


WARNING: multiple messages have this Message-ID (diff)
From: "Michael S. Tsirkin" <mst@redhat.com>
To: Eli Cohen <elic@nvidia.com>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
	Randy Dunlap <rdunlap@infradead.org>,
	LKML <linux-kernel@vger.kernel.org>,
	virtualization@lists.linux-foundation.org,
	Leon Romanovsky <leonro@nvidia.com>,
	Saeed Mahameed <saeedm@nvidia.com>
Subject: Re: [PATCH v3 -next] vdpa: mlx5: change Kconfig depends to fix build errors
Date: Tue, 29 Sep 2020 02:10:53 -0400	[thread overview]
Message-ID: <20200929021030-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <20200929060142.GA120395@mtl-vdi-166.wap.labs.mlnx>

On Tue, Sep 29, 2020 at 09:01:42AM +0300, Eli Cohen wrote:
> On Fri, Sep 25, 2020 at 06:20:45AM -0400, Michael S. Tsirkin wrote:
> > > > 
> > > > Hmm other drivers select VHOST_IOTLB, why not do the same?
> > > 
> > > I can't see another driver doing that.
> > 
> > Well grep VHOST_IOTLB and you will see some examples.
> 
> $ git grep -wn VHOST_IOTLB
> drivers/vhost/Kconfig:2:config VHOST_IOTLB
> drivers/vhost/Kconfig:11:       select VHOST_IOTLB
> drivers/vhost/Kconfig:18:       select VHOST_IOTLB
> 
> What am I missing here?

Nothing, there's a select here as expected.

> > > Perhaps I can set dependency on
> > > VHOST which by itself depends on VHOST_IOTLB?
> > 
> > VHOST is processing virtio in the kernel. You don't really need that
> > for mlx, do you?
> > 
> > > > 
> > > > 
> > > > > >  	help
> > > > > >  	  Support library for Mellanox VDPA drivers. Provides code that is
> > > > > >
> > > > 
> > 

_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization

  reply	other threads:[~2020-09-29  6:11 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-18  2:35 [PATCH v3 -next] vdpa: mlx5: change Kconfig depends to fix build errors Randy Dunlap
2020-09-18  2:35 ` Randy Dunlap
2020-09-18  8:22 ` Leon Romanovsky
2020-09-24  9:30   ` Michael S. Tsirkin
2020-09-24  9:30     ` Michael S. Tsirkin
2020-09-24 10:24     ` Eli Cohen
2020-09-24 15:47       ` Randy Dunlap
2020-09-24 15:47         ` Randy Dunlap
2020-09-24 16:02         ` Michael S. Tsirkin
2020-09-24 16:02           ` Michael S. Tsirkin
2020-09-25  7:20           ` Leon Romanovsky
2020-09-25 10:19             ` Michael S. Tsirkin
2020-09-25 10:19               ` Michael S. Tsirkin
2020-09-25 11:29               ` Jason Wang
2020-09-25 11:29                 ` Jason Wang
2020-09-26  6:53                 ` Leon Romanovsky
2020-09-29  7:47         ` Michael S. Tsirkin
2020-09-29  7:47           ` Michael S. Tsirkin
2020-09-25 10:20       ` Michael S. Tsirkin
2020-09-25 10:20         ` Michael S. Tsirkin
2020-09-29  6:01         ` Eli Cohen
2020-09-29  6:10           ` Michael S. Tsirkin [this message]
2020-09-29  6:10             ` Michael S. Tsirkin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200929021030-mutt-send-email-mst@kernel.org \
    --to=mst@redhat.com \
    --cc=elic@nvidia.com \
    --cc=jasowang@redhat.com \
    --cc=leonro@nvidia.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=rdunlap@infradead.org \
    --cc=saeedm@nvidia.com \
    --cc=virtualization@lists.linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.