* [PATCH v1 0/2] drm/rockchip: fix build + warning
@ 2020-09-25 21:55 ` Sam Ravnborg
0 siblings, 0 replies; 28+ messages in thread
From: Sam Ravnborg @ 2020-09-25 21:55 UTC (permalink / raw)
To: dri-devel, Heiko Stuebner, Thomas Zimmermann
Cc: Enric Balletbo i Serra, linux-arm-kernel, linux-rockchip,
Sandy Huang, stable, Sam Ravnborg
Fix a newly introduced build breakge in drm-misc-next
Patch 1/2 should be applied to drm-misc-next
Also fix a warning in the same driver - the warning is present in v5.8
Patch 2/2 is a drm-misc-fixes candidate
Sam
Sam Ravnborg (2):
drm/rockchip: fix build due to undefined drm_gem_cma_vm_ops
drm/rockchip: fix warning from cdn_dp_resume
drivers/gpu/drm/rockchip/cdn-dp-core.c | 2 +-
drivers/gpu/drm/rockchip/rockchip_drm_gem.c | 1 +
2 files changed, 2 insertions(+), 1 deletion(-)
^ permalink raw reply [flat|nested] 28+ messages in thread
* [PATCH v1 0/2] drm/rockchip: fix build + warning
@ 2020-09-25 21:55 ` Sam Ravnborg
0 siblings, 0 replies; 28+ messages in thread
From: Sam Ravnborg @ 2020-09-25 21:55 UTC (permalink / raw)
To: dri-devel, Heiko Stuebner, Thomas Zimmermann
Cc: Sandy Huang, stable, linux-rockchip, Enric Balletbo i Serra,
Sam Ravnborg, linux-arm-kernel
Fix a newly introduced build breakge in drm-misc-next
Patch 1/2 should be applied to drm-misc-next
Also fix a warning in the same driver - the warning is present in v5.8
Patch 2/2 is a drm-misc-fixes candidate
Sam
Sam Ravnborg (2):
drm/rockchip: fix build due to undefined drm_gem_cma_vm_ops
drm/rockchip: fix warning from cdn_dp_resume
drivers/gpu/drm/rockchip/cdn-dp-core.c | 2 +-
drivers/gpu/drm/rockchip/rockchip_drm_gem.c | 1 +
2 files changed, 2 insertions(+), 1 deletion(-)
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
^ permalink raw reply [flat|nested] 28+ messages in thread
* [PATCH v1 0/2] drm/rockchip: fix build + warning
@ 2020-09-25 21:55 ` Sam Ravnborg
0 siblings, 0 replies; 28+ messages in thread
From: Sam Ravnborg @ 2020-09-25 21:55 UTC (permalink / raw)
To: dri-devel, Heiko Stuebner, Thomas Zimmermann
Cc: Sandy Huang, stable, linux-rockchip, Enric Balletbo i Serra,
Sam Ravnborg, linux-arm-kernel
Fix a newly introduced build breakge in drm-misc-next
Patch 1/2 should be applied to drm-misc-next
Also fix a warning in the same driver - the warning is present in v5.8
Patch 2/2 is a drm-misc-fixes candidate
Sam
Sam Ravnborg (2):
drm/rockchip: fix build due to undefined drm_gem_cma_vm_ops
drm/rockchip: fix warning from cdn_dp_resume
drivers/gpu/drm/rockchip/cdn-dp-core.c | 2 +-
drivers/gpu/drm/rockchip/rockchip_drm_gem.c | 1 +
2 files changed, 2 insertions(+), 1 deletion(-)
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 28+ messages in thread
* [PATCH v1 0/2] drm/rockchip: fix build + warning
@ 2020-09-25 21:55 ` Sam Ravnborg
0 siblings, 0 replies; 28+ messages in thread
From: Sam Ravnborg @ 2020-09-25 21:55 UTC (permalink / raw)
To: dri-devel, Heiko Stuebner, Thomas Zimmermann
Cc: Sandy Huang, stable, linux-rockchip, Enric Balletbo i Serra,
Sam Ravnborg, linux-arm-kernel
Fix a newly introduced build breakge in drm-misc-next
Patch 1/2 should be applied to drm-misc-next
Also fix a warning in the same driver - the warning is present in v5.8
Patch 2/2 is a drm-misc-fixes candidate
Sam
Sam Ravnborg (2):
drm/rockchip: fix build due to undefined drm_gem_cma_vm_ops
drm/rockchip: fix warning from cdn_dp_resume
drivers/gpu/drm/rockchip/cdn-dp-core.c | 2 +-
drivers/gpu/drm/rockchip/rockchip_drm_gem.c | 1 +
2 files changed, 2 insertions(+), 1 deletion(-)
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 28+ messages in thread
* [PATCH v1 1/2] drm/rockchip: fix build due to undefined drm_gem_cma_vm_ops
2020-09-25 21:55 ` Sam Ravnborg
(?)
(?)
@ 2020-09-25 21:55 ` Sam Ravnborg
-1 siblings, 0 replies; 28+ messages in thread
From: Sam Ravnborg @ 2020-09-25 21:55 UTC (permalink / raw)
To: dri-devel, Heiko Stuebner, Thomas Zimmermann
Cc: Enric Balletbo i Serra, linux-arm-kernel, linux-rockchip,
Sandy Huang, stable, Sam Ravnborg
Commit 0d590af3140d ("drm/rockchip: Convert to drm_gem_object_funcs")
introduced the following build error:
rockchip_drm_gem.c:304:13: error: ‘drm_gem_cma_vm_ops’ undeclared here
304 | .vm_ops = &drm_gem_cma_vm_ops,
| ^~~~~~~~~~~~~~~~~~
| drm_gem_mmap_obj
Fixed by adding missing include file.
Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
Cc: Thomas Zimmermann <tzimmermann@suse.de>
Cc: Sandy Huang <hjc@rock-chips.com>
Cc: "Heiko Stübner" <heiko@sntech.de>
Cc: linux-arm-kernel@lists.infradead.org
Cc: linux-rockchip@lists.infradead.org
---
drivers/gpu/drm/rockchip/rockchip_drm_gem.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_gem.c b/drivers/gpu/drm/rockchip/rockchip_drm_gem.c
index bb3578469b03..6da15faf0192 100644
--- a/drivers/gpu/drm/rockchip/rockchip_drm_gem.c
+++ b/drivers/gpu/drm/rockchip/rockchip_drm_gem.c
@@ -10,6 +10,7 @@
#include <drm/drm.h>
#include <drm/drm_gem.h>
+#include <drm/drm_gem_cma_helper.h>
#include <drm/drm_prime.h>
#include <drm/drm_vma_manager.h>
--
2.25.1
^ permalink raw reply related [flat|nested] 28+ messages in thread
* [PATCH v1 1/2] drm/rockchip: fix build due to undefined drm_gem_cma_vm_ops
@ 2020-09-25 21:55 ` Sam Ravnborg
0 siblings, 0 replies; 28+ messages in thread
From: Sam Ravnborg @ 2020-09-25 21:55 UTC (permalink / raw)
To: dri-devel, Heiko Stuebner, Thomas Zimmermann
Cc: Sandy Huang, stable, linux-rockchip, Enric Balletbo i Serra,
Sam Ravnborg, linux-arm-kernel
Commit 0d590af3140d ("drm/rockchip: Convert to drm_gem_object_funcs")
introduced the following build error:
rockchip_drm_gem.c:304:13: error: ‘drm_gem_cma_vm_ops’ undeclared here
304 | .vm_ops = &drm_gem_cma_vm_ops,
| ^~~~~~~~~~~~~~~~~~
| drm_gem_mmap_obj
Fixed by adding missing include file.
Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
Cc: Thomas Zimmermann <tzimmermann@suse.de>
Cc: Sandy Huang <hjc@rock-chips.com>
Cc: "Heiko Stübner" <heiko@sntech.de>
Cc: linux-arm-kernel@lists.infradead.org
Cc: linux-rockchip@lists.infradead.org
---
drivers/gpu/drm/rockchip/rockchip_drm_gem.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_gem.c b/drivers/gpu/drm/rockchip/rockchip_drm_gem.c
index bb3578469b03..6da15faf0192 100644
--- a/drivers/gpu/drm/rockchip/rockchip_drm_gem.c
+++ b/drivers/gpu/drm/rockchip/rockchip_drm_gem.c
@@ -10,6 +10,7 @@
#include <drm/drm.h>
#include <drm/drm_gem.h>
+#include <drm/drm_gem_cma_helper.h>
#include <drm/drm_prime.h>
#include <drm/drm_vma_manager.h>
--
2.25.1
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
^ permalink raw reply related [flat|nested] 28+ messages in thread
* [PATCH v1 1/2] drm/rockchip: fix build due to undefined drm_gem_cma_vm_ops
@ 2020-09-25 21:55 ` Sam Ravnborg
0 siblings, 0 replies; 28+ messages in thread
From: Sam Ravnborg @ 2020-09-25 21:55 UTC (permalink / raw)
To: dri-devel, Heiko Stuebner, Thomas Zimmermann
Cc: Sandy Huang, stable, linux-rockchip, Enric Balletbo i Serra,
Sam Ravnborg, linux-arm-kernel
Commit 0d590af3140d ("drm/rockchip: Convert to drm_gem_object_funcs")
introduced the following build error:
rockchip_drm_gem.c:304:13: error: ‘drm_gem_cma_vm_ops’ undeclared here
304 | .vm_ops = &drm_gem_cma_vm_ops,
| ^~~~~~~~~~~~~~~~~~
| drm_gem_mmap_obj
Fixed by adding missing include file.
Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
Cc: Thomas Zimmermann <tzimmermann@suse.de>
Cc: Sandy Huang <hjc@rock-chips.com>
Cc: "Heiko Stübner" <heiko@sntech.de>
Cc: linux-arm-kernel@lists.infradead.org
Cc: linux-rockchip@lists.infradead.org
---
drivers/gpu/drm/rockchip/rockchip_drm_gem.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_gem.c b/drivers/gpu/drm/rockchip/rockchip_drm_gem.c
index bb3578469b03..6da15faf0192 100644
--- a/drivers/gpu/drm/rockchip/rockchip_drm_gem.c
+++ b/drivers/gpu/drm/rockchip/rockchip_drm_gem.c
@@ -10,6 +10,7 @@
#include <drm/drm.h>
#include <drm/drm_gem.h>
+#include <drm/drm_gem_cma_helper.h>
#include <drm/drm_prime.h>
#include <drm/drm_vma_manager.h>
--
2.25.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 28+ messages in thread
* [PATCH v1 1/2] drm/rockchip: fix build due to undefined drm_gem_cma_vm_ops
@ 2020-09-25 21:55 ` Sam Ravnborg
0 siblings, 0 replies; 28+ messages in thread
From: Sam Ravnborg @ 2020-09-25 21:55 UTC (permalink / raw)
To: dri-devel, Heiko Stuebner, Thomas Zimmermann
Cc: Sandy Huang, stable, linux-rockchip, Enric Balletbo i Serra,
Sam Ravnborg, linux-arm-kernel
Commit 0d590af3140d ("drm/rockchip: Convert to drm_gem_object_funcs")
introduced the following build error:
rockchip_drm_gem.c:304:13: error: ‘drm_gem_cma_vm_ops’ undeclared here
304 | .vm_ops = &drm_gem_cma_vm_ops,
| ^~~~~~~~~~~~~~~~~~
| drm_gem_mmap_obj
Fixed by adding missing include file.
Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
Cc: Thomas Zimmermann <tzimmermann@suse.de>
Cc: Sandy Huang <hjc@rock-chips.com>
Cc: "Heiko Stübner" <heiko@sntech.de>
Cc: linux-arm-kernel@lists.infradead.org
Cc: linux-rockchip@lists.infradead.org
---
drivers/gpu/drm/rockchip/rockchip_drm_gem.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_gem.c b/drivers/gpu/drm/rockchip/rockchip_drm_gem.c
index bb3578469b03..6da15faf0192 100644
--- a/drivers/gpu/drm/rockchip/rockchip_drm_gem.c
+++ b/drivers/gpu/drm/rockchip/rockchip_drm_gem.c
@@ -10,6 +10,7 @@
#include <drm/drm.h>
#include <drm/drm_gem.h>
+#include <drm/drm_gem_cma_helper.h>
#include <drm/drm_prime.h>
#include <drm/drm_vma_manager.h>
--
2.25.1
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 28+ messages in thread
* [PATCH v1 2/2] drm/rockchip: fix warning from cdn_dp_resume
2020-09-25 21:55 ` Sam Ravnborg
(?)
(?)
@ 2020-09-25 21:55 ` Sam Ravnborg
-1 siblings, 0 replies; 28+ messages in thread
From: Sam Ravnborg @ 2020-09-25 21:55 UTC (permalink / raw)
To: dri-devel, Heiko Stuebner, Thomas Zimmermann
Cc: Enric Balletbo i Serra, linux-arm-kernel, linux-rockchip,
Sandy Huang, stable, Sam Ravnborg
Commit 7c49abb4c2f8 ("drm/rockchip: cdn-dp-core: Make cdn_dp_core_suspend/resume static")
introduced the following warning in some builds:
cdn-dp-core.c:1124:12: warning: ‘cdn_dp_resume’ defined but not used
1124 | static int cdn_dp_resume(struct device *dev)
| ^~~~~~~~~~~~~
Fix this by defining cdn_dp_resume __maybe_unused
Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
Fixes: 7c49abb4c2f8 ("drm/rockchip: cdn-dp-core: Make cdn_dp_core_suspend/resume static")
Cc: Enric Balletbo i Serra <enric.balletbo@collabora.com>
Cc: Heiko Stuebner <heiko@sntech.de>
Cc: Sandy Huang <hjc@rock-chips.com>
Cc: linux-arm-kernel@lists.infradead.org
Cc: linux-rockchip@lists.infradead.org
Cc: <stable@vger.kernel.org> # v5.8+
---
drivers/gpu/drm/rockchip/cdn-dp-core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/rockchip/cdn-dp-core.c b/drivers/gpu/drm/rockchip/cdn-dp-core.c
index a4a45daf93f2..1162e321aaed 100644
--- a/drivers/gpu/drm/rockchip/cdn-dp-core.c
+++ b/drivers/gpu/drm/rockchip/cdn-dp-core.c
@@ -1121,7 +1121,7 @@ static int cdn_dp_suspend(struct device *dev)
return ret;
}
-static int cdn_dp_resume(struct device *dev)
+static int __maybe_unused cdn_dp_resume(struct device *dev)
{
struct cdn_dp_device *dp = dev_get_drvdata(dev);
--
2.25.1
^ permalink raw reply related [flat|nested] 28+ messages in thread
* [PATCH v1 2/2] drm/rockchip: fix warning from cdn_dp_resume
@ 2020-09-25 21:55 ` Sam Ravnborg
0 siblings, 0 replies; 28+ messages in thread
From: Sam Ravnborg @ 2020-09-25 21:55 UTC (permalink / raw)
To: dri-devel, Heiko Stuebner, Thomas Zimmermann
Cc: Sandy Huang, stable, linux-rockchip, Enric Balletbo i Serra,
Sam Ravnborg, linux-arm-kernel
Commit 7c49abb4c2f8 ("drm/rockchip: cdn-dp-core: Make cdn_dp_core_suspend/resume static")
introduced the following warning in some builds:
cdn-dp-core.c:1124:12: warning: ‘cdn_dp_resume’ defined but not used
1124 | static int cdn_dp_resume(struct device *dev)
| ^~~~~~~~~~~~~
Fix this by defining cdn_dp_resume __maybe_unused
Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
Fixes: 7c49abb4c2f8 ("drm/rockchip: cdn-dp-core: Make cdn_dp_core_suspend/resume static")
Cc: Enric Balletbo i Serra <enric.balletbo@collabora.com>
Cc: Heiko Stuebner <heiko@sntech.de>
Cc: Sandy Huang <hjc@rock-chips.com>
Cc: linux-arm-kernel@lists.infradead.org
Cc: linux-rockchip@lists.infradead.org
Cc: <stable@vger.kernel.org> # v5.8+
---
drivers/gpu/drm/rockchip/cdn-dp-core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/rockchip/cdn-dp-core.c b/drivers/gpu/drm/rockchip/cdn-dp-core.c
index a4a45daf93f2..1162e321aaed 100644
--- a/drivers/gpu/drm/rockchip/cdn-dp-core.c
+++ b/drivers/gpu/drm/rockchip/cdn-dp-core.c
@@ -1121,7 +1121,7 @@ static int cdn_dp_suspend(struct device *dev)
return ret;
}
-static int cdn_dp_resume(struct device *dev)
+static int __maybe_unused cdn_dp_resume(struct device *dev)
{
struct cdn_dp_device *dp = dev_get_drvdata(dev);
--
2.25.1
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
^ permalink raw reply related [flat|nested] 28+ messages in thread
* [PATCH v1 2/2] drm/rockchip: fix warning from cdn_dp_resume
@ 2020-09-25 21:55 ` Sam Ravnborg
0 siblings, 0 replies; 28+ messages in thread
From: Sam Ravnborg @ 2020-09-25 21:55 UTC (permalink / raw)
To: dri-devel, Heiko Stuebner, Thomas Zimmermann
Cc: Sandy Huang, stable, linux-rockchip, Enric Balletbo i Serra,
Sam Ravnborg, linux-arm-kernel
Commit 7c49abb4c2f8 ("drm/rockchip: cdn-dp-core: Make cdn_dp_core_suspend/resume static")
introduced the following warning in some builds:
cdn-dp-core.c:1124:12: warning: ‘cdn_dp_resume’ defined but not used
1124 | static int cdn_dp_resume(struct device *dev)
| ^~~~~~~~~~~~~
Fix this by defining cdn_dp_resume __maybe_unused
Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
Fixes: 7c49abb4c2f8 ("drm/rockchip: cdn-dp-core: Make cdn_dp_core_suspend/resume static")
Cc: Enric Balletbo i Serra <enric.balletbo@collabora.com>
Cc: Heiko Stuebner <heiko@sntech.de>
Cc: Sandy Huang <hjc@rock-chips.com>
Cc: linux-arm-kernel@lists.infradead.org
Cc: linux-rockchip@lists.infradead.org
Cc: <stable@vger.kernel.org> # v5.8+
---
drivers/gpu/drm/rockchip/cdn-dp-core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/rockchip/cdn-dp-core.c b/drivers/gpu/drm/rockchip/cdn-dp-core.c
index a4a45daf93f2..1162e321aaed 100644
--- a/drivers/gpu/drm/rockchip/cdn-dp-core.c
+++ b/drivers/gpu/drm/rockchip/cdn-dp-core.c
@@ -1121,7 +1121,7 @@ static int cdn_dp_suspend(struct device *dev)
return ret;
}
-static int cdn_dp_resume(struct device *dev)
+static int __maybe_unused cdn_dp_resume(struct device *dev)
{
struct cdn_dp_device *dp = dev_get_drvdata(dev);
--
2.25.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 28+ messages in thread
* [PATCH v1 2/2] drm/rockchip: fix warning from cdn_dp_resume
@ 2020-09-25 21:55 ` Sam Ravnborg
0 siblings, 0 replies; 28+ messages in thread
From: Sam Ravnborg @ 2020-09-25 21:55 UTC (permalink / raw)
To: dri-devel, Heiko Stuebner, Thomas Zimmermann
Cc: Sandy Huang, stable, linux-rockchip, Enric Balletbo i Serra,
Sam Ravnborg, linux-arm-kernel
Commit 7c49abb4c2f8 ("drm/rockchip: cdn-dp-core: Make cdn_dp_core_suspend/resume static")
introduced the following warning in some builds:
cdn-dp-core.c:1124:12: warning: ‘cdn_dp_resume’ defined but not used
1124 | static int cdn_dp_resume(struct device *dev)
| ^~~~~~~~~~~~~
Fix this by defining cdn_dp_resume __maybe_unused
Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
Fixes: 7c49abb4c2f8 ("drm/rockchip: cdn-dp-core: Make cdn_dp_core_suspend/resume static")
Cc: Enric Balletbo i Serra <enric.balletbo@collabora.com>
Cc: Heiko Stuebner <heiko@sntech.de>
Cc: Sandy Huang <hjc@rock-chips.com>
Cc: linux-arm-kernel@lists.infradead.org
Cc: linux-rockchip@lists.infradead.org
Cc: <stable@vger.kernel.org> # v5.8+
---
drivers/gpu/drm/rockchip/cdn-dp-core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/rockchip/cdn-dp-core.c b/drivers/gpu/drm/rockchip/cdn-dp-core.c
index a4a45daf93f2..1162e321aaed 100644
--- a/drivers/gpu/drm/rockchip/cdn-dp-core.c
+++ b/drivers/gpu/drm/rockchip/cdn-dp-core.c
@@ -1121,7 +1121,7 @@ static int cdn_dp_suspend(struct device *dev)
return ret;
}
-static int cdn_dp_resume(struct device *dev)
+static int __maybe_unused cdn_dp_resume(struct device *dev)
{
struct cdn_dp_device *dp = dev_get_drvdata(dev);
--
2.25.1
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 28+ messages in thread
* Re: [PATCH v1 2/2] drm/rockchip: fix warning from cdn_dp_resume
2020-09-25 21:55 ` Sam Ravnborg
(?)
(?)
@ 2020-09-28 14:42 ` Enric Balletbo i Serra
-1 siblings, 0 replies; 28+ messages in thread
From: Enric Balletbo i Serra @ 2020-09-28 14:42 UTC (permalink / raw)
To: Sam Ravnborg, dri-devel, Heiko Stuebner, Thomas Zimmermann
Cc: linux-arm-kernel, linux-rockchip, Sandy Huang, stable
Hi Sam,
Thank you for your patch.
On 25/9/20 23:55, Sam Ravnborg wrote:
> Commit 7c49abb4c2f8 ("drm/rockchip: cdn-dp-core: Make cdn_dp_core_suspend/resume static")
> introduced the following warning in some builds:
>
> cdn-dp-core.c:1124:12: warning: ‘cdn_dp_resume’ defined but not used
> 1124 | static int cdn_dp_resume(struct device *dev)
> | ^~~~~~~~~~~~~
>
> Fix this by defining cdn_dp_resume __maybe_unused
>
> Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
> Fixes: 7c49abb4c2f8 ("drm/rockchip: cdn-dp-core: Make cdn_dp_core_suspend/resume static")
> Cc: Enric Balletbo i Serra <enric.balletbo@collabora.com>
> Cc: Heiko Stuebner <heiko@sntech.de>
> Cc: Sandy Huang <hjc@rock-chips.com>
> Cc: linux-arm-kernel@lists.infradead.org
> Cc: linux-rockchip@lists.infradead.org
> Cc: <stable@vger.kernel.org> # v5.8+
> ---
Hopefully this time this change lands ;-) Similar patches [1], [2], [3], were
sent in the past by different authors but for some reason never reached upstream.
[1] https://lkml.org/lkml/2020/4/28/1703
[2] https://www.spinics.net/lists/dri-devel/msg268818.html
[3] https://lkml.org/lkml/2020/8/10/1412
> drivers/gpu/drm/rockchip/cdn-dp-core.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/rockchip/cdn-dp-core.c b/drivers/gpu/drm/rockchip/cdn-dp-core.c
> index a4a45daf93f2..1162e321aaed 100644
> --- a/drivers/gpu/drm/rockchip/cdn-dp-core.c
> +++ b/drivers/gpu/drm/rockchip/cdn-dp-core.c
> @@ -1121,7 +1121,7 @@ static int cdn_dp_suspend(struct device *dev)
Shouldn't cdn_dp_suspend also have a __maybe_unused?
With that,
Reviewed-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>
> return ret;
> }
>
> -static int cdn_dp_resume(struct device *dev)
> +static int __maybe_unused cdn_dp_resume(struct device *dev)
> {
> struct cdn_dp_device *dp = dev_get_drvdata(dev);
>
>
^ permalink raw reply [flat|nested] 28+ messages in thread
* Re: [PATCH v1 2/2] drm/rockchip: fix warning from cdn_dp_resume
@ 2020-09-28 14:42 ` Enric Balletbo i Serra
0 siblings, 0 replies; 28+ messages in thread
From: Enric Balletbo i Serra @ 2020-09-28 14:42 UTC (permalink / raw)
To: Sam Ravnborg, dri-devel, Heiko Stuebner, Thomas Zimmermann
Cc: linux-rockchip, stable, Sandy Huang, linux-arm-kernel
Hi Sam,
Thank you for your patch.
On 25/9/20 23:55, Sam Ravnborg wrote:
> Commit 7c49abb4c2f8 ("drm/rockchip: cdn-dp-core: Make cdn_dp_core_suspend/resume static")
> introduced the following warning in some builds:
>
> cdn-dp-core.c:1124:12: warning: ‘cdn_dp_resume’ defined but not used
> 1124 | static int cdn_dp_resume(struct device *dev)
> | ^~~~~~~~~~~~~
>
> Fix this by defining cdn_dp_resume __maybe_unused
>
> Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
> Fixes: 7c49abb4c2f8 ("drm/rockchip: cdn-dp-core: Make cdn_dp_core_suspend/resume static")
> Cc: Enric Balletbo i Serra <enric.balletbo@collabora.com>
> Cc: Heiko Stuebner <heiko@sntech.de>
> Cc: Sandy Huang <hjc@rock-chips.com>
> Cc: linux-arm-kernel@lists.infradead.org
> Cc: linux-rockchip@lists.infradead.org
> Cc: <stable@vger.kernel.org> # v5.8+
> ---
Hopefully this time this change lands ;-) Similar patches [1], [2], [3], were
sent in the past by different authors but for some reason never reached upstream.
[1] https://lkml.org/lkml/2020/4/28/1703
[2] https://www.spinics.net/lists/dri-devel/msg268818.html
[3] https://lkml.org/lkml/2020/8/10/1412
> drivers/gpu/drm/rockchip/cdn-dp-core.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/rockchip/cdn-dp-core.c b/drivers/gpu/drm/rockchip/cdn-dp-core.c
> index a4a45daf93f2..1162e321aaed 100644
> --- a/drivers/gpu/drm/rockchip/cdn-dp-core.c
> +++ b/drivers/gpu/drm/rockchip/cdn-dp-core.c
> @@ -1121,7 +1121,7 @@ static int cdn_dp_suspend(struct device *dev)
Shouldn't cdn_dp_suspend also have a __maybe_unused?
With that,
Reviewed-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>
> return ret;
> }
>
> -static int cdn_dp_resume(struct device *dev)
> +static int __maybe_unused cdn_dp_resume(struct device *dev)
> {
> struct cdn_dp_device *dp = dev_get_drvdata(dev);
>
>
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
^ permalink raw reply [flat|nested] 28+ messages in thread
* Re: [PATCH v1 2/2] drm/rockchip: fix warning from cdn_dp_resume
@ 2020-09-28 14:42 ` Enric Balletbo i Serra
0 siblings, 0 replies; 28+ messages in thread
From: Enric Balletbo i Serra @ 2020-09-28 14:42 UTC (permalink / raw)
To: Sam Ravnborg, dri-devel, Heiko Stuebner, Thomas Zimmermann
Cc: linux-rockchip, stable, Sandy Huang, linux-arm-kernel
Hi Sam,
Thank you for your patch.
On 25/9/20 23:55, Sam Ravnborg wrote:
> Commit 7c49abb4c2f8 ("drm/rockchip: cdn-dp-core: Make cdn_dp_core_suspend/resume static")
> introduced the following warning in some builds:
>
> cdn-dp-core.c:1124:12: warning: ‘cdn_dp_resume’ defined but not used
> 1124 | static int cdn_dp_resume(struct device *dev)
> | ^~~~~~~~~~~~~
>
> Fix this by defining cdn_dp_resume __maybe_unused
>
> Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
> Fixes: 7c49abb4c2f8 ("drm/rockchip: cdn-dp-core: Make cdn_dp_core_suspend/resume static")
> Cc: Enric Balletbo i Serra <enric.balletbo@collabora.com>
> Cc: Heiko Stuebner <heiko@sntech.de>
> Cc: Sandy Huang <hjc@rock-chips.com>
> Cc: linux-arm-kernel@lists.infradead.org
> Cc: linux-rockchip@lists.infradead.org
> Cc: <stable@vger.kernel.org> # v5.8+
> ---
Hopefully this time this change lands ;-) Similar patches [1], [2], [3], were
sent in the past by different authors but for some reason never reached upstream.
[1] https://lkml.org/lkml/2020/4/28/1703
[2] https://www.spinics.net/lists/dri-devel/msg268818.html
[3] https://lkml.org/lkml/2020/8/10/1412
> drivers/gpu/drm/rockchip/cdn-dp-core.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/rockchip/cdn-dp-core.c b/drivers/gpu/drm/rockchip/cdn-dp-core.c
> index a4a45daf93f2..1162e321aaed 100644
> --- a/drivers/gpu/drm/rockchip/cdn-dp-core.c
> +++ b/drivers/gpu/drm/rockchip/cdn-dp-core.c
> @@ -1121,7 +1121,7 @@ static int cdn_dp_suspend(struct device *dev)
Shouldn't cdn_dp_suspend also have a __maybe_unused?
With that,
Reviewed-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>
> return ret;
> }
>
> -static int cdn_dp_resume(struct device *dev)
> +static int __maybe_unused cdn_dp_resume(struct device *dev)
> {
> struct cdn_dp_device *dp = dev_get_drvdata(dev);
>
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 28+ messages in thread
* Re: [PATCH v1 2/2] drm/rockchip: fix warning from cdn_dp_resume
@ 2020-09-28 14:42 ` Enric Balletbo i Serra
0 siblings, 0 replies; 28+ messages in thread
From: Enric Balletbo i Serra @ 2020-09-28 14:42 UTC (permalink / raw)
To: Sam Ravnborg, dri-devel, Heiko Stuebner, Thomas Zimmermann
Cc: linux-rockchip, stable, Sandy Huang, linux-arm-kernel
Hi Sam,
Thank you for your patch.
On 25/9/20 23:55, Sam Ravnborg wrote:
> Commit 7c49abb4c2f8 ("drm/rockchip: cdn-dp-core: Make cdn_dp_core_suspend/resume static")
> introduced the following warning in some builds:
>
> cdn-dp-core.c:1124:12: warning: ‘cdn_dp_resume’ defined but not used
> 1124 | static int cdn_dp_resume(struct device *dev)
> | ^~~~~~~~~~~~~
>
> Fix this by defining cdn_dp_resume __maybe_unused
>
> Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
> Fixes: 7c49abb4c2f8 ("drm/rockchip: cdn-dp-core: Make cdn_dp_core_suspend/resume static")
> Cc: Enric Balletbo i Serra <enric.balletbo@collabora.com>
> Cc: Heiko Stuebner <heiko@sntech.de>
> Cc: Sandy Huang <hjc@rock-chips.com>
> Cc: linux-arm-kernel@lists.infradead.org
> Cc: linux-rockchip@lists.infradead.org
> Cc: <stable@vger.kernel.org> # v5.8+
> ---
Hopefully this time this change lands ;-) Similar patches [1], [2], [3], were
sent in the past by different authors but for some reason never reached upstream.
[1] https://lkml.org/lkml/2020/4/28/1703
[2] https://www.spinics.net/lists/dri-devel/msg268818.html
[3] https://lkml.org/lkml/2020/8/10/1412
> drivers/gpu/drm/rockchip/cdn-dp-core.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/rockchip/cdn-dp-core.c b/drivers/gpu/drm/rockchip/cdn-dp-core.c
> index a4a45daf93f2..1162e321aaed 100644
> --- a/drivers/gpu/drm/rockchip/cdn-dp-core.c
> +++ b/drivers/gpu/drm/rockchip/cdn-dp-core.c
> @@ -1121,7 +1121,7 @@ static int cdn_dp_suspend(struct device *dev)
Shouldn't cdn_dp_suspend also have a __maybe_unused?
With that,
Reviewed-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>
> return ret;
> }
>
> -static int cdn_dp_resume(struct device *dev)
> +static int __maybe_unused cdn_dp_resume(struct device *dev)
> {
> struct cdn_dp_device *dp = dev_get_drvdata(dev);
>
>
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 28+ messages in thread
* Re: [PATCH v1 1/2] drm/rockchip: fix build due to undefined drm_gem_cma_vm_ops
2020-09-25 21:55 ` Sam Ravnborg
(?)
(?)
@ 2020-09-29 6:53 ` Thomas Zimmermann
-1 siblings, 0 replies; 28+ messages in thread
From: Thomas Zimmermann @ 2020-09-29 6:53 UTC (permalink / raw)
To: Sam Ravnborg, dri-devel, Heiko Stuebner
Cc: Enric Balletbo i Serra, linux-arm-kernel, linux-rockchip,
Sandy Huang, stable
[-- Attachment #1.1: Type: text/plain, Size: 1765 bytes --]
Hi Sam
Am 25.09.20 um 23:55 schrieb Sam Ravnborg:
> Commit 0d590af3140d ("drm/rockchip: Convert to drm_gem_object_funcs")
> introduced the following build error:
>
> rockchip_drm_gem.c:304:13: error: ‘drm_gem_cma_vm_ops’ undeclared here
> 304 | .vm_ops = &drm_gem_cma_vm_ops,
> | ^~~~~~~~~~~~~~~~~~
> | drm_gem_mmap_obj
>
> Fixed by adding missing include file.
>
> Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
Didn't you review exactly this change yesterday? Anyway, you should add
Fixes: 0d590af3140d ("drm/rockchip: Convert to drm_gem_object_funcs")
and
Reviewed-by: Thomas Zimmermann <tzimmermann@suse.de>
It might happen that I land my patch first, depending on the urgency of
the issue.
Best regards
Thomas
> Cc: Thomas Zimmermann <tzimmermann@suse.de>
> Cc: Sandy Huang <hjc@rock-chips.com>
> Cc: "Heiko Stübner" <heiko@sntech.de>
> Cc: linux-arm-kernel@lists.infradead.org
> Cc: linux-rockchip@lists.infradead.org
> ---
> drivers/gpu/drm/rockchip/rockchip_drm_gem.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_gem.c b/drivers/gpu/drm/rockchip/rockchip_drm_gem.c
> index bb3578469b03..6da15faf0192 100644
> --- a/drivers/gpu/drm/rockchip/rockchip_drm_gem.c
> +++ b/drivers/gpu/drm/rockchip/rockchip_drm_gem.c
> @@ -10,6 +10,7 @@
>
> #include <drm/drm.h>
> #include <drm/drm_gem.h>
> +#include <drm/drm_gem_cma_helper.h>
> #include <drm/drm_prime.h>
> #include <drm/drm_vma_manager.h>
>
>
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
(HRB 36809, AG Nürnberg)
Geschäftsführer: Felix Imendörffer
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 516 bytes --]
^ permalink raw reply [flat|nested] 28+ messages in thread
* Re: [PATCH v1 1/2] drm/rockchip: fix build due to undefined drm_gem_cma_vm_ops
@ 2020-09-29 6:53 ` Thomas Zimmermann
0 siblings, 0 replies; 28+ messages in thread
From: Thomas Zimmermann @ 2020-09-29 6:53 UTC (permalink / raw)
To: Sam Ravnborg, dri-devel, Heiko Stuebner
Cc: Enric Balletbo i Serra, linux-rockchip, stable, Sandy Huang,
linux-arm-kernel
[-- Attachment #1.1.1: Type: text/plain, Size: 1765 bytes --]
Hi Sam
Am 25.09.20 um 23:55 schrieb Sam Ravnborg:
> Commit 0d590af3140d ("drm/rockchip: Convert to drm_gem_object_funcs")
> introduced the following build error:
>
> rockchip_drm_gem.c:304:13: error: ‘drm_gem_cma_vm_ops’ undeclared here
> 304 | .vm_ops = &drm_gem_cma_vm_ops,
> | ^~~~~~~~~~~~~~~~~~
> | drm_gem_mmap_obj
>
> Fixed by adding missing include file.
>
> Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
Didn't you review exactly this change yesterday? Anyway, you should add
Fixes: 0d590af3140d ("drm/rockchip: Convert to drm_gem_object_funcs")
and
Reviewed-by: Thomas Zimmermann <tzimmermann@suse.de>
It might happen that I land my patch first, depending on the urgency of
the issue.
Best regards
Thomas
> Cc: Thomas Zimmermann <tzimmermann@suse.de>
> Cc: Sandy Huang <hjc@rock-chips.com>
> Cc: "Heiko Stübner" <heiko@sntech.de>
> Cc: linux-arm-kernel@lists.infradead.org
> Cc: linux-rockchip@lists.infradead.org
> ---
> drivers/gpu/drm/rockchip/rockchip_drm_gem.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_gem.c b/drivers/gpu/drm/rockchip/rockchip_drm_gem.c
> index bb3578469b03..6da15faf0192 100644
> --- a/drivers/gpu/drm/rockchip/rockchip_drm_gem.c
> +++ b/drivers/gpu/drm/rockchip/rockchip_drm_gem.c
> @@ -10,6 +10,7 @@
>
> #include <drm/drm.h>
> #include <drm/drm_gem.h>
> +#include <drm/drm_gem_cma_helper.h>
> #include <drm/drm_prime.h>
> #include <drm/drm_vma_manager.h>
>
>
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
(HRB 36809, AG Nürnberg)
Geschäftsführer: Felix Imendörffer
[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 516 bytes --]
[-- Attachment #2: Type: text/plain, Size: 170 bytes --]
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
^ permalink raw reply [flat|nested] 28+ messages in thread
* Re: [PATCH v1 1/2] drm/rockchip: fix build due to undefined drm_gem_cma_vm_ops
@ 2020-09-29 6:53 ` Thomas Zimmermann
0 siblings, 0 replies; 28+ messages in thread
From: Thomas Zimmermann @ 2020-09-29 6:53 UTC (permalink / raw)
To: Sam Ravnborg, dri-devel, Heiko Stuebner
Cc: Enric Balletbo i Serra, linux-rockchip, stable, Sandy Huang,
linux-arm-kernel
[-- Attachment #1.1.1: Type: text/plain, Size: 1765 bytes --]
Hi Sam
Am 25.09.20 um 23:55 schrieb Sam Ravnborg:
> Commit 0d590af3140d ("drm/rockchip: Convert to drm_gem_object_funcs")
> introduced the following build error:
>
> rockchip_drm_gem.c:304:13: error: ‘drm_gem_cma_vm_ops’ undeclared here
> 304 | .vm_ops = &drm_gem_cma_vm_ops,
> | ^~~~~~~~~~~~~~~~~~
> | drm_gem_mmap_obj
>
> Fixed by adding missing include file.
>
> Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
Didn't you review exactly this change yesterday? Anyway, you should add
Fixes: 0d590af3140d ("drm/rockchip: Convert to drm_gem_object_funcs")
and
Reviewed-by: Thomas Zimmermann <tzimmermann@suse.de>
It might happen that I land my patch first, depending on the urgency of
the issue.
Best regards
Thomas
> Cc: Thomas Zimmermann <tzimmermann@suse.de>
> Cc: Sandy Huang <hjc@rock-chips.com>
> Cc: "Heiko Stübner" <heiko@sntech.de>
> Cc: linux-arm-kernel@lists.infradead.org
> Cc: linux-rockchip@lists.infradead.org
> ---
> drivers/gpu/drm/rockchip/rockchip_drm_gem.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_gem.c b/drivers/gpu/drm/rockchip/rockchip_drm_gem.c
> index bb3578469b03..6da15faf0192 100644
> --- a/drivers/gpu/drm/rockchip/rockchip_drm_gem.c
> +++ b/drivers/gpu/drm/rockchip/rockchip_drm_gem.c
> @@ -10,6 +10,7 @@
>
> #include <drm/drm.h>
> #include <drm/drm_gem.h>
> +#include <drm/drm_gem_cma_helper.h>
> #include <drm/drm_prime.h>
> #include <drm/drm_vma_manager.h>
>
>
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
(HRB 36809, AG Nürnberg)
Geschäftsführer: Felix Imendörffer
[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 516 bytes --]
[-- Attachment #2: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 28+ messages in thread
* Re: [PATCH v1 1/2] drm/rockchip: fix build due to undefined drm_gem_cma_vm_ops
@ 2020-09-29 6:53 ` Thomas Zimmermann
0 siblings, 0 replies; 28+ messages in thread
From: Thomas Zimmermann @ 2020-09-29 6:53 UTC (permalink / raw)
To: Sam Ravnborg, dri-devel, Heiko Stuebner
Cc: Enric Balletbo i Serra, linux-rockchip, stable, Sandy Huang,
linux-arm-kernel
[-- Attachment #1.1.1: Type: text/plain, Size: 1765 bytes --]
Hi Sam
Am 25.09.20 um 23:55 schrieb Sam Ravnborg:
> Commit 0d590af3140d ("drm/rockchip: Convert to drm_gem_object_funcs")
> introduced the following build error:
>
> rockchip_drm_gem.c:304:13: error: ‘drm_gem_cma_vm_ops’ undeclared here
> 304 | .vm_ops = &drm_gem_cma_vm_ops,
> | ^~~~~~~~~~~~~~~~~~
> | drm_gem_mmap_obj
>
> Fixed by adding missing include file.
>
> Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
Didn't you review exactly this change yesterday? Anyway, you should add
Fixes: 0d590af3140d ("drm/rockchip: Convert to drm_gem_object_funcs")
and
Reviewed-by: Thomas Zimmermann <tzimmermann@suse.de>
It might happen that I land my patch first, depending on the urgency of
the issue.
Best regards
Thomas
> Cc: Thomas Zimmermann <tzimmermann@suse.de>
> Cc: Sandy Huang <hjc@rock-chips.com>
> Cc: "Heiko Stübner" <heiko@sntech.de>
> Cc: linux-arm-kernel@lists.infradead.org
> Cc: linux-rockchip@lists.infradead.org
> ---
> drivers/gpu/drm/rockchip/rockchip_drm_gem.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_gem.c b/drivers/gpu/drm/rockchip/rockchip_drm_gem.c
> index bb3578469b03..6da15faf0192 100644
> --- a/drivers/gpu/drm/rockchip/rockchip_drm_gem.c
> +++ b/drivers/gpu/drm/rockchip/rockchip_drm_gem.c
> @@ -10,6 +10,7 @@
>
> #include <drm/drm.h>
> #include <drm/drm_gem.h>
> +#include <drm/drm_gem_cma_helper.h>
> #include <drm/drm_prime.h>
> #include <drm/drm_vma_manager.h>
>
>
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
(HRB 36809, AG Nürnberg)
Geschäftsführer: Felix Imendörffer
[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 516 bytes --]
[-- Attachment #2: Type: text/plain, Size: 160 bytes --]
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 28+ messages in thread
* Re: [PATCH v1 1/2] drm/rockchip: fix build due to undefined drm_gem_cma_vm_ops
2020-09-29 6:53 ` Thomas Zimmermann
(?)
(?)
@ 2020-09-29 7:17 ` Sam Ravnborg
-1 siblings, 0 replies; 28+ messages in thread
From: Sam Ravnborg @ 2020-09-29 7:17 UTC (permalink / raw)
To: Thomas Zimmermann
Cc: dri-devel, Heiko Stuebner, Enric Balletbo i Serra,
linux-arm-kernel, linux-rockchip, Sandy Huang, stable
On Tue, Sep 29, 2020 at 08:53:06AM +0200, Thomas Zimmermann wrote:
> Hi Sam
>
> Am 25.09.20 um 23:55 schrieb Sam Ravnborg:
> > Commit 0d590af3140d ("drm/rockchip: Convert to drm_gem_object_funcs")
> > introduced the following build error:
> >
> > rockchip_drm_gem.c:304:13: error: ‘drm_gem_cma_vm_ops’ undeclared here
> > 304 | .vm_ops = &drm_gem_cma_vm_ops,
> > | ^~~~~~~~~~~~~~~~~~
> > | drm_gem_mmap_obj
> >
> > Fixed by adding missing include file.
> >
> > Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
>
> Didn't you review exactly this change yesterday? Anyway, you should add
Yep.
>
> Fixes: 0d590af3140d ("drm/rockchip: Convert to drm_gem_object_funcs")
>
> and
>
> Reviewed-by: Thomas Zimmermann <tzimmermann@suse.de>
>
> It might happen that I land my patch first, depending on the urgency of
> the issue.
I expect you to land the patch you made asap so we can have the build
fixed again.
Sam
^ permalink raw reply [flat|nested] 28+ messages in thread
* Re: [PATCH v1 1/2] drm/rockchip: fix build due to undefined drm_gem_cma_vm_ops
@ 2020-09-29 7:17 ` Sam Ravnborg
0 siblings, 0 replies; 28+ messages in thread
From: Sam Ravnborg @ 2020-09-29 7:17 UTC (permalink / raw)
To: Thomas Zimmermann
Cc: Heiko Stuebner, Sandy Huang, dri-devel, linux-rockchip, stable,
Enric Balletbo i Serra, linux-arm-kernel
On Tue, Sep 29, 2020 at 08:53:06AM +0200, Thomas Zimmermann wrote:
> Hi Sam
>
> Am 25.09.20 um 23:55 schrieb Sam Ravnborg:
> > Commit 0d590af3140d ("drm/rockchip: Convert to drm_gem_object_funcs")
> > introduced the following build error:
> >
> > rockchip_drm_gem.c:304:13: error: ‘drm_gem_cma_vm_ops’ undeclared here
> > 304 | .vm_ops = &drm_gem_cma_vm_ops,
> > | ^~~~~~~~~~~~~~~~~~
> > | drm_gem_mmap_obj
> >
> > Fixed by adding missing include file.
> >
> > Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
>
> Didn't you review exactly this change yesterday? Anyway, you should add
Yep.
>
> Fixes: 0d590af3140d ("drm/rockchip: Convert to drm_gem_object_funcs")
>
> and
>
> Reviewed-by: Thomas Zimmermann <tzimmermann@suse.de>
>
> It might happen that I land my patch first, depending on the urgency of
> the issue.
I expect you to land the patch you made asap so we can have the build
fixed again.
Sam
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
^ permalink raw reply [flat|nested] 28+ messages in thread
* Re: [PATCH v1 1/2] drm/rockchip: fix build due to undefined drm_gem_cma_vm_ops
@ 2020-09-29 7:17 ` Sam Ravnborg
0 siblings, 0 replies; 28+ messages in thread
From: Sam Ravnborg @ 2020-09-29 7:17 UTC (permalink / raw)
To: Thomas Zimmermann
Cc: Heiko Stuebner, Sandy Huang, dri-devel, linux-rockchip, stable,
Enric Balletbo i Serra, linux-arm-kernel
On Tue, Sep 29, 2020 at 08:53:06AM +0200, Thomas Zimmermann wrote:
> Hi Sam
>
> Am 25.09.20 um 23:55 schrieb Sam Ravnborg:
> > Commit 0d590af3140d ("drm/rockchip: Convert to drm_gem_object_funcs")
> > introduced the following build error:
> >
> > rockchip_drm_gem.c:304:13: error: ‘drm_gem_cma_vm_ops’ undeclared here
> > 304 | .vm_ops = &drm_gem_cma_vm_ops,
> > | ^~~~~~~~~~~~~~~~~~
> > | drm_gem_mmap_obj
> >
> > Fixed by adding missing include file.
> >
> > Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
>
> Didn't you review exactly this change yesterday? Anyway, you should add
Yep.
>
> Fixes: 0d590af3140d ("drm/rockchip: Convert to drm_gem_object_funcs")
>
> and
>
> Reviewed-by: Thomas Zimmermann <tzimmermann@suse.de>
>
> It might happen that I land my patch first, depending on the urgency of
> the issue.
I expect you to land the patch you made asap so we can have the build
fixed again.
Sam
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 28+ messages in thread
* Re: [PATCH v1 1/2] drm/rockchip: fix build due to undefined drm_gem_cma_vm_ops
@ 2020-09-29 7:17 ` Sam Ravnborg
0 siblings, 0 replies; 28+ messages in thread
From: Sam Ravnborg @ 2020-09-29 7:17 UTC (permalink / raw)
To: Thomas Zimmermann
Cc: Sandy Huang, dri-devel, linux-rockchip, stable,
Enric Balletbo i Serra, linux-arm-kernel
On Tue, Sep 29, 2020 at 08:53:06AM +0200, Thomas Zimmermann wrote:
> Hi Sam
>
> Am 25.09.20 um 23:55 schrieb Sam Ravnborg:
> > Commit 0d590af3140d ("drm/rockchip: Convert to drm_gem_object_funcs")
> > introduced the following build error:
> >
> > rockchip_drm_gem.c:304:13: error: ‘drm_gem_cma_vm_ops’ undeclared here
> > 304 | .vm_ops = &drm_gem_cma_vm_ops,
> > | ^~~~~~~~~~~~~~~~~~
> > | drm_gem_mmap_obj
> >
> > Fixed by adding missing include file.
> >
> > Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
>
> Didn't you review exactly this change yesterday? Anyway, you should add
Yep.
>
> Fixes: 0d590af3140d ("drm/rockchip: Convert to drm_gem_object_funcs")
>
> and
>
> Reviewed-by: Thomas Zimmermann <tzimmermann@suse.de>
>
> It might happen that I land my patch first, depending on the urgency of
> the issue.
I expect you to land the patch you made asap so we can have the build
fixed again.
Sam
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 28+ messages in thread
* Re: [PATCH v1 1/2] drm/rockchip: fix build due to undefined drm_gem_cma_vm_ops
2020-09-29 7:17 ` Sam Ravnborg
(?)
(?)
@ 2020-09-29 7:47 ` Thomas Zimmermann
-1 siblings, 0 replies; 28+ messages in thread
From: Thomas Zimmermann @ 2020-09-29 7:47 UTC (permalink / raw)
To: Sam Ravnborg
Cc: Sandy Huang, dri-devel, linux-rockchip, stable,
Enric Balletbo i Serra, linux-arm-kernel
[-- Attachment #1.1: Type: text/plain, Size: 1593 bytes --]
Hi Sam
Am 29.09.20 um 09:17 schrieb Sam Ravnborg:
> On Tue, Sep 29, 2020 at 08:53:06AM +0200, Thomas Zimmermann wrote:
>> Hi Sam
>>
>> Am 25.09.20 um 23:55 schrieb Sam Ravnborg:
>>> Commit 0d590af3140d ("drm/rockchip: Convert to drm_gem_object_funcs")
>>> introduced the following build error:
>>>
>>> rockchip_drm_gem.c:304:13: error: ‘drm_gem_cma_vm_ops’ undeclared here
>>> 304 | .vm_ops = &drm_gem_cma_vm_ops,
>>> | ^~~~~~~~~~~~~~~~~~
>>> | drm_gem_mmap_obj
>>>
>>> Fixed by adding missing include file.
>>>
>>> Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
>>
>> Didn't you review exactly this change yesterday? Anyway, you should add
> Yep.
>
>>
>> Fixes: 0d590af3140d ("drm/rockchip: Convert to drm_gem_object_funcs")
>>
>> and
>>
>> Reviewed-by: Thomas Zimmermann <tzimmermann@suse.de>
>>
>> It might happen that I land my patch first, depending on the urgency of
>> the issue.
> I expect you to land the patch you made asap so we can have the build
> fixed again.
Oh, I just looked at the dates and your patch was actually first. Sorry
for the confusion. I've now merged what I had.
Best regards
Thomas
>
>
> Sam
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
>
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
(HRB 36809, AG Nürnberg)
Geschäftsführer: Felix Imendörffer
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 516 bytes --]
^ permalink raw reply [flat|nested] 28+ messages in thread
* Re: [PATCH v1 1/2] drm/rockchip: fix build due to undefined drm_gem_cma_vm_ops
@ 2020-09-29 7:47 ` Thomas Zimmermann
0 siblings, 0 replies; 28+ messages in thread
From: Thomas Zimmermann @ 2020-09-29 7:47 UTC (permalink / raw)
To: Sam Ravnborg
Cc: Sandy Huang, stable, linux-rockchip, dri-devel,
Enric Balletbo i Serra, linux-arm-kernel
[-- Attachment #1.1.1: Type: text/plain, Size: 1593 bytes --]
Hi Sam
Am 29.09.20 um 09:17 schrieb Sam Ravnborg:
> On Tue, Sep 29, 2020 at 08:53:06AM +0200, Thomas Zimmermann wrote:
>> Hi Sam
>>
>> Am 25.09.20 um 23:55 schrieb Sam Ravnborg:
>>> Commit 0d590af3140d ("drm/rockchip: Convert to drm_gem_object_funcs")
>>> introduced the following build error:
>>>
>>> rockchip_drm_gem.c:304:13: error: ‘drm_gem_cma_vm_ops’ undeclared here
>>> 304 | .vm_ops = &drm_gem_cma_vm_ops,
>>> | ^~~~~~~~~~~~~~~~~~
>>> | drm_gem_mmap_obj
>>>
>>> Fixed by adding missing include file.
>>>
>>> Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
>>
>> Didn't you review exactly this change yesterday? Anyway, you should add
> Yep.
>
>>
>> Fixes: 0d590af3140d ("drm/rockchip: Convert to drm_gem_object_funcs")
>>
>> and
>>
>> Reviewed-by: Thomas Zimmermann <tzimmermann@suse.de>
>>
>> It might happen that I land my patch first, depending on the urgency of
>> the issue.
> I expect you to land the patch you made asap so we can have the build
> fixed again.
Oh, I just looked at the dates and your patch was actually first. Sorry
for the confusion. I've now merged what I had.
Best regards
Thomas
>
>
> Sam
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
>
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
(HRB 36809, AG Nürnberg)
Geschäftsführer: Felix Imendörffer
[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 516 bytes --]
[-- Attachment #2: Type: text/plain, Size: 170 bytes --]
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
^ permalink raw reply [flat|nested] 28+ messages in thread
* Re: [PATCH v1 1/2] drm/rockchip: fix build due to undefined drm_gem_cma_vm_ops
@ 2020-09-29 7:47 ` Thomas Zimmermann
0 siblings, 0 replies; 28+ messages in thread
From: Thomas Zimmermann @ 2020-09-29 7:47 UTC (permalink / raw)
To: Sam Ravnborg
Cc: Sandy Huang, stable, linux-rockchip, dri-devel,
Enric Balletbo i Serra, linux-arm-kernel
[-- Attachment #1.1.1: Type: text/plain, Size: 1593 bytes --]
Hi Sam
Am 29.09.20 um 09:17 schrieb Sam Ravnborg:
> On Tue, Sep 29, 2020 at 08:53:06AM +0200, Thomas Zimmermann wrote:
>> Hi Sam
>>
>> Am 25.09.20 um 23:55 schrieb Sam Ravnborg:
>>> Commit 0d590af3140d ("drm/rockchip: Convert to drm_gem_object_funcs")
>>> introduced the following build error:
>>>
>>> rockchip_drm_gem.c:304:13: error: ‘drm_gem_cma_vm_ops’ undeclared here
>>> 304 | .vm_ops = &drm_gem_cma_vm_ops,
>>> | ^~~~~~~~~~~~~~~~~~
>>> | drm_gem_mmap_obj
>>>
>>> Fixed by adding missing include file.
>>>
>>> Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
>>
>> Didn't you review exactly this change yesterday? Anyway, you should add
> Yep.
>
>>
>> Fixes: 0d590af3140d ("drm/rockchip: Convert to drm_gem_object_funcs")
>>
>> and
>>
>> Reviewed-by: Thomas Zimmermann <tzimmermann@suse.de>
>>
>> It might happen that I land my patch first, depending on the urgency of
>> the issue.
> I expect you to land the patch you made asap so we can have the build
> fixed again.
Oh, I just looked at the dates and your patch was actually first. Sorry
for the confusion. I've now merged what I had.
Best regards
Thomas
>
>
> Sam
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
>
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
(HRB 36809, AG Nürnberg)
Geschäftsführer: Felix Imendörffer
[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 516 bytes --]
[-- Attachment #2: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 28+ messages in thread
* Re: [PATCH v1 1/2] drm/rockchip: fix build due to undefined drm_gem_cma_vm_ops
@ 2020-09-29 7:47 ` Thomas Zimmermann
0 siblings, 0 replies; 28+ messages in thread
From: Thomas Zimmermann @ 2020-09-29 7:47 UTC (permalink / raw)
To: Sam Ravnborg
Cc: Sandy Huang, stable, linux-rockchip, dri-devel,
Enric Balletbo i Serra, linux-arm-kernel
[-- Attachment #1.1.1: Type: text/plain, Size: 1593 bytes --]
Hi Sam
Am 29.09.20 um 09:17 schrieb Sam Ravnborg:
> On Tue, Sep 29, 2020 at 08:53:06AM +0200, Thomas Zimmermann wrote:
>> Hi Sam
>>
>> Am 25.09.20 um 23:55 schrieb Sam Ravnborg:
>>> Commit 0d590af3140d ("drm/rockchip: Convert to drm_gem_object_funcs")
>>> introduced the following build error:
>>>
>>> rockchip_drm_gem.c:304:13: error: ‘drm_gem_cma_vm_ops’ undeclared here
>>> 304 | .vm_ops = &drm_gem_cma_vm_ops,
>>> | ^~~~~~~~~~~~~~~~~~
>>> | drm_gem_mmap_obj
>>>
>>> Fixed by adding missing include file.
>>>
>>> Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
>>
>> Didn't you review exactly this change yesterday? Anyway, you should add
> Yep.
>
>>
>> Fixes: 0d590af3140d ("drm/rockchip: Convert to drm_gem_object_funcs")
>>
>> and
>>
>> Reviewed-by: Thomas Zimmermann <tzimmermann@suse.de>
>>
>> It might happen that I land my patch first, depending on the urgency of
>> the issue.
> I expect you to land the patch you made asap so we can have the build
> fixed again.
Oh, I just looked at the dates and your patch was actually first. Sorry
for the confusion. I've now merged what I had.
Best regards
Thomas
>
>
> Sam
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
>
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
(HRB 36809, AG Nürnberg)
Geschäftsführer: Felix Imendörffer
[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 516 bytes --]
[-- Attachment #2: Type: text/plain, Size: 160 bytes --]
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 28+ messages in thread
end of thread, other threads:[~2020-09-29 7:48 UTC | newest]
Thread overview: 28+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-09-25 21:55 [PATCH v1 0/2] drm/rockchip: fix build + warning Sam Ravnborg
2020-09-25 21:55 ` Sam Ravnborg
2020-09-25 21:55 ` Sam Ravnborg
2020-09-25 21:55 ` Sam Ravnborg
2020-09-25 21:55 ` [PATCH v1 1/2] drm/rockchip: fix build due to undefined drm_gem_cma_vm_ops Sam Ravnborg
2020-09-25 21:55 ` Sam Ravnborg
2020-09-25 21:55 ` Sam Ravnborg
2020-09-25 21:55 ` Sam Ravnborg
2020-09-29 6:53 ` Thomas Zimmermann
2020-09-29 6:53 ` Thomas Zimmermann
2020-09-29 6:53 ` Thomas Zimmermann
2020-09-29 6:53 ` Thomas Zimmermann
2020-09-29 7:17 ` Sam Ravnborg
2020-09-29 7:17 ` Sam Ravnborg
2020-09-29 7:17 ` Sam Ravnborg
2020-09-29 7:17 ` Sam Ravnborg
2020-09-29 7:47 ` Thomas Zimmermann
2020-09-29 7:47 ` Thomas Zimmermann
2020-09-29 7:47 ` Thomas Zimmermann
2020-09-29 7:47 ` Thomas Zimmermann
2020-09-25 21:55 ` [PATCH v1 2/2] drm/rockchip: fix warning from cdn_dp_resume Sam Ravnborg
2020-09-25 21:55 ` Sam Ravnborg
2020-09-25 21:55 ` Sam Ravnborg
2020-09-25 21:55 ` Sam Ravnborg
2020-09-28 14:42 ` Enric Balletbo i Serra
2020-09-28 14:42 ` Enric Balletbo i Serra
2020-09-28 14:42 ` Enric Balletbo i Serra
2020-09-28 14:42 ` Enric Balletbo i Serra
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.